Re: [PM-QA] question about cpufreq subtest

On 18/08/2017 08:29, Viresh Kumar wrote: > On 18 August 2017 at 11:52, Dai Xiang wrote: [ ... ] > I can see all of them fail and the reason is quite simple to see. Even > intel-pstate > doesn't provide a frequency table and so whatsoever depends on a frequency > table will fail. > > These tests

Re: [PM-QA] question about cpufreq subtest

On 18/08/2017 08:20, Viresh Kumar wrote: > On 18 August 2017 at 11:48, Daniel Lezcano wrote: >> I don't know the passive / active mode but the path changed. >> >> /sys/devices/system/cpu/cpufreq/policy[0-9]/scaling_driver > > Naah, we wouldn't have broken use

Re: [PM-QA] question about cpufreq subtest

On 18/08/2017 07:43, Viresh Kumar wrote: > On 18 August 2017 at 11:11, Dai Xiang wrote: > >> In fact, i has used intel_pstate driver: >> $ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver >> intel_pstate > > It may be running in *active* mode and you need to put it in *passive* mode. > >

Re: [PATCH PM-QA] Fixed array initializations to calculate freq deviation.

On 05/05/2016 12:06 PM, Saul Romero wrote: Changes in cpufreq_06.sh to calculate summatory and average of frequency measurements. Signed-off-by: Saul Romero --- Hi Saul, can you elaborate in the changelog what happens with the current and why it must be fixed. Also, a proper fix should not

Re: [PATCH 1/6] Change options to flag approach.

On 02/22/2016 04:19 PM, David Brown wrote: On Fri, Feb 19, 2016 at 02:32:40PM +, Daniel Lezcano wrote: From: Daniel Lezcano Did you mean to have these patches authored by your @free.fr address, but sent from Linaro? Yes, it is just one of them. Subject: Re: [PATCH 1/6] Change

[PATCH 6/6] Pass options to init functions.

Signed-off-by: Daniel Lezcano --- clocks.c | 5 - gpio.c | 5 - powerdebug.c | 19 --- powerdebug.h | 20 regulator.c | 5 - sensor.c | 5 - 6 files changed, 36 insertions(+), 23 deletions(-) diff --git a/clocks.c b

[PATCH 5/6] Consolidate the headers into a single one.

Signed-off-by: Daniel Lezcano --- clocks.c | 1 - clocks.h | 23 --- display.c| 1 - gpio.h | 23 --- powerdebug.c | 11 --- powerdebug.h | 19 +++ regulator.c | 3 --- regulator.h | 23

[PATCH 4/6] Fix license. Linaro switched years ago to GPL.

Signed-off-by: Daniel Lezcano --- LICENSE | 567 --- clocks.c | 28 +-- clocks.h | 28 +-- display.c| 28 +-- display.h| 28 +-- gpio.c | 28 +-- gpio.h | 28 +-- mainloop.c | 26 +-- mainloop.h

[PATCH 2/6] Fix compilation warnings.

Signed-off-by: Daniel Lezcano --- display.c | 7 ++- gpio.c| 11 ++- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/display.c b/display.c index ee9..1114366 100644 --- a/display.c +++ b/display.c @@ -198,13 +198,13 @@ static int display_prev_panel(void

[PATCH 3/6] Prevent to init a subsystem if it is not selected.

Signed-off-by: Daniel Lezcano --- powerdebug.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/powerdebug.c b/powerdebug.c index 555beea..bc8fc92 100644 --- a/powerdebug.c +++ b/powerdebug.c @@ -208,13 +208,12 @@ static struct powerdebug_options *powerdebug_init

[PATCH 1/6] Change options to flag approach.

From: Daniel Lezcano That has the benefit to simplify the code. Signed-off-by: Daniel Lezcano --- powerdebug.c | 65 +++- 1 file changed, 34 insertions(+), 31 deletions(-) diff --git a/powerdebug.c b/powerdebug.c index 6cf3a1b..555beea

Re: [PATCH v3] idlestat: Allocate struct cpufreq_pstate dynamically

On 10/21/2014 03:47 PM, Tuukka Tikkanen wrote: On Tue, Oct 21, 2014 at 3:42 PM, Daniel Lezcano wrote: On 10/04/2014 06:33 AM, pi-cheng.chen wrote: Initialize struct cpufreq_pstates with initial P-state of CPUs and allocate struct cpufreq_pstate dynamically when parsing trace file to solve

Re: [PATCH v3] idlestat: Allocate struct cpufreq_pstate dynamically

On 10/04/2014 06:33 AM, pi-cheng.chen wrote: Initialize struct cpufreq_pstates with initial P-state of CPUs and allocate struct cpufreq_pstate dynamically when parsing trace file to solve the issue caused by missing "scaling_avaialable_freqs" attr when using intel_pstate driver. Changes v2 to v3

Re: [PATCH v2] idlestat: Allocate struct cpufreq_pstate dynamically

On 09/10/2014 03:08 PM, Pi-Cheng Chen wrote: On 10 September 2014 17:15, Daniel Lezcano wrote: On 09/10/2014 09:33 AM, pi-cheng.chen wrote: When using intel_pstate driver, "scaling_available_freqs" attr is not exported to sysfs. It causes assertion of idlestat due to memory

Re: [PATCH v2] idlestat: Allocate struct cpufreq_pstate dynamically

On 09/10/2014 09:33 AM, pi-cheng.chen wrote: When using intel_pstate driver, "scaling_available_freqs" attr is not exported to sysfs. It causes assertion of idlestat due to memory of struct cpufreq_pstate was not allocated. Allocate struct cpufreq_pstate dynamically when getting frequency inform

Re: [PATCH idlestat] Add -o option to save output report to a file

On 08/19/2014 09:22 AM, pi-cheng.chen wrote: Currently the serial terminal connected to the boards running idlestat are restricted to be at least 80 characters wide to output the report. Otherwise idlestat quits with message "The terminal must be at least 80 columns wide". Fix it by adding a "-o

Re: [GIT PULL] Create a workload generator tool

On 08/08/2014 07:27 AM, Amit Kucheria wrote: [ ... ] We also said that the name of the tool could be changed, any opinions on this? Something like workload-gen or wload-gen ? IMHO, the name change is just a nice to have and not critical to the success of this project. Workload Generator is

[PATCH] Check the terminal window size is greater or equal to 80 columns

All the output assumes the terminal width is 80 cols min, check the terminal size in order to detect a smaller terminal and prevent to have a nested output. Signed-off-by: Daniel Lezcano --- idlestat.c | 24 1 file changed, 24 insertions(+) diff --git a/idlestat.c b

[PATCH V2 idlestat 09/12] Improve the output

| 8.00ms |10 | 0 | 0 | | C7-IVB | 0us | 98.04ms | 6.92ms | 26.99s | 3899 | 0 | 0 | Signed-off-by: Daniel Lezcano --- idlestat.c | 209

[PATCH V2 idlestat 02/12] Fix some lines to comply with 80 chars length

Fix lines exceeding 80 chars, so fulfill the conventional coding style of the opensource projects. Signed-off-by: Daniel Lezcano --- idlestat.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/idlestat.c b/idlestat.c index 2a0c549..30860db 100644 --- a

[PATCH V2 idlestat 07/12] Split display function

Make some code separations to prepare the code for cleanup. Signed-off-by: Daniel Lezcano --- idlestat.c | 84 ++-- 1 file changed, 54 insertions(+), 30 deletions(-) diff --git a/idlestat.c b/idlestat.c index 3e5b4bc..83655bd 100644

[PATCH V2 idlestat 03/12] Remove the debug option

This function is pointless. It was added initially for debugging purpose, remove it. Signed-off-by: Daniel Lezcano --- idlestat.c | 16 ++-- idlestat.h |1 - 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/idlestat.c b/idlestat.c index 30860db..abbb787 100644

[PATCH V2 idlestat 04/12] Add 'patches' directory to the ignored list of files in .gitignore

g it as an untracked file. Signed-off-by: Daniel Lezcano --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 968abde..4ee98b8 100644 --- a/.gitignore +++ b/.gitignore @@ -30,6 +30,7 @@ *.orig *~ \#*# +patches # # Top-level files -

[PATCH V2 idlestat 11/12] Split the display to show the wakeup separetely

The display functions are tied together in the code. Split this, so we can choose each subsystem to display separately. Signed-off-by: Daniel Lezcano --- idlestat.c | 102 ++-- topology.c | 11 --- 2 files changed, 71 insertions

[PATCH V2 idlestat 01/12] Fix CPU affinity mask

solve this issue, by properly recovering the original CPU affinity mask. Moreover, it avoids to wake up CPUs that will not be used to run the workload. Signed-off-by: Patrick Bellasi Signed-off-by: Daniel Lezcano --- idlestat.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a

[PATCH V2 idlestat 08/12] Don't double check with the estimate function

We want the output to be always the same even if the prediction accuracy is not possible because we are working on an old kernel. Signed-off-by: Daniel Lezcano --- idlestat.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/idlestat.c b/idlestat.c index 83655bd

[PATCH V2 idlestat 10/12] Add option to choose the data to be displayed

Add the options to select c-states, p-states and wakeup output. --idle, -c : show c-states --frequency, -p : show p-states --wakeup, -w: show wakeup sources Signed-off-by: Daniel Lezcano --- README |7 ++- idlestat.c | 35 +++ idlestat.h

[PATCH V2 idlestat 05/12] Add incremental verbose option

e. Signed-off-by: Daniel Lezcano --- idlestat.c |6 +- idlestat.h |1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/idlestat.c b/idlestat.c index abbb787..8138e35 100644 --- a/idlestat.c +++ b/idlestat.c @@ -1070,6 +1070,7 @@ int getoptions(int argc, char *argv

[PATCH V2 idlestat 12/12] Report even if the application returned an error code

In case the application is killed by the timeout and it handles the SIGTERM, it may return an error, thus idlestat won't display the result. Ignore the return code of the application. Signed-off-by: Daniel Lezcano --- idlestat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH V2 idlestat 06/12] Remove dump and iterations options

These options are pointless and not interesting. Removing them. Signed-off-by: Daniel Lezcano --- idlestat.c | 72 ++-- idlestat.h |2 -- topology.c | 12 +- topology.h |5 ++--- 4 files changed, 19 insertions(+), 72

[PATCH idlestat 05/12] Add incremental verbose option

e. Signed-off-by: Daniel Lezcano --- idlestat.c |6 +- idlestat.h |1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/idlestat.c b/idlestat.c index abbb787..8138e35 100644 --- a/idlestat.c +++ b/idlestat.c @@ -1070,6 +1070,7 @@ int getoptions(int argc, char *argv

[PATCH idlestat 07/12] Split display function

Make some code separations to prepare the code for cleanup. Signed-off-by: Daniel Lezcano --- idlestat.c | 84 ++-- 1 file changed, 54 insertions(+), 30 deletions(-) diff --git a/idlestat.c b/idlestat.c index e4dbb89..b084b5d 100644

[PATCH idlestat 10/12] Add option to choose the data to be displayed

Add the options to select c-states, p-states and wakeup output. --idle, -c : show c-states --frequency, -p : show p-states --wakeup, -w: show wakeup sources Signed-off-by: Daniel Lezcano --- idlestat.c | 33 ++--- idlestat.h |4 2 files changed

[PATCH idlestat 09/12] Improve the output

| 8.00ms |10 | 0 | 0 | | C7-IVB | 0us | 98.04ms | 6.92ms | 26.99s | 3899 | 0 | 0 | Signed-off-by: Daniel Lezcano --- idlestat.c | 209

[PATCH idlestat 01/12] Fix CPU affinity mask

solve this issue, by properly recovering the original CPU affinity mask. Moreover, it avoids to wake up CPUs that will not be used to run the workload. Signed-off-by: Patrick Bellasi Signed-off-by: Daniel Lezcano --- idlestat.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a

[PATCH idlestat 12/12] Report even if the application returned an error code

In case the application is killed by the timeout and it handles the SIGTERM, it may return an error, thus idlestat won't display the result. Ignore the return code of the application. Signed-off-by: Daniel Lezcano --- idlestat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH idlestat 08/12] Don't double check with the estimate function

Signed-off-by: Daniel Lezcano --- idlestat.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/idlestat.c b/idlestat.c index b084b5d..e5dde8c 100644 --- a/idlestat.c +++ b/idlestat.c @@ -72,15 +72,7 @@ static int display_cstates(struct cpuidle_cstates *cstates

[PATCH idlestat 02/12] Fix some lines to comply with 80 chars length

Signed-off-by: Daniel Lezcano --- idlestat.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/idlestat.c b/idlestat.c index 2a0c549..30860db 100644 --- a/idlestat.c +++ b/idlestat.c @@ -1162,7 +1162,8 @@ static int idlestat_file_for_each_line(const char *path

[PATCH idlestat 11/12] Split the display to show the wakeup separetely

Signed-off-by: Daniel Lezcano --- idlestat.c | 102 ++-- topology.c | 10 +++--- 2 files changed, 70 insertions(+), 42 deletions(-) diff --git a/idlestat.c b/idlestat.c index da1e14b..24248b2 100644 --- a/idlestat.c +++ b/idlestat.c

[PATCH idlestat 06/12] Remove dump and iterations options

Signed-off-by: Daniel Lezcano --- idlestat.c | 72 ++-- idlestat.h |2 -- topology.c | 12 +- topology.h |5 ++--- 4 files changed, 19 insertions(+), 72 deletions(-) diff --git a/idlestat.c b/idlestat.c index 8138e35

[PATCH idlestat 04/12] Add 'patches' directory to the ignored list of files in .gitignore

Signed-off-by: Daniel Lezcano --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 968abde..4ee98b8 100644 --- a/.gitignore +++ b/.gitignore @@ -30,6 +30,7 @@ *.orig *~ \#*# +patches # # Top-level files -- 1.7.9.5

[PATCH idlestat 03/12] Remove the debug and iteration options

This function are pointless, remove them. Signed-off-by: Daniel Lezcano --- idlestat.c | 16 ++-- idlestat.h |1 - 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/idlestat.c b/idlestat.c index 30860db..abbb787 100644 --- a/idlestat.c +++ b/idlestat.c

Re: [PATCH IDLESTAT] fix execute() function

On 06/04/2014 08:00 AM, Mohammad Merajul Islam Molla wrote: Patch to fix the below two issues - 1. Fix the part where parent waits to fetch child status. In case SIGALRM is received, fetch new status after killing child so that subsequent check for termination status passes. 2. In case of normal

Re: [idlestat 0/6] More cleanups

+++--- 2 files changed, 54 insertions(+), 27 deletions(-) For the whole series: Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pag

Re: idlestat: execute() function problems?

On 06/03/2014 11:53 AM, Mohammad Merajul Islam Molla wrote: Hello, I noticed some odd behaviors with idlestate.c/execute() function. 1. I wrote a sample program hello.c with infinite loop - int main() { while(1); } #sudo ../idlestat/idlestat -o /tmp/myoutput ../temp/

Re: [PATCH 8/9] improve help - show all available options

On 05/29/2014 12:17 AM, Amit Kucheria wrote: Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano --- README | 7 +-- idlestat.c | 11 --- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/README b/README index 3a8eb49..24485c5 100644 --- a/README +++ b

Re: [PATCH 9/9] idledebug? When did we ever call it that?

On 05/29/2014 12:17 AM, Amit Kucheria wrote: Signed-off-by: Amit Kucheria Yep, powerdebug => idledebug => idlestat :) Legacy copy/paste from powerdebug. Acked-by: Daniel Lezcano --- idlestat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/idlest

Re: [PATCH 7/9] struct option long_options doesn't need to be global

On 05/29/2014 12:17 AM, Amit Kucheria wrote: Change the flag field to NULL while we're at it Signed-off-by: Amit Kucheria --- idlestat.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/idlestat.c b/idlestat.c index 96fc1f2..c4a405a 100644 --- a/idl

Re: [PATCH 6/9] Make getopt_long handling more robust

On 05/29/2014 12:17 AM, Amit Kucheria wrote: Adding ':' as first character of optstring to getopt_long allows separating error message for invalid option and invalid option arguments Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano --- idlestat.c | 15 ++

Re: [PATCH 5/9] Stick to -d for debug according to widely used convention

On 05/29/2014 12:17 AM, Amit Kucheria wrote: Switch the dump option (which might be used infrequently) to use -m Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano --- idlestat.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/idlestat.c b

Re: [PATCH 3/9] Adding missing 'duration' option in long_options

On 05/29/2014 12:17 AM, Amit Kucheria wrote: commit 1e80e5eaf71b606405cbdf6751aa7446533d8b3a (idlestat: get ride of trace-cmd) seems to have missed adding this Signed-off-by: Amit Kucheria Good catch. Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open

Re: [PATCH 4/9] Specify which options need arguments and which don't to help getopt_long()

On 05/29/2014 12:17 AM, Amit Kucheria wrote: Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/lin

Re: [PATCH 2/9] Sort options in alphabetic order of the single-char options

On 05/29/2014 12:17 AM, Amit Kucheria wrote: Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg&g

Re: [PATCH 1/9] 'verbose' option isn't used anywhere, remove it

On 05/29/2014 12:17 AM, Amit Kucheria wrote: Signed-off-by: Amit Kucheria Acked-by: Daniel Lezcano --- idlestat.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/idlestat.c b/idlestat.c index 3b4bd17..27000aa 100644 --- a/idlestat.c +++ b/idlestat.c @@ -960,7

Re: [PATCH PMQA] cpuidle_killer: allocate per cpu process array dynamically

On 04/30/2014 10:34 AM, Mohammad Merajul Islam Molla wrote: Hello Sanjay, As far I know, if option argument is 0, the parent will wait for specified child pid to terminate, its not for immediate return as in case of WNOHANG. This is probably the intended use of the code (author will be able to co

Re: Arndale 5250 crash when unplugging CPU1

On 12 April 2014 14:51, Daniel Lezcano wrote: Hi all, I used the image: arndale-saucy_server_20140222-611.img I boots well but when I unplug CPU1, the kernel crashes. It seems related to the AFTR state (an idle state of cpuidle) and the u-boot version which is 2013-rc1. It seems

Re: Arndale 5250 crash when unplugging CPU1

tile says BE image the issue is applicable to LE thumb2 issue. Check your kernel config if THUMB2_KERNEL set the issue is applicable to you. Thanks, Victor On 12 April 2014 14:51, Daniel Lezcano wrote: Hi all, I used the image: arndale-saucy_server_20140222-611.img I boots well but

Re: Arndale 5250 crash when unplugging CPU1

your kernel config if THUMB2_KERNEL set the issue is applicable to you. Thanks, Victor On 12 April 2014 14:51, Daniel Lezcano wrote: Hi all, I used the image: arndale-saucy_server_20140222-611.img I boots well but when I unplug CPU1, the kernel crashes. It seems related to the AFTR

Arndale 5250 crash when unplugging CPU1

Hi all, I used the image: arndale-saucy_server_20140222-611.img I boots well but when I unplug CPU1, the kernel crashes. It seems related to the AFTR state (an idle state of cpuidle) and the u-boot version which is 2013-rc1. It seems this issue does not happen with a more recent u-b

Re: [PATCH] Produce a situation where L1 cache flush missing vs cpu power down hangs the system

. The only way to properly handle this is to call always v7_exit_coherency_flush before powering down the cpu. On 9 April 2014 13:24, Daniel Lezcano mailto:daniel.lezc...@linaro.org>> wrote: Hi Sandeep, On 04/09/2014 07:15 AM, Sandeep Tripathy wrote: Hi

Re: [PATCH] Produce a situation where L1 cache flush missing vs cpu power down hangs the system

a way to spot the issue, I will be happy to test it. Thanks -- Daniel On 8 April 2014 17:07, Daniel Lezcano mailto:daniel.lezc...@linaro.org>> wrote: On 04/08/2014 01:07 PM, Amit Kucheria wrote: Hi Daniel, Have you noticed this on any platform yet with this test?

Re: [PATCH] Produce a situation where L1 cache flush missing vs cpu power down hangs the system

On 04/08/2014 01:07 PM, Amit Kucheria wrote: Hi Daniel, Have you noticed this on any platform yet with this test? I have noticed a very very rare hang on the exynos4 board with this test and the dual cpu support but it is not reproducible enough to check if the cache flush fixes it or not (o

[PATCH] Produce a situation where L1 cache flush missing vs cpu power down hangs the system

issue everytime. Signed-off-by: Daniel Lezcano --- cpuidle/cpuidle-l1.c | 72 cpuidle/cpuidle_05.sh | 42 cpuidle/cpuidle_05.txt |1 + 3 files changed, 115 insertions(+) create mode 100644 cpuidle/cpuidle-l1

[PATCH] idlestat: add timeout for the exec'ed command

From: Daniel Lezcano Add a timeout for the specified command. The timeout option is shared with the -t option. When no command line has to be executed, the timeout becomes the duration of the acquisition, otherwise the command is executed during an amount of time and terminated if the timeout

[PATCH] idlestat: run a command with idlestat

From: Daniel Lezcano Add the support to run a command line with idlestat: ./idlestat -o out.dat -- /bin/sleep 3 Without the '-t' option, idlestat will blindly use the current buffer size which may not fit with the 'command' duration and lead to a buffer overflow. With t

[PATCH 3/6] Fix memory leak, result is being leaked on a realloc failure

From: Colin Ian King A realloc failure leaks result on the error return path. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c |1 + 1 file changed, 1 insertion(+) diff --git a/idlestat.c b/idlestat.c index 41ed3ab..739f6dc 100644 --- a/idlestat.c +++ b

[PATCH 5/6] Fix file and memory resource leak on error exit in idlestat_load

From: Colin Ian King The error returns in idlestat_load fail to close an open file and free allocated memory on the heap. This patch addresses this. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions

[PATCH 6/6] Use the correct format specifier for size_t type

From: Colin Ian King Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/idlestat.c b/idlestat.c index 0961463..3f6076e 100644 --- a/idlestat.c +++ b/idlestat.c @@ -447,7 +447,7 @@ static struct

[PATCH 4/6] check s_cpu rather than s_core on memory allocation

From: Colin Ian King s_cpu is not being checked for a memory allocation failure, instead s_core is being checked. Fix this cut-n-paste error. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- topology.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 1/6] Write open failure message to stderr

From: Colin Ian King Error message should be written to stderr rather than the failed to open file. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/idlestat.c b/idlestat.c index 3abfaaf..fce6112

[PATCH 2/6] Free memory on realloc failure.

From: Colin Ian King Fix a common coding error where realloc fails and the original allocated data is not free'd. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/idlesta

[PATCH 6/6] Use the correct format specifier for size_t type

From: Colin Ian King Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/idlestat.c b/idlestat.c index 0961463..3f6076e 100644 --- a/idlestat.c +++ b/idlestat.c @@ -447,7 +447,7 @@ static struct

[PATCH 4/6] check s_cpu rather than s_core on memory allocation

From: Colin Ian King s_cpu is not being checked for a memory allocation failure, instead s_core is being checked. Fix this cut-n-paste error. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- topology.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 5/6] Fix file and memory resource leak on error exit in idlestat_load

From: Colin Ian King The error returns in idlestat_load fail to close an open file and free allocated memory on the heap. This patch addresses this. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions

[PATCH 2/6] Free memory on realloc failure.

From: Colin Ian King Fix a common coding error where realloc fails and the original allocated data is not free'd. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/idlesta

[PATCH 3/6] Fix memory leak, result is being leaked on a realloc failure

From: Colin Ian King A realloc failure leaks result on the error return path. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c |1 + 1 file changed, 1 insertion(+) diff --git a/idlestat.c b/idlestat.c index 41ed3ab..739f6dc 100644 --- a/idlestat.c +++ b

[PATCH 1/6] Write open failure message to stderr

From: Colin Ian King Error message should be written to stderr rather than the failed to open file. Signed-off-by: Colin Ian King Signed-off-by: Daniel Lezcano --- idlestat.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/idlestat.c b/idlestat.c index 3abfaaf..fce6112

[GIT PULL] idlestat: some fixes on error path

Hi Zoran, Colin King sent me some patches to fixup memory leaks and some nits in the error code path. Please, pull these changes in your tree. The following changes since commit da6a8c94a8f8124711db0ae84a3ef4e0e186b388: Fixing improperly initialized cstate_max per-CPU. (2014-01-29 15:47:

Re: arndale ethernet not working on u-boot

: arndale ethernet not working on u-boot On 8 November 2013 13:44, Daniel Lezcano wrote: Hi all, I have an arndale and I am trying to have the ethernet working in u-boot but without success. (Re)start USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 2 USB Device(s) found scanning usb for

arndale ethernet not working on u-boot

Hi all, I have an arndale and I am trying to have the ethernet working in u-boot but without success. (Re)start USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 2 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 0 E

Re: [tool recommendation] tmate terminal sharing

On 10/17/2013 03:09 AM, Christoffer Dall wrote: Hi all, [apologies in advance for the spam nature of this message] I have been using a tool for remote collaboration and problem solving that I find perfect in the context of remote collaboration. It allows you to very easily share a terminal ses

Re: Beaglebone Black Core temperature

On 10/01/2013 03:50 PM, Sanjay Singh Rawat wrote: On Tuesday 01 October 2013 06:45 PM, Gaurang Shastri wrote: Hi, Do you mean to say something like lm-sensor kind of utility?? May be from this package you will get to know what you want :-) //Gaurang Shastri On Tue, Oct 1, 2013 at 5:32 PM, Da

u-boot and dnw

Hi, I am using the latest mainstream u-boot but the dnw command is not there. Is there an equivalent to download the kernel from USB (except sending the file through the console) ? Thanks -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: <

Re: ux500 not booting

On 06/07/2013 09:34 AM, Linus Walleij wrote: > On Thu, Jun 6, 2013 at 6:15 PM, Daniel Lezcano > wrote: > >> I tried to boot my ux500 > > Is this an HREF (black plastic box) or the Snowball board? > >> with the 3.10-rc4 kernel but it hangs at boot >> time

Re: ux500 not booting

On 06/07/2013 09:34 AM, Linus Walleij wrote: > On Thu, Jun 6, 2013 at 6:15 PM, Daniel Lezcano > wrote: > >> I tried to boot my ux500 > > Is this an HREF (black plastic box) or the Snowball board? It is the snowball board. >> with the 3.10-rc4 kernel but it han

ux500 not booting

Hi Linus, I tried to boot my ux500 with the 3.10-rc4 kernel but it hangs at boot time with the following messages: mmcblk0: error -110 transferring data, sector 2891778, nr 6, cmd response 0x900, card status 0x0 mmci-pl18x sdi4: error during DMA transfer! mmcblk0: error -110 transferring data, s

Re: [PATCH] cpuidle: arm_big_little: route target residency to mcpm

On 05/15/2013 05:24 PM, Liviu Dudau wrote: > Hi Sebastian, > > On Mon, May 13, 2013 at 07:53:42PM +0100, Sebastian Capella wrote: >> Pass residency information to the mcpm_cpu_suspend. The information >> is taken from the target_residency of the intended C-state. >> >> When a platform uses multip

Re: [resend] Timer broadcast question

On 02/21/2013 07:19 AM, Santosh Shilimkar wrote: > On Tuesday 19 February 2013 11:51 PM, Daniel Lezcano wrote: >> On 02/19/2013 07:10 PM, Thomas Gleixner wrote: >>> On Tue, 19 Feb 2013, Daniel Lezcano wrote: >>>> I am working on identifying the different wakeup source

Re: [pmqa,1/1] cpuidle: add function to log cpuidle stats

On 02/20/2013 12:54 PM, Amit Kucheria wrote: > On Tue, Feb 19, 2013 at 10:11 AM, Sanjay Singh Rawat > wrote: >> Add functionality to record the overall and current runtime cpuidle >> statistics. > > I'd like the output to be something list this: > > [state1]: [number of times entered]: [average

Re: [resend] Timer broadcast question

On 02/19/2013 07:10 PM, Thomas Gleixner wrote: > On Tue, 19 Feb 2013, Daniel Lezcano wrote: >> I am working on identifying the different wakeup sources from the >> interrupts and I have a question regarding the timer broadcast. >> >> The broadcast timer is setup to t

[resend] Timer broadcast question

Hi, I am working on identifying the different wakeup sources from the interrupts and I have a question regarding the timer broadcast. The broadcast timer is setup to the next event and that will wake up any idle cpu belonging to the "broadcast cpumask", right ? The cpu which has been woken up w

[PATCH 4/4] ACPI / idle: remove usage of the statedata

Len Brown sent a patch to remove this field in the intel_idle driver. The other user of this field is the davinci cpuidle driver and a patch has been sent to remove the usage of it. This patch removes the last user of this field. Signed-off-by: Daniel Lezcano --- drivers/acpi/processor_idle.c

[PATCH 2/4] ACPI / idle : remove pointless headers

These different headers are not needed. Signed-off-by: Daniel Lezcano --- drivers/acpi/processor_idle.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 5cb5f24..82626e9 100644 --- a/drivers

[PATCH 3/4] ACPI / idle: pass the cpuidle_device parameter

The cpuidle_device is retrieved in the function by using directly the global variable. But the caller of this function already have this device and it can be passed as a parameter. That is one small step to encapsulate the code more. Signed-off-by: Daniel Lezcano --- drivers/acpi

[PATCH 1/4] ACPI / idle: remove unused definition

The different definitions are not used anywhere in the code. Signed-off-by: Daniel Lezcano --- drivers/acpi/processor_idle.c |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index e606e36..5cb5f24 100644 --- a/drivers/acpi

Re: [PATCH 0/4] davinci: cpuidle - some cleanups

On 02/01/2013 07:49 PM, Len Brown wrote: > On 02/01/2013 08:48 AM, Daniel Lezcano wrote: >> This patchset does some cleanup. It could have been folded in a single >> patch but the review would have been less clean than splitting it into >> small and trivial patches. >>

[PATCH 1/4][V2] davinci: cpuidle - use global variable for ddr2 flag

Replace the flag by a simple global boolean in the cpuidle.c. That will allow to cleanup the rest of the code right after, because the ops won't make sense. Signed-off-by: Daniel Lezcano Acked-by: Sekhar Nori --- arch/arm/mach-davinci/cpuidle.c | 23 ++- 1 file ch

[PATCH 4/4][V2] davinci: cpuidle - remove useless initialization

The device->state_count is initialized in the cpuidle_register_device function. Signed-off-by: Daniel Lezcano Acked-by: Sekhar Nori --- arch/arm/mach-davinci/cpuidle.c |2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-davinci/cpuidle.c b/arch/arm/mach-davinci/cpuidl

[PATCH 0/4][V2] davinci: cpuidle - some cleanups

initialization to 'false' * added Acked-by: Sekhar Nori V1: initial post Daniel Lezcano (4): davinci: cpuidle - use global variable for ddr2 flag davinci: cpuidle - move code to prevent forward declaration davinci: cpuidle - remove the ops davinci: cpuidle - remove useless init

[PATCH 3/4][V2] davinci: cpuidle - remove the ops

With one function handling the idle state and a single variable, the usage of the davinci_ops is overkill. This patch removes these ops and simplify the code. Furthermore, the 'driver_data' field is no longer used, we have 1 of the 3 remaining user of this field removed. Signed-off-

  1   2   3   4   5   6   7   8   >