Re: Move Tweak_engraver to Score level (issue 8340044)

Reviewers: janek, Message: Regarding the description: "Acknowledgers should usually just register a grob (or write grob data) with any actual reading of grob data occurring at the end of the timestep instead." Strictly speaking, this principle has been violated already by allowing subproperty tw

Re: Change appearance of clef octavation (issue 3295) (issue 8359043)

It's probably worth noting that by far most uses of octavated clefs are for the purpose of correctness (similar to "transposition in xxx"): the player/singer would not actually execute the piece differently if the octavation was omitted from the clef. I can think of one exception: modern-clef ren

Re: Add point-and-click to SVG output (issue 8273045)

https://codereview.appspot.com/8273045/diff/2001/scm/output-svg.scm File scm/output-svg.scm (right): https://codereview.appspot.com/8273045/diff/2001/scm/output-svg.scm#newcode545 scm/output-svg.scm:545: (if close-link This code is too horrible to contemplate. Setting a global variable in this

Remove remaining uses of \times (3301) (issue 8509043)

https://codereview.appspot.com/8509043/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/8509043/diff/1/Documentation/learning/fundamental.itely#newcode502 Documentation/learning/fundamental.itely:502: between or

parser: more specific error messages; issue 3300 (issue 8506043)

https://codereview.appspot.com/8506043/diff/1/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/8506043/diff/1/lily/parser.yy#newcode2323 lily/parser.yy:2323: | STRING This not fully equivalent, but I think that LYRIC_ELEMENT is not expected to occur here, so it is likel

Re: parser: more specific error messages; issue 3300 (issue 8506043)

On 2013/04/08 17:58:43, Keith wrote: On 2013/04/08 16:05:20, dak wrote: > > Here is the problem I have with this change: for > \new Lyrics { hello, Dolly } > the error message will become quite less helpful. Yep. Version 2.16 printed the same "unexpected STRING". I

Re: doc: explain how to add lyrics to polyphonic sections (issue 3236) (issue 8384043)

On 2013/04/10 06:50:59, janek wrote: https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely File Documentation/notation/vocal.itely (right): https://codereview.appspot.com/8384043/diff/15001/Documentation/notation/vocal.itely#newcode1641 Documentation/notation/v

Re: Issue 3307: Rest positions incorrect with non-standard line count (issue 8580045)

On 2013/04/10 05:47:20, Keith wrote: You changed more than necessary to fix the reported bug. This is good because finally voiced r1-style whole rests are in the correct positions (which I confirmed with Ted Ross' book just to be careful). More by coincidence than by design. That was like

Re: doc: explain how to add lyrics to polyphonic sections (issue 3236) (issue 8384043)

On 2013/04/10 10:45:29, janek wrote: bang. that's why i don't like writing docs - i don't remember the syntax :) I wonder if it would be easier if we were using some wiki - this was a simple doc addition and it took me about an hour to do all the maintenance... You _are_ aware that a simpl

Re: Let horizontal-line be a straight-cut line rather than having rounded edges (issue 8685043)

Reviewers: thomasmorley65, Message: On 2013/04/11 23:44:03, thomasmorley65 wrote: Can't review C++ -code, though, from description, I do not understand the reason for it. Well, ofcourse it will merge better with barlines, but can you give an example where the problem isn't solvable with a

Re: parser: more specific error messages; issue 3300 (issue 8506043)

On 2013/04/12 04:07:15, Keith wrote: On 2013/04/08 18:07:50, dak wrote: > On 2013/04/08 17:58:43, Keith wrote: > > On 2013/04/08 16:05:20, dak wrote: > > > > Apropos: do you have an example of where your refactoring leads to > > > a better error behavior (inde

Re: parser: more specific error messages; issue 3300 (issue 8506043)

On 2013/04/12 05:58:58, dak wrote: Or something more verbose like "a markup here would require \\lyricmode". That exact wording would likely let the uset write \lyricmode \markup ... which will not be helpful. So perhaps rather "a markup here would require to be in \\ly

Re: parser: more specific error messages; issue 3300 (issue 8506043)

On 2013/04/12 06:05:42, dak wrote: On 2013/04/12 05:58:58, dak wrote: > Or something more verbose like > "a markup here would require \\lyricmode". That exact wording would likely let the uset write \lyricmode \markup ... which will not be helpful. So perhaps rather &quo

Re: Doc: rename section in LM (3280) (issue 8575044)

On 2013/04/12 09:31:17, Trevor Daniels wrote: On 2013/04/11 22:37:41, Graham Percival wrote: > I think it would be nicer if we could find a word that wasn't a command word > ("modifications"? "adjustments" ? "customizations"?) but I agree that in this > case "override" is better than "tweak

Re: Doc: rename section in LM (3280) (issue 8575044)

On 2013/04/12 10:26:46, mail_philholmes.net wrote: - Original Message - From: > I think "retouching" is pretty much on spot. Asking the thesaurus does > not really deliver anything more convincing: Sorry - I don't agree. In native English, retouching has a

Re: Be serious about setstrokeadjust in PostScript primitives (issue 8663044)

On 2013/04/14 20:38:12, janek wrote: David, i'm sorry, but i don't understand what the code does. Obviously, it would help if i knew Postscript ;) but unfortunately i don't have time to learn it now. The most important resource is PLRM.pdf (available on Adobe's website, though the locatio

Re: Be serious about setstrokeadjust in PostScript primitives (issue 8663044)

On 2013/04/14 21:43:36, janek wrote: 2013/4/14 : > On 2013/04/14 20:38:12, janek wrote: >> i'm sorry, but i don't understand what the code does. >> Obviously, it would help if i knew Postscript ;) but >> unfortunately i don't have time to learn it now. > > The most important resource is PLRM.pdf

Re: Woodwind diagrams (issue 1425041)

https://codereview.appspot.com/1425041/diff/12001/ps/music-drawing-routines.ps File ps/music-drawing-routines.ps (right): https://codereview.appspot.com/1425041/diff/12001/ps/music-drawing-routines.ps#newcode196 ps/music-drawing-routines.ps:196: +% Note that filled is not boolean to permit for d

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

On 2013/04/16 06:05:42, MikeSol wrote: https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/8613043/diff/19001/Documentation/changes.tely#newcode153 Documentation/changes.tely:153: @item I would a

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

On 2013/04/16 07:40:19, Trevor Daniels wrote: On 2013/04/16 07:20:59, dak wrote: > On 2013/04/16 06:05:42, MikeSol wrote: >> I would add a note that, if there is too-snug spacing >> for an object, setting its vertical skylines to #'() >> will generally restore old beh

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

On 2013/04/16 08:34:43, MikeSol wrote: On 2013/04/16 07:51:46, dak wrote: > > I hate it when I get last-minute realizations. Here is another > thing we need to do for the stable release: go through all > problems of the "too snug" kind and work out defaults that avoid &g

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/04/16 12:50:47, david.nalesnik wrote: On 2013/04/13 21:39:40, janek wrote: > There's one thing that puzzles me. Current syntax is > > \offset property offset-value grob-name > > I understand that grob-name is at the end because it's optional, and we want to > omit it when we're using \

Re: Add the command \offset to LilyPond (issue 8647044)

and there's too many "or-nothing"s there (i suppose that the biggest problem is an optional argument followed by non-optional one ("value")). However, in case of \offset, we can have either a \shape-like syntax \offset property value grobname-or-music or \offset grobwithproperty-or-prope

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/04/16 14:33:50, janek wrote: 2013/4/16 : > nothing-or-music in the last position only works if "nothing" is > _explicitly_ specified with \default > > There is no way that the last argument of a music function can be > "nothing" silently. pity. would it possible (and reasonable) t

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

On 2013/04/16 11:11:03, janek wrote: 2013/4/16 : > I hate it when I get last-minute realizations. Here is another thing we > need to do for the stable release: go through all problems of the "too > snug" kind and work out defaults that avoid them. This might be impossible. For example t

Re: Add callback factory grob::inherit-parent-property (issue 8726045)

Reviewers: MikeSol, Message: On 2013/04/17 18:27:05, MikeSol wrote: Hey, I hadn't seen this. I just finished writing an equivalent patch. Yours is better, so keep it. You can use this for the inherit-X-parent-visibility and eliminate the inherit-Y-parent-visibility callback, which is cruft

Re: Add callback factory grob::inherit-parent-property (issue 8726045)

On 2013/04/17 18:27:05, MikeSol wrote: Hey, I hadn't seen this. I just finished writing an equivalent patch. Yours is better, so keep it. You can use this for the inherit-X-parent-visibility and eliminate the inherit-Y-parent-visibility callback, which is cruft and can be replaced with the

Re: Doc: Document the use of \temporary (2938) (issue 8859044)

https://codereview.appspot.com/8859044/diff/1/Documentation/extending/programming-interface.itely File Documentation/extending/programming-interface.itely (right): https://codereview.appspot.com/8859044/diff/1/Documentation/extending/programming-interface.itely#newcode413 Documentation/extending

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/04/23 19:03:18, david.nalesnik wrote: On 2013/04/23 13:14:23, janek wrote: > anyway, this patch LTGM. Thanks, Janek! The patch has passed countdown, but in view of the fact that a stable release is on the horizon, it may not be appropriate to push it at this time. On the other

Re: Add the command \offset to LilyPond (issue 8647044)

Sorry for the late review. https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly File input/regression/offsets.ly (right): https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly#newcode5 input/regression/offsets.ly:5: the @code{\\offset} command. Th

Re: Add the command \offset to LilyPond (issue 8647044)

On 2013/04/23 20:24:57, dak wrote: Why would tweak/override add to the _immutable_ properties? How could they? Is there something I don't understand here? To answer myself: the basic properties would contain overrides (set there from the respectively changed context property) but not t

Re: Be serious about setstrokeadjust in PostScript primitives (issue 8663044)

On 2013/04/23 21:56:07, Keith wrote: Confirming that the .pdf size doubles, but only if we measure relative to the size of the smaller .pdfs we get if we know to use -dno-point-and-click. The time required to process the larger .ps was less that 1% the total time to compile my test .ly fil

Re: Be serious about setstrokeadjust in PostScript primitives (issue 8663044)

On 2013/04/25 03:10:59, Keith wrote: LGTM, if you really think masking the stem is a reliable solution. ahhahhahahahahahahahaha. Of course I really don't think it a reliable solution. I mean, look at how ridiculous the code is: I am bending the mask away from the stroke wherever possible

Re: Doc: Remove space before the tie symbol (3133) (issue 8758047)

On 2013/04/25 15:10:35, Graham Percival wrote: I'm not wild about having ties without a space in front of them, but I can't think of any rational reason for my reaction, so I guess LGTM. Oh, there is a perfectly rational reason: ties are placed symmetrically between notes, so placing them sym

Re: Be serious about setstrokeadjust in PostScript primitives (issue 8663044)

On 2013/04/25 07:47:47, dak wrote: On 2013/04/25 03:10:59, Keith wrote: > LGTM, > if you really think masking the stem is a reliable solution. ahhahhahahahahahahahaha. Of course I really don't think it a reliable solution. I mean, look at how ridiculous the code is: I am

Re: Markup, page-ref: do not backspace; issue 3334 (issue 8639045)

On 2013/04/27 05:29:48, Keith wrote: https://codereview.appspot.com/8639045/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (left): https://codereview.appspot.com/8639045/diff/1/scm/define-markup-commands.scm#oldcode4083 scm/define-markup-commands.scm:4083: (markup

Re: Markup, page-ref: do not backspace; issue 3334 (issue 8639045)

On 2013/04/27 06:14:00, Keith wrote: That symptom is probably a sign that it was unwise to have \hspace try to correct for inter-word space. Definitely. Given the amount of trouble we have had with \hspace so far (we have several alignment problems open in the context of trying to allow \hs

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/28 14:50:06, janek wrote: could you put this in a branch? I strongly prefer reading git log --patch than a single diff Small wonder. Pushed it into dev/issue3330 https://codereview.appspot.com/8869044/ ___ lilypond-devel mailing list

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/28 22:16:14, Keith wrote: https://codereview.appspot.com/8869044/diff/9001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/8869044/diff/9001/scm/define-markup-commands.scm#newcode3765 scm/define-markup-commands.scm:3765: *

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/28 21:59:37, janek wrote: changes i see generally LGTM (but i may be missing something, in particular Keith seems to make a good point). > Let Stencil::is_empty use Box::is_empty [...] I think the desription of this commit could use some more detail, for example that we need

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/29 07:39:04, Keith wrote: On 2013/04/29 07:26:50, janek wrote: > On 2013/04/29 03:31:14, Keith wrote: > > I worry a little about making the extent of markup different from the union of > > its components. Someone may have used c4^\markup{\hspace #-3 "text"} and > > the left side

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/29 07:35:05, janek wrote: On 2013/04/28 23:16:28, dak wrote: ok, and i agree that adding a comment like this into the source may not be a good idea. However, git commit message has a different purpose (to myself at least); i want to know why something changed. When i&#

Re: Issue 3293: Add point-and-click to SVG output (issue 8974043)

On 2013/04/29 15:57:10, Graham Percival wrote: Cool, that looks much better than my previous patch. Thanks! Unfortunately, although firefox and inkscape handle the resulting svg file quite well, it isn't a valid file. According to the w3c validator http://validator.w3.org/check svg 1.1

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/8869044/diff/22012/scm/stencil.scm#newcode46 scm/stencil.scm:46: (lambda (tail head) On 2013/04/30 03:10:52, Keith wrote: Usually, the head is fixed-length and the tail

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/04/30 03:10:52, Keith wrote: The commit 'simplify stack-stencils' seems strange, and wrong in one detail. I suppose that stacking the stencils from start of list to end is a bit simpler conceptually. "reduce" is appropriate to use here. The line stacking (with baseline), in contras

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

https://codereview.appspot.com/8869044/diff/60001/scripts/auxiliar/make-regtest-pngs.sh File scripts/auxiliar/make-regtest-pngs.sh (left): https://codereview.appspot.com/8869044/diff/60001/scripts/auxiliar/make-regtest-pngs.sh#oldcode9 scripts/auxiliar/make-regtest-pngs.sh:9: # On 2013/05/03 05:

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/05/03 05:18:26, Keith wrote: Shucks. It gets difficult to space a list of stencils if all you have to work with are the refpoint and extents of the next stencil, and the composite of those accumulated so far. What we would like is : \line {a b c ... } places the left extent of eac

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/05/05 01:50:23, Keith wrote: If you know how to keep track of a cursor position in Scheme, the you could put the implementation of backspace in stack-stencil-line and any other functions that assemble a line of stencils. That would probably be easier for future programmers to unde

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

Please try indicating the quoting levels. This is a bit confusing otherwise. Fixing in the reply On 2013/05/07 06:03:07, Keith wrote: On Mon, 06 May 2013 03:21:18 -0700, David Kastrup wrote: "Keith OHara" writes: Oh. I thought it was goo

Re: Issue 3330: redo much of the stencil stacking/spacing/empty-check (issue 8869044)

On 2013/05/12 21:50:13, Keith wrote: This works. I found a only couple cases on mutopiaproject that depended on the old behavior. \markup { "V" \translate #'(-2.5 . 0.325) \rotate #70 "—" } This would work with \hspace#'-2.5, or even better with \combine, which is what the manual suggest

Beams: be transparent if the first stem is transparent; issue 2866 (issue 9239046)

https://codereview.appspot.com/9239046/diff/1/scm/music-functions.scm File scm/music-functions.scm (left): https://codereview.appspot.com/9239046/diff/1/scm/music-functions.scm#oldcode1947 scm/music-functions.scm:1947: (map (lambda (st) That's a case for for-each, not map. https://codereview.ap

Re: Fixes problem with -dpreview cropping staff brackets (Issue 3386) (issue 9894043)

On 2013/05/31 12:29:46, PhilEHolmes wrote: Please review. Color me surprised. Patch set 3 from the original patch is called "Patch Set 3 : Removes evil code from C++, replaces with happy defaults in Scheme". Your partial revert only removes the "happy defaults in Scheme" without reinstating t

Re: Skylines: reject steep-sloped buildings; issue 3383 (issue 9890045)

https://codereview.appspot.com/9890045/diff/1/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/9890045/diff/1/lily/skyline.cc#newcode117 lily/skyline.cc:117: slope_ = 0.0; /* if they were both infinite, we would get nan, not 0, from the next line */ That comment is a

Re: Use @dots{} instead of ... in notation manual where appropriate (issue 9964043)

https://codereview.appspot.com/9964043/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): https://codereview.appspot.com/9964043/diff/1/Documentation/notation/simultaneous.itely#newcode49 Documentation/notation/simultaneous.itely:49: @funinde

Re: Reformat some files to let emacs do its work correctly. (issue 9863047)

https://codereview.appspot.com/9863047/diff/1/scm/define-context-properties.scm File scm/define-context-properties.scm (right): https://codereview.appspot.com/9863047/diff/1/scm/define-context-properties.scm#newcode325 scm/define-context-properties.scm:325: (glissandoMap ,list? "A map in the for

Re: Reformat some files to let emacs do its work correctly. (issue 9863047)

n the form of On 2013/06/06 09:44:49, dak wrote: _Every_ change in this file is _inside_ of strings, not exactly increasing their usefulness as documentation strings. I really don't understand why not even the author of large automated changes apparently can be bothered to scan once throug

Re: Reformat some files to let emacs do its work correctly. (issue 9863047)

n the form of On 2013/06/06 09:44:49, dak wrote: _Every_ change in this file is _inside_ of strings, not exactly increasing their usefulness as documentation strings. Ok, apparently I mixed up the purpose of this patch (which exactly was _not_ an automated patch but rather reformatted the strin

Re: Format inserting-score-fragments snippet nicer in the wake of issue 3187 (issue 9705045)

Reviewers: Graham Percival, Message: On 2013/06/06 21:26:28, Graham Percival wrote: I think the original version was more general, No, it wasn't. Not having a clue about the alignment of the staff within the score containing the tuning, it centered the whole score, in this case between the to

Re: Implement optional music function arguments (issue 5023044)

Next round. Getting past shift/reduce conflicts required adding precendences to every terminal token that can start the last non-optional argument. But the resulting grammar is O(n): adding more elements to it is quite straightforward. http://codereview.appspot.com/5023044/ ___

Re: Doc: add a note about \relative f to notation (issue 1909) (issue 5096046)

http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode258 Documentation/notation/pitches.itely:258: If you carefully consider al

Implement define-event-function (issue 5083045)

Reviewers: , Message: This allows defining music functions that can be used as directionless events, a frequently made request. It may be noted that the amount of code needed for implementing this functionality is not exactly staggering given the current infrastructure in lexer and parser. Exam

Re: Implement define-event-function (issue 5083045)

On 2011/09/21 19:44:46, Neil Puttock wrote: On 2011/09/21 19:40:37, http://reinhold_kainhofer.com wrote: > Huh? How do you verify that your feature works at all? I'm sure you are using > some simple test file for this. So, simply take that file, add a \header { > doctitle="some short descr

Re: Implement define-event-function (issue 5083045)

http://codereview.appspot.com/5083045/diff/1/scm/c++.scm File scm/c++.scm (right): http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38 scm/c++.scm:38: (define-public (event? x) On 2011/09/21 21:32:30, Neil Puttock wrote: I'd prefer a less vague name for this since it's going to c

Re: Implement define-event-function (issue 5083045)

http://codereview.appspot.com/5083045/diff/1/scm/c++.scm File scm/c++.scm (right): http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38 scm/c++.scm:38: (define-public (event? x) On 2011/09/21 22:14:40, dak wrote: On 2011/09/21 21:32:30, Neil Puttock wrote: > I'd prefe

Re: Implement define-event-function (issue 5083045)

Ok, I have made this based off origin/master, and I moved the stuff to using ly:event? instead of event? (not really addressing Neil's issue at all, merely for somewhat more symmetry to ly:music?). Untested. http://codereview.appspot.com/5083045/ ___

Re: Implement define-event-function (issue 5083045)

If this can be verified as working, it might go on the patch countdown, barring comments that require addressing. Note that ly:event? is not part of the public API of define-event-function: if ly:event?'s function name changes at some later point of time, uses of define-event-function will not ne

Re: Implement define-event-function (issue 5083045)

James, could you put this through the ringer? It's on patch countdown and I don't really trust my regtesting abilities all too much. Thanks. http://codereview.appspot.com/5083045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.g

Re: parser.yy: allow composite_music to also consist of a MUSIC_IDENTIFIER. (issue 5090045)

Reviewers: J_lowe, Message: Well, I reworked this into a somewhat saner state. Took me hours, so please don't be all too annoyed about the regtest you just completed. I need another one. Description: parser.yy: allow composite_music to also consist of a MUSIC_IDENTIFIER. Please review this at

Re: Implement optional music function arguments (issue 5023044)

Pushed as 83055a30e52c14b0fd49d6df3eb1c7af476ecb4b http://codereview.appspot.com/5023044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement optional music function arguments (issue 5023044)

Regtests and docs are there. The last upload, however, seems to have influences from a few unrelated commits. Rietveld is too complicated for me. On the plus side, a working version (compiles the docs as far as I can tell) has been pushed to dev/staging. http://codereview.appspot.com/5023044/

Re: Implement optional music function arguments (issue 5023044)

Pushed as b4ff85a2416e4b80deb9eef8329cd230ee4dc944 and preceding. http://codereview.appspot.com/5023044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement define-event-function (issue 5083045)

Pushed as 5aac8e8d8e2b1fc490354cba2cdecd204e9d5006 http://codereview.appspot.com/5083045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: parser.yy: allow composite_music to also consist of a MUSIC_IDENTIFIER. (issue 5090045)

Pushed as 049021415e2af3a48b1ec6d724df3d2f1d9f7dd3 http://codereview.appspot.com/5090045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

parser.yy et al: Make \relative a music function. (issue 5123043)

Reviewers: , Message: This is a rather straightforward patch to take \relative out of the grammar and let it be implemented as a music function. I have copied some code from parser.yy straight to music-scheme.cc to make ly:make-music-relative!. This code keeps the original indentation so that g

Re: parser.yy et al: Make \relative a music function. (issue 5123043)

Pushed as db3e78a1d3ac62dff61e80a3f0ccf60009f535ed to /dev/staging http://codereview.appspot.com/5123043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: add a note about \relative f to notation (issue 1909) (issue 5096046)

LGTM http://codereview.appspot.com/5096046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement optional music function arguments (issue 5023044)

http://codereview.appspot.com/5023044/diff/22001/scm/ly-syntax-constructors.scm File scm/ly-syntax-constructors.scm (right): http://codereview.appspot.com/5023044/diff/22001/scm/ly-syntax-constructors.scm#newcode52 scm/ly-syntax-constructors.scm:52: (format #f (_ "~a function can't return ~a") O

Re: First stab at getting script offsets right. (issue 5235052)

On 2011/10/10 07:15:35, MikeSol wrote: The newest patchset adds a debug function to bug.cc. Not according to the uploaded patch sets. I'd push it as a separate commit - it has helped me a lot with this & other patches & I'd like to keep it in the code base. Just make sure that it can rea

Re: First stab at getting script offsets right. (issue 5235052)

On 2011/10/10 07:40:24, mike_apollinemike.com wrote: Yes'r. I think that this will be useful in the same way that Skyline::print is useful (I use them in tandem). This is not meant as a criticism of you in this case, but as a general observation: we have locked away too many parts of Lilypo

Re: Make accidental styles available as context mods. (issue 4819064)

Sorry, I always start thinking only when far too late in the game. Anyway, here is a musing: should't the _main_ interface to accidental modifications be context mods? You won't need to set them in midcontext except in unusual situations, and then \applyContext (?) is available. Or does that mak

Re: Adds Scheme function for spring constructor. (issue 5306050)

http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc File lily/spring-smob.cc (left): http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42 lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F; On 2011/10/21 11:18:06, Neil Puttock wrote: Not sur

Re: Adds Scheme function for spring constructor. (issue 5306050)

On 2011/10/21 11:27:34, dak wrote: http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc File lily/spring-smob.cc (left): http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42 lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F; On 2011/10/21

Re: Adds Scheme function for spring constructor. (issue 5306050)

; On 2011/10/21 11:27:35, dak wrote: > scm_is_true (scm_is_eqv (a, b)) You mean scm_is_true(scm_eqv_p (a, b))? :) Yes. For me, this function is totally useless. If we want to check whether they are equal, we use scm_equal_p, if we want to see whether they are the same object, we

Re: Sketch for in-notes. (issue 5293053)

http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc#newcode79 lily/page-layout-problem.cc:79: footnotes_added = g->get_property ("footnote-stencil") !=

Re: Sketch for in-notes. (issue 5293053)

On 2011/10/21 23:49:26, Bertrand Bordage wrote: Sorry for this total mistake. !ly_is_equal (..., SCM_EOL) should do it, then. It is pretty pointless to use ly_is_equal instead of scm_is_eq on SCM_EOL, and !scm_is_null (...) is prettier anyway. http://codereview.appspot.com/5293053/ _

Re: lily-guile updates and CG: "Scheme->C interface" section. (issue 4917044)

As usual, too late in the game. Better late than never. http://codereview.appspot.com/4917044/diff/16006/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/4917044/diff/16006/Documentation/contributor/pr

Re: Rename \markuplines to \markuplist (before running convert-ly) (issue 5312050)

Reviewers: Bertrand Bordage, Message: On 2011/10/23 21:08:09, Bertrand Bordage wrote: LGTM. You'll be happy to know that Mike and I are currently trying to get rid of \markuplines, so that there will only be a \markup command. No, I am not happy, since for example fret markings in tabulatur

Uses convert-ly to update changes stemming from the creation of a Flag grob. (issue 5309059)

Seems like my suggestion to update the version numbers of files with manual fixes (in a separate commit) in order not to get them updated again got lost, as well as the bit about rereading the diff for problems. http://codereview.appspot.com/5309059/diff/1/Documentation/es/learning/tweaks.itely

Re: Get rid of most of the insane string-tunings API (issue 5318046)

Reviewers: carl.d.sorensen_gmail.com, http://codereview.appspot.com/5318046/diff/12002/input/regression/tablature-letter.ly File input/regression/tablature-letter.ly (right): http://codereview.appspot.com/5318046/diff/12002/input/regression/tablature-letter.ly#newcode32 input/regression/tablatu

Re: scheme-tutorial.itely: avoid unnecessary copying (issue 5314065)

Reviewers: carl.d.sorensen_gmail.com, Ian Hulin (gmail), Message: On 2011/10/28 23:04:31, Ian Hulin (gmail) wrote: David, I think you've updated an example in two places, and added material which needs to reference the second example after the first one. I disagree. I see only one example h

Re: Sketch for in-notes. (issue 5293053)

On 2011/10/28 13:26:22, mike_apollinemike.com wrote: On Oct 28, 2011, at 3:24 PM, mailto:n.putt...@gmail.com wrote: > > http://codereview.appspot.com/5293053/diff/11005/input/regression/footnote-break-visibility.ly > File input/regression/footnote-break-visibility.ly (left): > > http://co

Re: Fixes NoteColumn vs SpanBar collisions. (issue 5323062)

On 2011/11/01 08:25:48, mike_apollinemike.com wrote: Given that the 0.6 skyline horizontal padding is, according to the comment above it, only intended to block ledger lines from overlapping a bar line, I think that this blocking effect it has on horizontal spacing is an unintended side effec

Re: changing-defaults.itely: correct misstatement about variables for context mods (issue 5306076)

Reviewers: J_lowe, Message: Review addressed. Changes are trivial enough that countdown can continue. Description: changing-defaults.itely: correct misstatement about variables for context mods Please review this at http://codereview.appspot.com/5306076/ Affected files: M Documentation/nota

Re: Doc: NR Added new node for Custom Footnotes (issue 5315053)

Oh, by the way, I suggest that you wait for Issue 2003 to go through before investing too much effort in documenting your interfaces. Then you don't need a separate interface for "manual" and "automatic" footnotes, but can just use something like \footnote\default for autogeneration of footnote m

Re: Doc: NR Added new node for Custom Footnotes (issue 5315053)

\markup { \auto-footnote a b } Oh. \auto-footnote is a markup command. I haven't got my claws into those yet regarding optional arguments. I suppose I have to take a closer look before suggesting things. http://codereview.appspot.com/5315053/ ___

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

Reviewers: Reinhold, Message: On 2011/11/03 10:47:59, Reinhold wrote: LGTM, although regtests are missing (for \once applied to multiple settings at one, stored in a variable). There you are. Description: Implement \once as music function able to operate on complex stuff. Please review thi

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

On 2011/11/03 11:45:00, Reinhold wrote: http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly File input/regression/complex-once.ly (right): http://codereview.appspot.com/5322065/diff/3001/input/regression/complex-once.ly#newcode11 input/regression/complex-once.ly:

Re: changing-defaults.itely: correct misstatement about variables for context mods (issue 5306076)

http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (left): http://codereview.appspot.com/5306076/diff/3002/Documentation/notation/changing-defaults.itely#oldcode732 Documentation/notation/changing-def

Re: changing-defaults.itely: correct misstatement about variables for context mods (issue 5306076)

#oldcode732 Documentation/notation/changing-defaults.itely:732: The @code{\Staff \RemoveEmptyStaves} will overwrite your current On 2011/11/03 13:05:21, dak wrote: > On 2011/11/03 12:27:33, Neil Puttock wrote: > > This knownissue no longer applies. > > Not exactly my fault. Since I h

Re: Implement \once as music function able to operate on complex stuff. (issue 5322065)

As an illustration: take a look at ly/property-init.ly. It contains dozens of commands that will cooperate with the new \once. All of them (well, the reverting commands don't, just because \once\revert is not [yet?] workable in general). That's its principal selling point. And I don't want to

<    4   5   6   7   8   9   10   11   12   13   >