http://codereview.appspot.com/5083045/diff/1/scm/c++.scm File scm/c++.scm (right):
http://codereview.appspot.com/5083045/diff/1/scm/c++.scm#newcode38 scm/c++.scm:38: (define-public (event? x) On 2011/09/21 22:14:40, dak wrote:
On 2011/09/21 21:32:30, Neil Puttock wrote: > I'd prefer a less vague name for this since it's going to conflict
with the
> stream event predicate (currently ly:stream-event?) when we get
round to
> renaming Stream_event -> Event
Hm. It corresponds to 'event being in types. Since parser.yy also
checks this
property in C, it might make sense implementing it in C and offering
ly:event?
for calling it instead.
Since ly:music? is valid for all music objects having 'music in types,
and not
just those of class Music, I can't quite see a good reason for
preferring
ly:event? or event? to point to an Event music class.
Hm[2]. In scm/define-music-display-methods.scm (of all files) there is a definition post-event? apparently intended for something like this. More or less: it checks for a number of classes explicitly instead of looking at types. But that's not what lily/parser.yy does for deciding whether to interpret a Scheme value as MUSIC_IDENTIFIER or EVENT_IDENTIFIER. http://codereview.appspot.com/5083045/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
