Re: 2,21,4 released

2020-08-01 Thread Jonas Hahnfeld via Discussions on LilyPond development
Am Samstag, den 01.08.2020, 15:39 +0900 schrieb Masamichi Hosoda: > > Testing with Frescobaldi would be appreciated, and also with special > > characters in file names. I tried to model this after the code > > Masamichi-san wrote in March, but I'm not sure I understand what it's > > really needed f

removing regtest profiling

2020-08-01 Thread Han-Wen Nienhuys
did you get started on (title) ? If not I can start. -- Han-Wen Nienhuys - hanw...@gmail.com - http://www.xs4all.nl/~hanwen

Re: 2,21,4 released

2020-08-01 Thread James Lowe
On 01/08/2020 10:06, Jonas Hahnfeld via Discussions on LilyPond development wrote: Am Samstag, den 01.08.2020, 15:39 +0900 schrieb Masamichi Hosoda: Testing with Frescobaldi would be appreciated, and also with special characters in file names. I tried to model this after the code Masamichi-san w

Re: removing regtest profiling

2020-08-01 Thread Jonas Hahnfeld via Discussions on LilyPond development
Am Samstag, den 01.08.2020, 12:08 +0200 schrieb Han-Wen Nienhuys: > did you get started on (title) ? If not I can start. No, didn't get there yet. Note that this involves some doc editing because it's mentioned in a few places (both Usage and CG). signature.asc Description: This is a digitally s

Re: 2,21,4 released

2020-08-01 Thread Masamichi Hosoda
>> `stat ()` in msvcrt.dll has a problem with some Unicode file names. >> So we use `_wstat ()` instead of `stat ()` if msvcrt.dll is used. >> To use `_wstat ()`, we need a wide string, >> so we use `MultiByteToWideChar ()` to convert it. > > Do you have an example of a file name that should not w

Re: 2,21,4 released

2020-08-01 Thread Jonas Hahnfeld
Am Samstag, den 01.08.2020, 20:23 +0900 schrieb Masamichi Hosoda: > >> `stat ()` in msvcrt.dll has a problem with some Unicode file names. > >> So we use `_wstat ()` instead of `stat ()` if msvcrt.dll is used. > >> To use `_wstat ()`, we need a wide string, > >> so we use `MultiByteToWideChar ()` t

Re: 2,21,4 released

2020-08-01 Thread Masamichi Hosoda
> Thanks for all the explanation, I think I'm slowly starting to > understand the problem. I've tried to get short names with special > characters, but failed so far (maybe you need a setting for this?). > I'm giving up on this for now and will keep the code path with > MoveFileExW unless you feel

Re: 2,21,4 released

2020-08-01 Thread Jonas Hahnfeld
Am Samstag, den 01.08.2020, 22:15 +0900 schrieb Masamichi Hosoda: > > Thanks for all the explanation, I think I'm slowly starting to > > understand the problem. I've tried to get short names with special > > characters, but failed so far (maybe you need a setting for this?). > > I'm giving up on th

Re: GSoC-2020 update: Jul 31

2020-08-01 Thread Werner LEMBERG
>> Another issue: Maybe it makes sense if you try to rebase your >> branch from time to time. > > Really rebase? Yes, I favour rebasing over merging since the former causes a `prettier' git commit tree. > This would be a case where "general wisdom" argues against modifying > pushed commits. Typ

Re: 2,21,4 released

2020-08-01 Thread Masamichi Hosoda
>> Do you have an example of a file name that should not work? I now have >> three versions from GUB (one with MoveFileExW; one without but with >> wstat; and one without wstat) and all work correctly on a recent >> Windows 10. Does that mean the issue is gone with a recent update? > > Might it be

Re: 2,21,4 released

2020-08-01 Thread Masamichi Hosoda
> That was also my understanding, but "dir /x" already shows a short name > of "D15A~1.LY" for "ä.ly". Maybe I'm doing something wrong? (not used > Windows at that technical level for a few years now...) Sorry, I have no idea because I'm not familiar with non-Japanese Windows. At least in Japanese

Re: GSoC-2020 update: Jul 31

2020-08-01 Thread Urs Liska
Am 1. August 2020 16:12:24 MESZ schrieb Werner LEMBERG : >>> Another issue: Maybe it makes sense if you try to rebase your >>> branch from time to time. >> >> Really rebase? > >Yes, I favour rebasing over merging since the former causes a >`prettier' git commit tree. > >> This would be a case w

Re: GSoC-2020 update: Jul 31

2020-08-01 Thread Jean Abou Samra
Hi everyone, Le 01/08/2020 à 18:19, Urs Liska a écrit : Am 1. August 2020 16:12:24 MESZ schrieb Werner LEMBERG : Another issue: Maybe it makes sense if you try to rebase your branch from time to time. Really rebase? Yes, I favour rebasing over merging since the former causes a `prettier' git

Re: GSoC-2020 update: Jul 31

2020-08-01 Thread Urs Liska
Am 1. August 2020 23:31:32 MESZ schrieb Jean Abou Samra : >Hi everyone, > >Le 01/08/2020 à 18:19, Urs Liska a écrit : >> Am 1. August 2020 16:12:24 MESZ schrieb Werner LEMBERG : > Another issue: Maybe it makes sense if you try to rebase your > branch from time to time. Really reba

Re: GSoC-2020 update: Jul 31

2020-08-01 Thread Werner LEMBERG
Well, there's a good reason that gitlab has a big, fat 'rebase' button... >> >> Not sure about the meaning of your message: this button shows up >> because we enabled it as a project-wide setting. To my knowledge, >> the default and most common strategy is merging. Exactly! It's our po

Re: GSoC-2020 update: Jul 31

2020-08-01 Thread Jonas Hahnfeld via Discussions on LilyPond development
Am Samstag, den 01.08.2020, 23:31 +0200 schrieb Jean Abou Samra: > While I generally prefer merging over rebasing, since we enforce an > all-fast-forward policy for merging to master, I think we should rebase > here. My reasoning is that you put in more information when resolving > conflicts dur