Re: Automatic LyricExtenders (issue 313240043 by perpeduumimmob...@gmail.com)

2017-02-16 Thread dak
https://codereview.appspot.com/313240043/diff/21/lily/lyric-extender.cc File lily/lyric-extender.cc (right): https://codereview.appspot.com/313240043/diff/21/lily/lyric-extender.cc#newcode63 lily/lyric-extender.cc:63: while (hs && robust_scm2double (heads[hs-1]->get_property On 2017/02/0

Web: examples page: move more common use cases higher in the list (issue 318560043 by paulwmor...@gmail.com)

2017-02-16 Thread paulwmorris
Reviewers: , Message: Finally got around to this. -Paul Description: Web: examples page: move more common use cases higher in the list Makes the order match the list on the home page. Also adds an additional line between the code for each example for better readability. Please review this at

NR: Document \remove "Keep_alive_together_engraver" (issue 318580043 by g...@ursliska.de)

2017-02-16 Thread lemzwerg
LGTM https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely#newcode790 Documentation/notation/staff.itely:790: empty at the same time.

Re: NR: Document \remove "Keep_alive_together_engraver" (issue 318580043 by g...@ursliska.de)

2017-02-16 Thread git
Reviewers: lemzwerg, Message: On 2017/02/17 05:38:44, lemzwerg wrote: ... Please use two spaces after a full stop that closes a sentence. Sorry, missed that one. Fixed but without new patch set. Description: NR: Document \remove "Keep_alive_together_engraver" Please review this at https://

Re: NR: Document \remove "Keep_alive_together_engraver" (issue 318580043 by g...@ursliska.de)

2017-02-16 Thread dak
https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely#newcode793 Documentation/notation/staff.itely:793: removed from the @code{PianoSt

Re: NR: Document \remove "Keep_alive_together_engraver" (issue 318580043 by g...@ursliska.de)

2017-02-16 Thread git
On 2017/02/17 07:24:42, dak wrote: https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): https://codereview.appspot.com/318580043/diff/1/Documentation/notation/staff.itely#newcode793 Documentation/notation/staff.it

Re: NR: Document \remove "Keep_alive_together_engraver" (issue 318580043 by g...@ursliska.de)

2017-02-16 Thread dak
On 2017/02/17 07:27:27, git wrote: On 2017/02/17 07:24:42, dak wrote: > Documentation should not focus about how to use the wrong tool for the job. > If you want to document it, do it the other way round: explain how you can keep > the staves of a GrandStaff together and then mention that

Re: NR: Document \remove "Keep_alive_together_engraver" (issue 318580043 by g...@ursliska.de)

2017-02-16 Thread Urs Liska
Am 17.02.2017 um 08:34 schrieb d...@gnu.org: > On 2017/02/17 07:27:27, git wrote: >> On 2017/02/17 07:24:42, dak wrote: > >> > Documentation should not focus about how to use the wrong tool for > the job. >> > If you want to document it, do it the other way round: explain how > you can keep >> >