LGTM apart from some editorial nitpicks noted.
Trevor
http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode775
On Jun 25, 2011, at 6:38 PM, percival.music...@gmail.com wrote:
> On 2011/06/25 07:15:39, J_lowe wrote:
>> I get an error/seg fault when I try to make:
>
> I can confirm this.
>
>
Fixed. I had accidentally kept "annotation-whiteout" in balloon.cc whereas I
had scrubbed it in all the other fi
Colin Campbell wrote:
> Thanks for this, Graham! I've added this to the tracker
> as issue 1711. Can you also provide a test file which
> would demonstrate the problem? I recognise this may not
> be all that easy to do, but it would help in verifying
> the fix.
Here's an example based on one Ri
- Original Message -
From: "Graham Percival"
Hmm. Since even I can't state with certainty what the next step
would be to find the information about the failing build, this is
clearly a huge problem. (I have several suspicions on where to
look, but no certainty)
I have reverted that c
On Jun 26, 2011, at 11:26 AM, m...@apollinemike.com wrote:
> On Jun 25, 2011, at 6:38 PM, percival.music...@gmail.com wrote:
>
>> On 2011/06/25 07:15:39, J_lowe wrote:
>>> I get an error/seg fault when I try to make:
>>
>> I can confirm this.
>>
>>
>
> Fixed. I had accidentally kept "annotat
On Sat, Jun 25, 2011 at 11:12:25PM +0200, Valentin Villenave wrote:
> On Wed, Jun 22, 2011 at 1:30 AM, Graham Percival
> wrote:
> > I’m going to make the bold step of assuming that we will eliminate
> > tabs in all C++ files. I personally like the idea of tabs, but
> > from an examination of sourc
This is now abandoned; a new (working) version was created by Carl here:
http://codereview.appspot.com/4662055/
(google code issue 1709)
cheers,
Janek
http://codereview.appspot.com/4273119/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https:
Hi Reinhold,
I'm afraid this fails `make check'.
dynamics-alignment-no-line-linebreak.ly weirdly works directly without a
hitch, but crashes under test conditions:
Processing `./1e/lily-b9dc92b9.ly'
Parsing...
Renaming input to: `dynamics-alignment-no-line-linebreak.ly'
Interpreting music...
Pre
On 25 June 2011 22:56, Reinhold Kainhofer wrote:
> The previous commit 7bcdd37be15ece09cd97841137b075a576bbe696 ("Fixes issue
> 1706, issues a programming error at old assert error.") by Mike Solomon breaks
> make check, as the regtest issues lots of programming_error calls:
>
> beam-skip.ly:17:33
On 24 June 2011 15:40, wrote:
> I found this 10-month old patch of mine laying around. It still seems
> relevant, so I'm sending it to the list. Lemme know what y'all think.
http://lists.gnu.org/archive/html/lilypond-devel/2010-08/msg00065.html
Cheers,
Neil
_
some more little problems.
http://codereview.appspot.com/4641074/diff/5001/Documentation/contributor/build-notes.itexi
File Documentation/contributor/build-notes.itexi (right):
http://codereview.appspot.com/4641074/diff/5001/Documentation/contributor/build-notes.itexi#newcode679
Documentation/c
Reviewers: Neil Puttock,
Message:
On 2011/06/26 11:34:20, Neil Puttock wrote:
Hi Reinhold,
I'm afraid this fails `make check'.
dynamics-alignment-no-line-linebreak.ly
weirdly works directly without a hitch, but crashes under test
conditions:
Hmm, okay, it seems that -ddump-signatures also
Am Sonntag, 26. Juni 2011, 13:34:20 schrieben Sie:
> I'm afraid this fails `make check'.
> dynamics-alignment-no-line-linebreak.ly weirdly works directly without a
> hitch, but crashes under test conditions:
>
> Processing `./1e/lily-b9dc92b9.ly'
> Parsing...
> Renaming input to: `dynamics-alignme
Hi,
I know that test-output-distance.ly should show as a regression, but
i'm not sure whether other things that appeared are regressions or not
(especially that the differencies sem to appear in non-ly files).
Please see the atttached file.
cheers,
Janek
<>
Second Draft - Thanks for the comments Trevor
http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
http://codereview.appspot.com/4629073/diff/1/Documentation/notation/simultaneous.itely#newcode775
Document
On Sun, Jun 26, 2011 at 02:13:06PM +0200, Janek Warchoł wrote:
> I know that test-output-distance.ly should show as a regression, but
> i'm not sure whether other things that appeared are regressions or not
> (especially that the differencies sem to appear in non-ly files).
Looks fine. We have ra
On 26 June 2011 13:02, Reinhold Kainhofer wrote:
> Hmm, again the problem is that the parts after a line break of broken dynamic
> spanners (text / hairpin) do not have any parent set any more... Now, the
> function write-system-signature (subfunction found-grob, stencil.scm) calls
> ly:grob-exte
looks fine.
http://codereview.appspot.com/4629073/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Added to google tracker (sorry it's so late...), issue .
I understand that this Rietveld issue (4581060) is valid, not the other
one (4518052).
I like new shapes too, with one exception: the very smallest brace has
it's center too far to the left i think.
http://codereview.appspot.com/4581060/
_
2011/6/26 :
> Added to google tracker (sorry it's so late...), issue .
Sorry, something slipped through my fingers.
It's issue 1712 http://code.google.com/p/lilypond/issues/detail?id=1712
cheers,
Janek
___
lilypond-devel mailing list
lilypond-devel@gn
On Sun, Jun 26, 2011 at 10:46:15AM +0100, Phil Holmes wrote:
> - Original Message - From: "Graham Percival"
>
> >I have reverted that commit; the build should behave as usual now.
> >I'll take another look at this tomorrow, and we'll go through
> >another "patch countdown" for whatever new
re-sending to list.
On Sun, Jun 26, 2011 at 02:33:59PM +0200, Janek Warchoł wrote:
> 2011/6/26 Graham Percival :
> > On Sun, Jun 26, 2011 at 02:13:06PM +0200, Janek Warchoł wrote:
> >> I know that test-output-distance.ly should show as a regression, but
> >> i'm not sure whether other things that
LGTM.
http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc
File lily/midi-item.cc (right):
http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc#newcode202
lily/midi-item.cc:202: + audio_->transposing_.tone_pitch ()) * Rational
(2));
indent:
((audio_
+ audio
http://codere
(re-sending to list)
On Sun, Jun 26, 2011 at 03:47:11PM +0200, Jan Warchoł wrote:
> Ok, since comparing gperciva-fixcc and gperciva-astyle branches didn't
> work for me, plese verify whether i understood correctly:
> - we are discussing which program we will use for code formatting, not
> the act
Third Draft - Thanks again Graham.
James
http://codereview.appspot.com/4641074/diff/5001/Documentation/contributor/build-notes.itexi
File Documentation/contributor/build-notes.itexi (right):
http://codereview.appspot.com/4641074/diff/5001/Documentation/contributor/build-notes.itexi#newcode679
2011/6/22 Graham Percival :
> Speaking academically, C++ code style is a "solved problem". Let’s
> pick one of the existing solutions, and let a computer deal with
> this. Humans should not waste their time, energy, and creativity
> manually adding tabs or spaces to source code.
>
> I see three mai
2011/6/23 Benkő Pál :
>
>> Wow, thank you both!
>> I don't think i would be able to write this at so high level of
>> abstraction myself.
>> I think i understand your explanation and i can roughly see what is
>> going on in your code, except what the last argument(s) is (are) doing
>> - why is it #
ok, push it.
http://codereview.appspot.com/4641074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
2011/6/26 Graham Percival :
> re-sending to list.
yup, sorry for forgetting to reply-to-all.
> On Sun, Jun 26, 2011 at 02:33:59PM +0200, Janek Warchoł wrote:
>> Ok. So in general "if there is no graphic output, there is no problem"?
>
> No, unfortunately. In general "if the changes match the kin
2011/6/26 Graham Percival :
> On Sun, Jun 26, 2011 at 03:47:11PM +0200, Jan Warchoł wrote:
>> Ok, since comparing gperciva-fixcc and gperciva-astyle branches didn't
>> work for me, plese verify whether i understood correctly:
>> - we are discussing which program we will use for code formatting, not
http://codereview.appspot.com/4641074/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Sun, Jun 26, 2011 at 04:23:58PM +0200, Jan Warchoł wrote:
> 2011/6/26 Graham Percival :
> > The difference between output of astyle and fixcc is 778Kb, and is
> > 23173 lines long.
>
> Let's choose the simplest solution, which doesn't require installing
> anything and can be automated as much a
On 13 June 2011 12:03, wrote:
> My goal is to bypass the default calculation and replace it with this one,
> and it is easier to harvest the information about Y placement relative to the
> staff before line breaking happens. Currently, there is no mechanism in
> Line_spanner::calc_bound_info
On Jun 26, 2011, at 1:39 PM, Neil Puttock wrote:
> On 24 June 2011 15:40, wrote:
>
>> I found this 10-month old patch of mine laying around. It still seems
>> relevant, so I'm sending it to the list. Lemme know what y'all think.
>
> http://lists.gnu.org/archive/html/lilypond-devel/2010-08/ms
On Jun 26, 2011, at 4:57 PM, Neil Puttock wrote:
> On 13 June 2011 12:03, wrote:
>
>> My goal is to bypass the default calculation and replace it with this one,
>> and it is easier to harvest the information about Y placement relative to
>> the staff before line breaking happens. Currently,
On 11-06-26 06:25 AM, Neil Puttock wrote:
On 26 June 2011 13:02, Reinhold Kainhofer wrote:
Hmm, again the problem is that the parts after a line break of broken dynamic
spanners (text / hairpin) do not have any parent set any more... Now, the
function write-system-signature (subfunction found-
On 26 June 2011 17:09, Colin Campbell wrote:
> Just jumping in unwisely, before the coffee hits the brainstem: is a slur an
> instance of spanner?
Yes.
> This discussion sounds a good bit like the problems
> reported with slurs (ties?) over line breaks.
I'm afraid not. This is an alignment pr
- Original Message -
From: "Graham Percival"
To: "Phil Holmes"
Cc: "Reinhold Kainhofer" ;
Sent: Sunday, June 26, 2011 1:47 PM
Subject: Re: make check currently fails (beam-skip.ly,
commit7bcdd37be15ece09cd97841137b075a576bbe696)
On Sun, Jun 26, 2011 at 10:46:15AM +0100, Phil Holme
- Original Message -
From: "Graham Percival"
To: "Janek Warchoł"
I keep running these on different branches and nothing seems to
change... is it a problem that i have index.html opened in firefox all
the time?
Having index.html open isn't going to affect anything (although of
cours
http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly
File input/regression/glissando-broken-multiple.ly (right):
http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly#newcode7
input/regression/glissando-broken-mul
On Sun, Jun 26, 2011 at 05:55:58PM +0100, Phil Holmes wrote:
> - Original Message - From: "Graham Percival"
> >... yeah. No wonder Reinhold saw a 0-byte .err.log file!
>
> Yep - think that would explain it. I'd guess we'd get a long
> .err.log file and a zero byte .log file if this were
> I want to test your code thoroughly, but many things keep me busy all
> the time... I hope to have more time in a few days.
I want to look at Felipe's code more thoroughly, I didn't succeed
this weekend, perhaps midweek. I certainly have some ideas;
I think I understood his code and suggestions
in C++ there's std::cout, std::cerr and std::clog,
and I use all three in my private projects.
p
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Sun, Jun 26, 2011 at 06:04:41PM +0100, Phil Holmes wrote:
> - Original Message - From: "Graham Percival"
>
> >No. fixcc.py will emacs 23.1.1 to be installed. People with an
should be "will need"
> Lily Ubuntu... My version doesn't appear to have emacs.
Interesting, but only as a cu
Graham Percival percival-music.ca> writes:
> No. fixcc.py will [need] emacs 23.1.1 to be installed.
If the version of emacs matters, then
1) we might have more work when people move to 24
2) it hints that emacs formatting is not stable enough for our purpose
>
> astyle 2.02 is the simplest;
On Sun, Jun 26, 2011 at 05:43:26PM +, Keith OHara wrote:
>
> I am surprised you did not turn first to good old indent. Thu gnu guys give
> an
> option set for use with indent.
indent(1) can't handle C++ code. I forget exactly what made it
barf, but I think it was templates. It might have
Am Sonntag, 26. Juni 2011, 19:48:36 schrieb Graham Percival:
> On Sun, Jun 26, 2011 at 05:43:26PM +, Keith OHara wrote:
> > I am surprised you did not turn first to good old indent. Thu gnu guys
> > give an option set for use with indent.
>
> indent(1) can't handle C++ code. I forget exactly
A few more nitpicking typos - some I missed first time through, some you
missed when dealing with my earlier comments :)
I'm happy for you to push after fixing these. Thanks!
Trevor
http://codereview.appspot.com/4629073/diff/1003/Documentation/notation/simultaneous.itely
File Documentation/n
On Sun, 26 Jun 2011 10:48:36 -0700, Graham Percival
wrote:
indent(1) can't handle C++ code.
That's surprising. Bummer.
From earlier,
A few specific problems with astyle:
* it doesn’t indent enum in gnu style
I can't find gnu instructions for indenting enums, but if there are any the
Should this issue be closed, per the changes list announcing it in 2.14?
http://codereview.appspot.com/1428042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I gather this is connected to issue 684, so it should probably be marked
closed, Jan.
Thanks,
Colin
http://codereview.appspot.com/1579041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
I believe, since issue 867 is marked verified, that this could be
closed, John.
cheers,
Colin Campbell
Bug Squad
http://codereview.appspot.com/183048/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypo
52 matches
Mail list logo
