Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-18 Thread Graham Percival
On Sun, Apr 17, 2011 at 11:29:21PM +0200, Janek Warchoł wrote: > If you are curious about why i twice did try to pick up and fix an > issue without any questions and discussion, it was partly because of > http://percival-music.ca/blogfiles/sustainable.pdf (page 24, "net gain > to the project"). Unf

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-17 Thread Janek Warchoł
2011/4/17 Graham Percival > > On Sat, Apr 16, 2011 at 10:26:03PM +0200, Janek Warchoł wrote: > > 2011/4/16 Janek Warchoł : > > > Like attached one? > > > > Oh wait! it was already added as CG 12.6 building an Ubuntu distro - > > not in unsorted policies. So issue 1453 is invalid/fixed. > > That ri

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-17 Thread Graham Percival
On Sat, Apr 16, 2011 at 10:26:03PM +0200, Janek Warchoł wrote: > 2011/4/16 Janek Warchoł : > > Like attached one? > > Oh wait! it was already added as CG 12.6 building an Ubuntu distro - > not in unsorted policies. So issue 1453 is invalid/fixed. > That rings a bell. ouch, Phil should have known

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-16 Thread Janek Warchoł
2011/4/16 Janek Warchoł : > 2011/4/16 Graham Percival >> There are lots of tasks that need to be done, so if you *are* >> stuck waiting for a week or two for your mentor, you could try >> doing some other task? > > Like attached one? Oh wait! it was already added as CG 12.6 building an Ubuntu dis

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-16 Thread Janek Warchoł
2011/4/16 Graham Percival > > On Fri, Apr 15, 2011 at 11:17:23PM +0200, Janek Warchoł wrote: > > 2011/4/15 Graham Percival : > > > Note that both of these points require little or no technical > > > ability.  Non-technically-skilled users can help tremendously with > > > these points.  And if we c

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-16 Thread Graham Percival
On Fri, Apr 15, 2011 at 11:17:23PM +0200, Janek Warchoł wrote: > 2011/4/15 Graham Percival : > > Note that both of these points require little or no technical > > ability.  Non-technically-skilled users can help tremendously with > > these points.  And if we can reduce the time it takes to read > >

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-15 Thread Janek Warchoł
2011/4/15 Graham Percival : > On Fri, Apr 15, 2011 at 01:07:02AM +0200, Janek Warchoł wrote: >> Hi all, >> >> 2011/4/7 Graham Percival >> > You severely over-estimate either the number of "seasoned >> > developers", or the skill of most people on this mailing list. > ... >> > The same goes for vir

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-15 Thread Valentin Villenave
2011/4/15 Graham Percival : > But the development community has a very huge problem: > - the very skilled members generally have full-time jobs and >  familes. Then Graham, I'm afraid you and I desperately are without any skill :-) > - it takes about 5 hours a week simply to keep "up to date" >  

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-15 Thread Graham Percival
On Fri, Apr 15, 2011 at 01:07:02AM +0200, Janek Warchoł wrote: > Hi all, > > 2011/4/7 Graham Percival > > You severely over-estimate either the number of "seasoned > > developers", or the skill of most people on this mailing list. ... > > The same goes for virtually every aspect of lilypond.  The

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-14 Thread Janek Warchoł
Hi all, 2011/4/7 Graham Percival > > On Wed, Apr 06, 2011 at 10:36:15AM +0200, Janek Warchoł wrote: > > 2011/4/4 Graham Percival > > > Think about it this way: how many times have you reviewed my build > > > system patches, or Colin's documentation patches?  The same > > > reasons why you don't

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-07 Thread Graham Percival
On Wed, Apr 06, 2011 at 10:36:15AM +0200, Janek Warchoł wrote: > 2011/4/4 Graham Percival > > Think about it this way: how many times have you reviewed my build > > system patches, or Colin's documentation patches? The same > > reasons why you don't review those patches apply to people looking >

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-06 Thread Janek Warchoł
2011/4/4 Graham Percival > Ah. Well, unfortunately we (as a developer community) do not tend > to review patches very often. > > Think about it this way: how many times have you reviewed my build > system patches, or Colin's documentation patches? The same > reasons why you don't review those pa

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-04 Thread percival . music . ca
The latest patch dies badly when trying to compile flags-in-scheme.ly programming error: ignoring weird minimum distance continuing, cross fingers ... repeated tons and tons of times... terminate called after throwing an instance of 'std::bad_alloc' what(): std::bad_alloc Aborted I think thi

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-04 Thread Graham Percival
On Mon, Apr 04, 2011 at 10:51:16AM +0200, Janek Warchoł wrote: > 2011/4/4 > > > > This patch loses flags!  is that deliberate?! > >  stem-tremolo.ly > >  flags-default.ly > >  beam-collision-beamcount.ly > > ... etc... > > Did you "make clean" before building? No, sorry! My fault. I'll check t

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-04 Thread Janek Warchoł
2011/4/4 > > This patch loses flags!  is that deliberate?! >  stem-tremolo.ly >  flags-default.ly >  beam-collision-beamcount.ly > ... etc... Did you "make clean" before building? There are some missing dependancies in the fonts, so "make clean" must be called at least in /mf directory, otherwise

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-03 Thread percival . music . ca
This patch loses flags! is that deliberate?! stem-tremolo.ly flags-default.ly beam-collision-beamcount.ly ... etc... Have you tried a regtest comparison? Please read this: http://lilypond.org/doc/v2.13/Documentation/contributor/regtest-comparison and let me know if you need help with any

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-03 Thread mtsolo
Hey all, I don't have time for a few days to check this out in depth, but it definitely deserves to be read over & commented upon. Please review it if you can! Cheers, Mike http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilyp

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-04-03 Thread lemniskata . bernoullego
New patch set uploaded. After a week of trying, there is probably nothing more that i can do. The code works, but could be easily improved by someone skillful. Any comments and help are welcome. cheers, Janek http://codereview.appspot.com/4312057/ __

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-28 Thread lemniskata . bernoullego
New patch set uploaded, minor bugfix. http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-28 Thread lemniskata . bernoullego
Sorry, i clicked "publish" button too fast. New patch set uploaded, 1 TODO partly eliminated. cheers, Janek http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-28 Thread lemniskata . bernoullego
http://codereview.appspot.com/4312057/diff/10001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4312057/diff/10001/lily/stem.cc#newcode744 lily/stem.cc:744: flag_style = "standard"; Of course this will be properly encoded like other flag variants, as soon as i fint out how

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-28 Thread Graham Percival
On Sun, Mar 27, 2011 at 11:03:19AM +, lemniskata.bernoull...@gmail.com wrote: > New patch set uploaded. Font size is now taken into account when > calculating flag variants (one TODO eliminated). Thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1582 Cheers, - Graham _

Re: shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-27 Thread lemniskata . bernoullego
New patch set uploaded. Font size is now taken into account when calculating flag variants (one TODO eliminated). cheers, Janek http://codereview.appspot.com/4312057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/

shortened flags affair, part 8: choosing appropriate flag (issue4312057)

2011-03-26 Thread lemniskata . bernoullego
Reviewers: mike_apollinemike.com, Message: Hi, here comes the main part: code that chooses flags. I'm aware that it's quite imperfect. I'm working on it, however some problems are perhaps beyond my skills. Since i'll be busy after the weekend, it would be great if we were able to discuss and pol