Am 04.03.2011 um 20:41 schrieb Graham Percival:
> On Fri, Mar 04, 2011 at 05:17:39PM +0100, Patrick Schmidt wrote:
>>
>>> Hmm, it doesn't apply for me. Could you do a git pull -r , and then
>>> try making the patch again?
>>>
>> Sorry for that. Don't know what I'm doing wrong. How about this o
On Fri, Mar 04, 2011 at 05:17:39PM +0100, Patrick Schmidt wrote:
>
> > Hmm, it doesn't apply for me. Could you do a git pull -r , and then
> > try making the patch again?
> >
> Sorry for that. Don't know what I'm doing wrong. How about this one?
Thanks, it applied without any problems whatsoeve
On Fri, Mar 04, 2011 at 07:43:34PM +0100, Patrick Schmidt wrote:
>
> Am 04.03.2011 um 19:14 schrieb Trevor Daniels:
>
> > It should be
> > easy for Graham to fix this before applying.
Oops, I didn't notice. But yes, it will be.
> That is strange! I'm using Mac OS X/Ubuntu (Lilydev in
> Virtual
Am 04.03.2011 um 19:14 schrieb Trevor Daniels:
> Patrick Schmidt wrote Friday, March 04, 2011 4:17 PM
>>
>>> Hmm, it doesn't apply for me. Could you do a git pull -r , and then
>>> try making the patch again?
>>>
>> Sorry for that. Don't know what I'm doing wrong. How about this one?
>
> The
Patrick Schmidt wrote Friday, March 04, 2011 4:17 PM
Hmm, it doesn't apply for me. Could you do a git pull -r , and
then
try making the patch again?
Sorry for that. Don't know what I'm doing wrong. How about this
one?
The problem is the line endings. They are DOS but should be Unix
in pa
t mit
gratis Handy-Flat! http://portal.gmx.net/de/go/dsl
>From 472fe10042ac43a56b8fb30584edaa2419ff56e3 Mon Sep 17 00:00:00 2001
From: Patrick L. Schmidt
Date: Fri, 4 Mar 2011 17:04:53 +0100
Subject: [PATCH] Doc: harmonics and slides IX
---
Documentation/notation/fretted-strings.itely | 79
On 3/4/11, Patrick Schmidt wrote:
> Thanks for your help!
Hmm, it doesn't apply for me. Could you do a git pull -r , and then
try making the patch again?
Cheers,
- Graham
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mai
Looks good, and there's no complaints. Could you send me the full patch
for pushing?
http://codereview.appspot.com/4186049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Am 28.02.2011 um 22:14 schrieb James Lowe:
> Patrick
>
> -Original Message-
> From:
> Reply-To: , ,
> , , lilypond-devel
> ,
> Date: Mon, 28 Feb 2011 21:00:15 +
> To: , ,
>
> Cc: , lilypond-devel
>
> Subject: Re: Doc: harmonics and slides
Patrick
-Original Message-
From:
Reply-To: , ,
, , lilypond-devel
,
Date: Mon, 28 Feb 2011 21:00:15 +
To: , ,
Cc: , lilypond-devel
Subject: Re: Doc: harmonics and slides (issue4186049)
>BTW I accidentally created another issue number (4245047). Sorry for
>that. How can I
Hi all,
here is a revised patch. I hope everything is ok now. I don't know why
two files I did not alter are part of this patch:
hymn-template.ly and partcombine-and-autobeamoff.ly.
BTW I accidentally created another issue number (4245047). Sorry for
that. How can I delete it?
Thanks for your h
Am 28.02.2011 um 14:21 schrieb pkx1...@gmail.com:
> One comment.
>
> Thanks for your time.
>
>
> http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely
> File Documentation/notation/fretted-strings.itely (right):
>
> http://codereview.appspot.com/4186049/
LGTM.
Just one trivial nitpick.
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely#newcode389
Documen
One comment.
Thanks for your time.
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/4186049/diff/6002/Documentation/notation/fretted-strings.itely#newcode427
Doc
LGTM
http://codereview.appspot.com/4186049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Is it ok, now?
Thanks,
patrick
http://codereview.appspot.com/4186049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
I had to run
scripts/makelsr.py
before I could compile this patch. Please do the same, then do:
git add Documentation/snippets/*.ly
git commit .
and upload a new patch.
Other than that, LGTM.
http://codereview.appspot.com/4186049/
___
lilypond-
Reviewers: Graham Percival,
Message:
Hi Graham,
here is a revised patch.
Cheers,
patrick
Description:
harmonics and slides
new patch
# This will displayed on the codereview site.
harmonics-and-slides-V
include file for chord glissando
harmonics-and-slides-IV
new snippets
This issue should be closed; a new patch is at:
http://codereview.appspot.com/4186049/
http://codereview.appspot.com/3590041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
initial review.
http://codereview.appspot.com/4186049/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/4186049/diff/1/Documentation/notation/fretted-strings.itely#newcode389
Documentation/notation/frette
Hi Patrick,
Am 13.02.2011 um 21:49 schrieb Patrick McCarty:
> On Sun, Feb 13, 2011 at 6:28 AM, Patrick Schmidt wrote:
>>
>> I tried to upload three patches to rietveld. I got the message:
>>
>> pls@pls:~/lilypond-git$ git pull -r
>> Current branch master is up to date.
>> pls@pls:~/lilypond-gi
On Sun, Feb 13, 2011 at 6:28 AM, Patrick Schmidt wrote:
>
> I tried to upload three patches to rietveld. I got the message:
>
> pls@pls:~/lilypond-git$ git pull -r
> Current branch master is up to date.
> pls@pls:~/lilypond-git$ git cl upload origin/master
> Cannot upload with a dirty tree. You m
1/3] harmonics-and-slides-III
Revision of old patch
---
Documentation/notation/fretted-strings.itely | 76 +++---
1 files changed, 68 insertions(+), 8 deletions(-)
diff --git a/Documentation/notation/fretted-strings.itely b/Documentation/notation/fretted-strings.itely
index 98de
Hi Graham,
I haven't forgotten this patch but unfortunately I don't seem to find
time to fix it at the moment. It seems as if two patches got mixed up
at least. So I'm probably not responsible for the good stuff! ;-(
I can't promise but I'll try to take care of it next weekend.
Thanks,
patr
Sounds like there is something wrong with this patch. I will have a
look at it, tomorrow.
patrick
Am 22.01.2011 um 21:08 schrieb percival.music...@gmail.com:
It looks like there's lots of good work in this patch, but the latest
version seems to have some mixed patches. Could you try updating
It looks like there's lots of good work in this patch, but the latest
version seems to have some mixed patches. Could you try updating your
git tree, then try uploading a new patch?
If you need help with git (or with lily-git.tcl), then please don't
hesitate to ask.
http://codereview.appspot.c
On 12/11/10 1:35 PM, "Patrick Schmidt" wrote:
>
>
> Am 11.12.2010 um 21:16 schrieb Carl Sorensen:
>
>> On 12/11/10 12:55 PM, "Carl Sorensen" wrote:
>>
>>>
>>>
>>>
>>> On 12/11/10 12:44 PM, "Patrick Schmidt" wrote:
>>>
Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
Am 11.12.2010 um 21:16 schrieb Carl Sorensen:
On 12/11/10 12:55 PM, "Carl Sorensen" wrote:
On 12/11/10 12:44 PM, "Patrick Schmidt" wrote:
Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
On 12/11/10 9:54 AM, "Patrick Schmidt" wrote:
IMHO I think we want to have \hideNotes apply to T
On 12/11/10 12:55 PM, "Carl Sorensen" wrote:
>
>
>
> On 12/11/10 12:44 PM, "Patrick Schmidt" wrote:
>
>>
>>
>> Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
>>
>>> On 12/11/10 9:54 AM, "Patrick Schmidt" wrote:
>>>
IMHO I think we want to have \hideNotes apply to TabVoice. I tried t
On 12/11/10 12:44 PM, "Patrick Schmidt" wrote:
>
>
> Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
>
>> On 12/11/10 9:54 AM, "Patrick Schmidt" wrote:
>>
>>> IMHO I think we want to have \hideNotes apply to TabVoice. I tried to
>>> achieve glissandi with an indefinite beginning/ending (but
Am 11.12.2010 um 18:03 schrieb Carl Sorensen:
On 12/11/10 9:54 AM, "Patrick Schmidt" wrote:
IMHO I think we want to have \hideNotes apply to TabVoice. I tried to
achieve glissandi with an indefinite beginning/ending (but in vain):
You can test this really easily.
Simply add
\override Ta
On 12/11/10 9:54 AM, "Patrick Schmidt" wrote:
>
>
> Am 11.12.2010 um 17:34 schrieb carl.d.soren...@gmail.com:
>
>> Do we want to have\hideNotes apply to TabVoice? If so, we could
>> change
>> the definition of \hideNotes. That would probably be better than a
>> known issue.
> IMHO I think w
Am 11.12.2010 um 17:34 schrieb carl.d.soren...@gmail.com:
Looks pretty good to me. Looks *excellent* for a first patch.
Thanks,
Carl
http://codereview.appspot.com/3590041/diff/1/Documentation/notation/
fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
htt
Looks pretty good to me. Looks *excellent* for a first patch.
Thanks,
Carl
http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/3590041/diff/1/Documentation/notation
Looks basically good.
http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely
File Documentation/notation/fretted-strings.itely (right):
http://codereview.appspot.com/3590041/diff/1/Documentation/notation/fretted-strings.itely#newcode383
Documentation/notation/
Hi all,
I uploaded a small patch to http://codereview.appspot.com/3590041.
Thanks for reviewing it.
patrick
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
36 matches
Mail list logo
