Am 14.10.2012 19:17, schrieb janek.lilyp...@gmail.com:
I dedicate all my code reviews to Graham Percival.
Marc,
your change is so big that i have trouble grasping it and understanding
everything, but i have a few specific comments.
Janek
http://codereview.appspot.com/6498052/diff/50001/Docume
- Original Message -
From:
To: ; ; ;
; ; ;
Cc: ;
Sent: Sunday, October 14, 2012 6:17 PM
Subject: Re: bar-line interface part 2/2: New bar line definition
standard(issue 6498052)
http://codereview.appspot.com/6498052/diff/50001/Documentation/snippets/new/printing-a-repeat-sign
I dedicate all my code reviews to Graham Percival.
Marc,
your change is so big that i have trouble grasping it and understanding
everything, but i have a few specific comments.
Janek
http://codereview.appspot.com/6498052/diff/50001/Documentation/snippets/new/printing-a-repeat-sign-at-the-begin
Am 06.10.2012 11:23, schrieb Janek Warchoł:
On Fri, Oct 5, 2012 at 9:42 PM, Thomas Morley
wrote:
2012/10/5 :
It just occured to me: is there any way to specify different span bar
lines (at the end of the line and at the beginning of the line)?
Marc and me, we discussed this some time ago and
Am 05.10.2012 21:42, schrieb Thomas Morley:
2012/10/5 :
Marc wrote:
(define-bar-line ...) or \defineBarLine allows for new
definitions. These functions have four arguments,
namely the bar line itself, the bar line used at the end
of line, the bar line used at the begin of a new line
and the sp
Marc Hohl writes:
> Am 30.09.2012 22:03, schrieb d...@gnu.org:
>> On 2012/09/30 19:44:49, marc wrote:
>>> Am 30.09.2012 11:02, schrieb d...@gnu.org:
>>> > [...]
>>> > First, the define-public is asking for trouble. You are exposing an
>>> > internal Scheme data structure to users and make it over
Am 30.09.2012 22:03, schrieb d...@gnu.org:
On 2012/09/30 19:44:49, marc wrote:
Am 30.09.2012 11:02, schrieb d...@gnu.org:
> [...]
> First, the define-public is asking for trouble. You are exposing an
> internal Scheme data structure to users and make it overwritable by
the
> user. If the user
Am 06.10.2012 11:23, schrieb Janek Warchoł:
On Fri, Oct 5, 2012 at 9:42 PM, Thomas Morley
wrote:
2012/10/5 :
It just occured to me: is there any way to specify different span bar
lines (at the end of the line and at the beginning of the line)?
Marc and me, we discussed this some time ago and
On Fri, Oct 5, 2012 at 9:42 PM, Thomas Morley
wrote:
> 2012/10/5 :
>> It just occured to me: is there any way to specify different span bar
>> lines (at the end of the line and at the beginning of the line)?
>
> Marc and me, we discussed this some time ago and decided not to
> provide that functi
2012/10/5 :
> Marc wrote:
>>
>> (define-bar-line ...) or \defineBarLine allows for new
>> definitions. These functions have four arguments,
>> namely the bar line itself, the bar line used at the end
>> of line, the bar line used at the begin of a new line
>> and the span bar line.
>
>
> It just o
Marc wrote:
(define-bar-line ...) or \defineBarLine allows for new
definitions. These functions have four arguments,
namely the bar line itself, the bar line used at the end
of line, the bar line used at the begin of a new line
and the span bar line.
It just occured to me: is there any way to s
On Sunday, September 30, 2012, Davod Kastrup wrote:
> Hold your horses, this is another case too stupid for
> documenting and walking people through. Give me two days, and then you
> replace your define-public for the alists with define-session, and
> that's it. The rest of the code stays as it
Thomas Morley writes:
> 2012/9/30 :
>> On 2012/09/30 19:44:49, marc wrote:
>>>
>>> Am 30.09.2012 11:02, schrieb d...@gnu.org:
>>> > [...]
>>> > First, the define-public is asking for trouble. You are exposing an
>>> > internal Scheme data structure to users and make it overwritable by
>>
>> the
On 2012/10/01 08:46:09, marc wrote:
Am 30.09.2012 22:03, schrieb d...@gnu.org:
> On 2012/09/30 19:44:49, marc wrote:
>> Am 30.09.2012 11:02, schrieb d...@gnu.org:
>> > [...]
>> > First, the define-public is asking for trouble. You are exposing
an
>> > internal Scheme data structure to users and
Marc Hohl writes:
> Am 01.10.2012 11:00, schrieb d...@gnu.org:
>>
>> Or define-session-public. define-session will be for data that is reset
>> per session, but not publicly accessible. Which is probably what you
>> want if all the accessor functions are already in your .scm file.
> I think tha
Am 01.10.2012 11:00, schrieb d...@gnu.org:
On 2012/10/01 08:46:09, marc wrote:
Am 30.09.2012 22:03, schrieb d...@gnu.org:
> On 2012/09/30 19:44:49, marc wrote:
>> Am 30.09.2012 11:02, schrieb d...@gnu.org:
>> > [...]
>> > First, the define-public is asking for trouble. You are exposing
an
>> >
Am 30.09.2012 22:03, schrieb d...@gnu.org:
On 2012/09/30 19:44:49, marc wrote:
Am 30.09.2012 11:02, schrieb d...@gnu.org:
> [...]
> First, the define-public is asking for trouble. You are exposing an
> internal Scheme data structure to users and make it overwritable by
the
> user. If the user
2012/9/30 :
> On 2012/09/30 19:44:49, marc wrote:
>>
>> Am 30.09.2012 11:02, schrieb d...@gnu.org:
>> > [...]
>> > First, the define-public is asking for trouble. You are exposing an
>> > internal Scheme data structure to users and make it overwritable by
>
> the
>>
>> > user. If the user follows
On 2012/09/30 19:44:49, marc wrote:
Am 30.09.2012 11:02, schrieb d...@gnu.org:
> [...]
> First, the define-public is asking for trouble. You are exposing an
> internal Scheme data structure to users and make it overwritable by
the
> user. If the user follows this invitation, the effects will bl
Am 30.09.2012 11:02, schrieb d...@gnu.org:
[...]
First, the define-public is asking for trouble. You are exposing an
internal Scheme data structure to users and make it overwritable by the
user. If the user follows this invitation, the effects will bleed over
from session to session. Never do tha
On 2012/09/30 08:33:16, marc wrote:
Am 30.09.2012 10:01, schrieb d...@gnu.org:
>
> http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm
> File scm/bar-line.scm (right):
>
>
http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm#newcode225
>
> scm/bar-line.scm:225: (defi
Am 30.09.2012 10:01, schrieb d...@gnu.org:
http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm
File scm/bar-line.scm (right):
http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm#newcode225
scm/bar-line.scm:225: (define-public bar-glyph-alist '())
This interface de
On 30 sept. 2012, at 10:25, Marc Hohl wrote:
> Am 30.09.2012 04:11, schrieb k-ohara5...@oco.net:
>> Now looking at the log files, I do get "undead" errors for our
>> regression test 'bar-line-define-bar-glyph.ly' but not from any other
>> files that I tried. (I don't know why the scripts from `m
Am 30.09.2012 10:01, schrieb d...@gnu.org:
http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm
File scm/bar-line.scm (right):
http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm#newcode225
scm/bar-line.scm:225: (define-public bar-glyph-alist '())
This interface de
Am 30.09.2012 04:11, schrieb k-ohara5...@oco.net:
Now looking at the log files, I do get "undead" errors for our
regression test 'bar-line-define-bar-glyph.ly' but not from any other
files that I tried. (I don't know why the scripts from `make check` did
not flag it.)
Keith, thanks for your work
http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm
File scm/bar-line.scm (right):
http://codereview.appspot.com/6498052/diff/32001/scm/bar-line.scm#newcode225
scm/bar-line.scm:225: (define-public bar-glyph-alist '())
This interface definition is asking for trouble. It is an impor
Now looking at the log files, I do get "undead" errors for our
regression test 'bar-line-define-bar-glyph.ly' but not from any other
files that I tried. (I don't know why the scripts from `make check` did
not flag it.)
There are four messages, but the particular undead objects vary from run
to r
On 2012/09/29 09:14:08, marc wrote:
Am 29.09.2012 07:11, schrieb k-ohara5...@oco.net:
> In one pdf previewer (evince) at low resolution, the span bars look
a
> little thicker than the regular bar lines.
Disregard. The slight mis-rendering on screen was there before your
patch as well.
http
Am 29.09.2012 07:11, schrieb k-ohara5...@oco.net:
Looks good so far.
In one pdf previewer (evince) at low resolution, the span bars look a
little thicker than the regular bar lines. Maybe a rounding fault of
the viewer, but it would be better if you know how to avoid it.
If you zoom it, this wil
Looks good so far.
In one pdf previewer (evince) at low resolution, the span bars look a
little thicker than the regular bar lines. Maybe a rounding fault of
the viewer, but it would be better if you know how to avoid it.
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm
File s
Am 28.09.2012 00:54, schrieb thomasmorle...@googlemail.com:
One tiny addition:
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm
File scm/bar-line.scm (right):
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm#newcode1053
scm/bar-line.scm:1053: (define-bar-
Am 28.09.2012 00:21, schrieb ianhuli...@gmail.com:
Apart from a typo in changes.tely (q.v.), LGTM.
http://codereview.appspot.com/6498052/diff/24001/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/6498052/diff/24001/Documentation/changes.tely
One tiny addition:
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm
File scm/bar-line.scm (right):
http://codereview.appspot.com/6498052/diff/24001/scm/bar-line.scm#newcode1053
scm/bar-line.scm:1053: (define-bar-line ":|]" ":|]" #f " |")
When we provide a bracket-repeat-sign
Apart from a typo in changes.tely (q.v.), LGTM.
http://codereview.appspot.com/6498052/diff/24001/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/6498052/diff/24001/Documentation/changes.tely#newcode67
Documentation/changes.tely:67: as @code{:|}.
34 matches
Mail list logo
