Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-12 Thread lilyliska
This notation _may_ make a score harder to read than typing all meter changes explicitly. But the intention of this patch is not to provide a better notation but to better support an existing notation. https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly File ly/music-fu

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread k-ohara5a5a
On 2014/05/10 09:52:41, Trevor Daniels wrote: (We try to avoid referring to the reader with 'you', Instruction manuals, especially those for a machine, usually make clear what actions the user takes versus what the machine does. This manual doesn't even use third person (as in "The user indica

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread k-ohara5a5a
The score is harder to understand with this function, than it was after I expanded the function's contents in-line. The boundary of the action of this function (part timing, mostly printed representation) is hard to understand and remember. This version of the function does partial changes to th

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread lilyliska
https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly#newcode144 ly/music-functions-init.ly:144: #{ \once\override Staff.TimeSignature.stencil = On 2014/

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread janek . lilypond
Come comments. https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/97110045/diff/80001/ly/music-functions-init.ly#newcode144 ly/music-functions-init.ly:144: #{ \once\override Staff.TimeSignature.st

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread Phil Holmes
- Original Message - From: "Urs Liska" To: Sent: Saturday, May 10, 2014 12:23 PM Subject: Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045) Thanks, I'll update accordingly. Generally speaking, should a modification of this kind trigger a new review

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread lilyliska
https://codereview.appspot.com/97110045/diff/60001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/97110045/diff/60001/Documentation/notation/rhythms.itely#newcode1754 Documentation/notation/rhythms.itely:1754: aren't printed

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread Urs Liska
Am 10.05.2014 11:52, schrieb tdanielsmu...@googlemail.com: I've suggested some style changes to conform to the rest of the NR. (We try to avoid referring to the reader with 'you', and entering LilyPond code within text, instead leaving the example to speak for itself.) Otherwise, LGTM. Trevor

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread tdanielsmusic
I've suggested some style changes to conform to the rest of the NR. (We try to avoid referring to the reader with 'you', and entering LilyPond code within text, instead leaving the example to speak for itself.) Otherwise, LGTM. Trevor https://codereview.appspot.com/97110045/diff/60001/Docume

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread lilyliska
This is the right one, hopefully better understandable https://codereview.appspot.com/97110045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-10 Thread lilyliska
On 2014/05/10 08:33:44, uliska wrote: rewording doc section Oops? This Patch set is invalid ... https://codereview.appspot.com/97110045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-09 Thread Urs Liska
Am 09.05.2014 13:31, schrieb d...@gnu.org: https://codereview.appspot.com/97110045/diff/20001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/97110045/diff/20001/Documentation/notation/rhythms.itely#newcode1780 Documentati

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-09 Thread dak
https://codereview.appspot.com/97110045/diff/20001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/97110045/diff/20001/Documentation/notation/rhythms.itely#newcode1780 Documentation/notation/rhythms.itely:1780: Different from

Re: Issue 3917: Add \alternatingTimeSignatures (issue 97110045)

2014-05-09 Thread lilyliska
On 2014/05/09 09:02:44, uliska wrote: Fixing doc error I think I found the issue (no new line after end of lilypond example). I'm very sorry that I currently can't test make doc due to an installation issue with dblatex. But I can't imagine any other spot here that could cause make doc to fail.