Latest version LGTM.
Keith, could you send me the git-format patch privately, so that I can
push it in 24 hours if nobody complains?
http://codereview.appspot.com/4095041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mai
On 2011/02/02 23:14:39, Neil Puttock wrote:
LGTM.
http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc
File lily/separation-item.cc (right):
http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc#newcode83
lily/separation-item.cc:83: double horizon_pa
LGTM.
http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc
File lily/separation-item.cc (right):
http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc#newcode83
lily/separation-item.cc:83: double horizon_padding = robust_scm2double
(me->get_property ("skyl
LGTM
On Tue, Feb 1, 2011 at 7:49 PM, wrote:
> LGTM
>
> http://codereview.appspot.com/4095041/
>
--
Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailm
LGTM
http://codereview.appspot.com/4095041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/01/31 19:50:38, Carl wrote:
Since the 0.1s are all part of a Separation_item, what if we
defined a new grob-property default-separation, and set the value
to 0.1 for NonMusicalPaperColumn, NoteColumn, and PaperColumn,
since these are the grobs having separation_item_interface?
Done; and
On 31 January 2011 20:20, wrote:
> I had discounted the new property idea because of all the extra property
> lookups, but it seems your idea costs only one lookup per Column.
> For a name, default-clearance might better indicate that this is a
> vertical clearance maintained while choosing hori
On 2011/01/31 19:50:38, Carl wrote:
We could then get the value of default-separation from the paper
column, and use
that value throughout separation-item.cc
I had discounted the new property idea because of all the extra property
lookups, but it seems your idea costs only one lookup per Col
On 2011/01/31 19:36:16, Keith wrote:
On 2011/01/31 11:20:39, hanwenn wrote:
> * this hardcodes 0.1 in several places. Make a property,
> so we can override this
Agreed in principle; the relevant property extra-spacing-height should
absorb
these magic numbers, but I am not willing to do so in
On 2011/01/31 11:20:39, hanwenn wrote:
* this hardcodes 0.1 in several places. Make a property,
so we can override this
Agreed in principle; the relevant property extra-spacing-height should
absorb these magic numbers, but I am not willing to do so in this patch.
The 0.1s were in the previous
2 issues:
* this hardcodes 0.1 in several places. Make a property, so we can
override this
* rewrite the commit description so it explains what you are doing (ie.
what issues 1120, 1472, 1474 are). The desc. should be understandable
without access to the bug database.
http://codereview.appspot
This patch solves Neil's problem with clef spacing.
LGTM.
Carl
http://codereview.appspot.com/4095041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/01/26 18:18:21, Graham Percival wrote:
Neil has identified a potential downside to this patch.
That was a restoration of 2.12.3 behavior, which I had mentioned in the
original email thread but didn't explicitly handle until now.
Status of this patch is
1)revert ee0488, which was a glob
On 2011/01/25 04:47:23, Carl wrote:
This patch seems to have some very good benefits.
Neil has identified a potential downside to this patch.
Some kind of additional work is required -- maybe adding some special
case to avoid changing clefs in this way, or possibly just an argument
that the ch
On Mon, 24 Jan 2011 20:47:24 -0800, wrote:
This patch also resolves the problem in issue 1229 of notes extending
beyond the right-hand bar line.
Adding additional extra-spacing-height to the TimeSignature grob
resolves the 1229 issue of overlapping the time signature.
This patch seems to have
This patch also resolves the problem in issue 1229 of notes extending
beyond the right-hand bar line.
Adding additional extra-spacing-height to the TimeSignature grob
resolves the 1229 issue of overlapping the time signature.
This patch seems to have some very good benefits.
http://codereview.a
On 1/24/11 11:15 AM, "Bernard Hurley" wrote:
> Is there any point in anyone working on 1474 before this is resolved?
I don't think so. 1120, 1472, and 1474 are intimately connected and will be
resolved together.
Thanks,
Carl
___
lilypond-devel
Is there any point in anyone working on 1474 before this is resolved?
/Bernard
On Mon, Jan 24, 2011 at 02:24:16PM -, Phil Holmes wrote:
> - Original Message - From:
> To:
> Cc: ;
> Sent: Monday, January 24, 2011 5:15 AM
> Subject: Re: Fix 1120 in a way to av
- Original Message -
From:
To:
Cc: ;
Sent: Monday, January 24, 2011 5:15 AM
Subject: Re: Fix 1120 in a way to avoid issues 1472, 1474 (issue4095041)
Extended to cover the other issues that were fixed along with 1120. The
regression test that /could/ have caught the breakage of
Extended to cover the other issues that were fixed along with 1120. The
regression test that /could/ have caught the breakage of issue 1120 is
revised so it will (more likely) catch any future breakage.
http://codereview.appspot.com/4095041/diff/32001/scm/define-grobs.scm
File scm/define-grobs.
Needs adjustments as marked, to handle all the other issues that commit
ee0488 fixed :
886 (=819) 1138 and 1137(already handled)
and some exactly analogous situations not yet reported.
New patch within a day, to come along with reg tests.
http://codereview.appspot.com/4095041/diff/32001/scm/de
Regtest comparison shows nothing obviously wrong, and it compiles the
docs from scratch.
http://codereview.appspot.com/4095041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
22 matches
Mail list logo
