Extended to cover the other issues that were fixed along with 1120. The regression test that /could/ have caught the breakage of issue 1120 is revised so it will (more likely) catch any future breakage.
http://codereview.appspot.com/4095041/diff/32001/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4095041/diff/32001/scm/define-grobs.scm#newcode261 scm/define-grobs.scm:261: (stencil . ,ly:text-interface::print) On 2011/01/23 04:48:19, Keith wrote:
extra-spacing-height . (-0.5 . 0.5) for issue 1138
.. is not required for the regtest that raised issue 1138 (figured-bass-extenders-markup) Also, if the line above is added to FiguredBass, it spaces complicated basso continuo too tightly. Figured Bass is more similar to NoteHeads than it is to Lyrics. http://codereview.appspot.com/4095041/diff/32001/scm/define-grobs.scm#newcode586 scm/define-grobs.scm:586: (extra-spacing-height . (-0.5 . 0.5)) CueClef and CueEndClef were added after ee00488 so a simple revert missed these. They should match Clef. http://codereview.appspot.com/4095041/diff/32001/scm/define-grobs.scm#newcode967 scm/define-grobs.scm:967: (stencil . ,system-start-text::print) InstrumentName goes left of the staff. No analogy with the melismata issue 1120 http://codereview.appspot.com/4095041/diff/32001/scm/define-grobs.scm#newcode1183 scm/define-grobs.scm:1183: (stencil . ,ly:measure-grouping::print) On 2011/01/23 04:48:19, Keith wrote:
extra-spacing-height analogous to Lyrics?
MeasureGrouping does not work analogously to Lyrics. No need to extend a fix for 1120 here. http://codereview.appspot.com/4095041/diff/42001/input/regression/lyrics-melisma-beam.ly File input/regression/lyrics-melisma-beam.ly (right): http://codereview.appspot.com/4095041/diff/42001/input/regression/lyrics-melisma-beam.ly#newcode17 input/regression/lyrics-melisma-beam.ly:17: g4 d8[ b8 d8 g8] g4 Moved some note heads so their stems interfere with lyrics, so that these notes will move should something like issue 1120 recur. http://codereview.appspot.com/4095041/diff/42001/scm/define-grobs.scm File scm/define-grobs.scm (right): http://codereview.appspot.com/4095041/diff/42001/scm/define-grobs.scm#newcode178 scm/define-grobs.scm:178: (BalloonTextItem Similar to Lyrics in its spacing needs http://codereview.appspot.com/4095041/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
