LGTM.

http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc
File lily/separation-item.cc (right):

http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc#newcode83
lily/separation-item.cc:83: double horizon_padding = robust_scm2double
(me->get_property ("skyline-vertical-padding"), 0.0);
Real horizon_padding

http://codereview.appspot.com/4095041/diff/52002/lily/separation-item.cc#newcode94
lily/separation-item.cc:94: double horizon_padding = robust_scm2double
(me->get_property ("skyline-vertical-padding"), 0.0);
Real horizon_padding

http://codereview.appspot.com/4095041/diff/52002/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4095041/diff/52002/scm/define-grob-properties.scm#newcode727
scm/define-grob-properties.scm:727: Y-extents and extra-spacing-heights
of the constituent grobs in the
@code{Y-extent}s and @code{extra-spacing-height}s

http://codereview.appspot.com/4095041/diff/52002/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4095041/diff/52002/scm/define-grobs.scm#newcode1081
scm/define-grobs.scm:1081: (extra-spacing-height . (+inf.0 . -inf.0))
fix indent (tab)

http://codereview.appspot.com/4095041/diff/52002/scm/define-grobs.scm#newcode1161
scm/define-grobs.scm:1161: ; Recede in height for purposes of note
spacing,
;;

http://codereview.appspot.com/4095041/diff/52002/scm/define-grobs.scm#newcode1162
scm/define-grobs.scm:1162: ; so notes in melismata can be freely spaced
above lyrics
;;

http://codereview.appspot.com/4095041/

_______________________________________________
lilypond-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to