Re: Lilypond patch

2022-05-24 Thread Lukas-Fabian Moser
Hi Jean & everybody, Am 23.05.22 um 19:33 schrieb Jean Abou Samra: If you have a core dump, that normally means you encountered a bug in LilyPond. Having such a crash is quite rare, so it seems like bad luck if you hit one as a new user That's what I told Andrea when she asked me (we're at the

Re: Lilypond patch

2022-05-24 Thread Jean Abou Samra
Hi, Again, please keep the list in copy. In your mail client, you should see lilypond-devel@gnu.org in the To: or CC: field. You will normally find a "Reply to all" button that you can use instead of just "Reply" in order to keep all recipients. That way, everyone can keep helping you, not just m

Re: Lilypond patch

2022-05-23 Thread Jean Abou Samra
Le 23/05/2022 à 20:09, Andrea lienbacher a écrit : Dear Jean! Thank for your support!:) Alternatively, you might have tried to process a huuuge score to the point that your computer couldn't cope anymore. (That would normally not happen before hundreds of pages, or large nesting levels.) I mad

Re: Lilypond patch

2022-05-23 Thread Werner LEMBERG
>> Iam a very new user of Lilypond (MacOS). Yesterday i made a new >> sheet. Suddenly after texting, there was the information “core >> dump”. Today i tried to see, whats going on. After that, my mac >> hangs up and react at nothing. So i had to delete Lilypond, bc >> nothing else worked. Can yo

Re: Lilypond patch

2022-05-23 Thread Jean Abou Samra
On 2022-05-23 11:09, Andrea lienbacher wrote: Hello! Iam a very new user of Lilypond (MacOS). Yesterday i made a new sheet. Suddenly after texting, there was the information “core dump”. Today i tried to see, whats going on. After that, my mac hangs up and react at nothing. So i had to delete

Re: Lilypond patch

2022-05-23 Thread Colin Campbell
Guten Morgen Andrea. Ich leite Ihre Frage an die E-Mail-Liste der Lilypond-Entwickler weiter. Einige der Entwickler sind deutschsprachig und werden Ihre Frage viel besser beantworten können als ich. Willkommen bei Lilypond! Colin On 2022-05-23 11:09, Andrea lienbacher wrote: Hello! Iam a ve

Re: [PATCH] beam: remove unnecessary vector of forbidden intervals

2022-04-17 Thread Jean Abou Samra
terval gap = allowed_regions[i]; Thanks, and welcome. The Contributor's Guide explains how to upload a patch on GitLab. https://lilypond.org/doc/v2.23/Documentation/contributor/working-with-source-code Best, Jean

[PATCH] beam: remove unnecessary vector of forbidden intervals

2022-04-16 Thread Nihal Jere
The same vector is constructed twice, so just do it once. --- Not sure if this is the right place to send patches, but here it is. lily/beam.cc | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lily/beam.cc b/lily/beam.cc index 340d9fe1a1..dbb9c186c5 100644 --- a/lily/beam.

Re: Patch scheduling

2022-02-10 Thread Dan Eble
On Feb 6, 2022, at 22:23, Colin Campbell wrote: > > For my guidance, I'd be grateful if the community would correct or amplify > the following recap of the patch handling process. > Colin, I think you summed it up well and I agree with Lukas' additions. Thanks, — Dan

Re: Patch scheduling

2022-02-07 Thread Colin Campbell
On 2022-02-07 02:07, Lukas-Fabian Moser wrote: Hi Colin, forgive me for butting in as someone who has made very few contributions (but followed some of the discussions quite closely over the last few years): So what I'm trying to say is: A task that seems like a trivial cron job 95% of th

Re: Patch scheduling

2022-02-07 Thread Lukas-Fabian Moser
. MRs can also be set back in the flow by developers, when issues are found, or after new commits are added. Open discussions are not necessarily a reason to hold back an MR. If all that is reasonably close to the way things operate, the role of the patch scheduler is pretty mechanical

Patch scheduling

2022-02-06 Thread Colin Campbell
For my guidance, I'd be grateful if the community would correct or amplify the following recap of the patch handling process. Working backwards: When an MR has been on Countdown for 48 hours, it goes to Push. When an MR has been or Review for 24 hours, it goes on the next countdown. Wh

Re: Stepping down from Patch Meister role

2022-01-30 Thread Jean Abou Samra
Le 30/01/2022 à 22:07, Jean Abou Samra a écrit : Le 30/01/2022 à 18:19, James a écrit : Documentation and Patch Meister ? OK. But I see that you just deleted your GitLab account. Does this mean you no longer intend to contribute? I was hoping you would stay with us for documentation, bug

Re: Stepping down from Patch Meister role

2022-01-30 Thread Jean Abou Samra
understand how to resolve? That way there is at least some percieved semblance of a hand-over. One thought in passing: we need to update the Contributor's Guide as well as http://lilypond.org/authors.html. James, how should you be called on the latter page? Documentation and Patch Meis

Re: Stepping down from Patch Meister role

2022-01-30 Thread James
ere is at least some percieved semblance of a hand-over. One thought in passing: we need to update the Contributor's Guide as well as http://lilypond.org/authors.html. James, how should you be called on the latter page? Documentation and Patch Meister ? -- Regards James

Re: Stepping down from Patch Meister role

2022-01-29 Thread Jean Abou Samra
Le 28/01/2022 à 10:49, pkx1...@posteo.net a écrit : Why don't you do the 'next' countdown (on Jan 30th) while I am still about and let me know what problems/questions you had or need to understand how to resolve? That way there is at least some percieved semblance of a hand-over. One though

Re: Stepping down from Patch Meister role

2022-01-29 Thread Jean-Charles Malahieude
Le 08/01/2022 à 12:15, Jonas Hahnfeld via Discussions on LilyPond development a écrit : Am Samstag, dem 08.01.2022 um 10:06 + schrieb James: Hello, I am going to stop doing the Patch countdown at the end of this month. I'll continue for the next few weeks, but my last countdown wi

Re: Stepping down from Patch Meister role

2022-01-28 Thread Colin Campbell
On 2022-01-28 02:49, pkx1...@posteo.net wrote: Colin, Why don't you do the 'next' countdown (on Jan 30th) while I am still about and let me know what problems/questions you had or need to understand how to resolve? That way there is at least some percieved semblance of a hand-over. You

Re: Stepping down from Patch Meister role

2022-01-28 Thread pkx166h
need formal permissions within Lilypond? Yes, IIRC Jonas will need to give you a level of access so you can comment and change labels of MRs (i.e. move MRs from Patch::review to Patch::push etc). Excellent, James; just what I needed. As this is copied to the devel list, I'm hoping it will

Re: Stepping down from Patch Meister role

2022-01-28 Thread Jonas Hahnfeld via Discussions on LilyPond development
gitlab account, based on this email, do I need formal > > > permissions within Lilypond? > > Yes, IIRC Jonas will need to give you a level of access so you can > > comment and change labels of MRs (i.e. move MRs from Patch::review to > > Patch::push etc). > >

Re: Stepping down from Patch Meister role

2022-01-26 Thread Colin Campbell
and change labels of MRs (i.e. move MRs from Patch::review to Patch::push etc). Does "middle green tick" refer to what I see on lilypond/merge requests/!? Yes, if you hover over the middle tick it says 'tests passed'. Click it and you get taken to a console window where yo

Re: Stepping down from Patch Meister role

2022-01-26 Thread pkx166h
opers, different interface. Patch testing has been completely automated so all you are doing is viewing reg test diffs (middle green tick on the MR, find the link in the cmd window and clikc on it in a browser). All you need is a gitlab login and email. Good morning to you,James! A couple of

Re: Stepping down from Patch Meister role

2022-01-26 Thread Colin Campbell
On 2022-01-23 09:15, pkx1...@posteo.net wrote: Colin hi, Apart from the interface of GitLab and a nice countdown script (instead of the old script that was used) it's more or less the same process as before. Different developers, different interface. Patch testing has been compl

Re: Stepping down from Patch Meister role

2022-01-23 Thread pkx166h
Colin hi, On 22/01/2022 22:32, Colin Campbell wrote: On 2022-01-08 03:06, James wrote: Hello, I am going to stop doing the Patch countdown at the end of this month. I'll continue for the next few weeks, but my last countdown will be whatever the last date in January ends up being. T

Re: Stepping down from Patch Meister role

2022-01-23 Thread pkx166h
Hello, On 22/01/2022 22:12, Carl Sorensen wrote: James, How much time do you spend per week as Patch Meister? I spend about 15-20 mins every 2 days. I don't review code, I just check reg tests (pasting those that are new or changed significantly) I also make sure all threads that are

Re: Stepping down from Patch Meister role

2022-01-23 Thread Jean Abou Samra
Le 22/01/2022 à 23:32, Colin Campbell a écrit : On 2022-01-08 03:06, James wrote: Hello, I am going to stop doing the Patch countdown at the end of this month. I'll continue for the next few weeks, but my last countdown will be whatever the last date in January ends up being. T

Re: Stepping down from Patch Meister role

2022-01-22 Thread Colin Campbell
On 2022-01-08 03:06, James wrote: Hello, I am going to stop doing the Patch countdown at the end of this month. I'll continue for the next few weeks, but my last countdown will be whatever the last date in January ends up being. Thanks for your understanding. Since James took over

Re: Stepping down from Patch Meister role

2022-01-22 Thread Carl Sorensen
James, How much time do you spend per week as Patch Meister? If the time requirement is manageable, I could step in. I don't have lots of time to spend on Lilypond (hence my lack of current development work), but I could plan to spend some. Please help me understand the time you

Re: Stepping down from Patch Meister role

2022-01-22 Thread Jean Abou Samra
Lowe should be some indication that this is not a conflict of interest as such. It may end up a conflict of resources. Yes, my initial message wasn't entirely clear, it's of course possible to contribute patches while being "Patch Meister". The "impartiality" asp

Re: Stepping down from Patch Meister role

2022-01-22 Thread Han-Wen Nienhuys
e > > > > should be some indication that this is not a conflict of interest as > > such. It may end up a conflict of resources. > > Yes, my initial message wasn't entirely clear, it's of course possible > to contribute patches while being "Patch Meister&quo

Re: Stepping down from Patch Meister role

2022-01-22 Thread Han-Wen Nienhuys
On Sat, Jan 8, 2022 at 11:07 AM James wrote: > I am going to stop doing the Patch countdown at the end of this month. > > I'll continue for the next few weeks, but my last countdown will be > whatever the last date in January ends up being. > > Thanks for your understa

Re: Stepping down from Patch Meister role

2022-01-22 Thread Jonas Hahnfeld via Discussions on LilyPond development
e indication that this is not a conflict of interest as > such. It may end up a conflict of resources. Yes, my initial message wasn't entirely clear, it's of course possible to contribute patches while being "Patch Meister". The "impartiality" aspect is that you should try

Re: Stepping down from Patch Meister role

2022-01-13 Thread David Kastrup
Kevin Barry writes: > Hi James, > > This is a big loss; you will be missed. Thank you for all of your hard work. > >> I want to stay a >> developer and that conflicts both time-wise and with respect to >> impartiality. > > Finding a non-developer to fill James's shoes sounds difficult. I > would

Re: Stepping down from Patch Meister role

2022-01-13 Thread Kevin Barry
Hi James, This is a big loss; you will be missed. Thank you for all of your hard work. > I want to stay a > developer and that conflicts both time-wise and with respect to > impartiality. Finding a non-developer to fill James's shoes sounds difficult. I would volunteer, but I still plan to contr

Re: Stepping down from Patch Meister role

2022-01-08 Thread Jean Abou Samra
Le 08/01/2022 à 11:06, James a écrit : Hello, I am going to stop doing the Patch countdown at the end of this month. I'll continue for the next few weeks, but my last countdown will be whatever the last date in January ends up being. Thanks for your understanding. You definitely de

Re: Stepping down from Patch Meister role

2022-01-08 Thread Werner LEMBERG
> As said before off-list, thanks a lot for all the work you've been > doing. Yes. Thanks, James! Werner

Re: Stepping down from Patch Meister role

2022-01-08 Thread Dan Eble
On Jan 8, 2022, at 05:06, James wrote: > > I am going to stop doing the Patch countdown at the end of this month. > Thanks for the many years of steady contribution, James. — Dan

Re: Stepping down from Patch Meister role

2022-01-08 Thread Thomas Morley
Am Sa., 8. Jan. 2022 um 11:06 Uhr schrieb James : > > Hello, > > I am going to stop doing the Patch countdown at the end of this month. > > I'll continue for the next few weeks, but my last countdown will be > whatever the last date in January ends up being. > &g

Re: Stepping down from Patch Meister role

2022-01-08 Thread Jonas Hahnfeld via Discussions on LilyPond development
Am Samstag, dem 08.01.2022 um 10:06 + schrieb James: > Hello, > > I am going to stop doing the Patch countdown at the end of this month. > > I'll continue for the next few weeks, but my last countdown will be > whatever the last date in January ends up bein

Stepping down from Patch Meister role

2022-01-08 Thread James
Hello, I am going to stop doing the Patch countdown at the end of this month. I'll continue for the next few weeks, but my last countdown will be whatever the last date in January ends up being. Thanks for your understanding. -- Regards James

[PATCH] fix broken building of guile branch "branch_release-1-8"

2021-03-21 Thread Knut Petersen
Hi Thien-Thi Nguy, Two days ago I reported that building of guile branch_release-1-8 failed on my system based on openSuSE Tumbleweed with autoconf 2.71. I had a look into the case and found that it was introduced by your commits 88155da and c43f252. The attached patch fixes the problem

Re: Policy concerning 'Patch::review'

2021-02-15 Thread James
sy and perhaps not generate more emails. This is similar reasoning that we assume no update to a thread by another developer infers approval (or at the very least no dis-approval) of a MR/Patch, so that it can move on, rather than have to wait for someone to OK a patch explicitly. I check ever

Policy concerning 'Patch::review'

2021-02-15 Thread Michael Käppler
Hi all, I'm not sure if I missed some policy change, but I noticed that recently some MRs were set to 'Review' without posting the test results. I assume that in such cases the tests were unchanged, but it would be good to clarify this. Have a nice day everyone, Michael

Re: who needs script `update-patch-version`?

2021-02-01 Thread Jonas Hahnfeld
Am Montag, dem 01.02.2021 um 16:06 +0100 schrieb Werner LEMBERG: > > > Unfortunately, this is next to impossible since there are so many > > > changes.  I will provide a PDF that holds the changed pages so > > > that > > > you and others can simply read what's written there, comparing it > > > with

Re: who needs script `update-patch-version`?

2021-02-01 Thread James
On 01/02/2021 15:06, Werner LEMBERG wrote: Unfortunately, this is next to impossible since there are so many changes. I will provide a PDF that holds the changed pages so that you and others can simply read what's written there, comparing it with the current version of the Contributor guide if

Re: who needs script `update-patch-version`?

2021-02-01 Thread Werner LEMBERG
>>Unfortunately, this is next to impossible since there are so many >>changes. I will provide a PDF that holds the changed pages so that >>you and others can simply read what's written there, comparing it >>with the current version of the Contributor guide if necessary. > > It was this condition

Re: who needs script `update-patch-version`?

2021-02-01 Thread Michael Käppler
Am 01.02.2021 um 12:39 schrieb Jonas Hahnfeld: Am Montag, dem 01.02.2021 um 12:11 +0100 schrieb Werner LEMBERG: Right now I'm completely revising `programming-work.itexi`, so I can take care of that, too. It would be great if you can structure the revision as incremental updates and not as a bi

Re: who needs script `update-patch-version`?

2021-02-01 Thread Werner LEMBERG
>> > It would be great if you can structure the revision as incremental >> > updates and not as a big dump. Those are quite tedious to review >> > and usually take much longer to go through... >> >> Unfortunately, this is next to impossible since there are so many >> changes. > > No, it is poss

Re[2]: who needs script `update-patch-version`?

2021-02-01 Thread Trevor
Werner wrote 01/02/2021 11:11:21 It would be great if you can structure the revision as incremental updates and not as a big dump. Those are quite tedious to review and usually take much longer to go through... Unfortunately, this is next to impossible since there are so many changes. I wi

Re: who needs script `update-patch-version`?

2021-02-01 Thread Jonas Hahnfeld
Am Montag, dem 01.02.2021 um 12:11 +0100 schrieb Werner LEMBERG: > > > > > Right now I'm completely revising `programming-work.itexi`, so I > > > can take care of that, too. > > > > It would be great if you can structure the revision as incremental > > updates and not as a big dump. Those are qui

Re: who needs script `update-patch-version`?

2021-02-01 Thread Werner LEMBERG
>> Is there still any benefit in using the >> `scripts/auxiliar/update-patch-version` script as described in the >> Contributor Guide?  It seems to me that this and the related >> documentation should be simply deleted. > > I don't, and if need be we can ru

Re: who needs script `update-patch-version`?

2021-01-31 Thread Jonas Hahnfeld
Am Montag, dem 01.02.2021 um 06:38 +0100 schrieb Werner LEMBERG: > Is there still any benefit in using the > `scripts/auxiliar/update-patch-version` script as described in the > Contributor Guide?  It seems to me that this and the related > documentation should be simply deleted. I d

who needs script `update-patch-version`?

2021-01-31 Thread Werner LEMBERG
Is there still any benefit in using the `scripts/auxiliar/update-patch-version` script as described in the Contributor Guide? It seems to me that this and the related documentation should be simply deleted. Right now I'm completely revising `programming-work.itexi`, so I can take care of

Re: Advancing to Patch::review

2020-12-19 Thread Jonas Hahnfeld
Am Mittwoch, dem 02.12.2020 um 18:16 +0100 schrieb Jonas Hahnfeld: > > My gut feeling is that this should be somebody else than the MR author > > [...] To elaborate a bit, this tries to keep the pleasant effect that > somebody else at least opens your MR and nobody is tempted to change > labels be

Advancing to Patch::review - RFC (was Re: Advancing to Patch::review)

2020-12-06 Thread James Lowe
On 02/12/2020 11:27, Michael Käppler wrote: On 01/12/2020 19:10, Jonas Hahnfeld wrote: FYI: 'make check' is running in pipelines for merge requests since this morning 🙂 So ... what does everyone think of this 'new' process? Apart from 'just now', I deliberately avoided checking/testing any n

Re: Advancing to Patch::review

2020-12-03 Thread Jonas Hahnfeld
Am Donnerstag, dem 03.12.2020 um 12:33 + schrieb James: > On 03/12/2020 11:46, Michael Käppler wrote: > > What do you mean with "full reg test suite"? Additional examples that > > are not in the normal reg test suite? > > Well in the 'olden days' we'd have a set of tests on the website - here

Re: Advancing to Patch::review

2020-12-03 Thread James
On 03/12/2020 11:50, Michael Käppler wrote: "IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors out') would have failed 'make test' in the old system, already." The 'old system' was me doing the tests manuall

Re: Advancing to Patch::review

2020-12-03 Thread James
On 03/12/2020 11:50, Michael Käppler wrote: "IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors out') would have failed 'make test' in the old system, already." The 'old system' was me doing the tests manuall

Re: Advancing to Patch::review

2020-12-03 Thread James
On 03/12/2020 11:46, Michael Käppler wrote: What do you mean with "full reg test suite"? Additional examples that are not in the normal reg test suite? Well in the 'olden days' we'd have a set of tests on the website - here is an old URL that no longer works (http://lilypond.org/test/v2.13.

Re: Advancing to Patch::review

2020-12-03 Thread Michael Käppler
Am 03.12.2020 um 12:46 schrieb Michael Käppler: [snip] No, that step remains manually, if I'm not mistaken. IIUC, a patch that fails 'make check' ('fails' in the sense of 'errors out') would have failed 'make test' already. As I understood the (old

Re: Advancing to Patch::review

2020-12-03 Thread Michael Käppler
problem. James, what is your opinion on that? Would you still be willing to do this job? Testing Patches was always orthogonal to managing the countdown (which was the original point of the 'Patch Meister' role). I only fell into the testing patches because at the time we had limite

Re: Advancing to Patch::review

2020-12-03 Thread James
nion on that? Would you still be willing to do this job? Testing Patches was always orthogonal to managing the countdown (which was the original point of the 'Patch Meister' role). I only fell into the testing patches because at the time we had limited resources (hardware was not

Re: Advancing to Patch::review

2020-12-02 Thread Michael Käppler
Am 02.12.2020 um 18:16 schrieb Jonas Hahnfeld: [snip] Circling back to my original proposal: My gut feeling is that this should be somebody else than the MR author Do I interpret your actions that you disagree with this? To elaborate a bit, this tries to keep the pleasant effect that somebody

Re: Advancing to Patch::review

2020-12-02 Thread Jonas Hahnfeld
pipelines for merge requests since this > > > > morning 🙂 > > > > > > > > One thing I forgot in that lengthy email two weeks ago was how MRs get > > > > to Patch::review. Traditionally James posted "Passes make check" and > > > >

Re: Advancing to Patch::review

2020-12-02 Thread Michael Käppler
MRs get to Patch::review. Traditionally James posted "Passes make check" and updated the labels accordingly. As 'make check' is now happening automatically, I think it makes sense to distribute this job: Basically once the pipeline is green and 'make check' produced *so

Re: Advancing to Patch::review

2020-12-02 Thread Michael Käppler
Am 02.12.2020 um 07:36 schrieb James Lowe: On 01/12/2020 19:10, Jonas Hahnfeld wrote: FYI: 'make check' is running in pipelines for merge requests since this morning 🙂 One thing I forgot in that lengthy email two weeks ago was how MRs get to Patch::review. Traditionally James post

Re: Advancing to Patch::review

2020-12-01 Thread James Lowe
On 01/12/2020 19:10, Jonas Hahnfeld wrote: FYI: 'make check' is running in pipelines for merge requests since this morning 🙂 One thing I forgot in that lengthy email two weeks ago was how MRs get to Patch::review. Traditionally James posted "Passes make check" an

Advancing to Patch::review

2020-12-01 Thread Jonas Hahnfeld
FYI: 'make check' is running in pipelines for merge requests since this morning 🙂 One thing I forgot in that lengthy email two weeks ago was how MRs get to Patch::review. Traditionally James posted "Passes make check" and updated the labels accordingly. As 'mak

Re: Handling problems with patches after the patch is pushed

2020-05-17 Thread Carl Sorensen
On Sun, May 17, 2020 at 3:10 PM Trevor wrote: > > Carl Sorensen wrote 17/05/2020 18:32:27 >> It seems to me that there are at least two possibilities for how this >> should be handled. >> >> 1) Once an issue is accepted and pushed, if there are problems >> resulting from the issue, a new issue sh

Re: Handling problems with patches after the patch is pushed

2020-05-17 Thread Trevor
ue is accepted and pushed, if there are problems resulting from the issue, a new issue should be created. This lets the original issue stand as fixed. 2) Once an issue is accepted and pushed, if there are problems resulting from the issue, the patch should be reverted, the issue should be reopened, an

Re: Handling problems with patches after the patch is pushed

2020-05-17 Thread Jonas Hahnfeld via Discussions on LilyPond development
have been pushed. > > > > Consider issue 5890: > > https://gitlab.com/lilypond/lilypond/-/issues/5890 > > > > > > The issue was fixed and a solution was pushed. > > > > Then, Dan recognized that there was another warning that either showed > > u

Re: Handling problems with patches after the patch is pushed

2020-05-17 Thread James Lowe
On 17/05/2020 18:43, David Kastrup wrote: New issue + crossreference would be my suggestion. and mine. James

Re: Handling problems with patches after the patch is pushed

2020-05-17 Thread David Kastrup
The issue was fixed and a solution was pushed. > > Then, Dan recognized that there was another warning that either showed > up in the patch or was not fixed by the patch. So he posted an > excellent comment pointing out the problem. > > So now, we have a situation where there is

Handling problems with patches after the patch is pushed

2020-05-17 Thread Carl Sorensen
that there was another warning that either showed up in the patch or was not fixed by the patch. So he posted an excellent comment pointing out the problem. So now, we have a situation where there is a closed issue with status fixed, and a request for a change simultaneously. I don't k

RE: Another patch

2020-05-10 Thread lilypond
Dan, As you already did see, I did not a simple cast, but instead my solution is raising an error in those cases where a simple cast would change the value tested. However, I will follow your suggestion, and break the patch in parts. I also will pay attention to your particular example, as I

Re: Another patch

2020-05-10 Thread Dan Eble
On May 10, 2020, at 08:11, lilyp...@de-wolff.org wrote: > > I did replace all implicit casts to an int by a inline function, checking if > the value is valid, and then casting to int. > > Together with my previous patch now all but one compiler warnings are > solved. Jaap

Re: Remove last compiler warning patch

2020-05-10 Thread David Kastrup
writes: > > > Patch to remove warning in flex generated code. > > > > This patch together with the previous 2 patches I have sent, remove all > compiler warnings while compiling lilypond on my machine (Debian 64 buster). Just so that you don't feel like you a

Remove last compiler warning patch

2020-05-10 Thread lilypond
Patch to remove warning in flex generated code. This patch together with the previous 2 patches I have sent, remove all compiler warnings while compiling lilypond on my machine (Debian 64 buster). Jaap de Wolff >From 9cb9dbf8d91194c13a6331ab482b6bc5b2e3895c Mon Sep 17 00:00:00 2

Another patch

2020-05-10 Thread lilypond
I did replace all implicit casts to an int by a inline function, checking if the value is valid, and then casting to int. Together with my previous patch now all but one compiler warnings are solved. Remark: I do not have git rights on the lilypond tree, so someone else should merge those

See attached patch

2020-05-10 Thread lilypond
Hi, I solved some compiler warnings. See attached patch Jaap de Wolff 0001-Solve-several-compiler-warnings.patch Description: Binary data

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Kevin Barry
Hi Jonas, > Done (hopefully). Thank you very much; it looks like it worked! Kevin

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Jonas Hahnfeld
Am Dienstag, den 28.04.2020, 18:31 +0100 schrieb Kevin Barry: > Hi James, > > > We do have a process, see: > > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers > > > > I have followed this as best I can, but it seems I need to have write > acce

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread Kevin Barry
Hi James, > We do have a process, see: > http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#summary-for-experienced-developers I have followed this as best I can, but it seems I need to have write access to the issue tracker before I can send patches. If that is the case then can s

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-28 Thread James
Hello Kevin, On 27/04/2020 18:07, Kevin Barry wrote: Hi James, Thank you for responding. On Mon, Apr 27, 2020 at 11:09:50AM +0100, James wrote: Is this patch read for full testing or is it work-in-progress you just want someone to comment on it? It's not work in progress no - unless so

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-27 Thread Kevin Barry
Hi James, Thank you for responding. On Mon, Apr 27, 2020 at 11:09:50AM +0100, James wrote: > Is this patch read for full testing or is it work-in-progress you just want > someone to comment on it? It's not work in progress no - unless someone has objections or observations, but I do

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-27 Thread James
Kevin, Is this patch read for full testing or is it work-in-progress you just want someone to comment on it? James On 25/04/2020 08:42, Kevin Barry wrote: Patch is attached to this mail as a file if that is more convenient. Kevin

Re: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-25 Thread Kevin Barry
Patch is attached to this mail as a file if that is more convenient. Kevin >From 1c5715ad52139aab936ee7dffb2cdef3d123b369 Mon Sep 17 00:00:00 2001 From: Kevin Barry Date: Fri, 24 Apr 2020 19:26:26 +0100 Subject: [PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

[PATCH v1] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
Empty skylines forces a fallback to the grob's bounding box, which restores the behaviour from before the patch to improve skyline approximations (issue 2148). This does not fix the issue that there is no routine for determining skylines for utf-8-strings when the backend is svg, but it does at le

Re: [PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
e done this wrong. A revised patch will follow with an added regression test. Kevin

Re: [PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
On Fri, Apr 24, 2020 at 09:18:10PM +0200, Han-Wen Nienhuys wrote: > Can you add a regression test that shows the problem? Yes. I'll go read the docs to see how to do that and do one up (but feel free to point me in the right direction...) Kevin

Re: [PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Han-Wen Nienhuys
On Fri, Apr 24, 2020 at 9:21 PM Kevin Barry wrote: > > On Fri, Apr 24, 2020 at 09:18:10PM +0200, Han-Wen Nienhuys wrote: > > Can you add a regression test that shows the problem? > > Yes. I'll go read the docs to see how to do that and do one up (but feel > free to point me in the right direction

Re: [PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Han-Wen Nienhuys
) to collide with other grobs. > > While looping over the stencils, check for utf-8-string and if found, > clear the skylines and break out of the loop. Empty skylines forces a > fallback to the grob's bounding box, which restores the behaviour from > before the patch to improve sky

[PATCH] Issue 3778: Use bounding box as skylines for markup in svg backend

2020-04-24 Thread Kevin Barry
Empty skylines forces a fallback to the grob's bounding box, which restores the behaviour from before the patch to improve skyline approximations (issue 2148). This does not fix the issue that there is no routine for determining skylines for utf-8-strings when the backend is svg, but it does at le

Re: Patch on dynamics and \RemoveEmptyStaves

2020-03-26 Thread Valentin Villenave
On 3/26/20, James Lowe wrote: > Yes David K is correct. If someone could take a look at the scripts in > git-cl and get them working smoothly again (there are other errors > reported on this list about git-cl) it would be a boon to the dev team. By the way (this is not directly related but may or

Re: Patch on dynamics and \RemoveEmptyStaves

2020-03-26 Thread James Lowe
ith Update and Create permissions in addition to Read. Welcome aboard! Trevor Thank you! Here is a question about updating patches using git-cl: whenever I try to upload the patch, I get this error. IOError: ('http error', 401, 'Unauthorized', ) Traceback attached. What am I

Re: Patch on dynamics and \RemoveEmptyStaves

2020-03-26 Thread David Kastrup
dded as a Developer, with Update and Create permissions in addition >> to Read. >> >> Welcome aboard! >> >> Trevor > > Thank you! > > Here is a question about updating patches using git-cl: whenever I try > to upload the patch, I get this error. > > >

Re: Patch on dynamics and \RemoveEmptyStaves

2020-03-26 Thread Jean Abou Samra
d! Trevor Thank you! Here is a question about updating patches using git-cl: whenever I try to upload the patch, I get this error. IOError: ('http error', 401, 'Unauthorized', instance at 0x7f8715613370>) Traceback attached. What am I doing wrong? Best, Jean Abo

Re[2]: Patch on dynamics and \RemoveEmptyStaves

2020-03-24 Thread Trevor
Hi "Jean Abou Samra", you wrote My SourceForge username is jean-abou-samra. Could someone please give me write access to the issue tracker? Added as a Developer, with Update and Create permissions in addition to Read. Welcome aboard! Trevor

Re: Patch on dynamics and \RemoveEmptyStaves

2020-03-24 Thread Jean Abou Samra
Hi Valentin, How strange it sounds to write you in English. Le 24/03/2020 à 19:24, Valentin Villenave a écrit :Hi Jean, some step-by-step instructions are available here: http://lilypond.org/doc/latest/Documentation/contributor/quick-start.html Thanks for the pointer. My SourceForge username

Re: Patch on dynamics and \RemoveEmptyStaves

2020-03-24 Thread Valentin Villenave
On 3/24/20, Jean Abou Samra wrote: > I have the attached very simple patch for LilyPond. Could anyone please > guide me through the process for patch submission? Hi Jean, some step-by-step instructions are available here: http://lilypond.org/doc/latest/Documentation/contributor/quick-star

  1   2   3   4   5   6   7   8   9   10   >