Re: Map voices to channels in MIDI output

2011-03-20 Thread Jan Nieuwenhuizen
Keith OHara schreef op vr 18-03-2011 om 21:30 [-0700]: > The code seems to work, but requires great effort to understand. Good, yes alas. > I was suggesting that, having decided what you want in the MIDI, you > might simplify the design. That would be nice and I'm sure that it can be simplified

Re: Map voices to channels in MIDI output

2011-03-18 Thread Keith OHara
On Wed, 16 Mar 2011 06:39:26 -0700, Jan Nieuwenhuizen wrote: Keith OHara schreef op di 15-03-2011 om 23:09 [-0700]: I tried to summarize what the relevant classes do, and indicated the desired extensions in [[ ]] below : Not really: * midiChannelMapping = #'instrument (default) midiIns

Re: Map voices to channels in MIDI output

2011-03-16 Thread Jan Nieuwenhuizen
Keith OHara schreef op di 15-03-2011 om 23:09 [-0700]: > On Tue, 15 Mar 2011 13:53:41 -0700, Jan Nieuwenhuizen > wrote: > It is, at least, the same kludge others (classicalmidiconnection.com) > use when they have more than 16 simultaneous lines of music. To have > some sympathy for the brokennes

Re: Map voices to channels in MIDI output

2011-03-15 Thread Keith OHara
On Tue, 15 Mar 2011 13:53:41 -0700, Jan Nieuwenhuizen wrote: To create a new track for each voice as we do now, still seems a bit like a kludge to fix MIDI's brokenness. It is, at least, the same kludge others (classicalmidiconnection.com) use when they have more than 16 simultaneous lines of

Re: Map voices to channels in MIDI output

2011-03-15 Thread Jan Nieuwenhuizen
Keith OHara schreef op di 15-03-2011 om 13:24 [-0700]: > On Tue, 15 Mar 2011 01:50:32 -0700, Jan Nieuwenhuizen > wrote:> > We have input\regression\midi-volume-equaliser.ly; the equalizer is > still effective, but the values will probably need re-balancing if you > implemnt dynamics differently.

Re: Map voices to channels in MIDI output

2011-03-15 Thread Keith OHara
On Tue, 15 Mar 2011 01:50:32 -0700, Jan Nieuwenhuizen wrote:> 1) re-balancing the instruments Do you have a test file for that? We have input\regression\midi-volume-equaliser.ly; the equalizer is still effective, but the values will probably need re-balancing if you implemnt dynamics differe

Re: Map voices to channels in MIDI output

2011-03-15 Thread Jan Nieuwenhuizen
Keith OHara schreef op ma 14-03-2011 om 13:50 [-0700]: > On Mon, 14 Mar 2011 02:14:14 -0700, Jan Nieuwenhuizen wrote: > Midi tracks (from a Staff with midiInstrument) sometimes contain a > program change event, sometimes not, depending on the path taken > through Staff_performer::acknowledge_audi

Re: Map voices to channels in MIDI output

2011-03-15 Thread Jan Nieuwenhuizen
> 1) re-balancing the instruments (because the new implementation messed up the > equalizer) Do you have a test file for that? As far as I can see, the velocity still comes through the equalizer. > 2) implementing (de)crescendi on held notes (which sometimes works > accidentally in 2.12, due

Re: Map voices to channels in MIDI output

2011-03-14 Thread Keith OHara
On Mon, 14 Mar 2011 14:19:46 -0700, Jan Nieuwenhuizen wrote: Keith OHara schreef op ma 14-03-2011 om 13:50 [-0700]: Dynamics are newly implemented as note-on-velocity, but the old implementation as channel-volume is still there, What would the correct fix be? Well, MIDI note-on-velocity i

Re: Map voices to channels in MIDI output

2011-03-14 Thread Jan Nieuwenhuizen
Jan Nieuwenhuizen schreef op ma 14-03-2011 om 22:19 [+0100]: > Keith OHara schreef op ma 14-03-2011 om 13:50 [-0700]: > > (Unfortunately for me, the player I formerly used, NotationPlayer, > > gets confused by Tracks with no program change containing notes > > directed to a Channel that had an ear

Re: Map voices to channels in MIDI output

2011-03-14 Thread Jan Nieuwenhuizen
Keith OHara schreef op ma 14-03-2011 om 13:50 [-0700]: > Dynamics are newly implemented as note-on-velocity, > but the old implementation as channel-volume is still there, causing > instruments of the same type to partially influence each others' > loudness. What would the correct fix be? What t

Re: Map voices to channels in MIDI output

2011-03-14 Thread Keith OHara
On Mon, 14 Mar 2011 02:14:14 -0700, Jan Nieuwenhuizen wrote: Keith OHara schreef op zo 13-03-2011 om 17:05 [-0700]: Sensible, but this leaves a partially-finished major change in the branch that Graham just tagged as 2.14 release candidate. What's partial about the change? Nothing cr

Re: Map voices to channels in MIDI output

2011-03-14 Thread Jan Nieuwenhuizen
Reinhold Kainhofer schreef op ma 14-03-2011 om 14:42 [+0100]: > Yes, but my main concern is not to use midi2ly on files generated by lilypond > in the first place. Fair enough. My concern is mainly the MIDI->ly traject, in combination with adding a combined test suite. Until now, MIDI has been

Re: Map voices to channels in MIDI output

2011-03-14 Thread Jan Nieuwenhuizen
Jan Nieuwenhuizen schreef op ma 14-03-2011 om 12:45 [+0100]: Reinhold, To follow-up on my request for actual failing .ly's -- I've just added an initial lyrics test \score { << \relative c'' { \key g \major \time 6/8 d4 b8 c4 a8 | d4 b8 g4 } \addlyrics { Gir

Re: Map voices to channels in MIDI output

2011-03-14 Thread Jan Nieuwenhuizen
Reinhold Kainhofer schreef op ma 14-03-2011 om 10:49 [+0100]: Hi Reinold, > There are some problems with the new method: > > -) All staves with \partcombine now use four (!) different midi tracks: > shared, > one, two and solo (because partcombine internally uses four voices) Yes, is that a p

Re: Map voices to channels in MIDI output

2011-03-14 Thread Reinhold Kainhofer
Am Montag, 14. März 2011, um 10:21:53 schrieb Jan Nieuwenhuizen: > Keith OHara schreef op zo 13-03-2011 om 21:55 [-0700]: > > I don't know of any yet, and I will not be looking for any. > > The changes within the past week were significant enough that I expect > > complaints from people who use MID

Re: Map voices to channels in MIDI output

2011-03-14 Thread Jan Nieuwenhuizen
Keith OHara schreef op zo 13-03-2011 om 00:19 [-0800]: > The MIDI port assignments are still being written to the output file; > I don't know if that is intended. Fix pushed. Jan. -- Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar® http://Ava

Re: Map voices to channels in MIDI output

2011-03-14 Thread Jan Nieuwenhuizen
Keith OHara schreef op zo 13-03-2011 om 21:55 [-0700]: > I don't know of any yet, and I will not be looking for any. > The changes within the past week were significant enough that I expect > complaints from people who use MIDI. That would be nice! Esp. if they send patches. MIDI support in Lil

Re: Map voices to channels in MIDI output

2011-03-14 Thread Jan Nieuwenhuizen
Keith OHara schreef op zo 13-03-2011 om 17:05 [-0700]: > Sensible, but this leaves a partially-finished major change in the > branch that Graham just tagged as 2.14 release candidate. What's partial about the change? Also, the old behaviour should be mostly reproducible by setting midiChannelMap

Re: Map voices to channels in MIDI output

2011-03-13 Thread Keith OHara
On Sun, 13 Mar 2011 17:10:48 -0700, Graham Percival wrote: If there is a critical regression, then go ahead and add an issue I don't know of any yet, and I will not be looking for any. The changes within the past week were significant enough that I expect complaints from people who use MIDI

Re: Map voices to channels in MIDI output

2011-03-13 Thread Graham Percival
On Sun, Mar 13, 2011 at 05:05:51PM -0700, Keith OHara wrote: > On Sun, 13 Mar 2011 03:20:51 -0700, Jan Nieuwenhuizen wrote: > > > >I'm not removing anything just yet until we find a good way to > >test these things or get some more info. > > > Sensible, but this leaves a partially-finished major c

Re: Map voices to channels in MIDI output

2011-03-13 Thread Keith OHara
On Sun, 13 Mar 2011 03:20:51 -0700, Jan Nieuwenhuizen wrote: I'm not removing anything just yet until we find a good way to test these things or get some more info. Sensible, but this leaves a partially-finished major change in the branch that Graham just tagged as 2.14 release candidate. D

Re: Map voices to channels in MIDI output

2011-03-13 Thread Jan Nieuwenhuizen
Colin Campbell schreef op zo 13-03-2011 om 10:02 [-0600]: > I would *really* love the ability to patch my children! Patching parents first is easier and more effective. Jan -- Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcad

Re: Map voices to channels in MIDI output

2011-03-13 Thread Colin Campbell
On 11-03-13 05:21 AM, Graham Percival wrote: On Sun, Mar 13, 2011 at 10:00:24AM +, James Lowe wrote: -Original Message- From: Marc Hohl I might as well be talking to my computer. Oh man, how I wait for that. The possibility to shout at your operating System I find that sticking my

Re: Map voices to channels in MIDI output

2011-03-13 Thread Marc Hohl
Am 13.03.2011 11:00, schrieb James Lowe: -Original Message- From: Marc Hohl Date: Sun, 13 Mar 2011 09:53:42 +0100 To: David Kastrup Cc: Lilypond Dev Subject: Re: Map voices to channels in MIDI output I might as well be talking to my computer. Oh man, how I wait for that. The

Re: Map voices to channels in MIDI output

2011-03-13 Thread David Kastrup
Graham Percival writes: > On Sun, Mar 13, 2011 at 10:00:24AM +, James Lowe wrote: >> >> -Original Message- >> From: Marc Hohl >> >>I might as well be talking to my computer. >> > >> >Oh man, how I wait for that. The possibility to shout at your operating >> >System >> >> I find tha

Re: Map voices to channels in MIDI output

2011-03-13 Thread Graham Percival
On Sun, Mar 13, 2011 at 10:00:24AM +, James Lowe wrote: > > -Original Message- > From: Marc Hohl > >>I might as well be talking to my computer. > > > >Oh man, how I wait for that. The possibility to shout at your operating > >System > > I find that sticking my two fingers up at the s

Re: Map voices to channels in MIDI output

2011-03-13 Thread David Kastrup
Jan Nieuwenhuizen writes: > To my surprise, I found out that this note on velocity was not being > used. We'll have to see what volume changes should go where exactly. > I note that some suggestions have been made, and I look forward to any > patches to back them up. Considering that the mechan

Re: Map voices to channels in MIDI output

2011-03-13 Thread Jan Nieuwenhuizen
Keith OHara schreef op zo 13-03-2011 om 00:19 [-0800]: > I see you encode dynamics as MIDI note-on-velocity. (This is much > better than the old way of encoding dynamics as MIDI volume!) The old > encoding of dynamics in MIDI volume is still being output, though. I > assume you want to remove t

Re: Map voices to channels in MIDI output

2011-03-13 Thread James Lowe
-Original Message- From: Marc Hohl Date: Sun, 13 Mar 2011 09:53:42 +0100 To: David Kastrup Cc: Lilypond Dev Subject: Re: Map voices to channels in MIDI output >>I might as well be talking to my computer. > >Oh man, how I wait for that. The possibility to shout at yo

Re: Map voices to channels in MIDI output

2011-03-13 Thread Marc Hohl
Am 13.03.2011 09:43, schrieb David Kastrup: Keith OHara writes: Keith OHara oco.net> writes: I see you encode dynamics as MIDI note-on-velocity. (This is much better than the old way of encoding dynamics as MIDI volume!) Except that using MIDI volume for dynamics lets LilyPond perform (d

Re: Map voices to channels in MIDI output

2011-03-13 Thread David Kastrup
Keith OHara writes: > Keith OHara oco.net> writes: > >> I see you encode dynamics as MIDI note-on-velocity. (This is much >> better than >> the old way of encoding dynamics as MIDI volume!) > > Except that using MIDI volume for dynamics lets LilyPond perform > (de)crescendos on a held note.

Re: Map voices to channels in MIDI output

2011-03-13 Thread Keith OHara
Keith OHara oco.net> writes: > > I see you encode dynamics as MIDI note-on-velocity. (This is much better > than > the old way of encoding dynamics as MIDI volume!) Except that using MIDI volume for dynamics lets LilyPond perform (de)crescendos on a held note. Somebody might complain if

Re: Map voices to channels in MIDI output

2011-03-13 Thread David Kastrup
"Keith OHara" writes: > On Sat, 12 Mar 2011 12:35:16 -0800, Jan Nieuwenhuizen wrote: > >> Ok, pushed. Something much like the previous output can still >> be selected, just like the voice->channel mapping for reproducing >> voice and staff mapping with the current midi2ly. >> > > It generally w

Re: Map voices to channels in MIDI output

2011-03-13 Thread Keith OHara
On Sat, 12 Mar 2011 12:35:16 -0800, Jan Nieuwenhuizen wrote: Ok, pushed. Something much like the previous output can still be selected, just like the voice->channel mapping for reproducing voice and staff mapping with the current midi2ly. It generally works. The MIDI port assignments are s

Re: Map voices to channels in MIDI output

2011-03-12 Thread Jan Nieuwenhuizen
Keith OHara schreef op za 12-03-2011 om 10:00 [-0800]: > I see (with hexedit) the new midi events for instrument changes on all > voices, and port settings. > > I have only one sound card in my system. All players I tried > (Timidity(linux) WindowsMediaPlayer NotationPlayer and Podium) route > a

Re: Map voices to channels in MIDI output

2011-03-12 Thread Keith OHara
On Sat, 12 Mar 2011 05:48:08 -0800, Jan Nieuwenhuizen wrote: Ugh. I have just pushed fixes for setting the instrument and assigning each track to a new port. It would be nice if you could test it, but afaics it does not work with timidity, alas. I see (with hexedit) the new midi events for

Re: Map voices to channels in MIDI output

2011-03-12 Thread Jan Nieuwenhuizen
Keith OHara schreef op vr 11-03-2011 om 11:15 [-0800]: > On Fri, 11 Mar 2011 10:12:59 -0800, Jan Nieuwenhuizen wrote: > I know nothing about this, but some other people with similar goals are > http://www.classicalmidiconnection.com/2port.htm Right. Using many ports, (if fact, one port per trac

Re: Map voices to channels in MIDI output

2011-03-12 Thread Jan Nieuwenhuizen
Keith OHara schreef op vr 11-03-2011 om 09:16 [-0800]: > On Fri, 11 Mar 2011 01:32:39 -0800, Jan Nieuwenhuizen wrote: > The structure that *can* contain several channels is a Port, separate > Ports corresponding to separate cables in the hardware. One can > optionally specify a different Port fo

Re: Map voices to channels in MIDI output

2011-03-11 Thread Keith OHara
On Fri, 11 Mar 2011 10:12:59 -0800, Jan Nieuwenhuizen wrote: Technical correctness probably has little merit if no player supports it, but it is worth a try. Setting ports should be quite easy and if major players support this, we're safe. I know nothing about this, but some other people wi

Re: Map voices to channels in MIDI output

2011-03-11 Thread Jan Nieuwenhuizen
Keith OHara schreef op vr 11-03-2011 om 09:16 [-0800]: > On Fri, 11 Mar 2011 01:32:39 -0800, Jan Nieuwenhuizen wrote: > The structure that *can* contain several channels is a Port, separate > Ports corresponding to separate cables in the hardware. One can > optionally specify a different Port fo

Re: Map voices to channels in MIDI output

2011-03-11 Thread Keith OHara
On Fri, 11 Mar 2011 01:32:39 -0800, Jan Nieuwenhuizen wrote: Neil Puttock schreef op do 10-03-2011 om 21:41 [+]: both voices will still be allocated the same channel Why would that be a problem? They're in different tracks. Are you saying that the instrument of channel 0 of track 1

Re: Map voices to channels in MIDI output

2011-03-11 Thread Jan Nieuwenhuizen
Keith OHara schreef op do 10-03-2011 om 18:15 [-0800]: > > It works for me, [...] > > Oh! Thanks for checking. > I'll post a report on the bug list with the (very tiny) midi files and see if > it's just my midi players (timidity and WMP) Thanks. Note that I now found that if there are two vo

Re: Map voices to channels in MIDI output

2011-03-11 Thread Jan Nieuwenhuizen
Neil Puttock schreef op do 10-03-2011 om 21:41 [+]: > On 10 March 2011 21:04, Jan Nieuwenhuizen wrote: > Doesn't that still fall foul of the lack of synchronization between > Staff_performer instances though? For example, if I have two staves > with one voice each, both voices will still be

Re: Map voices to channels in MIDI output

2011-03-10 Thread Keith OHara
On Thu, 10 Mar 2011 11:57:48 -0800, Jan Nieuwenhuizen wrote:> Commits e5380f2 and 8dc343b break the MIDI output from all the examples in the documentation that use midiInstrument, and the regtest ‘midi-volume-equaliser.ly’. It works for me, [...] Oh! Thanks for checking. Maybe your midi p

Re: Map voices to channels in MIDI output

2011-03-10 Thread Neil Puttock
On 10 March 2011 21:04, Jan Nieuwenhuizen wrote: > I see, whenever a new channel is opened (for a new voice) > by the staff-performer, it should also set the instrument > there.  Actually, that's nicer than doing it in > Staff_performer::process_music () Doesn't that still fall foul of the lack

Re: Map voices to channels in MIDI output

2011-03-10 Thread Jan Nieuwenhuizen
Neil Puttock schreef op do 10-03-2011 om 20:11 [+]: > On 10 March 2011 19:57, Jan Nieuwenhuizen wrote: > All staves default to channel 0 for midi instruments (since channel_ > is never set). I see, whenever a new channel is opened (for a new voice) by the staff-performer, it should also set

Re: Map voices to channels in MIDI output

2011-03-10 Thread Neil Puttock
On 10 March 2011 19:57, Jan Nieuwenhuizen wrote: > It works for me, and I think Neil also could not confirm this, so] I'm afraid I can now (I was puzzled by Keith's report initially since I'd only tested midiInstrument settings on a single stave). All staves default to channel 0 for midi instru

Re: Map voices to channels in MIDI output

2011-03-10 Thread Jan Nieuwenhuizen
Keith OHara schreef op do 10-03-2011 om 10:40 [-0800]: > Commits e5380f2 and 8dc343b break the MIDI output from all the > examples in the documentation that use midiInstrument, and the regtest > ‘midi-volume-equaliser.ly’. The midi output is much less useful for > proofreading, because all the

Re: Map voices to channels in MIDI output

2011-03-10 Thread Keith OHara
Jan, Commits e5380f2 and 8dc343b break the MIDI output from all the examples in the documentation that use midiInstrument, and the regtest ‘midi-volume-equaliser.ly’. The midi output is much less useful for proofreading, because all the voices sound the same. The problem is that the all sett

Re: Map voices to channels in MIDI output

2011-03-09 Thread Keith OHara
Neil Puttock gmail.com> writes: > On 9 March 2011 00:09, Keith OHara oco.net> wrote: > > > In 2.13.53, I cannot find a way to make midiInstrument have effect. > > Can you post a snippet showing the problem? Let's use the manual example I linked earlier, but give names to the Voice contexts.

Re: Map voices to channels in MIDI output

2011-03-09 Thread Neil Puttock
On 9 March 2011 00:09, Keith OHara wrote: > In 2.13.53, I cannot find a way to make midiInstrument have effect. I can't confirm this; apart from instruments which my MIDI output doesn't seem to support, every instrument I've tried works fine. Can you post a snippet showing the problem? Cheers,

Map voices to channels in MIDI output

2011-03-08 Thread Keith OHara
Is there more to this change, started in commit e5380f2, on the way? In 2.13.53, I cannot find a way to make midiInstrument have effect. There is also the problem reported on -bugs http://lists.gnu.org/archive/html/bug-lilypond/2011-03/msg00152.html Maybe the previous workaround to have one ch