Re: Issue 659: alternate segno symbol (issue181144)

Graham Percival schrieb: On Tue, Mar 30, 2010 at 09:50:49AM +0200, Marc Hohl wrote: Marc Hohl schrieb: [...] Is the segno patch ready to be applied, or did I miss something? I don't want to annoy you, but if there is some more work I should do to improve the patch, let me know .

Re: Issue 659: alternate segno symbol (issue181144)

On Tue, Mar 30, 2010 at 09:50:49AM +0200, Marc Hohl wrote: > Marc Hohl schrieb: >> [...] >> Is the segno patch ready to be applied, or did I miss something? > I don't want to annoy you, but if there is some more work I should > do to improve the patch, let me know ... on the other hand, > if it is

Re: Issue 659: alternate segno symbol (issue181144)

Marc Hohl schrieb: [...] Is the segno patch ready to be applied, or did I miss something? I don't want to annoy you, but if there is some more work I should do to improve the patch, let me know ... on the other hand, if it is ready now, don't hesitate to push it ;-) Marc ___

Re: Issue 659: alternate segno symbol (issue181144)

Graham Percival schrieb: On Tue, Mar 02, 2010 at 12:29:09PM +0100, Marc Hohl wrote: Graham Percival schrieb: In the feta font (I think that's included/font-table.ly), and in NR 1.2.5 rehearsal marks, in the example wi ththe other segno signs. I didn't touch included/font-tabl

Re: Issue 659: alternate segno symbol (issue181144)

On Tue, Mar 02, 2010 at 12:29:09PM +0100, Marc Hohl wrote: > Graham Percival schrieb: >> In the feta font (I think that's included/font-table.ly), and in NR >> 1.2.5 rehearsal marks, in the example wi ththe other segno signs. >> > I didn't touch included/font-table.ly, because the varsegno is pa

Re: Issue 659: alternate segno symbol (issue181144)

Graham Percival schrieb: On Mon, Mar 1, 2010 at 9:30 AM, Marc Hohl wrote: Should the new segno sign be included in the documentation? If yes, where? In the feta font (I think that's included/font-table.ly), and in NR 1.2.5 rehearsal marks, in the example wi ththe other segno signs.

Re: Issue 659: alternate segno symbol (issue181144)

On Mon, Mar 1, 2010 at 9:30 AM, Marc Hohl wrote: > Should the new segno sign be included in the documentation? > If yes, where? In the feta font (I think that's included/font-table.ly), and in NR 1.2.5 rehearsal marks, in the example wi ththe other segno signs. (if I understand the matter at han

Re: Issue 659: alternate segno symbol (issue181144)

Marc Hohl schrieb: n.putt...@gmail.com schrieb: Hi Marc, LGTM, though I still think this is a lot of effort for a very obscure and little-used symbol. [...] Should the new segno sign be included in the documentation? If yes, where? Apart from that, are there any further objections to this pa

Re: Issue 659: alternate segno symbol (issue181144)

n.putt...@gmail.com schrieb: Hi Marc, LGTM, though I still think this is a lot of effort for a very obscure and little-used symbol. Perhaps it is little-used because it was missing in lilypond? ;-) Or do you think this is just too much and we should forget about it all? (I don't hope so, becau

Re: Issue 659: alternate segno symbol (issue181144)

Hi Marc, LGTM, though I still think this is a lot of effort for a very obscure and little-used symbol. Cheers, Neil http://codereview.appspot.com/181144/diff/5028/4010 File input/regression/bar-line-segno.ly (right): http://codereview.appspot.com/181144/diff/5028/4010#newcode2 input/regressio

Re: Issue 659: alternate segno symbol (issue181144)

carl.d.soren...@gmail.com schrieb: Looks good to me, with the exception of the hardcoded value stuff. Thanks, Carl http://codereview.appspot.com/181144/diff/4008/5018 File lily/bar-line.cc (right): http://codereview.appspot.com/181144/diff/4008/5018#newcode242 lily/bar-line.cc:242: m.add_at

Re: Enhancements on Issue 659: alternate segno symbol (issue181144)

Carl Sorensen schrieb: On 2/15/10 12:33 PM, "Marc Hohl" wrote: Hello all, I have uploaded some enhancements due to Alexander Kobel's proposals. The first attempt to upload broke on my console with some error messages, so I did it again - now I see that I uploaded two identical versions. A

Re: Enhancements on Issue 659: alternate segno symbol (issue181144)

On 2/15/10 12:33 PM, "Marc Hohl" wrote: > Hello all, > > I have uploaded some enhancements due to Alexander Kobel's proposals. > The first attempt to upload broke on my console with some error messages, > so I did it again - now I see that I uploaded two identical versions. > And furthermore,

Re: Issue 659: alternate segno symbol (issue181144)

Looks good to me, with the exception of the hardcoded value stuff. Thanks, Carl http://codereview.appspot.com/181144/diff/4008/5018 File lily/bar-line.cc (right): http://codereview.appspot.com/181144/diff/4008/5018#newcode242 lily/bar-line.cc:242: m.add_at_edge (X_AXIS, RIGHT, thick, 2.5 * s

Enhancements on Issue 659: alternate segno symbol (issue181144)

Hello all, I have uploaded some enhancements due to Alexander Kobel's proposals. The first attempt to upload broke on my console with some error messages, so I did it again - now I see that I uploaded two identical versions. And furthermore, the changes to scm/tablature.scm which Carl had pushed

Re: Issue 659: alternate segno symbol (issue181144)

n.putt...@gmail.com schrieb: http://codereview.appspot.com/181144/diff/1009/29 File lily/span-bar.cc (right): http://codereview.appspot.com/181144/diff/1009/29#newcode204 lily/span-bar.cc:204: else if (type == "S") You also need to pick up "S."/".S" here, otherwise you'll get a nasty surprise b

Re: Issue 659: alternate segno symbol (issue181144)

On 2010/01/11 01:05:07, Reinhold wrote: AFAICS, Bar_line::compound_barline resets both "S." and ".S" to "S", so this should be fine. Or am I missing something? If "S." or ".S" is (incorrectly) set in the middle of a line, the glyph calculation won't be reset, resulting in a segno glyph paste

Re: Issue 659: alternate segno symbol (issue181144)

http://www.codereview.appspot.com/181144/diff/1009/29 File lily/span-bar.cc (right): http://www.codereview.appspot.com/181144/diff/1009/29#newcode204 lily/span-bar.cc:204: else if (type == "S") On 2010/01/10 20:50:38, Neil Puttock wrote: You also need to pick up "S."/".S" here, otherwise you'll

Re: Issue 659: alternate segno symbol (issue181144)

http://codereview.appspot.com/181144/diff/1009/29 File lily/span-bar.cc (right): http://codereview.appspot.com/181144/diff/1009/29#newcode204 lily/span-bar.cc:204: else if (type == "S") You also need to pick up "S."/".S" here, otherwise you'll get a nasty surprise between staves ;) else if (typ

Re: Issue 659: alternate segno symbol (issue181144)

>> [Not tested yet the actual changes.] Is your fontforge version >> compiled with --enable-double? > > I use fontforge out of the box from my ubuntu distro. I don't know > how it is built. Since you get warnings even without your changes, you haven't --enable-double. I strongly suggest to get

Re: Issue 659: alternate segno symbol (issue181144)

n.putt...@gmail.com schrieb: http://codereview.appspot.com/181144/diff/1002/1003 File input/regression/bar-line-segno.ly (right): http://codereview.appspot.com/181144/diff/1002/1003#newcode9 input/regression/bar-line-segno.ly:9: \relative \new StaffGroup << \relative c' Ok, done. I copied this

Re: Issue 659: alternate segno symbol (issue181144)

Werner LEMBERG schrieb: -) Compiling the font gives some warnings: Invoking "fontforge -script feta26.pe feta26.pfb"... Copyright (c) 2000-2009 by George Williams. Executable based on sources from 22:35 GMT 22-Jun-2009. Library based on sources from 22:35 GMT 22-Jun-2009. Internal

Re: Issue 659: alternate segno symbol (issue181144)

> -) Compiling the font gives some warnings: > > Invoking "fontforge -script feta26.pe feta26.pfb"... > Copyright (c) 2000-2009 by George Williams. > Executable based on sources from 22:35 GMT 22-Jun-2009. > Library based on sources from 22:35 GMT 22-Jun-2009. > Internal Error in sc

Re: Issue 659: alternate segno symbol (issue181144)

Reinhold Kainhofer schrieb: Am Mittwoch, 6. Januar 2010 16:27:14 schrieb Marc Hohl: After consulting wikipedia for several keyboard layouts, you have convinced me. I changed the § sign to an uppercase S, which should be accessible from any latin keyboard. http://codereview.appspot.com/

Re: Issue 659: alternate segno symbol (issue181144)

Am Mittwoch, 6. Januar 2010 16:27:14 schrieb Marc Hohl: > After consulting wikipedia for several keyboard layouts, you have > convinced me. > I changed the § sign to an uppercase S, which should be accessible from any > latin keyboard. > > > http://codereview.appspot.com/181144 I've now tried out

Re: Issue 659: alternate segno symbol (issue181144)

http://codereview.appspot.com/181144/diff/1002/1003 File input/regression/bar-line-segno.ly (right): http://codereview.appspot.com/181144/diff/1002/1003#newcode9 input/regression/bar-line-segno.ly:9: \relative \new StaffGroup << \relative c' http://codereview.appspot.com/181144/diff/1002/1004 F

Re: Issue 659: alternate segno symbol (issue181144)

reinhold.kainho...@gmail.com schrieb: I haven't tried this out, but some things simply jump out.. http://codereview.appspot.com/181144/diff/1/3 File lily/bar-line.cc (right): http://codereview.appspot.com/181144/diff/1/3#newcode96 lily/bar-line.cc:96: Stencil segno = Font_interface::get_defaul

Issue 659: alternate segno symbol (issue181144)

I haven't tried this out, but some things simply jump out.. http://codereview.appspot.com/181144/diff/1/3 File lily/bar-line.cc (right): http://codereview.appspot.com/181144/diff/1/3#newcode96 lily/bar-line.cc:96: Stencil segno = Font_interface::get_default_font (me)->find_by_name ("scripts.var