Am Mittwoch, 6. Januar 2010 16:27:14 schrieb Marc Hohl:
> After consulting wikipedia for several keyboard layouts, you have
> convinced me.
> I changed the ยง sign to an uppercase S, which should be accessible from any
> latin keyboard.
>
> > http://codereview.appspot.com/181144
I've now tried out the patch. Looks fine, but still some random comments:
-) Are you aware that a \bar "S." does not have any effect, unless it appears
at a line break? you should really add some segno bar lines not appearing at
line breaks to your regtest. E.g.
\new Staff {
c4 \bar "S." c \bar ".S" c \bar "S" c \bar ".S" \break
c4 c c c \bar "S." \break
c4 c c2 \bar "S" \break
s1 }
-) Your setting the width to zero is really a bad idea, since the notes
practically overlap (the ledger lines at least touch the segno bar line).
-) The double bar lines look way too heavy here (that's actually not due to
your patch. All bar lines look too heavy here, also when printed out, the
double bar line just makes it worse...)
-) Compiling the font gives some warnings:
Invoking "fontforge -script feta26.pe feta26.pfb"...
Copyright (c) 2000-2009 by George Williams.
Executable based on sources from 22:35 GMT 22-Jun-2009.
Library based on sources from 22:35 GMT 22-Jun-2009.
Internal Error in scripts.varcoda: couldn't find a needed exit from an
intersection
Internal Error:
Could not find finalm
Internal Error in scripts.varcoda: couldn't find a needed exit from an
intersection
Cheers,
Reinhold
--
------------------------------------------------------------------
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
* Financial & Actuarial Math., Vienna Univ. of Technology, Austria
* http://www.fam.tuwien.ac.at/, DVR: 0005886
* LilyPond, Music typesetting, http://www.lilypond.org
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
