Hi Marc, LGTM, though I still think this is a lot of effort for a very obscure and little-used symbol.
Cheers, Neil http://codereview.appspot.com/181144/diff/5028/4010 File input/regression/bar-line-segno.ly (right): http://codereview.appspot.com/181144/diff/5028/4010#newcode2 input/regression/bar-line-segno.ly:2: \header { texidoc = "Segno bar lines can be used to mark newline for texidoc http://codereview.appspot.com/181144/diff/5028/4010#newcode7 input/regression/bar-line-segno.ly:7: \paper { ragged-right = ##t } { ragged-right http://codereview.appspot.com/181144/diff/5028/4011 File lily/bar-line.cc (right): http://codereview.appspot.com/181144/diff/5028/4011#newcode97 lily/bar-line.cc:97: Stencil segno; I'd move this back to a separate if { } block (like Reinhold suggested for your original patch) (see below) http://codereview.appspot.com/181144/diff/5028/4011#newcode210 lily/bar-line.cc:210: else if (str == "S") (as mentioned above) else if (str.find ("S") != NPOS || str = "|._.|") { Stencil segno ... if (str == "S") { ... http://codereview.appspot.com/181144/show _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
