Re: Improve implementation of dashed slurs

2009-04-18 Thread Carl D. Sorensen
On 4/18/09 9:26 PM, "Joe Neeman" wrote: > On Sat, 2009-04-18 at 21:08 -0600, Carl D. Sorensen wrote: >> >> >> On 4/18/09 7:56 PM, "Joe Neeman" wrote: >> >> >> If I do change to static typing, then I should have one routine that is >> called from all three places, something like scm2dash_d

Re: Improve implementation of dashed slurs

2009-04-18 Thread Joe Neeman
On Sat, 2009-04-18 at 21:08 -0600, Carl D. Sorensen wrote: > > > On 4/18/09 7:56 PM, "Joe Neeman" wrote: > > > On Fri, 2009-04-17 at 22:17 -0600, Carl D. Sorensen wrote: > > > >>> http://codereview.appspot.com/41099/diff/1021/62#newcode347 > >>> Line 347: SCM dash_details) > >>> Since dash_det

Re: Improve implementation of dashed slurs

2009-04-18 Thread Carl D. Sorensen
On 4/18/09 7:56 PM, "Joe Neeman" wrote: > On Fri, 2009-04-17 at 22:17 -0600, Carl D. Sorensen wrote: > >>> http://codereview.appspot.com/41099/diff/1021/62#newcode347 >>> Line 347: SCM dash_details) >>> Since dash_details seems to just be a list of Reals, perhaps its better >>> to have a vect

Re: Improve implementation of dashed slurs

2009-04-18 Thread Joe Neeman
On Fri, 2009-04-17 at 22:17 -0600, Carl D. Sorensen wrote: > > > On 4/17/09 1:47 PM, "joenee...@gmail.com" wrote: > > > Very pretty slurs! > > Thanks! > > > > > > > http://codereview.appspot.com/41099/diff/1021/59 > > File lily/bezier.cc (right): > > > > http://codereview.appspot.com/41099

Re: Improve implementation of dashed slurs

2009-04-18 Thread Neil Puttock
2009/4/18 Carl D. Sorensen : > > > > On 4/17/09 1:34 PM, "n.putt...@gmail.com" wrote: >> http://codereview.appspot.com/41099/diff/1021/52 >> File Documentation/user/expressive.itely (right): >> >> http://codereview.appspot.com/41099/diff/1021/52#newcode634 >> Line 634: @lilypondfile[verbatim,lily

Re: Improve implementation of dashed slurs

2009-04-18 Thread Carl D. Sorensen
On 4/18/09 8:54 AM, "Werner LEMBERG" wrote: >> Using a smaller design size might work with a squiggle-arpeggio, but >> for composers who use the slur-arpeggio (I think Grieg was one?), >> typesetting a thinner curve might be too subtle a difference. > > Ah, I haven't thought of the slur-arpeggi

Re: Improve implementation of dashed slurs

2009-04-18 Thread Werner LEMBERG
> Using a smaller design size might work with a squiggle-arpeggio, but > for composers who use the slur-arpeggio (I think Grieg was one?), > typesetting a thinner curve might be too subtle a difference. Ah, I haven't thought of the slur-arpeggio. Yes, I've meant the squiggle-arpeggio. Werne

Re: Improve implementation of dashed slurs

2009-04-18 Thread Carl D. Sorensen
On 4/17/09 10:20 PM, "Carl Sorensen" wrote: > > > > On 4/17/09 1:47 PM, "joenee...@gmail.com" wrote: > >> >> http://codereview.appspot.com/41099/diff/1021/59 >> File lily/bezier.cc (right): >> >> http://codereview.appspot.com/41099/diff/1021/59#newcode275 >> Line 275: Bezier::subdivide

Re: Improve implementation of dashed slurs

2009-04-18 Thread Mark Polesky
Werner LEMBERG wrote: > > An example of a useful dashed bezier-sandwich arpeggio would be when > > indicating arpeggios presumed to have been accidentally omitted from > > a manuscript, within an urtext edition. > > I don't think so. The proper way would be rather to use an arpeggio > typeset wi

Re: Improve implementation of dashed slurs

2009-04-17 Thread Werner LEMBERG
> An example of a useful dashed bezier-sandwich arpeggio would be when > indicating arpeggios presumed to have been accidentally omitted from > a manuscript, within an urtext edition. I don't think so. The proper way would be rather to use an arpeggio typeset with a smaller design size. IMHO a

Re: Improve implementation of dashed slurs

2009-04-17 Thread Carl D. Sorensen
On 4/17/09 1:47 PM, "joenee...@gmail.com" wrote: > Very pretty slurs! Thanks! > > > http://codereview.appspot.com/41099/diff/1021/59 > File lily/bezier.cc (right): > > http://codereview.appspot.com/41099/diff/1021/59#newcode275 > Line 275: Bezier::subdivide (Real t, Bezier &left_part, Bez

Re: Improve implementation of dashed slurs

2009-04-17 Thread Mark Polesky
Carl D. Sorensen wrote: > On 4/17/09 1:34 PM, "n.putt...@gmail.com" wrote: > > http://codereview.appspot.com/41099/diff/1021/58 > > File lily/arpeggio.cc (right): > > > > http://codereview.appspot.com/41099/diff/1021/58#newcode168 > > Line 168: Stencil mol (Lookup::slur (curve, lt, lt, SCM_UNDEF

Re: Improve implementation of dashed slurs

2009-04-17 Thread Carl D. Sorensen
On 4/17/09 1:34 PM, "n.putt...@gmail.com" wrote: Thanks for the review, Neil. > > > http://codereview.appspot.com/41099/diff/1021/52 > File Documentation/user/expressive.itely (right): > > http://codereview.appspot.com/41099/diff/1021/52#newcode634 > Line 634: @lilypondfile[verbatim,lilyqu

Re: Improve implementation of dashed slurs

2009-04-17 Thread joeneeman
Very pretty slurs! http://codereview.appspot.com/41099/diff/1021/59 File lily/bezier.cc (right): http://codereview.appspot.com/41099/diff/1021/59#newcode275 Line 275: Bezier::subdivide (Real t, Bezier &left_part, Bezier &right_part) We only use references if they are const (for clarity), so ple

Improve implementation of dashed slurs

2009-04-17 Thread n . puttock
http://codereview.appspot.com/41099/diff/1021/52 File Documentation/user/expressive.itely (right): http://codereview.appspot.com/41099/diff/1021/52#newcode634 Line 634: @lilypondfile[verbatim,lilyquote,texidoc,doctitle] @ignore this unless you're going to run makelsr.py (or create input/lsr file