Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

author Paul Morris Tue, 5 May 2015 03:18:15 + (23:18 -0400) committer James Lowe Sun, 17 May 2015 18:34:15 + (19:34 +0100) commit 51aecfed170349c19e10923c9ce18773ad1786c3 and author Paul Morris Tue, 5 May 2015 03:12:52 + (23:12 -0

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

Patch counted down - please push https://codereview.appspot.com/235090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

Patch on countdown for May 16th https://codereview.appspot.com/235090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

https://codereview.appspot.com/235090043/diff/60001/input/regression/stencil-flip.ly File input/regression/stencil-flip.ly (right): https://codereview.appspot.com/235090043/diff/60001/input/regression/stencil-flip.ly#newcode1 input/regression/stencil-flip.ly:1: \version "2.19.19" On 2015/05/07 0

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

LGTM. https://codereview.appspot.com/235090043/diff/60001/input/regression/stencil-flip.ly File input/regression/stencil-flip.ly (right): https://codereview.appspot.com/235090043/diff/60001/input/regression/stencil-flip.ly#newcode1 input/regression/stencil-flip.ly:1: \version "2.19.19" I would

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

Here's another round of edits, also: WARNING: could not change issue labels; please email lilypond-devel with the issue number: 4370 No permission to edit issue Thanks, -Paul https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.a

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

Some nitpicks. Otherwise LGTM https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode665 scm/stencil.scm:665: (define-public (stencil-flip axis stil) I'd call it 'flip-stencil',

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode668 scm/stencil.scm:668: An @var{axis} of Y or 1 will flip it vertically. What about: Value @code{X} (or @code{0}) for @

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

Thanks for the feedback! I've improved the doc strings, and revised the doc string for ly:stencil-scale so that it covers negative arguments. -Paul https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly File input/regression/stencil-scale.ly (right): https://coderevi

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

Looks good! Thanks for posting it. A couple of comments included. https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly File input/regression/stencil-scale.ly (right): https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly#newcode8 input

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

LGTM. https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly File input/regression/stencil-scale.ly (right): https://codereview.appspot.com/235090043/diff/1/input/regression/stencil-scale.ly#newcode8 input/regression/stencil-scale.ly:8: its bounding box.)" Please use

Re: Add stencil-flip function (issue 235090043 by paulwmor...@gmail.com)

Please review, thanks. https://codereview.appspot.com/235090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel