Some nitpicks.
Otherwise LGTM

https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm
File scm/stencil.scm (right):

https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode665
scm/stencil.scm:665: (define-public (stencil-flip axis stil)
I'd call it 'flip-stencil', would be more in line with the majority of
namings
here in stencil.scm

https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode668
scm/stencil.scm:668: An @var{axis} of Y or 1 will flip it vertically.
Why not simply delete these two lines.
I feel they are pretty much redundant.

https://codereview.appspot.com/235090043/diff/40001/scm/stencil.scm#newcode670
scm/stencil.scm:670: X and Y coordinates of its bounding box, remains
the same."
I'd delete "X and Y" in order not to lead to confusing with the meaning
of X- and Y-axis in LilyPond

https://codereview.appspot.com/235090043/

_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Reply via email to