On 1/24/11, pkx1...@gmail.com wrote:
>
> No problem. What would be the best thing to do with this 'code' would
> putting the 'patch' I have on the tracker issue, with explanation and
> appropriate comments from this Rietveld thread, be the right thing if
> only to save re-doing more work for anyon
On 2011/01/24 16:20:20, c_sorensen_byu.edu wrote:
snip...
But -- Neil's comment indicated that this approach wrong for getting
this
functionality into the LilyPond distribution. He suggests that a new
engraver will be needed.
Therefore, putting this up as an LSR snippet in the original fo
On 1/24/11 9:14 AM, "pkx1...@gmail.com" wrote:
> Patch v.3 is up. Still having compile issues even after Carl's
> suggestions - so I wonder if someone can take a look and see if I have
> edited in the correct place.
>
> PS. I am not seeing any emails go to dev when I update or upload so I am
> n
Patch v.3 is up. Still having compile issues even after Carl's
suggestions - so I wonder if someone can take a look and see if I have
edited in the correct place.
PS. I am not seeing any emails go to dev when I update or upload so I am
not sure if my gmail account is set up for dev properly. So I
This is a nice hack, but the way it's currently implemented makes it
unsuitable to be merged.
The full-bar rests should be collected by an engraver (like the
Rest_collision_engraver), rather than using a hash table.
http://codereview.appspot.com/4005046/
On 1/23/11 2:10 PM, "pkx1...@gmail.com" wrote:
> Reviewers: carl.d.sorensen_gmail.com, Graham Percival,
>
> Message:
> I have done all the changes (except added a reg test) and uploaded them.
> However this does not make cleanly. I am getting an error
>
> current/scm/lily.scm:851:21: Unbound va
Reviewers: carl.d.sorensen_gmail.com, Graham Percival,
Message:
I have done all the changes (except added a reg test) and uploaded them.
However this does not make cleanly. I am getting an error
current/scm/lily.scm:851:21: Unbound variable:
merge-rests-on-positioning
Any help would be apprecia
Correction.
http://codereview.appspot.com/4005046/diff/1/ly/merge-function.ly
File ly/merge-function.ly (right):
http://codereview.appspot.com/4005046/diff/1/ly/merge-function.ly#newcode3
ly/merge-function.ly:3:
On 2011/01/23 00:07:33, Graham Percival wrote:
Having an example is a nice idea, b
A few nitpicks. BTW, expect to produce 3-6 drafts.
http://codereview.appspot.com/4005046/diff/1/ly/merge-function.ly
File ly/merge-function.ly (right):
http://codereview.appspot.com/4005046/diff/1/ly/merge-function.ly#newcode3
ly/merge-function.ly:3:
Having an example is a nice idea, but don't
Great start, James!
Getting this far is more than half the battle.
Are you up for the next round of changes now?
Thanks,
Carl
http://codereview.appspot.com/4005046/diff/1/ly/declarations-init.ly
File ly/declarations-init.ly (right):
http://codereview.appspot.com/4005046/diff/1/ly/declarati
10 matches
Mail list logo
