Great start, James! Getting this far is more than half the battle.
Are you up for the next round of changes now? Thanks, Carl http://codereview.appspot.com/4005046/diff/1/ly/declarations-init.ly File ly/declarations-init.ly (right): http://codereview.appspot.com/4005046/diff/1/ly/declarations-init.ly#newcode31 ly/declarations-init.ly:31: \include "merge-function.ly" Once we move ly/merge-function.ly to scm/merge-rests.scm, this will need to move to scm/lily.scm as part of the definition of init-scheme-files (see lines 393 and thereabouts. http://codereview.appspot.com/4005046/diff/1/ly/merge-function.ly File ly/merge-function.ly (right): http://codereview.appspot.com/4005046/diff/1/ly/merge-function.ly#newcode1 ly/merge-function.ly:1: %{ Once you have moved the commands out to ly/property-init.ly and ly/engraver-init.ly, there's nothing but scheme code in this file, so it should become a scheme file. Let's call it scm/merge-rests.scm. Put a LilyPond copyright statement at the top of it (use one from any other .scm file), with Wilbert Berendsen and James Lowe as the copyright holders. http://codereview.appspot.com/4005046/diff/1/ly/merge-function.ly#newcode118 ly/merge-function.ly:118: mergeRestsOn = { You have properly defined mergeRestsOn and mergeRestsOff in ly/property-init.ly, so they should be removed here. mergeRests should be moved to ly/engraver-init.ly (and removed here). http://codereview.appspot.com/4005046/diff/1/ly/property-init.ly File ly/property-init.ly (right): http://codereview.appspot.com/4005046/diff/1/ly/property-init.ly#newcode282 ly/property-init.ly:282: mergeRests = \layout { mergeRests should have the \layout{} block removed, so that it can be included in anybody's layout block. It should be in ly/engraver-init.ly. http://codereview.appspot.com/4005046/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
