Re: Run regression tests for lilypond-book (issue 2223). (issue 5569045)

2020-02-24 Thread julien . rioux
https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile File input/regression/lilypond-book/GNUmakefile (right): https://codereview.appspot.com/5569045/diff/3001/input/regression/lilypond-book/GNUmakefile#newcode36 input/regression/lilypond-book/GNUmakefile:36

Re: CG: Update of Patchy instructions (issue 112280043 by pkx1...@gmail.com)

2014-07-24 Thread julien . rioux
Don't think it needs another countdown cycle, so the changes below could be made before pushing. Cheers, Julien https://codereview.appspot.com/112280043/diff/40001/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right): https://codereview.apps

Re: CG: Update of Patchy instructions (issue 112280043 by pkx1...@gmail.com)

2014-07-21 Thread julien . rioux
Thanks for this! Some comments. Cheers, Julien https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administration.itexi File Documentation/contributor/administration.itexi (right): https://codereview.appspot.com/112280043/diff/20001/Documentation/contributor/administra

Re: Leave extension in .dep under mf/ , as we have multiple rules generating .dep files. (issue 99300043)

2014-05-20 Thread julien . rioux
On 2014/05/18 12:12:27, hanwenn wrote: according to git it was Julien. lgtm https://codereview.appspot.com/99300043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Python 3 support

2014-03-18 Thread Julien Rioux
On Tue, Mar 18, 2014 at 4:43 PM, Jeremiah Benham wrote: > I have forked gub and have been working on it for a while now. > > https://github.com/jjbenham/gub > > It is very different now from https://github.com/gperciva/gub and the > main master. I don't know how to contribute changes unless via p

Re: Python 3 support

2014-03-18 Thread Julien Rioux
On Tue, Mar 18, 2014 at 12:44 PM, David Kastrup wrote: > > That's not quite the same as "we already have hosting, a platform for > contribution and review comments". Everything beyond the content in > private repositories is gone if a project is removed. And "we have" is > a bit of a euphemism

Re: Python 3 support

2014-03-18 Thread Julien Rioux
On Tue, Mar 18, 2014 at 10:39 AM, David Kastrup wrote: > Julien Rioux writes: > > > The current hosting situation isn't bad that we need to take such > > important actions with savannah. With github, we already have hosting, > > a platform for contribution and re

Re: Python 3 support

2014-03-18 Thread Julien Rioux
On Mon, Mar 17, 2014 at 9:38 PM, Graham Percival wrote: > On Sun, Mar 16, 2014 at 04:41:46PM -0400, Julien Rioux wrote: > > I think the following would be a good 1-2 punch approach for the > > current development cycle: First, upgrade python in GUB and make > > sure we can

Re: Python 3 support

2014-03-18 Thread Julien Rioux
On Tue, Mar 18, 2014 at 6:24 AM, David Kastrup wrote: > Julien Rioux writes: > > > (BTW moving GUB to a user-agnostic home such as > > https://github.com/lilypond > > > would make sense to avoid such confusion. After Jan went mostly > > inactive, Graham took ov

Re: Python 3 support

2014-03-18 Thread Julien Rioux
On Tue, Mar 18, 2014 at 3:33 AM, David Kastrup wrote: > I was of the opinion that GUB already uses Python 2.6? > > GUB master at https://github.com/gperciva/gub (the current "official" home) definitely does not use python 2.6. It ships python 2.4.5 If you are using GUB master at https://github.c

Python 3 support

2014-03-16 Thread Julien Rioux
Hi, Our python scripts currently require a python2 interpreter with version at least 2.4, but by bumping the requirement to 2.6 we could start introducing from __future__ import print_function which will be one of the major step towards supporting both python2 and python3 interpreters with a

Re: [translations] Re: 2.18 release plans (again).

2013-10-29 Thread Julien Rioux
On 29/10/2013 4:43 AM, David Kastrup wrote: Julien Rioux writes: On 27/10/2013 2:09 PM, Janek Warchoł wrote: That's good, but the most irritating thing about this patch is not that i have to solve merge conflicts. I'm mainly irritated because a piece of solid code (maybe it'

Re: [translations] Re: 2.18 release plans (again).

2013-10-29 Thread Julien Rioux
On 27/10/2013 2:09 PM, Janek Warchoł wrote: That's good, but the most irritating thing about this patch is not that i have to solve merge conflicts. I'm mainly irritated because a piece of solid code (maybe it's not as solid as i think, but to know that i need _reviews_) is laying dormant for *h

Build: Fix compilation with GNU make 4.0 (issue 18700043)

2013-10-28 Thread julien . rioux
Reviewers: John Mandereau, Message: Thanks to Thomas Klausner. This seems like the correct fix. Cheers, Julien Description: Build: Fix compilation with GNU make 4.0 Fix "recipes commence before first target" error. Patch from Thomas Klausner. Please review this at https://codereview.appspot.

Re: Build: Fix out-of-tree build from tarball. (issue 13854043)

2013-10-02 Thread julien . rioux
https://codereview.appspot.com/13854043/diff/16001/Documentation/GNUmakefile File Documentation/GNUmakefile (right): https://codereview.appspot.com/13854043/diff/16001/Documentation/GNUmakefile#newcode283 Documentation/GNUmakefile:283: $(outdir)/contributor.texi: $(outdir)/ly-grammar.txt On 2013

Re: Build: Fix out-of-tree build from tarball. (issue 13854043)

2013-10-01 Thread julien . rioux
https://codereview.appspot.com/13854043/diff/7001/Documentation/GNUmakefile File Documentation/GNUmakefile (right): https://codereview.appspot.com/13854043/diff/7001/Documentation/GNUmakefile#newcode283 Documentation/GNUmakefile:283: $(outdir)/contributor.texi: $(outdir)/ly-grammar.txt On 2013/1

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-09-30 Thread julien . rioux
Again, can we add a check if there is already a numbered backup around? Make numbered backups for files that have numbered backups already. Otherwise, make single backups. This is the default. That would mean: https://codereview.appspot.com/14040043/diff/6001/scripts/convert-ly.py File

Let convert-ly -d reflect last effective rather than last applied rule (issue 14077043)

2013-09-30 Thread julien . rioux
lgtm Cheers, Julien https://codereview.appspot.com/14077043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add backup option to convert-ly (Issue 3572) (issue 14040043)

2013-09-27 Thread julien . rioux
This suggestion from David sounded like a good default: Make numbered backups for files that have numbered backups already. https://codereview.appspot.com/14040043/diff/1/scripts/convert-ly.py File scripts/convert-ly.py (right): https://codereview.appspot.com/14040043/diff/1/scripts/convert-ly

scripts: improve strip-whitespace.py (issue 13720049)

2013-09-27 Thread julien . rioux
LGTM. You might want to add to your comment at the top: "Also convert the file to Unix line endings." https://codereview.appspot.com/13720049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: ERROR: Please install required programs: International New Century Schoolbook fonts

2013-09-12 Thread Julien Rioux
On 12/09/2013 6:09 PM, Federico Bruni wrote: 2013/8/3 Federico Bruni mailto:fedel...@gmail.com>> I'm getting this error if I run ./autogen.sh in git master: ERROR: Please install required programs: International New Century Schoolbook fonts International New Century Schoolbook font

Build dependencies for metafont files (issue 779). (issue 13681043)

2013-09-12 Thread julien . rioux
Reviewers: John Mandereau, Message: Please review. Description: Build dependencies for metafont files (issue 779). Write .dep files containing make dependency rules for .mf files, allowing to simply type `make' to process the fonts after changing an input'ed file and have the fonts updated with

Re: Build everything on the first pass of make. (issue 13333048)

2013-09-12 Thread Julien Rioux
On Thu, Sep 12, 2013 at 5:47 AM, Phil Holmes wrote: > I don't understand what you're fixing here, Julien. On my machine, > deleting the build directory completely, then recreating it and running > make (-j9 of course) completely rebuilds the binaries in a single pass. > Further immediate calls

Re: ./test-patchy on steroids

2013-09-11 Thread Julien Rioux
On Wed, Sep 11, 2013 at 6:19 PM, James wrote: > Julien, > > I just had a bit of a shock when I ran the test-patchy script - then > realized that I had inadvertently added an extra character before running > the script > > --snip-- > jlowe@jlowe26vm ~/lilypond-extra/patches (master)$ ./test-patche

Re: getting fc-list to see gsfonts

2013-09-11 Thread Julien Rioux
On 11/09/2013 2:38 PM, Mark Polesky wrote: Julien Rioux wrote: But now I'm curious, how do I get fc-list to "see" the fonts in the gsfonts directory? Looks like you have to run fc-cache to update the database. Something like: sudo fc-cache -fsv Julien and David, I'll

Re: Restore the default `make' target. (issue 13290047)

2013-09-11 Thread julien . rioux
On 2013/09/11 18:54:01, Mark Polesky wrote: personally, I would find this wording more intuitive: same as `make all', but restricted to the current directory Sounds good. Although... I guess `make local-all' and `make default' do the same thing? Maybe you could just say same as

Build everything on the first pass of make. (issue 13333048)

2013-09-11 Thread julien . rioux
Reviewers: John Mandereau, lemzwerg, Message: Please review. Description: Build everything on the first pass of make. Everything should be built and up-to-date after a one-shot `make' call. Currently, this is not the case: fonts are being rebuilt on the secnod pass. This required a dependency f

Disallow metapost versions 1.504 < x < 1.803. (issue 13413046)

2013-09-11 Thread julien . rioux
Reviewers: dak, lemzwerg, Message: Please review. Description: Disallow metapost versions 1.504 < x < 1.803. Add a check in ./configure to avoid these buggy versions of metapost: 1.504 < mpost --version < 1.803 Fixes issue 3539: Configure should forbid mpost 1.802 from TexLive 2013 http://cod

Re: Restore the default `make' target. (issue 13290047)

2013-09-11 Thread julien . rioux
Updated to be purely documentational. https://codereview.appspot.com/13290047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: getting fc-list to see gsfonts

2013-09-11 Thread Julien Rioux
On 11/09/2013 3:28 AM, Mark Polesky wrote: So, after Julien's patch https://codereview.appspot.com/13390043 I finally get a proper error at the configure stage: ERROR: Please install required programs: International New Century Schoolbook fonts (make sure the fc-list utility can s

Re: Restore the default `make' target. (issue 13290047)

2013-09-06 Thread julien . rioux
Reviewers: dak, Message: On 2013/09/06 16:39:24, dak wrote: https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make File stepmake/stepmake/generic-targets.make (right): https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make#newcode

Since Bison is optional, need to distribute Documentation/out/ly-grammar.txt (issue 13475043)

2013-09-02 Thread julien . rioux
LGTM https://codereview.appspot.com/13475043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Keep bison-generated files in sync. (issue 13466043)

2013-09-02 Thread julien . rioux
See http://code.google.com/p/lilypond/issues/detail?id=3528 https://codereview.appspot.com/13466043/diff/2001/stepmake/stepmake/c++-rules.make File stepmake/stepmake/c++-rules.make (right): https://codereview.appspot.com/13466043/diff/2001/stepmake/stepmake/c++-rules.make#newcode16 stepmake/ste

Re: patch to remove unused header tie-column-format.hh

2013-08-21 Thread Julien Rioux
On 21/08/2013 12:32 AM, Frédéric Bron wrote: Please read http://www.lilypond.org/doc/v2.17/Documentation/contributor-big-page.html#summary-for-experienced-developers and start using git-cl. Plain patches posted to -devel tend to get forgotten in mist of syntax changes and font standards debates.

Re: patch to remove unused header tie-column-format.hh

2013-08-20 Thread Julien Rioux
On 20/08/2013 3:00 PM, Frédéric Bron wrote: Dear all, The header tie-column-format.hh is unused. tie-column-format.cc was removed in 2.10 and removing the header does not prevent lilypond to build. Only 2 files were including it without actually using it. Here is the proposed patch. Frédéric

Re: colorful make output! yum!

2013-08-20 Thread Julien Rioux
On 20/08/2013 9:00 AM, Phil Holmes wrote: However, I (and, from what I've seen, David K, and almost certainly Graham and probably Julien) would strongly oppose adding extra complexity to the already over-complex build system. I actually don't mind this, provided I can turn it off. I think it's

Re: Windows tutorial updates (issue 12980044)

2013-08-20 Thread julien . rioux
On 2013/08/17 12:29:08, Julien Rioux wrote: It looks like we can download individual patches for each file, so maybe we can use this with Patchy somehow, I've updated Patchy to handle the "too large to download" patchset. You can review here: https://github.com/gperciva/lilypon

Re: make website fails on platforms where python3 is the default. (issue 12769043)

2013-08-17 Thread julien . rioux
Reviewers: janek, Graham Percival, Message: On 2013/08/16 04:45:59, Graham Percival wrote: When building with WEBSITE_ONLY_BUILD, $(PYTHON) will default to python (as defined at the top of the file). We do that because we don't run ./configure on the web server. I _think_ this will be sa

Re: Windows tutorial updates (issue 12980044)

2013-08-17 Thread julien . rioux
On 2013/08/17 11:31:41, PhilEHolmes wrote: The patch set on Rietveld now includes the new images (thanks, Julien). hmm, the images are there, we can see them in the side-by-side diffs... but for the patch, Rietveld says "Patch set is too large to download". Bummer. It looks like we can download

Re: Support for testing min and max versions of Guile. (issue 11303044)

2013-07-22 Thread Julien Rioux
On Mon, Jul 22, 2013 at 1:18 PM, Graham Percival wrote: > On Mon, Jul 22, 2013 at 02:03:31PM +, d...@gnu.org wrote: > > As far as I know, 1.9 is the development series culminating in the > > stable 2.0, so while 1.9 is not all too likely to be installed on > > current systems, allowing/preferr

Re: Fedora 19 comes with guile 2.0.9 - cannot use 2.17.22

2013-07-20 Thread Julien Rioux
On 20/07/2013 5:00 PM, Ian Hulin wrote: On 13/07/13 20:51, Frédéric Bron wrote: I don't think ./configure should do this automatically, but at the very least, it should fail when it finds a guile version that is incompatible with our source code. Can you please open an issue for it\? good poin

Re: Unable to run test patchy - URI changed for tracker?

2013-07-18 Thread Julien Rioux
On 18/07/2013 11:46 AM, James wrote: On 18/07/13 16:08, Phil Holmes wrote: - Original Message - From: "Julien Rioux" To: Sent: Thursday, July 18, 2013 4:04 PM Subject: Re: Unable to run test patchy - URI changed for tracker? On 18/07/2013 11:00 AM, Phil Ho

Re: Unable to run test patchy - URI changed for tracker?

2013-07-18 Thread Julien Rioux
On 18/07/2013 11:00 AM, Phil Holmes wrote: - Original Message - From: "Julien Rioux" To: Sent: Thursday, July 18, 2013 3:50 PM Subject: Re: Unable to run test patchy - URI changed for tracker? On 18/07/2013 2:39 AM, Graham Percival wrote: On Wed, Jul 17, 2013 at 03:48:

Re: Unable to run test patchy - URI changed for tracker?

2013-07-18 Thread Julien Rioux
On 18/07/2013 2:39 AM, Graham Percival wrote: On Wed, Jul 17, 2013 at 03:48:52PM +0100, Phil Holmes wrote: Three options I can think of. 1) use something other than Google. [...] 3) "Screen scrape". I'd be seriously concerned about breakage. That said, it wouldn't be too bad if we used a

Re: Fedora 19 comes with guile 2.0.9 - cannot use 2.17.22

2013-07-13 Thread Julien Rioux
On 13/07/2013 6:52 AM, Frédéric Bron wrote: I read also that: "The packages will have to be patched to Require and BuildRequire the compat-guile18(-devel) package. Furthermore, they will have to be patched (if necessary) to use the renamed autotools macros. The patches to spec files and autotools

Re: Issues building documentation on Fedora 19

2013-07-13 Thread Julien Rioux
On 13/07/2013 3:19 PM, Frédéric Bron wrote: I can now build lilypond and compile at least the simple score { c } But when I do my build process: export GUILE=/usr/bin/guile1.8 export GUILE_CONFIG=/usr/bin/guile1.8-config export GUILE_TOOLS=/usr/bin/guile1.8-tools sh autogen.sh --noconfigure mkd

Re: Images from Liedboek with attribution

2013-06-12 Thread Julien Rioux
On 12/06/2013 2:27 PM, James wrote: Nice. But where are the images of the score? ;) http://www.liedboek.nl/voorbeelden/proefbundel It looks really nice :) -- Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/ma

Re: make doc fails

2013-03-16 Thread Julien Rioux
On 16/03/2013 6:27 PM, David Nalesnik wrote: /usr/bin/python -tt /home/david/lilypond-git/scripts/build/create-weblinks-itexi.py > out-www/weblinks.itexi make[3]: *** No rule to make target `/home/david/lilypond-git/Documentation/cs/web/news-front.itexi', needed by `out-www/web.texi'. Stop. Tr

Re: build: missing explicit dependency?

2013-03-15 Thread Julien Rioux
On Thu, Mar 14, 2013 at 5:39 AM, Francisco Vila wrote: > 2013/3/12 Julien Rioux : >> OK I see, so testing for the binaries is not enough. We`ll need to >> find out what else is required and add a test for it. Does anybody >> know? If you or anyone else do uninstall texlive

Re: build: missing explicit dependency?

2013-03-12 Thread Julien Rioux
On Tue, Mar 12, 2013 at 2:05 PM, Francisco Vila wrote: > 2013/3/12 Julien Rioux : >> On 02/03/2013 11:54 AM, Francisco Vila wrote: >>> >>> Hello. When trying to build lilypond, I had to install the >>> texlive-metapost package which the autogen.sh did not ask f

Re: build: missing explicit dependency?

2013-03-12 Thread Julien Rioux
On 02/03/2013 11:54 AM, Francisco Vila wrote: Hello. When trying to build lilypond, I had to install the texlive-metapost package which the autogen.sh did not ask for. Is this a flaw of the config process? Actually, ./configure is checking for both mf and mpost. Do you still have a config.log

Re: Alternative pixel-based regtest checker

2013-03-09 Thread Julien Rioux
On 01/03/2013 2:15 PM, Phil Holmes wrote: 4 files attached. To try this out: create a new directory and place NoTagline.ly in it. Create a subdirectory called input and put some regtest files in there. Run MakeOldPix.sh. Make a change to lilypond. Run MakeNewPix.sh. Run ComparePix.sh. Om my

Re: build: missing explicit dependency?

2013-03-09 Thread Julien Rioux
On 05/03/2013 11:07 AM, Francisco Vila wrote: 2013/3/3 James : On 2 March 2013 16:54, Francisco Vila wrote: Hello. When trying to build lilypond, I had to install the texlive-metapost package which the autogen.sh did not ask for. Is this a flaw of the config process? Well when I follow the

Re: DOC: Update CG 8.7 Patch Handling (issue 7101048)

2013-01-14 Thread julien . rioux
Reitveld -> Rietveld https://codereview.appspot.com/7101048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: CG: explicitly detail the correct values for git cl config (issue 7096052)

2013-01-14 Thread julien . rioux
At this point, the git-cl used by the project has been sufficiently geared towards lilypond development that I somewhat doubt anybody is using it for work outside of lilypond. It might not make sense at all for "our" git-cl to keep asking these superfluous questions; should they be remove entirely

Fix KeyError in website_post.py from Issue 847 (issue 7021043)

2012-12-29 Thread julien . rioux
LGTM https://codereview.appspot.com/7021043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Update contributors. (issue 6689045)

2012-10-19 Thread Julien Rioux
On Fri, Oct 19, 2012 at 8:47 AM, Janek Warchoł wrote: > On Fri, Oct 19, 2012 at 10:36 AM, wrote: >> I missed that Bertrand Bordage, Joe Neeman, and Carl D. Sorensen are >> listed both under "developers" and "contributors". According to the >> policy they should be removed from "contributors". Al

Re: Update contributors. (issue 6689045)

2012-10-19 Thread julien . rioux
I missed that Bertrand Bordage, Joe Neeman, and Carl D. Sorensen are listed both under "developers" and "contributors". According to the policy they should be removed from "contributors". Also Colin Hall is listed under "developers" so probably should not be added under "contributors: bug squad" l

Re: problem uploading a patch

2012-10-17 Thread Julien Rioux
On 10/17/2012 02:55 PM, David Nalesnik wrote: Julien, On Wed, Oct 17, 2012 at 1:33 AM, Julien Rioux wrote: On 16/10/2012 4:36 PM, David Nalesnik wrote: david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue 2445 Issue number: 2445 (http://codereview.appspot.com/2445

Re: problem uploading a patch

2012-10-16 Thread Julien Rioux
On 16/10/2012 4:36 PM, David Nalesnik wrote: david@david-desktop ~/lilypond-git (dev/measure_counter)$ git cl issue 2445 Issue number: 2445 (http://codereview.appspot.com/2445) This should be the issue number from the Rietveld page, not the one from google code page. -- Julien _

Re: Update contributors. (issue 6689045)

2012-10-16 Thread Julien Rioux
On Mon, Oct 15, 2012 at 5:18 PM, wrote: > Sorry, there's a bit of confusion here. The past policy was: Thanks, I've updated the file to clarify the policy and made sure that I do not move contributors from past to current but simply add them to current. Cheers, Julien

Re: Translations for create-weblinks-itexi.py (issue 6681045)

2012-10-15 Thread Julien Rioux
On Mon, Oct 15, 2012 at 7:40 AM, wrote: > this looks strange: when i go to side-by-side diffs, i don't see any > changes, just "error: old chunk mismatch". I don't know what caused that, but you can rely on the raw patch set. Since this patch only adds lines and does not remove any lines, the re

Re: convert-ly (issue 2670) (issue 6610058)

2012-10-08 Thread Julien Rioux
On Mon, Oct 8, 2012 at 4:08 PM, wrote: > The changelog says > > "Don't update \version when no rule is applied." > > That's what the existing -d --diff-version-update command does. If this > is intended to be the default behaviour now, then the command-line > option should be removed. No, -d do

Re: [talk] why it'd be great to have web interface for submittingsimple doc patches

2012-10-07 Thread Julien Rioux
On 07/10/2012 5:33 AM, Phil Holmes wrote: - Original Message - From: "Joseph Rushton Wakeling" To: "Phil Holmes" Cc: "James" ; Sent: Saturday, October 06, 2012 5:26 PM Subject: Re: [talk] why it'd be great to have web interface for submittingsimple doc patches On 10/06/2012 05:46 PM

Re: convert-ly (issue 2670) (issue 6610058)

2012-10-06 Thread Julien Rioux
On Sat, Oct 6, 2012 at 1:06 AM, wrote: > Are you going to report the number of errors using the `errors' > variable? In case this is true, I would consider this a bad idea, since > you abuse the functionality of the exit status. > > How large can `errors' become? The value returned by `exit' mu

Re: lilypond-book: treat iffalse sections in latex as block comments (issue 6584073)

2012-10-05 Thread julien . rioux
Try to add a regression test example with a valid lilypond block inbetween two multiline comments. http://codereview.appspot.com/6584073/diff/1/python/book_latex.py File python/book_latex.py (right): http://codereview.appspot.com/6584073/diff/1/python/book_latex.py#newcode88 python/book_latex.p

convert-ly (issue 2670) (issue 6610058)

2012-10-05 Thread julien . rioux
Reviewers: , Message: For review: Description: convert-ly: - Exit with error status when errors occur. - Use unicode strings for file names printing. - Don't update \version when no rule is applied. This fixes issue 2670. Please review this at http://codereview.appspot.com/6610058/ Affecte

Re: make test

2012-08-21 Thread Julien Rioux
On 08/08/2012 4:59 AM, Phil Holmes wrote: I've been looking at how the regression test comparison works. The first thing I find is that we have 2 effectively duplicate, but different, pages on running regtest comparisons: http://lilypond.org/doc/v2.15/Documentation/contributor/verify-regression

Re: Patchy switches for forcing make doc don't seem to work

2012-08-21 Thread Julien Rioux
On 20/08/2012 8:53 AM, James wrote: John, On 20 August 2012 13:09, John Mandereau wrote: Hi James, Il giorno lun, 20/08/2012 alle 10.40 +0100, James ha scritto: I am not able to work out how to force patchy during a test-patches.py to also make doc as well as the test and test-baseline. I do

Re: Fix for several musicxml2ly bugs. (issue 5697059)

2012-06-28 Thread julien . rioux
Hi Patrick, A cleaned up version of this patch has been committed (and credited to you), so you may close this Rietveld issue. You will see the fix in version 2.15.41, the next development release. Cheers, Julien http://codereview.appspot.com/5697059/ __

Re: LSR updates and translations

2012-06-25 Thread Julien Rioux
On 25/06/2012 1:53 PM, John Mandereau wrote: Il giorno lun, 25/06/2012 alle 18.50 +0100, Phil Holmes ha scritto: And John M could no doubt help. It's a question of how much time they have to contribute. If what we want to achieve is well enough specified, then I can offer to go for it. Cheers

Re: Add missing shebang line in MacOSX instructions. (issue 6300118)

2012-06-22 Thread julien . rioux
Reviewers: Graham Percival, Message: On 2012/06/22 08:19:29, Graham Percival wrote: I thought that bash doesn't need the shebang in some cases? at least, I could have sworn that I never added the shebang in this case? As I understand it, problems ensue when you try to call that script from

Re: Treat accidentals parentheses as cautionary (issue 6310065)

2012-06-22 Thread julien . rioux
Reviewers: MikeSol, Graham Percival, Message: On 2012/06/22 08:20:56, Graham Percival wrote: LGTM, although I'd personally have prepended "musicxml2ly:" to the beginning of the patch subject line. That makes it much more obvious when skimming the git history (or just available patches to re

Re: Website build crashing

2012-04-30 Thread Julien Rioux
On 26/04/2012 5:53 AM, m...@mikesolomon.org wrote: Hey all, My website build crashes with: mikesol@mikesol-laptop:~/lilypond-git$ sudo make LILYPOND_WEB_MEDIA_GIT=/home/mikesol/lilypond-extra website make --no-builtin-rules config_make=./config.make \ top-src-dir=/home/mikesol/

Re: Changes .tex files to get rid of warning (issue 5976055)

2012-04-02 Thread Julien Rioux
On Mon, Apr 2, 2012 at 11:11 AM, Phil Holmes wrote: > - Original Message - From: "Julien Rioux" > To: ; ; > ; ; ; > > >> > A snippet with a deprecated option, triggering compatibility mode: >> > >> > -\lilypond[11pt,fragment]{c&#x

Doc: CG Update compile.itexi for doc build (issue 5967060)

2012-04-02 Thread julien . rioux
LGTM http://codereview.appspot.com/5967060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Changes .tex files to get rid of warning (issue 5976055)

2012-04-02 Thread Julien Rioux
On Sun, Apr 1, 2012 at 2:32 PM, wrote: > Reviewers: Julien Rioux, Graham Percival, dak, > > Message: > Please review > > Description: > These files used what appears to be a deprecated syntax to invoke > lilypond-book, resulting in these warnings: > > lilypond-b

Re: volunteer for patchy new-patches

2012-03-27 Thread Julien Rioux
On 27/03/2012 3:20 PM, Marek Klein wrote: 2012/3/27 Julien Rioux On 27/03/2012 2:58 PM, Marek Klein wrote: However, I cannot find the log file :( On a default configuration this logfile would be in /tmp/lilypond-autobuild Cheers, Julien Here it is: http://gregoriana.sk/data/log-None

Re: volunteer for patchy new-patches

2012-03-27 Thread Julien Rioux
On 27/03/2012 2:58 PM, Marek Klein wrote: 2012/3/27 James I reset one of mine on the countdown http://code.google.com/p/lilypond/issues/detail?id=2216 Try that. This is the output: Trying issue 2216 Found patch: (2216, '/home/marek/lilypond-patchy/issue5843060_6001.diff', 'AU: Documen

Re: dist-check failure

2012-03-27 Thread Julien Rioux
On 26/03/2012 8:42 PM, Graham Percival wrote: ge.ja.html file from VC not distributed: lilypond-2.15.35/Documentation/misc/browser-language.nl.html file from VC not distributed: lilypond-2.15.35/input/regression/lilypond-book/include/example.ly file from VC not distributed: lilypond-2.15.35/input

Re: In-tree make check fails with lilypond-book include file regtest.

2012-03-27 Thread Julien Rioux
On 27/03/2012 9:37 AM, David Kastrup wrote: David Kastrup writes: commit ee70161485a2d2f347db3e29724a943c741ef524 Author: Julien Rioux Date: Wed Mar 21 09:13:55 2012 -0400 Regtests for lilypond-book include files located in subdir. causes the regtests to fail. Rerunning configure

Re: volunteer for patchy new-patches

2012-03-27 Thread Julien Rioux
On 27/03/2012 1:48 PM, Marek Klein wrote: Hi, 2012/3/23 Graham Percival Well, you need to figure out why git fetch in your $LILYPOND_GIT repository fails. git fetch works now... I need som new patch for play with... Marek ___ lilypond-deve

Re: Don't reload initialization files when processing multiple files (issue 5874044)

2012-03-23 Thread julien . rioux
LGTM http://codereview.appspot.com/5874044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Tracks old announcements, news and changelogs. (issue 5843069)

2012-03-23 Thread Julien Rioux
On Fri, Mar 23, 2012 at 5:12 AM, wrote: > Awesome work as always.  There's some unintended (and bad) changes to > GNUmakefile.in. > That's a mistake when I uploaded (pointing to the wrong commit in git-cl upload). Just trust me that I won't commit this, but I am not uploading again in order to g

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-23 Thread Julien Rioux
On Fri, Mar 23, 2012 at 4:33 AM, wrote: > I'm seeing "old chunk mismatch" for this patch.  Could you try uploading > it again to a new rietveld issue? > > http://codereview.appspot.com/5846075/ Fixed, it was a bad upload (no need for a new issue number).

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-22 Thread Julien Rioux
On Wed, Mar 21, 2012 at 9:37 AM, Julien Rioux wrote: > On Wed, Mar 21, 2012 at 1:39 AM,   wrote: >> >> http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py >> File scripts/lilypond-book.py (right): >> >> http://codereview.appspot.com/584607

Re: Corrected style of comments (issue 5862052)

2012-03-22 Thread julien . rioux
Are the changes to .gitignore intentional? http://codereview.appspot.com/5862052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: A new home for browser-language (issue 2412). (issue 5870043)

2012-03-21 Thread Julien Rioux
On Wed, Mar 21, 2012 at 4:42 PM, Julien Rioux wrote: > On Wed, Mar 21, 2012 at 4:33 PM,   wrote: >> >> http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py >> File python/auxiliar/postprocess_html.py (right): >> >> http://codereview.

Re: Tracks old announcements, news and changelogs. (issue 5843069)

2012-03-21 Thread Julien Rioux
On Wed, Mar 21, 2012 at 5:16 PM, wrote: > > http://codereview.appspot.com/5843069/diff/17/Documentation/common-macros.itexi > File Documentation/common-macros.itexi (right): > > http://codereview.appspot.com/5843069/diff/17/Documentation/common-macros.itexi#newcode185 > Documentation/common-macro

Re: A new home for browser-language (issue 2412). (issue 5870043)

2012-03-21 Thread Julien Rioux
On Wed, Mar 21, 2012 at 4:33 PM, wrote: > > http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py > File python/auxiliar/postprocess_html.py (right): > > http://codereview.appspot.com/5870043/diff/1/python/auxiliar/postprocess_html.py#newcode71 > python/auxiliar/postpro

Re: lilypond-book: Set include path for --output option (issue 2423). (issue 5846075)

2012-03-21 Thread Julien Rioux
On Wed, Mar 21, 2012 at 1:39 AM, wrote: > > http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py > File scripts/lilypond-book.py (right): > > http://codereview.appspot.com/5846075/diff/1/scripts/lilypond-book.py#newcode639 > scripts/lilypond-book.py:639: global_options.include_pa

Re: volunteer for patchy new-patches

2012-03-20 Thread Julien Rioux
On 20/03/2012 4:26 PM, Marek Klein wrote: Hi, 2012/3/16 Graham Percival On Fri, Mar 16, 2012 at 09:52:52PM +0100, Marek Klein wrote: I can do it, I think (almost every day). Great! Here's the link to get started: http://lilypond.org/doc/v2.15/Documentation/contributor/patchy ... although

Re: Tracks old announcements, news and changelogs. (issue 5843069)

2012-03-20 Thread Julien Rioux
On Tue, Mar 20, 2012 at 2:07 PM, wrote: > LGTM > > http://codereview.appspot.com/5843069/ Thanks for having a look. By the way, it looks like http://lilypond.org/website just replicates http://lilypong.org at a deeper level -- any reason why this is so? Is that from before the switch to the new

Re: What's with the build directories?

2012-03-19 Thread Julien Rioux
Graham Percival percival-music.ca> writes: > On Mon, Mar 19, 2012 at 01:24:54PM +0100, David Kastrup wrote: > > I find that in my patchy runs, I get directories > > /tmp/lilypond-autobuild (my configured build directory) > > and a hierarchy of "build" directories under it, possibly one per tested

Re: Sets lilypond-id message to type progress (issue 5848056)

2012-03-18 Thread Julien Rioux
On Sun, Mar 18, 2012 at 1:49 PM, wrote: > > http://codereview.appspot.com/5848056/diff/1/scripts/lilypond-book.py > File scripts/lilypond-book.py (right): > > http://codereview.appspot.com/5848056/diff/1/scripts/lilypond-book.py#newcode104 > scripts/lilypond-book.py:104: progress(_ ('%s (GNU Lily

Re: Hiding old website /web/install page (issue 5500069)

2012-03-17 Thread julien . rioux
this rietveld issue can be closed. http://codereview.appspot.com/5500069/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Copy pdf docs to new website folder (issue 5507046)

2012-03-17 Thread julien . rioux
On 2012/01/03 20:36:48, Graham Percival wrote: On Tue, Jan 03, 2012 at 06:31:54PM +, mailto:hashas...@gmail.com wrote: > Sorry, didn't understand what you mean by "add issue 2166 to track this" It's not relevant unless you're going to be making other patches. If you are, read the "summar

Re: FW: [LilyPond] Your organization application has been rejected.

2012-03-16 Thread Julien Rioux
On 16/03/2012 5:16 PM, Julien Rioux wrote: There are a few organisations interesting for lilypond hackers: inkscape (to learn about svg), closure (to learn a scheme-like language), buildbot (could be helpful but we already have the gran unified builder). libreoffice (improve the lilypond

Re: volunteer for patchy new-patches

2012-03-16 Thread Julien Rioux
On 16/03/2012 4:55 PM, Graham Percival wrote: On Fri, Mar 16, 2012 at 09:52:52PM +0100, Marek Klein wrote: I can do it, I think (almost every day). Great! Here's the link to get started: http://lilypond.org/doc/v2.15/Documentation/contributor/patchy ... although apparently that doesn't incl

Re: FW: [LilyPond] Your organization application has been rejected.

2012-03-16 Thread Julien Rioux
On 16/03/2012 4:45 PM, Janek Warchoł wrote: On Fri, Mar 16, 2012 at 6:53 PM, Carl Sorensen wrote: On 3/16/12 11:44 AM, "no-re...@google-melange.appspotmail.com" wrote: Thank you for submitting "LilyPond" organization application to Google Summer of Code 2012. Unfortunately, we were unable t

  1   2   3   >