Reviewers: dak,
Message:
On 2013/09/06 16:39:24, dak wrote:
https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make
File stepmake/stepmake/generic-targets.make (right):
https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make#newcode1
stepmake/stepmake/generic-targets.make:1: .PHONY : all clean bin-clean
default
dist exe help html lib man TAGS\
That change might be independently useful.
https://codereview.appspot.com/13290047/diff/1/stepmake/stepmake/generic-targets.make#newcode5
stepmake/stepmake/generic-targets.make:5: default: all
I have no idea what makes you think that default is not a defined
target for
most Makefiles.
git grep "^default:"
turns up a host of default targets.
Documentation/GNUmakefile:default: local-txt-doc
Documentation/css/GNUmakefile:default:
Documentation/logo/GNUmakefile:default: $(lilypond-icon) $(ly-icon)
Documentation/misc/GNUmakefile:default: local-txt-doc
Documentation/pictures/GNUmakefile:default:
GNUmakefile.in:default: $(config_h) build-dir-setup build-scripts
lily/GNUmakefile:default:
make/abc-targets.make:default:
make/doc-i18n-root-targets.make:default:
make/lilypond-book-targets.make:default:
make/midi-targets.make:default:
make/musicxml-targets.make:default:
mf/GNUmakefile:default: $(ALL_GEN_FILES) \
po/GNUmakefile:default: $(MO_FILES)
python/GNUmakefile:default: $(outdir)/relocate-preamble.py
python/auxiliar/GNUmakefile:default:
stepmake/stepmake/automatically-generated.sub.make:default:
stepmake/stepmake/documentation-targets.make:default:
stepmake/stepmake/executable-targets.make:default: $(EXECUTABLE)
stepmake/stepmake/help2man-targets.make:default: man
stepmake/stepmake/library-targets.make:default: $(LIBRARY)
stepmake/stepmake/python-module-targets.make:default:
$(OUT_PY_MODULES) $(OUT_PY
stepmake/stepmake/shared-library-targets.make:default:
$(SHARED_LIBRARY)
stepmake/stepmake/texinfo-targets.make:default: $(INFO_FILES)
stepmake/stepmake/topdocs-targets.make:default: local-txt-doc
So you should likely check which particular Makefile is missing a
default target
and double-check by trying "make default" since there are a lot of
opportunities
for having the default target defined in an include file.
I was confused. default exists, it's just not what I expected after
reading the description: the empty target is equivalent to `make all'
(which recurses through all subdirectories) and not `make default'
(which acts in the local directory only). I'll turn this issue into a
documentation one, changing what `make help' has to say about the
default target.
Cheers,
Julien
Description:
Restore the default `make' target.
`make help' mentions that `default' is the same as the
empty target, but it's not even a defined target. This
commit restores `default' as the default, empty target.
Please review this at https://codereview.appspot.com/13290047/
Affected files (+4, -2 lines):
M stepmake/stepmake/generic-targets.make
Index: stepmake/stepmake/generic-targets.make
diff --git a/stepmake/stepmake/generic-targets.make
b/stepmake/stepmake/generic-targets.make
index
1b998b938dfc3eb6b2c0bbb13dc0aa1c06be10e3..6837bf5558a7411b5fd7dc187b0114bc813aa47f
100644
--- a/stepmake/stepmake/generic-targets.make
+++ b/stepmake/stepmake/generic-targets.make
@@ -1,8 +1,10 @@
-.PHONY : all clean bin-clean default dist exe help html lib TAGS\
+.PHONY : all clean bin-clean default dist exe help html lib man TAGS\
po doc doc-stage-1 WWW-1 WWW-2 WWW-post local-WWW-1 local-WWW-2\
log-clean
-all: default
+default: all
+
+all:
$(LOOP)
man:
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
