>> So the `stable' branch should add the file `txi-pt.tex' from
>> upstream, right?
>
> Yes. And we need to add the filename to the list of copied files in
> grand-replace.py. See attached patch for stable/2.20.
LGTM, thanks!
Werner
___
lilypon
Hi David!
Attached is bc4f5fdc299 of master ported to stable/2.20.
Cherry picking did not work as the aclocal.m4 files diverged to much.
Knut
>From db670c8174b3f00c0e9676683f3f1c74b787b5ee Mon Sep 17 00:00:00 2001
From: Knut Petersen
Date: Thu, 4 Jul 2019 08:09:22 +0200
Subject: [PATCH 2/2] Add
Hi Werner!
So the `stable' branch should add the file `txi-pt.tex' from upstream,
right?
Yes. And we need to add the filename to the list of copied files in
grand-replace.py. See attached patch for stable/2.20.
Knut
>From 36e4be23ca414ca9d315d89b94d5a3e4cbb20f4d Mon Sep 17 00:00:00 2001
Fr
Reviewers: ,
Message:
Passes make, make check and a full make doc.
Description:
stem.cc - issue 5303 - misplaced notehead
In loop calculating the attachments
of chord node heads to stem,
calculate last used position by
_rounding_ to int rather than by
truncating to int.
This fixes issue 5303 (
Lukas-Fabian Moser writes:
> To me, this would seem to suggest that the "less invasive" bugfix I
> proposed (by rounding) would in fact preserve the incompleteness in
> the move from int to float calculations that Han-Wen probably
> introduced by accident (unless (*) is motivated in a way I do no
I would think that rounding the int and keeping lastpos as an integer
would be less invasive and I would do that.
It would be less invasive, the question is what the right thing would
be. Anybody have an idea whether non-integer positions can sensibly be
employed here for, say, chromatic notat
Hello,
Here is the current patch countdown list. The next countdown will be on
July 7th
A quick synopsis of all patches currently in the review process can be
found here:
http://philholmes.net/lilypond/allura/
Push:
5524 New function css-color (accompanying x11-color) - Urs Liska
David Kastrup ezt írta (időpont: 2019. júl. 4., Cs, 18:16):
>
> "Phil Holmes" writes:
>
> > - Original Message -
> > From: "Lukas-Fabian Moser"
> >>
> >> Questions:
> >>
> >> a) How to decide which fix is "better"? (My guess that using floats
> >> might pose the danger of rounding errors
"Phil Holmes" writes:
> - Original Message -
> From: "Lukas-Fabian Moser"
>>
>> Questions:
>>
>> a) How to decide which fix is "better"? (My guess that using floats
>> might pose the danger of rounding errors adding up until something bad
>> happens - probably only for huge chords compr
- Original Message -
From: "Lukas-Fabian Moser"
Questions:
a) How to decide which fix is "better"? (My guess that using floats
might pose the danger of rounding errors adding up until something bad
happens - probably only for huge chords comprising hundreds of notes,
but I'd tend to
Hi James,
a) How to decide which fix is "better"? (My guess that using floats
might pose the danger of rounding errors adding up until something bad
happens - probably only for huge chords comprising hundreds of notes,
but I'd tend to favor the solution with rounding.)
That question is above my
> During building stable/ 2.20 we have to build the Portuguese
> website. As we have no txi-pt.tex in the tex/ directory that will
> fail if there is no installation of texinfo on the host system.
So the `stable' branch should add the file `txi-pt.tex' from upstream,
right?
> Before I write a p
Knut Petersen writes:
> Hi everybody!
>
> During building stable/ 2.20 we have to build the Portuguese
> website. As we have no txi-pt.tex in the tex/ directory that will
> fail if there is no installation of texinfo on the host system.
>
> Before I write a patch: Could someone please explain to
Hi everybody!
During building stable/ 2.20 we have to build the Portuguese
website. As we have no txi-pt.tex in the tex/ directory that will
fail if there is no installation of texinfo on the host system.
Before I write a patch: Could someone please explain to me why
we use txi-*.tex files stor
Hello
On Thu, 4 Jul 2019 12:31:46 +0200, Lukas-Fabian Moser wrote:
> Folks,
>
> only now was I able to do regression tests regarding my proposed fix(es)
> of the misplaced-note-head-bug (issue 5303):
>
> The bug is caused by the integer-cast
>
> lastpos = int (p);
>
> in lily/stem.cc:629.
>
Folks,
only now was I able to do regression tests regarding my proposed fix(es)
of the misplaced-note-head-bug (issue 5303):
The bug is caused by the integer-cast
lastpos = int (p);
in lily/stem.cc:629.
Replacing it by either
i) lastpos = p; // use float value
or
ii) lastpos = int (round (p
16 matches
Mail list logo
