Reviewers: pkx, dak,
Message:
This patch provides a more thorough solution to the spacing problem than
my other patch, specifically for metronome marks:
https://codereview.appspot.com/323420043/ .
Description:
Issue 1434: Fix text spacing in SVG
This change makes every SVG contain a style tag w
We are not losing spaces, the standard is to ignore trailing whitespace,
such as line-breaks and (breaking) spaces at the beginning of tabs. We
are still using normal spaces where appropriate (such as the second
space on line 78). Our translation from markup to SVG does have issues
(see issues 517
Thank you for your reviewing.
https://codereview.appspot.com/330040043/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/330040043/diff/1/Documentation/notation/input.itely#newcode2845
Documentation/notation/input.itely:284
On 2017/08/17 19:59:30, Ebe123 wrote:
On 2017/08/16 22:03:31, dak wrote:
> Uh, isn't that just skirting the issue? SVG text generation has a
bug
> swallowing spaces and instead of fixing that, one instance of space
use rather
> uses something else?
>
> That sounds like a bottomless barrel.
https://codereview.appspot.com/330040043/diff/1/Documentation/notation/text.itely
File Documentation/notation/text.itely (right):
https://codereview.appspot.com/330040043/diff/1/Documentation/notation/text.itely#newcode1627
Documentation/notation/text.itely:1627: #:factor (/ staff-height pt 20)
https://codereview.appspot.com/330040043/diff/1/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
https://codereview.appspot.com/330040043/diff/1/Documentation/notation/input.itely#newcode2845
Documentation/notation/input.itely:2845: @end example
I think it woul
Hello,
Here is the current patch countdown list. The next countdown will be on
August 20th.
A quick synopsis of all patches currently in the review process can be
found here:
http://philholmes.net/lilypond/allura/
Push:
5171 Self_alignment_interface::aligned_on_self: bad warning - David
On 2017/08/16 22:03:31, dak wrote:
Uh, isn't that just skirting the issue? SVG text generation has a bug
swallowing spaces and instead of fixing that, one instance of space
use rather
uses something else?
That sounds like a bottomless barrel. Shouldn't we rather try to fix
the actual
pro
David
On Thu, 17 Aug 2017 10:06:48 +0200
David Kastrup wrote:
> James writes:
>
> > David,
> >
> > On Thu, 17 Aug 2017 09:21:03 +0200
> > David Kastrup wrote:
> >
> >
> >>
> >> Can't think of anything right now.
> >>
> >
> > How about the 'Fixed_x_x_x' label we use in the tracker when a
James writes:
> David,
>
> On Thu, 17 Aug 2017 09:21:03 +0200
> David Kastrup wrote:
>
>
>>
>> Can't think of anything right now.
>>
>
> How about the 'Fixed_x_x_x' label we use in the tracker when a patch is
> pushed. So for example if we continue to put the unstable version there
> is that '
David,
On Thu, 17 Aug 2017 09:21:03 +0200
David Kastrup wrote:
>
> Can't think of anything right now.
>
How about the 'Fixed_x_x_x' label we use in the tracker when a patch is
pushed. So for example if we continue to put the unstable version there
is that 'good enough'?
James
_
David Kastrup writes:
> James writes:
>
>>> What should be done in stable/2.20?
>>>
>>> Documentation/changes.tely should be reorganized: it is currently in
>>> chronological order which does not make sense for the stable release.
>>> It should be organized topically.
>>
>> I'll start a tracker
James writes:
> On Wed, 16 Aug 2017 22:25:38 +0200
> David Kastrup wrote:
>
>> Ok, I've started sorting out stable and master branch and pushed some
>> 2.21-change on top of some already 2.21-only changes in master.
>
> As I cannot remember what we did in the last fork to stable, I assume I
> ju
13 matches
Mail list logo
