Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by thomasmorle...@gmail.com)

On 2015/08/29 18:13:13, dak wrote: On 2015/08/29 17:28:33, thomasmorley651 wrote: > On 2015/08/26 08:55:14, dak wrote: > > https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm > > File scm/lily-library.scm (right): > > > > > https://codereview.appspot.com/257580043/diff/1/scm/

Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by thomasmorle...@gmail.com)

On 2015/08/29 17:28:33, thomasmorley651 wrote: On 2015/08/26 08:55:14, dak wrote: > https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm > File scm/lily-library.scm (right): > > https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm#newcode793 > scm/lily-library.s

Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by thomasmorle...@gmail.com)

2015-08-26 11:24 GMT+02:00 : > Sorry, too busy with non LilyPond work right now. Maybe I can continue > the upcoming weekend. For now setting > > PATCH-NEEDS_WORK > > https://codereview.appspot.com/257580043/ I've uploaded a new patch-set to https://codereview.appspot.com/257580043/ Setting: P

Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by thomasmorle...@gmail.com)

On 2015/08/26 08:55:14, dak wrote: https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/257580043/diff/1/scm/lily-library.scm#newcode793 scm/lily-library.scm:793: char-set:whitespace)) A mostly theoretic musing:

Re: Clear fret-diagram- and harp-pedal-input-strings from whitespace (issue 257580043 by thomasmorle...@gmail.com)

On 2015/08/23 15:11:08, dak wrote: https://codereview.appspot.com/257580043/diff/1/scm/fret-diagrams.scm File scm/fret-diagrams.scm (right): https://codereview.appspot.com/257580043/diff/1/scm/fret-diagrams.scm#newcode45 scm/fret-diagrams.scm:45: (define (not-number-error input output) "input

Re: Change the LilyPond default fonts to TeX Gyre

2015-08-22 19:05 GMT+02:00 James Lowe : > On 22/08/15 04:44, Masamichi HOSODA wrote: > If you use Debian or Ubuntu etc., please install > `fonts-texgyre' package like following command before > compiling LilyPond. > > $ sudo apt-get install fonts-texgyre Didn’t work in

Re: Strange error message installing master from git sources

2015-08-29 17:42 GMT+02:00 David Kastrup : > Thomas Morley writes: > >> 2015-08-29 5:30 GMT+02:00 David Kastrup : >>> Thomas Morley writes: >>> Being on LilyDev3 ("Debian GNU/Linux 7 (wheezy)") I nuked my build, and started from scratch and I knew texgyre was _not_ installed.

Re: Strange error message installing master from git sources

Thomas Morley writes: > 2015-08-29 5:30 GMT+02:00 David Kastrup : >> Thomas Morley writes: >> >>> Being on LilyDev3 ("Debian GNU/Linux 7 (wheezy)") >>> >>> I nuked my build, and started from scratch and I knew texgyre was >>> _not_ installed. >>> >>> Trying Dan's advice to get texgyre >>> http:/

Re: Strange error message installing master from git sources

2015-08-29 5:30 GMT+02:00 David Kastrup : > Thomas Morley writes: > >> Being on LilyDev3 ("Debian GNU/Linux 7 (wheezy)") >> >> I nuked my build, and started from scratch and I knew texgyre was >> _not_ installed. >> >> Trying Dan's advice to get texgyre >> http://lists.gnu.org/archive/html/lilypon

Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by nine.fierce.ball...@gmail.com)

On 2015/08/29 13:11:02, Dan Eble wrote: whitespace and comments I'll address filter_map_into/filter_map_assign later; I'm not sure if I'll have time this weekend. https://codereview.appspot.com/264950043/ ___ lilypond-devel mailing list lilypond-dev

Re: Allura at SF is ready

David Kastrup wrote Saturday, August 29, 2015 11:12 AM > "Trevor Daniels" writes: > >> David Kastrup wrote Saturday, August 29, 2015 10:34 AM >> >>> Sounds more like a job for a script. >> >> It would be tricky. The script would need to find all >> issues with a GC reference by a search, look

Re: Allura at SF is ready

"Trevor Daniels" writes: > David Kastrup wrote Saturday, August 29, 2015 10:34 AM > > >> "Trevor Daniels" writes: >> >>> What doesn't work is a link to a specific comment. They take you >>> back to the start of the issue, not the comment. But as the old >>> comments are all linear it is possib

Re: Allura at SF is ready

2015-08-29 11:30 GMT+02:00 Trevor Daniels : > > Pál, you wrote Saturday, August 29, 2015 8:21 AM >> >> I also noted that explicit links like >> https://code.google.com/p/lilypond/issues/detail?id=2249 >> are not converted. Again, not a big problem, just some >> inconvenience in reading old issues.

Re: Allura at SF is ready

David Kastrup wrote Saturday, August 29, 2015 10:34 AM > "Trevor Daniels" writes: > >> What doesn't work is a link to a specific comment. They take you >> back to the start of the issue, not the comment. But as the old >> comments are all linear it is possible to count down to find the >> spe

Re: Allura at SF is ready

"Trevor Daniels" writes: > Pál, you wrote Saturday, August 29, 2015 8:21 AM >> >> 2015-08-28 21:32 GMT+02:00 Trevor Daniels : >>> >>> There is a link field available in every comment to cut and >>> paste in order to refer to it from elsewhere, including other >>> issues, when threading doesn't me

Re: Allura at SF is ready

Pál, you wrote Saturday, August 29, 2015 8:21 AM > > 2015-08-28 21:32 GMT+02:00 Trevor Daniels : >> >> There is a link field available in every comment to cut and >> paste in order to refer to it from elsewhere, including other >> issues, when threading doesn't meet the need. > > Yes; so it will w

Re: Strange error message installing master from git sources

Thomas Morley writes: > Being on LilyDev3 ("Debian GNU/Linux 7 (wheezy)") > > I nuked my build, and started from scratch and I knew texgyre was > _not_ installed. > > Trying Dan's advice to get texgyre > http://lists.gnu.org/archive/html/lilypond-devel/2015-08/msg00132.html > didn't succeed. > >

Re: Strange error message installing master from git sources

On 29-08-2015 01:12, Thomas Morley wrote: . . I had a similiar problem: Being on LilyDev3 ("Debian GNU/Linux 7 (wheezy)") I nuked my build, and started from scratch and I knew texgyre was _not_ installed. Trying Dan's advice to get texgyre http://lists.gnu.org/archive/html/lilypond-

NR Changing Defaults: Explain sticky contexts accurately (issue 260960043 by d...@gnu.org)

Passes make, make check and a full make doc. PATCH_REVIEW https://codereview.appspot.com/260960043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add StaffAxis context type (issue 265730043 by d...@gnu.org)

Passes make, make check and a full make doc. PATCH_REIVEW https://codereview.appspot.com/265730043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES: Countdown for September 2nd 2015

Hello, Here is the current patch countdown list. The next countdown will be on September 2nd. PUSH: Masamichi Hosada: Fix fontforge version detection https://code.google.com/p/lilypond/issues/detail?id=4573 https://codereview.appspot.com/258400043/ Paul Morris: Revert inter

Re: Issue 4564: make Grob an abstract class (issue 260810043 by nine.fierce.ball...@gmail.com)

Leaving on 'review' for now. PATCH_REVIEW https://codereview.appspot.com/260810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 4504: Let whiteout-box take a number argument (issue 264810043 by paulwmor...@gmail.com)

Patch counted down - please push. PATCH_PUSH (if you don't have push access - I can never remember who has and who has not these days) then you can email me a git formatted patch and I can push it for you. https://codereview.appspot.com/264810043/ __

Re: Fix fontforge version detection (issue 258400043 by truer...@gmail.com)

Patch counted down, please push. PATCH_PUSH https://codereview.appspot.com/258400043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by nine.fierce.ball...@gmail.com)

Passes make, make check and a full make doc. PATCH_REVIEW https://codereview.appspot.com/264950043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Beautify Grob_array and stop using std::vector::data() (issue 264950043 by nine.fierce.ball...@gmail.com)

"Beautify" is appropriate for changes in comments or formatting. For code, it is subjective and non-descriptive. Overall, the changes look like an improvement. https://codereview.appspot.com/264950043/diff/1/lily/break-substitution.cc File lily/break-substitution.cc (right): https://coderevie