Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

2012-10-01 Thread dak
On 2012/10/02 00:23:55, Graham Percival wrote: https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly#newcode649 ly/music-functions-init.ly:649: no = why

Re: Various clean-ups in stems and beams. (issue 6584045)

2012-10-01 Thread aleksandr . andreev
On 2012/10/01 23:34:39, MikeSol wrote: I think a user should be able to use Kievan notation and normal stems/flags/beams if she so chooses. I'll define something like [snip] and then use it in the documentation. I still see some issues with this. As written now in stem.cc, when the style

Re: Doc: extend description of glissandi (2844) (issue 6567059)

2012-10-01 Thread graham
LGTM https://codereview.appspot.com/6567059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Provide \hide and \no functions for transparent and void glyphs (issue 6575048)

2012-10-01 Thread graham
https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/6575048/diff/8001/ly/music-functions-init.ly#newcode649 ly/music-functions-init.ly:649: no = why not use "omit" instead of "no" ? I think that "omi

Added \clef "treble_8" for guitar harmonics (issue 6588049)

2012-10-01 Thread graham
LGTM https://codereview.appspot.com/6588049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Various clean-ups in stems and beams. (issue 6584045)

2012-10-01 Thread mtsolo
Reviewers: aleksandr.andreev, Message: I think a user should be able to use Kievan notation and normal stems/flags/beams if she so chooses. I'll define something like startKievanNotation = { %% Set glyph styles. \override NoteHead #'style = #'kievan \override Rest #'style = #'mensural \ove

Re: Provide define-session and define-session-public commands (issue 6588056)

2012-10-01 Thread ianhulin44
On 2012/10/01 18:24:20, dak wrote: 15.6 `@tie{}': Inserting an Unbreakable Space = The `@tie{}' command produces a normal interword space at which a line break may not occur. Always write it with following (empty) braces, as usual for commands

Re: Patch-testing-problem

2012-10-01 Thread Thomas Morley
2012/9/30 James : > Hello, > > On 30 September 2012 16:06, Thomas Morley > wrote: [...] >> I couldn't comprehend your own work. > > The problem is that not all errors are the same - I am no expert but > after testing patches for the last year or so, you get a feel for this > I guess. Phil's work

Re: Outdated help2man; avoiding needing to "build" help2man.pl

2012-10-01 Thread Don Armstrong
On Mon, 01 Oct 2012, Pavel Roskin wrote: > On Thu, 13 Sep 2012 14:51:53 -0700 > Don Armstrong wrote: > > While it's correct, you can trivially work around this problem by > > changing > > > > #!@PERL@ -w > > > > to > > > > #!@PERL@ -w > > #! perl -w > > Considering the subsequent discussion

Various clean-ups in stems and beams. (issue 6584045)

2012-10-01 Thread aleksandr . andreev
http://codereview.appspot.com/6584045/diff/2001/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/6584045/diff/2001/ly/engraver-init.ly#newcode1150 ly/engraver-init.ly:1150: \override Beam #'positions = #beam::get-kievan-positions The only issue with putting thi

Re: Outdated help2man; avoiding needing to "build" help2man.pl

2012-10-01 Thread Pavel Roskin
On Thu, 13 Sep 2012 14:51:53 -0700 Don Armstrong wrote: > In stepmake/stepmake/help2man-rules.make, I ran across the following: > > # We must invoke the generated $(outdir)/help2man script instead of > # the help2man.pl source, which means that the scripts/build directory > # must be built first

Re: Provide define-session and define-session-public commands (issue 6588056)

2012-10-01 Thread dak
Reviewers: Ian Hulin (gmail), Message: On 2012/10/01 18:02:16, Ian Hulin (gmail) wrote: Just a question about the doc-string. http://codereview.appspot.com/6588056/diff/1/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/6588056/diff/1/scm/lily.scm#newcode51 scm/lily.sc

Provide define-session and define-session-public commands (issue 6588056)

2012-10-01 Thread ianhulin44
Just a question about the doc-string. http://codereview.appspot.com/6588056/diff/1/scm/lily.scm File scm/lily.scm (right): http://codereview.appspot.com/6588056/diff/1/scm/lily.scm#newcode51 scm/lily.scm:51: A@tie{}session basically corresponds to one LilyPond file on the Is a space needed some

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

2012-10-01 Thread David Kastrup
Thomas Morley writes: > 2012/9/30 : >> On 2012/09/30 19:44:49, marc wrote: >>> >>> Am 30.09.2012 11:02, schrieb d...@gnu.org: >>> > [...] >>> > First, the define-public is asking for trouble. You are exposing an >>> > internal Scheme data structure to users and make it overwritable by >> >> the

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

2012-10-01 Thread dak
On 2012/10/01 08:46:09, marc wrote: Am 30.09.2012 22:03, schrieb d...@gnu.org: > On 2012/09/30 19:44:49, marc wrote: >> Am 30.09.2012 11:02, schrieb d...@gnu.org: >> > [...] >> > First, the define-public is asking for trouble. You are exposing an >> > internal Scheme data structure to users and

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

2012-10-01 Thread David Kastrup
Marc Hohl writes: > Am 01.10.2012 11:00, schrieb d...@gnu.org: >> >> Or define-session-public. define-session will be for data that is reset >> per session, but not publicly accessible. Which is probably what you >> want if all the accessor functions are already in your .scm file. > I think tha

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

2012-10-01 Thread Marc Hohl
Am 01.10.2012 11:00, schrieb d...@gnu.org: On 2012/10/01 08:46:09, marc wrote: Am 30.09.2012 22:03, schrieb d...@gnu.org: > On 2012/09/30 19:44:49, marc wrote: >> Am 30.09.2012 11:02, schrieb d...@gnu.org: >> > [...] >> > First, the define-public is asking for trouble. You are exposing an >> >

Re: bar-line interface part 2/2: New bar line definition standard (issue 6498052)

2012-10-01 Thread Marc Hohl
Am 30.09.2012 22:03, schrieb d...@gnu.org: On 2012/09/30 19:44:49, marc wrote: Am 30.09.2012 11:02, schrieb d...@gnu.org: > [...] > First, the define-public is asking for trouble. You are exposing an > internal Scheme data structure to users and make it overwritable by the > user. If the user