Re: Narrowly target warnings for multiple slurs; Issue 1967 (issue 6272046)

2012-06-05 Thread k-ohara5a5a
http://codereview.appspot.com/6272046/diff/9001/lily/slur-engraver.cc File lily/slur-engraver.cc (right): http://codereview.appspot.com/6272046/diff/9001/lily/slur-engraver.cc#newcode174 lily/slur-engraver.cc:174: bool ended = false; On 2012/06/05 12:04:36, dak wrote: Moving this out of the loo

PATCH: Countdown canceled tonight

2012-06-05 Thread Colin Campbell
There is a patch up for possible countdown, but I don't see any agreement on whether or not it is ready. I propose to leave it on review, and ask that other devels have a look at Issue 2584 : please make partcombine merge slurs - R 6272

Re: GUB on recent Ubuntu release

2012-06-05 Thread Colin Hall
On Tue, Jun 05, 2012 at 10:01:04PM +0100, Graham Percival wrote: > On Tue, Jun 05, 2012 at 06:47:28PM +0100, Colin Hall wrote: > > I'm aware that libmpfr is a listed requirement for GUB and I have > > apt-get installed it. > > > > However, I see that libmpfr is also built by GUB. Not sure if it is

Re: GUB on recent Ubuntu release

2012-06-05 Thread Graham Percival
On Tue, Jun 05, 2012 at 06:47:28PM +0100, Colin Hall wrote: > I'm aware that libmpfr is a listed requirement for GUB and I have > apt-get installed it. > > However, I see that libmpfr is also built by GUB. Not sure if it is > host or cross. The history here is a bit vague, but in case you haven't

Re: GUB on recent Ubuntu release

2012-06-05 Thread Carl Sorensen
On 6/5/12 11:47 AM, "Colin Hall" wrote: >On Mon, Jun 04, 2012 at 12:56:56PM +0100, Colin Hall wrote: >> >> On Mon, Jun 04, 2012 at 11:15:33AM +0100, Colin Hall wrote: >> > >> > I'm attempting GUB on 64-bit VM runing Ubuntu Server 12.04 LTS >> >> Build failed on odcctools with a claim that th

Re: another GUB build failure from translations

2012-06-05 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Francisco Vila" Cc: "Phil Holmes" ; Sent: Tuesday, June 05, 2012 4:19 PM Subject: Re: another GUB build failure from translations On Tue, Jun 05, 2012 at 05:15:54PM +0200, Francisco Vila wrote: 2012/6/5 Phil Holmes : > It looks like

Re: another GUB build failure from translations

2012-06-05 Thread Graham Percival
On Tue, Jun 05, 2012 at 05:15:54PM +0200, Francisco Vila wrote: > 2012/6/5 Phil Holmes : > > It looks like an error in the French translation's file name - it's there as > > broken-crescendo-hairpin.ly whereas in es/texidocs/ (for example) it's > > broken-crescendo-hairpin.texidoc > > Ah yes, than

Re: another GUB build failure from translations

2012-06-05 Thread Francisco Vila
2012/6/5 Phil Holmes : > It looks like an error in the French translation's file name - it's there as > broken-crescendo-hairpin.ly whereas in es/texidocs/ (for example) it's > broken-crescendo-hairpin.texidoc Ah yes, thank you, I will fix it in staging. Right? -- Francisco Vila. Badajoz (Spain)

Re: another GUB build failure from translations

2012-06-05 Thread Phil Holmes
- Original Message - From: "Francisco Vila" To: "Graham Percival" Cc: Sent: Tuesday, June 05, 2012 3:52 PM Subject: Re: another GUB build failure from translations 2012/6/5 Graham Percival : file from VC not distributed: lilypond-2.15.40/Documentation/fr/texidocs/broken-crescendo-h

Re: another GUB build failure from translations

2012-06-05 Thread Francisco Vila
2012/6/5 Graham Percival : > file from VC not distributed: > lilypond-2.15.40/Documentation/fr/texidocs/broken-crescendo-hairpin.ly How is this possible? Documentation/xx/texicods/GNUmakefile is identical for xx = es fr de etc. In case this is not only possible but a fact, how could we have avoi

Re: Auto-merging translations and master

2012-06-05 Thread Han-Wen Nienhuys
On Tue, Jun 5, 2012 at 5:11 AM, John Mandereau wrote: > What do you think of this? > > The only objection I'm seeing for now is that there are too frequent > issues of files non distributed in tarball; for dealing with this I > propose to use dist-check from GUB, with an option to try using it >

another GUB build failure from translations

2012-06-05 Thread Graham Percival
file from VC not distributed: lilypond-2.15.40/Documentation/fr/texidocs/broken-crescendo-hairpin.ly rm -rf /tmp/tmpEc298t Traceback (most recent call last): File "test-lily/dist-check.py", line 137, in main () File "test-lily/dist-check.py", line 132, in main check_files (tarball, rep

Re: Auto-merging translations and master

2012-06-05 Thread David Kastrup
Graham Percival writes: > On Tue, Jun 05, 2012 at 10:11:46AM +0200, John Mandereau wrote: >> Now that I have looked at the scripts for building staging and merging >> it into master, upgraded my Fedora installation, a cron job runs this >> every two hours on my computer in the lab, and sends an e

Re: Auto-merging translations and master

2012-06-05 Thread Graham Percival
On Tue, Jun 05, 2012 at 10:11:46AM +0200, John Mandereau wrote: > Now that I have looked at the scripts for building staging and merging > it into master, upgraded my Fedora installation, a cron job runs this > every two hours on my computer in the lab, and sends an email > notification only if som

Re: Document <> and improve other simultanous music documentation. (issue 6248080)

2012-06-05 Thread dak
On 2012/06/04 14:50:54, Graham Percival wrote: LGTM, pending a serious discussion of this stuff in GLISS. The topic of GLISS is not how useful we allow the documentation for existing syntax and functionality to get. According to its acronym, it is about standardizing syntax, not its documenta

Re: Narrowly target warnings for multiple slurs; Issue 1967 (issue 6272046)

2012-06-05 Thread dak
http://codereview.appspot.com/6272046/diff/9001/lily/slur-engraver.cc File lily/slur-engraver.cc (right): http://codereview.appspot.com/6272046/diff/9001/lily/slur-engraver.cc#newcode174 lily/slur-engraver.cc:174: bool ended = false; Moving this out of the loop is simply wrong. This will get a

Re: Auto-merging translations and master

2012-06-05 Thread David Kastrup
John Mandereau writes: > Il giorno mar, 05/06/2012 alle 12.15 +0200, David Kastrup ha scritto: >> Change A redefines a function and its callers. >> >> Change B introduces another call of the function. >> >> No merge conflict. > > I see. You're right, in an ideal world change B would always pro

Re: Auto-merging translations and master

2012-06-05 Thread John Mandereau
Il giorno mar, 05/06/2012 alle 12.15 +0200, David Kastrup ha scritto: > Change A redefines a function and its callers. > > Change B introduces another call of the function. > > No merge conflict. I see. You're right, in an ideal world change B would always produce a build error, but in the real

Re: Auto-merging translations and master

2012-06-05 Thread David Kastrup
John Mandereau writes: > Il giorno mar, 05/06/2012 alle 11.16 +0200, David Kastrup ha scritto: >> The only automatic merges that are actually safe to do are >> fast-forwards, and the translation merges are not of that kind. > > Aren't merges that don't produce conflicts safe to handle with a > no

Re: Auto-merging translations and master

2012-06-05 Thread John Mandereau
Il giorno mar, 05/06/2012 alle 11.16 +0200, David Kastrup ha scritto: > The only automatic merges that are actually safe to do are > fast-forwards, and the translation merges are not of that kind. Aren't merges that don't produce conflicts safe to handle with a non-interactive cron job? Such a jo

Re: Auto-merging translations and master

2012-06-05 Thread David Kastrup
Francisco Vila writes: > 2012/6/5 David Kastrup : >> The only automatic merges that are actually safe to do are >> fast-forwards, and the translation merges are not of that kind. > > Sure? we change our own distinct files. commit 30339cb3706f6399c84607426988b25f79b4998c Merge: 9578677 9564d28 A

Re: Auto-merging translations and master

2012-06-05 Thread Francisco Vila
2012/6/5 David Kastrup : > The only automatic merges that are actually safe to do are > fast-forwards, and the translation merges are not of that kind. Sure? we change our own distinct files. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___

Re: Auto-merging translations and master

2012-06-05 Thread David Kastrup
John Mandereau writes: > Hello, > > Now that I have looked at the scripts for building staging and merging > it into master, upgraded my Fedora installation, a cron job runs this > every two hours on my computer in the lab, and sends an email > notification only if something fails or when a build

Re: [translations] Auto-merging translations and master

2012-06-05 Thread John Mandereau
Il giorno mar, 05/06/2012 alle 11.07 +0200, Francisco Vila ha scritto: > It would be a time-saver for me. But imagine that translations has a > compile stopper and I am not reacheable for 48 hours. Would it mean 24 > alert messages? It should mean an alert message every time a new commit is pushed

Re: [translations] Auto-merging translations and master

2012-06-05 Thread Francisco Vila
2012/6/5 John Mandereau : > Hello, > > Now that I have looked at the scripts for building staging and merging > it into master, upgraded my Fedora installation, a cron job runs this > every two hours on my computer in the lab, and sends an email > notification only if something fails or when a buil

Auto-merging translations and master

2012-06-05 Thread John Mandereau
Hello, Now that I have looked at the scripts for building staging and merging it into master, upgraded my Fedora installation, a cron job runs this every two hours on my computer in the lab, and sends an email notification only if something fails or when a build is done. How about adding merging