http://codereview.appspot.com/6272046/diff/9001/lily/slur-engraver.cc File lily/slur-engraver.cc (right):
http://codereview.appspot.com/6272046/diff/9001/lily/slur-engraver.cc#newcode174 lily/slur-engraver.cc:174: bool ended = false; On 2012/06/05 12:04:36, dak wrote:
Moving this out of the loop is simply wrong. This will get a warning
only if
_all_ closing events don't have an associated starting event
regardless of the
spanner-id. This needs to be done more carefully instead of just
changing the
code until it stops giving warnings.
Thanks, I think. We could simply move this initializer back where it was, and issue 1967 would still be as "fixed" as much as it is in current master. I think it would be clearest to have a separate loop through stop_events_ at this point to remove redundant ')'s with duplicate 'spanner-id's. Then that whole loop could go when partcombine is improved. But I won't be running Linux to test the code for a day or so. http://codereview.appspot.com/6272046/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
