Re: Build: Try to convince `make' to keep intermediate files. (issue 5490077)

2011-12-21 Thread Julien Rioux
On Wed, Dec 21, 2011 at 2:42 AM, wrote: > Works with no problem on my (single-processor) Fedora system, for what > little that is worth. > > Could you point out which files are affected by .SECONDARY, Julien, so > users of the affected systems might test specifically to see if this > addresses th

Patchy email

2011-12-21 Thread lilypond . patchy . graham
Begin LilyPond compile, commit: 1665810dee903c597ecafdbf64461899141165f4 *** FAILED STEP *** merge from staging maybe somebody pushed a commit directly to master? ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gn

Re: Tie LilyPond, lexer and parser together more type-safely. (issue 5501056)

2011-12-21 Thread David Kastrup
Han-Wen Nienhuys writes: > LGTM. > > Does this require a required version bump in configure for flex/bison? Good question. Looking at /usr/share/doc/bison/changelog.gz, I see for example 2003-04-28 Tim Van Holder * data/yacc.c: (b4_lex_param): Corrected for the case where %l

Re: Tie LilyPond, lexer and parser together more type-safely. (issue 5501056)

2011-12-21 Thread Han-Wen Nienhuys
LGTM. Does this require a required version bump in configure for flex/bison? On Wed, Dec 21, 2011 at 3:18 PM, wrote: > Looks excellent to me.  Thanks! > > http://codereview.appspot.com/5501056/ > > ___ > lilypond-devel mailing list > lilypond-devel@gn

Emacs mode lines for parser.yy and lexer.ll (issue 5505059)

2011-12-21 Thread graham
LGTM, please push directly to staging http://codereview.appspot.com/5505059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Give slurs skylines in outside-staff-priority calculations. (issue 5504055)

2011-12-21 Thread m...@apollinemike.com
On Dec 21, 2011, at 6:11 PM, carl.d.soren...@gmail.com wrote: > Mike, have you done any work to examine the effect of the value of > n_boxes on a) computation time, and b) quality of engraving fit? If > there is no effect on computation time, then we might as well err on the > side of too many.

Re: Sends woodwind regtest op to stderr (issue 5502058)

2011-12-21 Thread dak
http://codereview.appspot.com/5502058/diff/1/input/regression/woodwind-diagrams-key-lists.ly File input/regression/woodwind-diagrams-key-lists.ly (right): http://codereview.appspot.com/5502058/diff/1/input/regression/woodwind-diagrams-key-lists.ly#newcode1 input/regression/woodwind-diagrams-key-

Re: T2026: Use new (scm markup-facility-defs) scheme module for markup commands. (issue 5464045)

2011-12-21 Thread dak
http://codereview.appspot.com/5464045/diff/8002/input/regression/markup-cyclic-reference.ly File input/regression/markup-cyclic-reference.ly (right): http://codereview.appspot.com/5464045/diff/8002/input/regression/markup-cyclic-reference.ly#newcode2 input/regression/markup-cyclic-reference.ly:2

Sends woodwind regtest op to stderr (issue 5502058)

2011-12-21 Thread PhilEHolmes
Reviewers: percivall, dak, Message: Please review Description: I've used David's excellent update to display-woodwind-diagrams.scm and updated the woodwind-diagrams-key-lists.ly to use stderr as the output port for this list of fingerings. This will reduce clutter from make doc and should make

Re: Tie LilyPond, lexer and parser together more type-safely. (issue 5501056)

2011-12-21 Thread reinhold . kainhofer
LGTM (looks very much like a code simplification) http://codereview.appspot.com/5501056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: mentor needed

2011-12-21 Thread Alberto Simões
Specially because I am in Mac and I might miss most of the needed tools :-/ Depending on how serious you are to help with Lilypond Dev, I was also on a mac for 2 years helping but I used VirtualBox and the pre-built Linux Environment as a Virtual Machine - LilyDev - which you can find all about

Tie LilyPond, lexer and parser together more type-safely. (issue 5501056)

2011-12-21 Thread Carl . D . Sorensen
Looks excellent to me. Thanks! http://codereview.appspot.com/5501056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: mentor needed

2011-12-21 Thread James
Alberto, 2011/12/21 Alberto Simões : > > > On 12/21/11 15:31 , Graham Percival wrote: >> >> On Wed, Dec 21, 2011 at 02:19:49PM +, Alberto Simões wrote: >>> >>> >>> On 12/21/11 13:56 , Graham Percival wrote: I highly recommend that you read http://lilypond.org/doc/v2.15/Docu

Re: Give slurs skylines in outside-staff-priority calculations. (issue 5504055)

2011-12-21 Thread Carl . D . Sorensen
On 2011/12/21 16:13:13, dak wrote: http://codereview.appspot.com/5504055/diff/1/lily/slur.cc File lily/slur.cc (right): http://codereview.appspot.com/5504055/diff/1/lily/slur.cc#newcode388 lily/slur.cc:388: vsize N_BOXES = 100; On 2011/12/21 15:59:52, Neil Puttock wrote: > Don't you think this

Re: Give slurs skylines in outside-staff-priority calculations. (issue 5504055)

2011-12-21 Thread dak
http://codereview.appspot.com/5504055/diff/1/lily/slur.cc File lily/slur.cc (right): http://codereview.appspot.com/5504055/diff/1/lily/slur.cc#newcode388 lily/slur.cc:388: vsize N_BOXES = 100; On 2011/12/21 15:59:52, Neil Puttock wrote: Don't you think this is a bit extravagant? At least, this

Give slurs skylines in outside-staff-priority calculations. (issue 5504055)

2011-12-21 Thread n . puttock
http://codereview.appspot.com/5504055/diff/1/lily/slur.cc File lily/slur.cc (right): http://codereview.appspot.com/5504055/diff/1/lily/slur.cc#newcode388 lily/slur.cc:388: vsize N_BOXES = 100; Don't you think this is a bit extravagant? At least, this shouldn't be hard-coded. A coarser integral

Re: mentor needed

2011-12-21 Thread Alberto Simões
On 12/21/11 15:31 , Graham Percival wrote: On Wed, Dec 21, 2011 at 02:19:49PM +, Alberto Simões wrote: On 12/21/11 13:56 , Graham Percival wrote: I highly recommend that you read http://lilypond.org/doc/v2.15/Documentation/contributor/summary-for-experienced-developers http://lilypond.or

mentor needed (was: Taking the old website down)

2011-12-21 Thread Graham Percival
On Wed, Dec 21, 2011 at 02:19:49PM +, Alberto Simões wrote: > > On 12/21/11 13:56 , Graham Percival wrote: > >I highly recommend that you read > >http://lilypond.org/doc/v2.15/Documentation/contributor/summary-for-experienced-developers > >http://lilypond.org/doc/v2.15/Documentation/contributo

Re: Build: Try to convince `make' to keep intermediate files. (issue5490077)

2011-12-21 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; Sent: Wednesday, December 21, 2011 3:18 PM Subject: Re: Build: Try to convince `make' to keep intermediate files. (issue5490077) On Wed, Dec 21, 2011 at 09:22:11AM -, Phil Holmes wrote: A general comment

Re: Build: Try to convince `make' to keep intermediate files. (issue5490077)

2011-12-21 Thread Graham Percival
On Wed, Dec 21, 2011 at 09:22:11AM -, Phil Holmes wrote: > A general comment on changes to the build system. How do we know > that there's been no unintended other effects of changes like this? > I think it would be wise to work up a system of checking, by doing > something like creating a lis

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-21 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; ; Sent: Wednesday, December 21, 2011 2:16 PM Subject: Re: Directs output of texi2html to log files (GOP 9) (issue 5495092) On Wed, Dec 21, 2011 at 09:29:31AM -, Phil Holmes wrote: I'll hold on this one a

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-21 Thread Graham Percival
On Wed, Dec 21, 2011 at 09:29:31AM -, Phil Holmes wrote: > I'll hold on this one and look again once Julien's patch is pushed. > As I said, it's almost inconceivable that there would be an error > from texi2pdf causing the build to fail. I've seen half a dozen in the past month. (my fault, it

Re: Problems with lilypond and lion?

2011-12-21 Thread Alberto Simões
On 12/20/11 19:54 , Hans Aberg wrote: On 20 Dec 2011, at 20:49, Alberto Simões wrote: If someone else could verify this (nice to get a second or third opinion) then perhaps this could be added to Documentation/web/download.itexi until we fix it or maybe added to the tracker - I don't want to

Re: Problems with lilypond and lion?

2011-12-21 Thread Alberto Simões
On 12/20/11 19:46 , Hans Aberg wrote: On 20 Dec 2011, at 20:00, James wrote: If someone else could verify this (nice to get a second or third opinion) then perhaps this could be added to Documentation/web/download.itexi until we fix it or maybe added to the tracker - I don't want to make more

Re: PATCH: Countdown to 20111222

2011-12-21 Thread Colin Campbell
On 11-12-21 02:59 AM, Phil Holmes wrote: Colin, Please remove my GOP9 patch for now - I'll re-introduce it when Julien's build patch is pushed. Phil Holmes Julien has pushed his Issue 2125 : Patch: Build: Don't rebuild everything e

Re: do not tinker with the position of a pitched rest (issue 5434061)

2011-12-21 Thread Benkő Pál
patch rebased http://codereview.appspot.com/5434061/ >>> >>> Unless you use the new git-cl to upload it, nobody will notice >>> that you have updated your patch. >>> manually change it from Patch-needs_work to Patch-new. > Added to the tracker as a committer. thanks, Phil; label up

Re: do not tinker with the position of a pitched rest (issue 5434061)

2011-12-21 Thread Phil Holmes
- Original Message - From: "Benko Pál" To: "Graham Percival" Cc: ; ; "Phil Holmes" Sent: Wednesday, December 21, 2011 10:34 AM Subject: Re: do not tinker with the position of a pitched rest (issue 5434061) hi Graham, 2011/12/20 Graham Percival : On Mon, Dec 19, 2011 at 08:41:3

Re: do not tinker with the position of a pitched rest (issue 5434061)

2011-12-21 Thread Benkő Pál
hi Graham, 2011/12/20 Graham Percival : > On Mon, Dec 19, 2011 at 08:41:36PM +, benko@gmail.com wrote: >> patch rebased >> >> http://codereview.appspot.com/5434061/ > > Unless you use the new git-cl to upload it, nobody will notice > that you have updated your patch. I used the new git-cl

Re: PATCH: Countdown to 20111222

2011-12-21 Thread Phil Holmes
Colin, Please remove my GOP9 patch for now - I'll re-introduce it when Julien's build patch is pushed. Phil Holmes - Original Message - From: Colin Campbell To: Devel Sent: Wednesday, December 21, 2011 4:31 AM Subject: PATCH: Countdown to 20111222 For 05:30 UTC Friday

Re: Changes to allow compiling with -Werror using gcc 4.6.2 on i386. (issue 5489092)

2011-12-21 Thread dak
On 2011/12/21 02:56:37, md5i wrote: http://codereview.appspot.com/5489092/diff/1/lily/parser.yy File lily/parser.yy (right): http://codereview.appspot.com/5489092/diff/1/lily/parser.yy#newcode36 lily/parser.yy:36: /* Define to get rid of conversion warning, int -> int16_t. I'd love to see a

Re: Directs output of texi2html to log files (GOP 9) (issue 5495092)

2011-12-21 Thread Phil Holmes
- Original Message - From: To: ; ; Cc: ; Sent: Tuesday, December 20, 2011 7:19 PM Subject: Re: Directs output of texi2html to log files (GOP 9) (issue 5495092) On 2011/12/19 20:53:49, Julien Rioux wrote: Oh, I don't mean to suggest to pull your patch. I don't know if mine survi

Re: Build: Try to convince `make' to keep intermediate files. (issue5490077)

2011-12-21 Thread Phil Holmes
- Original Message - From: To: Cc: ; Sent: Monday, December 19, 2011 11:37 PM Subject: Build: Try to convince `make' to keep intermediate files. (issue5490077) A general comment on changes to the build system. How do we know that there's been no unintended other effects of chang

Re: Shortest duration is *not* printed when running 'lilypond --verbose'

2011-12-21 Thread Xavier Scheuer
Sorry to come again with that. Should I request to add an issue to the tracker stating that 'lilypond --verbose' does not print common shortest duration (and should, as it supposedly did before, because it is what is explained in NR 4.5.1 Horizontal spacing overview) ? Cheers, Xavier On

Re: Doc: Usage added note for Windows Users (issue 5489072)

2011-12-21 Thread pkx166h
Reviewers: , Message: Wed, 21 Dec 2011 07:57:51 + (07:57 +) commit f3a43f0e3bbec46b4b82b4bd51d7482442163348 James Description: Doc: Usage added note for Windows Users Tracker 2090 Removed double quote from '-dpoint-and-click='f'' example (as it is unnecessary) so as to then make clar