Re: GOP-PROP 11: git repositories

2011-09-06 Thread Trevor Daniels
Janek Warchoł wrote Tuesday, September 06, 2011 8:22 PM 2011/9/6 Carl Sorensen : But your last statement forces a particular location. What if on my system I have a conflict with that location? I shouldn't be forced to do it. Currently, I don't use lilypond-git. And I don't do an out-of-t

Re: Adds a site search to website and improves doc search (issue 4894053)

2011-09-06 Thread Janek Warchoł
2011/8/26 : > I have grave doubts about adding a second search box. > 1) it makes the top bar uncomfortably squashed in my default web browser > window > 2) it requires users to choose which type of search they want to do. > > > #1 isn't about me forcing my desktop browser preferences on anybody,

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Graham Percival
On Tue, Sep 06, 2011 at 08:17:44PM +0200, Reinhold Kainhofer wrote: > Am Dienstag, 6. September 2011, 19:20:05 schrieb Graham Percival: > > What about just using environment variables, $LILYPOND_GIT and > > $LILYPOND_MEDIA_GIT, then telling the user to set up these > > variables by themselves? (po

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Janek Warchoł
2011/9/6 Carl Sorensen : > But your last statement forces a particular location.  What if on my system > I have a conflict with that location?  I shouldn't be forced to do it. > > Currently, I don't use lilypond-git.  And I don't do an out-of-tree build > (because it doesn't work for me on OS/X, an

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Carl Sorensen
On 9/6/11 11:25 AM, "Phil Holmes" wrote: >> -Original Message- >> From: Graham Percival [mailto:gra...@percival-music.ca] >> Sent: 06 September 2011 18:20 >> To: Phil Holmes >> Cc: 'Trevor Daniels'; lilypond-devel@gnu.org >> Subject: Re: GOP-PROP 11: git repositories >> >> On Tue, Sep 06

Re: Kievan square notation in LilyPond

2011-09-06 Thread Janek Warchoł
2011/9/5 Aleksandr Andreev : > Hi Janek, > >> >> Please report is these worked for you.  If so, i will update > > Just a thought: if you're editing the documentation, it would be > useful to indicate that git-cl pulls up an interface of vim and that > to get out of it, you use the standard vim comm

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Reinhold Kainhofer
Am Dienstag, 6. September 2011, 19:20:05 schrieb Graham Percival: > On Tue, Sep 06, 2011 at 06:14:57PM +0100, Phil Holmes wrote: > > > The only kind of person who's interested in those other > > > repositories will have their own favorite directory layout > > > anyway (like me; all my source reposi

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Reinhold Kainhofer
Am Dienstag, 6. September 2011, 19:14:57 schrieb Phil Holmes: > > -Original Message- > > From: Graham Percival [mailto:gra...@percival-music.ca] > > The only kind of person who's interested in those other > > repositories will have their own favorite directory layout > > anyway (like me; al

RE: GOP-PROP 11: git repositories

2011-09-06 Thread Phil Holmes
> -Original Message- > From: Graham Percival [mailto:gra...@percival-music.ca] > Sent: 06 September 2011 18:38 > To: Phil Holmes > Cc: 'Trevor Daniels'; lilypond-devel@gnu.org > Subject: Re: GOP-PROP 11: git repositories > > On Tue, Sep 06, 2011 at 06:25:34PM +0100, Phil Holmes wrote: > >

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Graham Percival
On Tue, Sep 06, 2011 at 06:25:34PM +0100, Phil Holmes wrote: > > -Original Message- > > From: Graham Percival [mailto:gra...@percival-music.ca] > > > > What about just using environment variables, $LILYPOND_GIT > > and $LILYPOND_MEDIA_GIT, then telling the user to set up > > these varia

RE: GOP-PROP 11: git repositories

2011-09-06 Thread Phil Holmes
> -Original Message- > From: Graham Percival [mailto:gra...@percival-music.ca] > Sent: 06 September 2011 18:20 > To: Phil Holmes > Cc: 'Trevor Daniels'; lilypond-devel@gnu.org > Subject: Re: GOP-PROP 11: git repositories > > On Tue, Sep 06, 2011 at 06:14:57PM +0100, Phil Holmes wrote: > >

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Graham Percival
On Tue, Sep 06, 2011 at 06:14:57PM +0100, Phil Holmes wrote: > > The only kind of person who's interested in those other > > repositories will have their own favorite directory layout > > anyway (like me; all my source repositories go under > > $HOME/src/) so they'd ignore any recommendation any

Re: include lines in breve X-extent (issue 1814) (issue 4931043)

2011-09-06 Thread lemniskata . bernoullego
Reviewers: janek, Bertrand Bordage, MikeSol, J_lowe, Ian Hulin (gmail), graham_percival-music.ca, Message: On 2011/09/06 16:26:40, Bertrand Bordage wrote: On 2011/09/06 08:54:40, janek wrote: > I'm not sure what you mean. Are you saying that i should assign (i * (gap + > stemthick), 0) to a

RE: GOP-PROP 11: git repositories

2011-09-06 Thread Phil Holmes
> -Original Message- > From: Graham Percival [mailto:gra...@percival-music.ca] > Sent: 06 September 2011 17:49 > To: Phil Holmes > Cc: 'Trevor Daniels'; lilypond-devel@gnu.org > Subject: Re: GOP-PROP 11: git repositories > > On Tue, Sep 06, 2011 at 05:45:19PM +0100, Phil Holmes wrote: > >

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Graham Percival
On Tue, Sep 06, 2011 at 05:45:19PM +0100, Phil Holmes wrote: > Another thought. We've established a standard (that not everyone adopts, > but it's still a standard) that the git repository is locally stored in > lilypond-git with the build being done in lilypond-git/build. Where would > these new

RE: GOP-PROP 11: git repositories

2011-09-06 Thread Phil Holmes
> -Original Message- > From: lilypond-devel-bounces+mail=philholmes@gnu.org > [mailto:lilypond-devel-bounces+mail=philholmes@gnu.org] > On Behalf Of Trevor Daniels > Sent: 06 September 2011 10:27 > To: Graham Percival; lilypond-devel@gnu.org > Subject: Re: GOP-PROP 11: git reposit

Re: Add some polyphonically directed grobs (issue 4387046)

2011-09-06 Thread bordage . bertrand
Ok, DynamicText and DynamicLineSpanner should be removed. But what about the others? * Simple trill is directed (as a Script), so TrillSpanner logically has to be directed. * Slurs, Ties and TupletBrackets are also directed, so I don't see any reason for LigatureBrackets to behave differently.

Re: Make accidental styles available as context mods. (issue 4819064)

2011-09-06 Thread David Kastrup
Reinhold Kainhofer writes: > Am Montag, 5. September 2011, 23:02:11 schrieb David Kastrup: >> #{..#} _is_ a direct Scheme construct interpreted at _read_ time in the >> Scheme reader. It is enabled in scm/parser-ly-from-scheme.scm with the >> line (read-hash-extend #\{ read-lily-expression). >>

Re: include lines in breve X-extent (issue 1814) (issue 4931043)

2011-09-06 Thread bordage . bertrand
On 2011/09/06 08:54:40, janek wrote: I'm not sure what you mean. Are you saying that i should assign (i * (gap + stemthick), 0) to a variable in the for loop? I.e. sth like for i := 0 step 1 until linecount - 1: foobar := (i * (gap + stemthick), 0);

RE: GOP-PROP 11: git repositories

2011-09-06 Thread Phil Holmes
> -Original Message- > From: Graham Percival [mailto:gra...@percival-music.ca] > Sent: 06 September 2011 15:26 > To: Phil Holmes > Cc: 'Trevor Daniels'; lilypond-devel@gnu.org > Subject: Re: GOP-PROP 11: git repositories > > On Tue, Sep 06, 2011 at 02:45:25PM +0100, Phil Holmes wrote:

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Graham Percival
On Tue, Sep 06, 2011 at 02:45:25PM +0100, Phil Holmes wrote: > > How easy is it to switch between the various git repositories? Would we > update lilygit, or reserve use of the new repositories for those who had > started to use terminal? It's not hard for command-line people. We would not upd

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Reinhold Kainhofer
Am Tuesday, 6. September 2011, 15:45:25 schrieb Phil Holmes: > How easy is it to switch between the various git repositories? It's really simple: git remote set-url origin [new-URL-comes-here] Or if you want to keep the old, simply create a new remote: git remote add newserver [new-URL-comes

RE: GOP-PROP 11: git repositories

2011-09-06 Thread Phil Holmes
> -Original Message- > From: lilypond-devel-bounces+mail=philholmes@gnu.org > [mailto:lilypond-devel-bounces+mail=philholmes@gnu.org] > On Behalf Of Trevor Daniels > Sent: 06 September 2011 10:27 > To: Graham Percival; lilypond-devel@gnu.org > Subject: Re: GOP-PROP 11: git repo

RE: please push patches

2011-09-06 Thread James Lowe
Hello )-Original Message- )From: Neil Puttock [mailto:n.putt...@gmail.com] )Sent: 05 September 2011 16:44 )To: Graham Percival )Cc: k-ohara5...@oco.net; Janek Warchoł; James Lowe; lilypond- )de...@gnu.org )Subject: Re: please push patches ) )On 4 September 2011 20:39, Graham Percival wrot

include lines in breve X-extent (issue 1814) (issue 4986042)

2011-09-06 Thread janek . lilypond
Reviewers: Bertrand Bordage, Ian Hulin (gmail), Message: New patch set uploaded, two of Bertrand's concerns addressed (i'm not sure what the third one means). this replaces 4931043. http://codereview.appspot.com/4986042/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): http://cod

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Graham Percival
On Tue, Sep 06, 2011 at 10:27:25AM +0100, Trevor Daniels wrote: > > Graham Percival wrote Monday, September 05, 2011 9:39 PM > > > >http://lilypond.org/~graham/gop/gop_11.html > > I'm happy with this proposal, but the origin/dev branches > are not mentioned explicitly. Presumably they remain > u

Re: include lines in breve X-extent (issue 1814) (issue 4931043)

2011-09-06 Thread Graham Percival
On Tue, Sep 06, 2011 at 08:54:40AM +, janek.lilyp...@gmail.com wrote: > I have new patch set ready, but i have trouble logging as another user > in git-cl (this issue was created by my previous e-mail account). Can > you give me some clue? Just make a new issue. Follow the instructions in th

Re: GOP-PROP 11: git repositories

2011-09-06 Thread Trevor Daniels
Graham Percival wrote Monday, September 05, 2011 9:39 PM http://lilypond.org/~graham/gop/gop_11.html I'm happy with this proposal, but the origin/dev branches are not mentioned explicitly. Presumably they remain unchanged? Trevor ___ lilypond-

Re: include lines in breve X-extent (issue 1814) (issue 4931043)

2011-09-06 Thread janek . lilypond
Ian, On 2011/08/30 10:29:42, Ian Hulin (gmail) wrote: Janek, Bertrand posted some review comments here. I think it would be polite in the case of a newer contributor like Bertrand to post some responses one way or another (either "don't worry about it, because. . ." or "nice catch, I'll uploa

Re: Added glyphs for Kievan Notation (issue 4951062)

2011-09-06 Thread janek . lilypond
LGTM. Only some minor style nitpicks; you may also wish to change commit's message (currently it says that there is only one glyph added). You can modify commit messages using git rebase -i origin/master http://codereview.appspot.com/4951062/diff/1/mf/feta-kievan.mf File mf/feta-kievan.mf (rig

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

2011-09-06 Thread Peekay Ex
Janek On Mon, Sep 5, 2011 at 9:54 PM, wrote: > James, > i see this patch is quite orphaned despite being very nice and > ready-to-go. Shall i push it for you? > > cheers, > Janek > > http://codereview.appspot.com/**4837050/ > Thanks for the offer, that's

Re: Prevents nested tuplets from colliding. (issue 4808082)

2011-09-06 Thread tdanielsmusic
Mike says this is not yet ready for pushing in comment #11. We should not push while he is away without his confirmation. Trevor http://codereview.appspot.com/4808082/diff/45009/lily/tuplet-bracket.cc File lily/tuplet-bracket.cc (right): http://codereview.appspot.com/4808082/diff/45009/lily/t