Graham, you wrote Wednesday, August 31, 2011 6:11 AM
On Tue, Aug 30, 2011 at 11:25:27PM +0100, Trevor Daniels wrote:
Graham, you wrote Tuesday, August 30, 2011 2:43 AM
>LARGE PATCHES
>
>SHORT PATCHES
I think just CODE PATCHES for these. It's
hard to think of a meaningful difference.
Numbe
Graham Percival percival-music.ca> writes:
> please add a new Critical issue for [profiles]. We can always mark it
> invalid later.
now issue 1858
> song-melisma.ly
The former extra space was issue 1779
> beam-feather-breaking.ly : lots of changes system spacing. Mike,
> IIRC feathered bea
On Wed, Aug 31, 2011 at 03:08:04AM +, Keith OHara wrote:
> I've looked closely at the changes with distance 5.0 or above, and
> looked quickly at the others. If one more person takes a shift
> starting at the small 'distances' that would be great.
5.0 and above? ok, I'll do the rest.
> One
Keith OHara oco.net> writes:
> Two unexpected spacing changes that I will investigate:
> beam-extreme.ly spacing-correction-accidentals.ly
The /new/ behavior is correct in these two tests.
(That is, the output matches the intent of the code)
I forgot to mention, tuplet brackets now span thei
On Tue, Aug 30, 2011 at 11:25:27PM +0100, Trevor Daniels wrote:
>
> Graham, you wrote Tuesday, August 30, 2011 2:43 AM
>
> >LARGE PATCHES
> >
> >SHORT PATCHES
>
> I think just CODE PATCHES for these. It's
> hard to think of a meaningful difference.
> Number of affected files, number of changed
On Mon, Aug 29, 2011 at 05:24:51PM +0100, Phil Holmes wrote:
> OK. My claim that this is fixed is partly down to the number of
> copies of web-big-page.html on the system after a build. It's fixed
> in the wrong one, but not fixed in the right one. To get my head
> fully around this, I think I n
http://codereview.appspot.com/4951047/diff/1/scripts/build/create-weblinks-itexi.py
File scripts/build/create-weblinks-itexi.py (right):
http://codereview.appspot.com/4951047/diff/1/scripts/build/create-weblinks-itexi.py#newcode31
scripts/build/create-weblinks-itexi.py:31: # Unable to find langd
sweet mao that's disgusting. I love it. :)
If you can make doc from scratch, then push.
http://codereview.appspot.com/4950053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Tue, Aug 30, 2011 at 11:45:39PM +0100, Trevor Daniels wrote:
>
> I vaguely remember having a problem with copying
> keys into Savannah. Something about avoiding
> returns in the middle of the key string. Did
> you ensure your copied string was all on a single
> line when you scraped it, or ha
Phil Holmes philholmes.net> writes:
> Or we could take shifts in checking images.
I've looked closely at the changes with distance 5.0 or above, and
looked quickly at the others. If one more person takes a shift
starting at the small 'distances' that would be great.
One concern: Cell counts
Ian, you wrote Hulin"
I can't set up the ssh connection properly, does anyone know if
this
configuration (which I have enabled on my router - public IP
address
87.12.149.79) will cause problems talking to the Savannah server
via
ssh? This is snip from my router's help.
"Block WAN Requests
Graham, you wrote Tuesday, August 30, 2011 2:43 AM
Rather, I'd like to have a clearer format for the countdowns. I'm
thinking of something like this:
SYNTAX CHANGES
tick
MAINTAINABILITY
tick
LARGE PATCHES
SHORT PATCHES
I think just CODE PATCHES for these. It's
hard to think of a m
Mike, passes make but during reg test check i get
--snip--
Failed files: (6c/lily-5110fb03.ly)
fatal error: Children (3) exited with errors.
command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond -I
/home/jlowe/lilypond-git/input/regression/ -I ./out-test -I
/home/jlowe/lilypond-git/inp
Passes make but get two reg tests show up that look ok but that need a
second opinion.
Attached on
http://code.google.com/p/lilypond/issues/detail?id=1854#c1
http://codereview.appspot.com/4387046/
___
lilypond-devel mailing list
lilypond-devel@gnu.o
sses make and reg tests and I ran a make doc too (seemed relevant) and
it failed
--snip--
tal error: failed files: "78/lily-63af708e.ly"
fatal error: Children (3) exited with errors.
command failed: /home/jlowe/lilypond-git/build/out/bin/lilypond
-dbackend=eps --formats=ps,png,pdf -djob-count=7
On Tue, Aug 30, 2011 at 8:58 AM, Mike Solomon wrote:
> On Aug 30, 2011, at 5:53 PM, joenee...@gmail.com wrote:
>
>> Correct me if I'm wrong, but this is my understanding: wherever there's
>> a SpanBar, you're creating SpanBarStubs between every relevant pair of
>> staves. These don't actually get
Passes make and reg test shows one change see attached on
http://code.google.com/p/lilypond/issues/detail?id=11#c14
probably expected.
http://codereview.appspot.com/4941041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org
http://codereview.appspot.com/4965053/diff/9004/scm/define-grob-properties.scm#newcode841
scm/define-grob-properties.scm:841: (stem-begin-position
,ly:dimension? "User
override for the
shouldn't this be number? ?
I'm not sure - what's the difference between the two types?
Someone more fam
On 2011/08/30 20:39:25, Trevor Daniels wrote:
Thanks Mike :)
LGTM (with one query) AFAICT in this complex area.
http://codereview.appspot.com/4965053/diff/9004/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
http://codereview.appspot.com/4965053/diff/9004/scm
Thanks Mike :)
LGTM (with one query) AFAICT in this complex area.
http://codereview.appspot.com/4965053/diff/9004/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
http://codereview.appspot.com/4965053/diff/9004/scm/define-grob-properties.scm#newcode841
scm/define-gro
Can you add a regtest for overriding Stem #'length?
http://codereview.appspot.com/4965053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hey all,
I've made a pretty significant change to this patch resulting from the
conversation on the list tonight. master builds clean and I'm halfway
into a clean doc build. Will check regtests tomorrow. I'd like this to
stay on the countdown in spite of the change, although if people want me
Graham Percival wrote Tuesday, August 30, 2011 1:17 PM
How about we make a "staging" branch in git, then encourage people
to push to "staging" instead of master? We will then have
somebody (probably James) merge from staging to master, after
checking that it builds completely.
Sounds like a
Am Dienstag, 30. August 2011, 19:40:31 schrieb Mike Solomon:
> In this case, it seems like the property should be called positions and not
> length. Length presupposes that the begin position remains constant and
> the end chagnes, whereas positions should take a pair that gives the
> bottom and t
Mike Solomon wrote Tuesday, August 30, 2011 6:40 PM
In this case, it seems like the property should
be called positions and not length.
Why, if it's a length?
Length presupposes that the begin position remains
constant
Exactly. That's why it's easy to understand. It
conveys exactly t
Mike Solomon writes:
> On Aug 30, 2011, at 7:17 PM, Keith OHara wrote:
>
>> Mike Solomon ufl.edu> writes:
>>
>>> As I stated in a previous mail, it is easy to re-instate
>>> a length property in the stem-interface and then
>>> build it into either Stem::internal_height or Stem::print.
>>> I
On Aug 30, 2011, at 7:17 PM, Keith OHara wrote:
> Mike Solomon ufl.edu> writes:
>
>> As I stated in a previous mail, it is easy to re-instate
>> a length property in the stem-interface and then
>> build it into either Stem::internal_height or Stem::print.
>> I have no problem with this.
>>
>
Mike Solomon ufl.edu> writes:
> As I stated in a previous mail, it is easy to re-instate
> a length property in the stem-interface and then
> build it into either Stem::internal_height or Stem::print.
> I have no problem with this.
>
The KEEP LENGTH option is the best,
because 'length and 'Y
On Aug 30, 2011, at 4:14 PM, Dmytro O. Redchuk wrote:
> On Tue 30 Aug 2011, 16:08 Mike Solomon wrote:
>> Currently, the stem stencil function is doable in Scheme, which means that
>> the result from 2.15.8 can be achieved via :
> Thank you for your work! I've "bookmarked" this hint/thread, of cour
On Aug 30, 2011, at 3:46 PM, Phil Holmes wrote:
> Well - there are too many differences on the official page for me to count.
> It was clearly going to be iffy when I looked at the "items still to load" in
> the browser and it was over 1100. In my pixel comparator, I've got 1,031
> difference
On Aug 30, 2011, at 5:53 PM, joenee...@gmail.com wrote:
> Correct me if I'm wrong, but this is my understanding: wherever there's
> a SpanBar, you're creating SpanBarStubs between every relevant pair of
> staves. These don't actually get printed; they're just there for the
> pure-height (because t
Phil Holmes philholmes.net> writes:
> the other
> is a slight spacing change - it looks like, as a general rule, 2.15.9 is
> slightly more compact on ragged-right versus 2.15.7 (which is my local
> baseline).
Due to the fix for issue 1779.
> I'll attach one difference file which I don't und
Correct me if I'm wrong, but this is my understanding: wherever there's
a SpanBar, you're creating SpanBarStubs between every relevant pair of
staves. These don't actually get printed; they're just there for the
pure-height (because the SpanBar height is pretty much the whole system,
so it doesn't
David
The documentation of \applyContext has not been touched
for several years (other than moving it around between
manuals.) It may well be quite out-of-date. This state
of affairs is because no one interested in documentation
understands it well enough and with enough confidence
to rewrite i
Mike, you wrote Tuesday, August 30, 2011 3:41 PM
As I stated in a previous mail, it is easy to
re-instate a length property in the stem-interface
and then build it into either Stem::internal_height
or Stem::print. I have no problem with this.
I'd vote for this. Let's see what others thin
David Kastrup writes:
> the documentation for applyOutput states
>
> `applyContext' - PROC (procedure)
> Modify context properties with Scheme procedure PROC.
[...]
> What's the deal here? Why this completely misleading
> characterization, documentation and description? What's with the n
Hi,
the documentation for applyOutput states
`applyContext' - PROC (procedure)
Modify context properties with Scheme procedure PROC.
After digging back and forth through documentation and scratching my
head, I have come to the conclusion that \applyContext is the
_canonical_ way to actuall
On Aug 30, 2011, at 3:04 PM, Trevor Daniels wrote:
>
> Mike Solomon wrote Tuesday, August 30, 2011 12:45 PM
>
>> I believe that Trevor is claiming that #(stem::length 5) is worse from a
>> UI-perspective than #5.
>
> Yes.
>> I think he is right insofar as stem::length means there are more t
- Original Message -
From: "Ian Hulin"
I can't set up the ssh connection properly, does anyone know if this
configuration (which I have enabled on my router - public IP address
87.12.149.79) will cause problems talking to the Savannah server via
ssh? This is snip from my router's help
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi all,
I'm still having problems with enabling push access to git.
On Wed 24 Aug 2011 13:52:13 BST, Ian Hulin wrote:
> Hi all, I've been getting problems setting up git push access to
> savanna.
>
> On 21/08/11 02:41, Graham Percival wrote:
>> My b
On Tue 30 Aug 2011, 16:08 Mike Solomon wrote:
> Currently, the stem stencil function is doable in Scheme, which means that
> the result from 2.15.8 can be achieved via :
Thank you for your work! I've "bookmarked" this hint/thread, of course.
I am still wondering, is stem the single grob so far, wh
On Aug 30, 2011, at 2:31 PM, Dmytro O. Redchuk wrote:
> On Tue 30 Aug 2011, 15:02 I wrote:
>> Being a user, I often used to override 'Y-extent for some specific purposes:
>>
>> {
>> \override Stem #'Y-extent = #'(-10 . 0)
>> c''_\fermata
>> }
> Oh, yes, 2.15.9 changes stem's length.
>
> 2.15.8
Well - there are too many differences on the official page for me to count.
It was clearly going to be iffy when I looked at the "items still to load"
in the browser and it was over 1100. In my pixel comparator, I've got 1,031
difference files to check.
There are 2 obvious causes of this: one
Hi,
On Sun, Jun 12, 2011 at 06:24:37PM +0100, Graham Percival wrote:
> > 2011/6/7 Graham Percival :
> > > Anybody interested in setting up a weekly chat? Either IRC or
> > > skype or some other chat protocol.
[...]
> Hmm, no overwhelming interest.
>
> Short-term: let's just make a conscious eff
On Aug 30, 2011, at 1:53 PM, Graham Percival wrote:
> On Tue, Aug 30, 2011 at 01:45:20PM +0200, Mike Solomon wrote:
>> In current master, #'Y-extent = #(stem::length 5) does exactly what #'length
>> = #5 did a week ago.
>
> There is essentially no different in going frmo
> \override Stem #'leng
I've been debugging a couple of 53 page spreadsheets in the last few
days, so I overlooked Mike's request below. Given the recent work on
flags and stems, I'd like to add his patch to last night's countdown.
Cheers,
Colin
Original Message
Subject: Going on vacation on Th
Mike Solomon wrote Tuesday, August 30, 2011 12:45 PM
I believe that Trevor is claiming that
#(stem::length 5) is worse from a UI-perspective
than #5.
Yes.
I think he is right insofar as stem::length
means there are more things to type,
No. That's not the point. A user wanting to
ch
On Tue 30 Aug 2011, 15:02 I wrote:
> Being a user, I often used to override 'Y-extent for some specific purposes:
>
> {
> \override Stem #'Y-extent = #'(-10 . 0)
> c''_\fermata
> }
Oh, yes, 2.15.9 changes stem's length.
2.15.8 and below did not change it.
2.15.8 and below changed grob's _ext
On Tue, Aug 30, 2011 at 02:11:31PM +0200, David Kastrup wrote:
> Graham Percival writes:
>
> > At least until we've had two more unstable releases (.9 and .10)
> > If you haven't tested your patch from a COMPLETELY EMPTY build
> > directory, done make and make docs FROM SCRATCH, then don't push
>
Graham Percival writes:
> Guys,
> --
> *** STOP PUSHING BROKEN STUFF TO MASTER. ***
> --
>
> At least until we've had two more unstable releases (.9 and .10)
> If you haven't tested your patch from a C
On Tue 30 Aug 2011, 12:53 Graham Percival wrote:
> On Tue, Aug 30, 2011 at 01:45:20PM +0200, Mike Solomon wrote:
> > In current master, #'Y-extent = #(stem::length 5) does exactly what
> > #'length = #5 did a week ago.
>
> There is essentially no different in going frmo
> \override Stem #'lengt
On Tue, Aug 30, 2011 at 01:45:20PM +0200, Mike Solomon wrote:
> In current master, #'Y-extent = #(stem::length 5) does exactly what #'length
> = #5 did a week ago.
There is essentially no different in going frmo
\override Stem #'length = #5
to
\override Stem #'Y-extent = #5
as far as users a
On Aug 30, 2011, at 1:27 PM, Graham Percival wrote:
> On Tue, Aug 30, 2011 at 01:07:46PM +0200, Mike Solomon wrote:
>> Bad: the user has to use a new syntax - instead of \override Stem #'length =
>> #5, they need to type \override Stem #'Y-extent = #(stem::length 5)
>
> What's the difference (fr
On Tue, Aug 30, 2011 at 01:07:46PM +0200, Mike Solomon wrote:
> Bad: the user has to use a new syntax - instead of \override Stem #'length =
> #5, they need to type \override Stem #'Y-extent = #(stem::length 5)
What's the difference (from your end) between #(stem::length 5)
and #5 ?
> A mid-way
On Aug 30, 2011, at 12:06 PM, Trevor Daniels wrote:
>
> Mike Solomon wrote Monday, August 29, 2011 9:11 AM
>
>> On Mon, Aug 29, 2011 at 07:45:04AM +, tdanielsmu...@googlemail.com wrote:
>>
>>> I can't say I like this change: it makes a complex user
>>> interface more complex. Shouldn't we
Janek,
Bertrand posted some review comments here.
I think it would be polite in the case of a newer contributor like
Bertrand to post some responses one way or another (either "don't worry
about it, because. . ." or "nice catch, I'll upload an updated patch
set".)
Cheers,
Ian
http://codereview.
Mike Solomon wrote Monday, August 29, 2011 9:11 AM
On Mon, Aug 29, 2011 at 07:45:04AM +,
tdanielsmu...@googlemail.com wrote:
I can't say I like this change: it makes a complex user
interface more complex. Shouldn't we be moving in the
opposite direction?
I disagree.
[snip descriptio
Hey all,
In this e-mail are a few tips if (when) you find a bug that comes from my
recent Stem, Flag, and Tremolo work.
***
* FLAG extents are still kludgy. You'll see that in Flag::width, the value
returned is a half stem-width thinner than the actual width. This is done to
reflect how the
- Original Message -
From: "Graham Percival"
To:
Sent: Tuesday, August 30, 2011 8:10 AM
Subject: Re: merging regtests
On Tue, Aug 30, 2011 at 06:39:06AM +0100, Graham Percival wrote:
On Tue, Aug 30, 2011 at 06:25:44AM +0100, Graham Percival wrote:
> As a temporary workaround, I will
Guys,
--
*** STOP PUSHING BROKEN STUFF TO MASTER. ***
--
At least until we've had two more unstable releases (.9 and .10)
If you haven't tested your patch from a COMPLETELY EMPTY build
directory, done m
On Tue, Aug 30, 2011 at 06:39:06AM +0100, Graham Percival wrote:
> On Tue, Aug 30, 2011 at 06:25:44AM +0100, Graham Percival wrote:
> > As a temporary workaround, I will now reduce the number of
> > regression tests. In particular, I will merge the segfault
> > regtests -- we don't care about the
Thanks Han-Wen!
Cheers,
MS
http://codereview.appspot.com/4917046/diff/1/lily/align-interface.cc
File lily/align-interface.cc (right):
http://codereview.appspot.com/4917046/diff/1/lily/align-interface.cc#newcode399
lily/align-interface.cc:399: Align_interface::vertical_sort (Grob *g1,
Grob *g2)
62 matches
Mail list logo
