On Tue, Aug 30, 2011 at 8:58 AM, Mike Solomon <mike...@ufl.edu> wrote: > On Aug 30, 2011, at 5:53 PM, joenee...@gmail.com wrote: > >> Correct me if I'm wrong, but this is my understanding: wherever there's >> a SpanBar, you're creating SpanBarStubs between every relevant pair of >> staves. These don't actually get printed; they're just there for the >> pure-height (because the SpanBar height is pretty much the whole system, >> so it doesn't tell you where the gaps are). >> > > Yes. > >> If that's correct, I have two broad comments: it's worth commenting >> somewhere (span-bar-stub-engraver.cc, maybe) that the purpose of >> SpanBarStub is for pure-height only. > > Will do. > >> But more importantly, isn't SpanBar >> now obsoleted by SpanBarStub? That is, you can just remove the SpanBar >> altogether and print the SpanBarStubs. >> > > Mmm...you're not unright, but I'd prefer to do that in another patch if > that's OK. It'd require a lot of deleting and moving around, and I'd first > like to make sure that these stubs are the code base and bug free for a while > before I deprecate an entire grob (and figure out how to deal with the syntax > changes that come with said deprecation).
Ok, then lgtm. Probably worth putting in a comment that we intend to remove SpanBar. Cheers, Joe _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
