Re: modifying default behaviour of tremolo slashes (issue4636081)

2011-07-10 Thread joeneeman
Actually, non-rectangular, constant-sloped beams used to be the default, but I changed them (some years ago now) to be rectangular and parallel to the beam, since that's what most of my scores have. My music collection isn't with me right now, but I can confirm at least that B&H's urtext edition o

Re: Fix 1676: Properly count the notes in a chord tremolo (ignore all non-note events) (issue4685049)

2011-07-10 Thread pkx166h
This passes a make but fails a reg test check --snip-- Processing 6b/lily-e3e71d48 Processing f3/lily-989d2907 Processing 56/lily-9940850d Processing 7c/lily-568fad2b error: Children (1) exited with errors. command failed: /home/jlowe/lilypond-git/out/bin/lilypond -I ./ -I ./out-test -I ../../inp

Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055)

2011-07-10 Thread Carl Sorensen
On 7/10/11 4:41 PM, "Neil Puttock" wrote: > On 10 July 2011 23:34, Carl Sorensen wrote: > >> Ahh, thanks.  Fixed now: >> >> { >>  \new Voice \with  { >>    \consists Ambitus_engraver >>    \consists Mensural_ligature_engraver > > Heh, you didn't have to do this; I meant the missing quotati

Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055)

2011-07-10 Thread Neil Puttock
On 10 July 2011 23:34, Carl Sorensen wrote: > Ahh, thanks.  Fixed now: > > { >  \new Voice \with  { >    \consists Ambitus_engraver >    \consists Mensural_ligature_engraver Heh, you didn't have to do this; I meant the missing quotation marks around the engraver names. :) (and now you've added

Re: Does type checking for all context property sets. (issue4654090)

2011-07-10 Thread Reinhold Kainhofer
Am Sonntag, 10. Juli 2011, 23:19:13 schrieb pkx1...@gmail.com: > Passes make and reg tests - I'd open a tracker if I understood what this > was about :) that's actually a fix for bug 1734 (since it prevents the user from setting the properties in a layout block to a wrong type, which would then l

Re: Does type checking for all context property sets. (issue4654090)

2011-07-10 Thread pkx166h
Passes make and reg tests - I'd open a tracker if I understood what this was about :) http://codereview.appspot.com/4654090/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055)

2011-07-10 Thread Carl Sorensen
On 7/10/11 3:09 PM, "Neil Puttock" wrote: > On 7 July 2011 23:22, wrote: >> On 2011/07/07 16:12:08, Neil Puttock wrote: >>> >>> LGTM, though the regtest is still a bit messy. >> >> What do you consider messy about the regtest? > > Just a few nitpicks: > > +\score{ > > + \context Staff="def

Re: Fix segfault with ambitus and ligature (Issue 1715) (issue4667055)

2011-07-10 Thread Neil Puttock
On 7 July 2011 23:22, wrote: > On 2011/07/07 16:12:08, Neil Puttock wrote: >> >> LGTM, though the regtest is still a bit messy. > > What do you consider messy about the regtest? Just a few nitpicks: +\score{ + \context Staff="default" { + \context{ + \consists Ambitus_engraver + \consists Me

Fix 1581: Only NoteEvents can cause a tie. Ignore all other events that create note heads (issue4686047)

2011-07-10 Thread n . puttock
LGTM. http://codereview.appspot.com/4686047/diff/1/lily/tie-engraver.cc File lily/tie-engraver.cc (right): http://codereview.appspot.com/4686047/diff/1/lily/tie-engraver.cc#newcode275 lily/tie-engraver.cc:275: { remove braces http://codereview.appspot.com/4686047/

Re: an example of minimal example (issue4636082)

2011-07-10 Thread lemniskata . bernoullego
New patch set uploaded. I think that everything works now. cheers, Janek http://codereview.appspot.com/4636082/diff/10003/Documentation/css/lilypond-website.css File Documentation/css/lilypond-website.css (right): http://codereview.appspot.com/4636082/diff/10003/Documentation/css/lilypond-webs

Re: print transposed guitar chords on piano sheets (issue4626094)

2011-07-10 Thread Neil Puttock
On 8 July 2011 04:37, Carl Sorensen wrote: > The grob has everything that is necessary to create the printed output.  You > can't apply a music function to a grob, but you can apply a scheme function > to the music contents of the grob.  So rather than translate the chord (a > music event), you'l

Re: PATCH: 48-hour countdown

2011-07-10 Thread Colin Campbell
On 11-07-09 09:08 PM, Carl Sorensen wrote: On 7/9/11 8:43 PM, "Colin Campbell" wrote: 21:00 MST Monday A paltry pile of patches presented, presumably prior patches (of which there are a metric shedload marked for review) preoccupying people. Issue 1735

Re: Does type checking for all context property sets. (issue4654090)

2011-07-10 Thread n . puttock
On 2011/07/10 21:32:43, mike_apollinemike.com wrote: New patchset uploaded - is that the sorta thing you're talking about? I can change the name of the variable to something else if you think that'd work better. Hah, that's a bit too much. :) A more descriptive name than `ok' will do (e.

Re: PATCH: 48-hour countdown

2011-07-10 Thread Jan Warchoł
2011/7/10 Carl Sorensen : > On 7/9/11 8:43 PM, "Colin Campbell" wrote: > >>    21:00 MST Monday >> >>  A paltry pile of patches presented, presumably prior patches (of which there >> are a metric shedload marked for review) preoccupying people. >> >>  Issue 1735

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-10 Thread lemniskata . bernoullego
Graham, I'm worried that i don't hear anything from you since 2 weeks! Do you experience any problems with fixing code style issues pointed to by Neil? If you are very busy, i can fix them myself, but i'd prefer that you fix them and send me the collection of all patches, up-to-date (this will mi

Re: Converting ly to musicxml

2011-07-10 Thread Jan Warchoł
2011/7/10 cab : > Converting from midi to ly is possible, but ly to musicxml has never > been done... So my plan is to program it myself > I think I would do it in python as musicxml2ly is also written in python. > > If I manage to do it , will it be possible to add it in the source tree ? If done

[PATCH] Fix 1390: Add slashedGrace function (graces with slashed stems but no slur, e.g. when the grace is tied)

2011-07-10 Thread Reinhold Kainhofer
Please review: http://codereview.appspot.com/4670056 Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial & Actuarial Math., Vienna Univ. of Technology, Austria * http://www.

Re: Does type checking for all context property sets. (issue4654090)

2011-07-10 Thread m...@apollinemike.com
On Jul 10, 2011, at 11:04 PM, n.putt...@gmail.com wrote: > > http://codereview.appspot.com/4654090/diff/8001/lily/context.cc > File lily/context.cc (right): > > http://codereview.appspot.com/4654090/diff/8001/lily/context.cc#newcode496 > lily/context.cc:496: assert (ok); > This doesn't tell you

Re: Issue 1482 in lilypond: \caps and \smallCaps don't work with \fromproperty

2011-07-10 Thread Colin Campbell
On 11-07-09 05:27 PM, lilyp...@googlecode.com wrote: Comment #1 on issue 1482 by elliot.w...@gmail.com: \caps and \smallCaps don't work with \fromproperty http://code.google.com/p/lilypond/issues/detail?id=1482 I just ran into this bug. Until it gets fixed, is there a workaround (other than

Fix 1676: Properly count the notes in a chord tremolo (ignore all non-note events) (issue4685049)

2011-07-10 Thread n . puttock
http://codereview.appspot.com/4685049/diff/1/input/regression/chord-tremolo-other-commands.ly File input/regression/chord-tremolo-other-commands.ly (right): http://codereview.appspot.com/4685049/diff/1/input/regression/chord-tremolo-other-commands.ly#newcode3 input/regression/chord-tremolo-other

Re: Suggestions for a Contemporary Music Font

2011-07-10 Thread Janek Warchoł
2011/7/10 Bernardo Barros : > I'm thinking of creating a font for contemporary music with the most > commonly used symbols. > I miss a lot of specific symbols and I'm sure a lot of LilyPond users do too. > > I know that there are some sources for this purpose, and find them very > useful. > But mo

Re: Fix 750: No warning for non-found voice in lyrics combine when lyrics are empty (issue4641097)

2011-07-10 Thread n . puttock
LGTM. http://codereview.appspot.com/4641097/diff/1/input/regression/lyric-combine-empty-warning.ly File input/regression/lyric-combine-empty-warning.ly (right): http://codereview.appspot.com/4641097/diff/1/input/regression/lyric-combine-empty-warning.ly#newcode1 input/regression/lyric-combine-e

[PATCH] Fix 1676: Properly count the notes in a chord tremolo (ignore all non-note events)

2011-07-10 Thread Reinhold Kainhofer
Please review: http://codereview.appspot.com/4685049 Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial & Actuarial Math., Vienna Univ. of Technology, Austria * http://www.

Re: Does type checking for all context property sets. (issue4654090)

2011-07-10 Thread n . puttock
http://codereview.appspot.com/4654090/diff/8001/lily/context.cc File lily/context.cc (right): http://codereview.appspot.com/4654090/diff/8001/lily/context.cc#newcode496 lily/context.cc:496: assert (ok); This doesn't tell you anything about the assertion failure (unlike the existing code). http:

[PATCH] Fix 1581: Only NoteEvents can cause a tie. Ignore all other events that create note heads

2011-07-10 Thread Reinhold Kainhofer
Please review: http://codereview.appspot.com/4686047 Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial & Actuarial Math., Vienna Univ. of Technology, Austria * http://www.

Re: GOP-PROP 5: build system output

2011-07-10 Thread Matthias Kilian
On Sun, Jul 10, 2011 at 01:10:05PM +0200, Reinhold Kainhofer wrote: > But we don't solve the problem of the log output. I mean, how many people > really **want** the full output from the build system? What about a *default* output similar to what you now get with QUIET_BUILD=1? That is currently

Re: GOP-PROP 5: build system output

2011-07-10 Thread Phil Holmes
- Original Message - From: "Reinhold Kainhofer" To: Sent: Sunday, July 10, 2011 12:10 PM Subject: Re: GOP-PROP 5: build system output Am Sonntag, 10. Juli 2011, 12:50:19 schrieb Phil Holmes: - Original Message - From: "Graham Percival" > On Thu, Jul 07, 2011 at 01:16:21PM +

Re: Converting ly to musicxml

2011-07-10 Thread cab
Le 10/07/2011 12:26, Valentin Villenave a écrit : > On Sun, Jul 10, 2011 at 11:46 AM, Martin Tarenskeen > wrote: >> I guess the idea was to make it possible to export MusicXML directly from >> Lilypond (just like midi, png, pdf, and postscript), re-using Lilypond >> parsing-code that is available

Re: GOP-PROP 5: build system output

2011-07-10 Thread Matthias Kilian
On Sun, Jul 10, 2011 at 11:53:08AM +0100, Phil Holmes wrote: > >Little bit difficult as it seems, so here's a simple version (without > >the combined log). You can invoke it like this: > > > >lilylog.sh o.log e.log ls -l . dontexist > > > >which is the `verbose' mode (i.e. you still see stdout and

Re: Converting ly to musicxml

2011-07-10 Thread Reinhold Kainhofer
Am Sonntag, 10. Juli 2011, 12:26:31 schrieb Valentin Villenave: > On Sun, Jul 10, 2011 at 11:46 AM, Martin Tarenskeen > > wrote: > > I guess the idea was to make it possible to export MusicXML directly from > > Lilypond (just like midi, png, pdf, and postscript), re-using Lilypond > > parsing-cod

Re: GOP-PROP 5: build system output

2011-07-10 Thread Jan Nieuwenhuizen
Phil Holmes writes: > My concern with this is that we may get a lot of people surprised and > confused by this Probably not. Linux and Git have been doing this for years and autoconf/automake is also adopting this convention. Everyone building packages knows to use --disable-silent-rules or jus

Re: GOP-PROP 5: build system output

2011-07-10 Thread Reinhold Kainhofer
Am Sonntag, 10. Juli 2011, 12:50:19 schrieb Phil Holmes: > - Original Message - > From: "Graham Percival" > > On Thu, Jul 07, 2011 at 01:16:21PM +0100, Graham Percival wrote: > > I think we should use logfiles by default -- actually, we should > > use logfiles exclusively -- and then displ

Re: GOP-PROP 5: build system output

2011-07-10 Thread Phil Holmes
- Original Message - From: "Matthias Kilian" To: "Graham Percival" ; Sent: Thursday, July 07, 2011 2:40 PM Subject: Re: GOP-PROP 5: build system output On Thu, Jul 07, 2011 at 02:59:37PM +0200, Matthias Kilian wrote: Wouldn't it be better to either collect both stdout and stderr in

Re: GOP-PROP 5: build system output

2011-07-10 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: Sent: Friday, July 08, 2011 2:00 PM Subject: Re: GOP-PROP 5: build system output On Thu, Jul 07, 2011 at 01:16:21PM +0100, Graham Percival wrote: * We do not change the output of make, make doc, or any of the other make comm

Re: Converting ly to musicxml

2011-07-10 Thread Valentin Villenave
On Sun, Jul 10, 2011 at 11:46 AM, Martin Tarenskeen wrote: > I guess the idea was to make it possible to export MusicXML directly from > Lilypond (just like midi, png, pdf, and postscript), re-using Lilypond > parsing-code that is available anyway? And Scheme is the language that > integrates perf

Re: Converting ly to musicxml

2011-07-10 Thread Martin Tarenskeen
On Sun, 10 Jul 2011, cab wrote: This is something I proposed to the French users list earlier this year and it got a lukewarm response from the community (save several well-thought-out responses from Scheme and/or musicxml and/or accessibility enthusiasts). I have started some sketches for

Re: Converting ly to musicxml

2011-07-10 Thread Reinhold Kainhofer
Am Sonntag 10 Juli 2011, 11:14:36 schrieb m...@apollinemike.com: > On Jul 10, 2011, at 10:56 AM, cab wrote: > > Converting from midi to ly is possible, but ly to musicxml has never > > been done... So my plan is to program it myself > > I think I would do it in python as musicxml2ly is also written

Re: Converting ly to musicxml

2011-07-10 Thread cab
Le 10/07/2011 11:23, Jan Nieuwenhuizen a écrit : > cab writes: > >> However I think it would be easier to convert ly to musicxml > > This starts to be a faq. Have a look at scm/to-xml.scm > >> (in fact i want to convert like this : midi -> ly -> musicxml). > > This puzzles me, doesn't google s

Re: Converting ly to musicxml

2011-07-10 Thread cab
Le 10/07/2011 11:14, m...@apollinemike.com a écrit : > On Jul 10, 2011, at 10:56 AM, cab wrote: > >> Hi, >> >> >> I have been using lilypond for 3 years in my projects: >> http://www.psautiers.org (this is the website on which I am currently >> working on), and http://www.score-catcher.org (the si

Re: Converting ly to musicxml

2011-07-10 Thread Jan Nieuwenhuizen
cab writes: > However I think it would be easier to convert ly to musicxml This starts to be a faq. Have a look at scm/to-xml.scm > (in fact i want to convert like this : midi -> ly -> musicxml). This puzzles me, doesn't google show you several midi2xml converters? Jan. -- Jan Nieuwenhuizen

Re: Converting ly to musicxml

2011-07-10 Thread m...@apollinemike.com
On Jul 10, 2011, at 10:56 AM, cab wrote: > Hi, > > > I have been using lilypond for 3 years in my projects: > http://www.psautiers.org (this is the website on which I am currently > working on), and http://www.score-catcher.org (the sister site) in which > I convert musicxml to lilypond and then

Converting ly to musicxml

2011-07-10 Thread cab
Hi, I have been using lilypond for 3 years in my projects: http://www.psautiers.org (this is the website on which I am currently working on), and http://www.score-catcher.org (the sister site) in which I convert musicxml to lilypond and then I put the score online. The thing is that the musicxml

Re: Does type checking for all context property sets. (issue4654090)

2011-07-10 Thread mtsolo
On 2011/07/08 12:56:40, c_sorensen_byu.edu wrote: The statistical conclusion has to be "no slow-down". Thanks, Carl New patch set uploaded that keeps do_internal_type_checking_global. Cheers, MS http://codereview.appspot.com/4654090/ ___ l