Graham, I'm worried that i don't hear anything from you since 2 weeks! Do you experience any problems with fixing code style issues pointed to by Neil? If you are very busy, i can fix them myself, but i'd prefer that you fix them and send me the collection of all patches, up-to-date (this will minimize the risk of messing something up). If you encounter any problems with git, i'll gladly help.
cheers, Janek On 2011/06/26 13:13:50, Neil Puttock wrote:
LGTM.
http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc File lily/midi-item.cc (right):
http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc#newcode202
lily/midi-item.cc:202: + audio_->transposing_.tone_pitch ()) *
Rational (2));
indent:
((audio_ + audio
http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc#newcode203
lily/midi-item.cc:203: return (tune > 0)? int (tune + 0.5): int(tune -
0.5);
int (rint (tune));
http://codereview.appspot.com/4654063/diff/1/lily/midi-item.cc#newcode216
lily/midi-item.cc:216: finetune = PITCH_WHEEL_CENTER +
get_fine_tuning();
get_fine_tuning ();
http://codereview.appspot.com/4654063/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
