Looks, and sounds, good to me.
http://codereview.appspot.com/4654063/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Hello,
From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
[lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Reinhold
Kainhofer [reinh...@kainhofer.com]
Sent: 26 June 2011 01:05
To: lilypond-devel@gnu.org
Subject: Re: LSR Partc
Am Sonntag, 26. Juni 2011, 00:59:24 schrieb James Lowe:
> Hello,
>
> I'd like someone else's opinion please?
>
> http://lsr.dsi.unimi.it/LSR/Item?id=704
>
> It states in one line
>
> "\partcombine apparently works with 3 voices -- stem up single, stem down
> single, stem up combined."
>
> yet
Reviewers: Graham Percival,
Message:
2nd Draft. Thanks for the comments Graham.
http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-notes.itexi
File Documentation/contributor/build-notes.itexi (right):
http://codereview.appspot.com/4641074/diff/1/Documentation/contribu
Reviewers: ,
Message:
To address
http://code.google.com/p/lilypond/issues/detail?id=1643
I realise this is slightly more than the above issue asks for :) but I
hope you like the edits and it improves this section.
I certainly learnt some 'stuff'.
James
Description:
Doc: NR @knownissue for p
On Sun, Jun 26, 2011 at 12:32:52AM +0200, Reinhold Kainhofer wrote:
> Am Sonntag, 26. Juni 2011, 00:14:59 schrieben Sie:
> > Yes, that was introduced in
> > 3623cfc12bb53499a591ae45ac61931bafc6bf20
> >
> > We've had some discussions about how to fix it, and we have a
> > solid plan, but we didn'
hello,
From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
[lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Reinhold
Kainhofer [reinh...@kainhofer.com]
Sent: 25 June 2011 23:13
To: lilypond-devel@gnu.org
Subject: Re: 'Translat
Hello,
I'd like someone else's opinion please?
http://lsr.dsi.unimi.it/LSR/Item?id=704
It states in one line
"\partcombine apparently works with 3 voices -- stem up single, stem down
single, stem up combined."
yet in the NR it explicitly states that \partcombine only works with 2 voices.
So
On 11-06-25 02:13 PM, lemniskata.bernoull...@gmail.com wrote:
Graham Breed wrote:
I've found and patched two problems with the pitch bend
tuning code:
1) The pitch isn't always rounded to the nearest equally
tempered value, so the result looks strange in a sequencer,
and artifacts caused by the
Am Sonntag, 26. Juni 2011, 00:08:17 schrieb Graham Percival:
> On Sat, Jun 25, 2011 at 09:54:18PM +, James Lowe wrote:
> > --snip--
> > @code{\partcombine} only observes onset times of notes. It cannot
> > determine whether a previously started note is playing or not, leading
> > to various pr
On Sat, Jun 25, 2011 at 11:56:53PM +0200, Reinhold Kainhofer wrote:
> PS: If "make check" fails, it does not give ANY indication where it fails or
> how to get any information about the offending file. All it says is:
Yes, that was introduced in
3623cfc12bb53499a591ae45ac61931bafc6bf20
We've h
On Sat, 25 Jun 2011 13:24:28 -0700, Jan Warchoł
wrote:
have you considered fixing issue 39 by shortening the flag (as we're
going to have plenty of shortened flags available)? Or maybe
shortening a flag a bit and lenghtening the stem a bit would be the
best solution?
Yes, and that simplifie
On Sat, Jun 25, 2011 at 09:54:18PM +, James Lowe wrote:
> --snip--
> @code{\partcombine} only observes onset times of notes. It cannot
> determine whether a previously started note is playing or not, leading
> to various problems.
> --snip--
My initial guess is that if you have
c1
r2 c2
(
Finally, I found a way to fix issues #1259 and #1433. Patch is up at:
http://codereview.appspot.com/4630070
Please review!
Fix issues 1259 and 1433 (\breakDynamicSpan and a spanner's style=#'none over
a line break)
With \breakDynamicSpan and \override DynamicTextSpanner #'style = #'none
the Dy
On 2011/06/25 21:50:08, J_lowe wrote:
On 2011/06/25 19:42:38, Reinhold wrote:
> On 2011/06/25 19:32:49, Colin Campbell wrote:
> > I believe James or I could work with you on the documentation, as
> > well.
>
> That would be nice. It would only require extending the docs for
lilypond-book
> wit
The previous commit 7bcdd37be15ece09cd97841137b075a576bbe696 ("Fixes issue
1706, issues a programming error at old assert error.") by Mike Solomon breaks
make check, as the regtest issues lots of programming_error calls:
beam-skip.ly:17:33: Programmierfehler: must have Item for spanner bound of
Hello,
Can someone explain in more simple terms (perhaps with an example) what
--snip--
@code{\partcombine} only observes onset times of notes. It cannot
determine whether a previously started note is playing or not, leading
to various problems.
--snip--
means?
I'm just making a new patch to t
On 2011/06/25 19:42:38, Reinhold wrote:
On 2011/06/25 19:32:49, Colin Campbell wrote:
> I believe James or I could work with you on the documentation, as
> well.
That would be nice. It would only require extending the docs for
lilypond-book
with those additional commands and their options.
On Wed, Jun 22, 2011 at 1:30 AM, Graham Percival
wrote:
> I’m going to make the bold step of assuming that we will eliminate
> tabs in all C++ files. I personally like the idea of tabs, but
> from an examination of source code styles (both official and
> unofficial) in various projects, I must adm
Jan Nieuwenhuizen writes:
> Graham Percival writes:
>
>> I think we need to go here.
>
> No. There will be no progress, warning or error messages to stdout.
stdout is usually line-buffered (like stdin), so progress messages are
not really useful.
The GNU utilities take the distinction between
Hi,
have you considered fixing issue 39 by shortening the flag (as we're
going to have plenty of shortened flags available)? Or maybe
shortening a flag a bit ang lenghtening the stem a bit would be the
best solution?
As Carl found a way to separate flags from noteheads in font
(http://codereview.a
- Original Message -
From:
To: ; ;
Cc: ;
Sent: Saturday, June 25, 2011 7:42 PM
Subject: Re: Add feta-flags to build system (issue4662055)
LGTM - is there any way to get this in a pixel comparator w/ the
previous flags just to be certain that it doesn't cause any problems to
the fla
2011/6/25 Graham Percival
>
> On Sat, Jun 25, 2011 at 09:18:13PM +0200, Jan Warchoł wrote:
> > I understand that i should call these in separate branches, not in master.
> > janek@janek-lilydev5:~/lilypond-git$ git branch astyle
>
> That creates a new branch. I think you should have done the
> g
Reviewers: gbreed,
Message:
Graham Breed wrote:
I've found and patched two problems with the pitch bend
tuning code:
1) The pitch isn't always rounded to the nearest equally
tempered value, so the result looks strange in a sequencer,
and artifacts caused by the pitch bends are more severe.
2)
Am Samstag, 25. Juni 2011, 20:09:50 schrieb Matthias Kilian:
> On Sat, Jun 25, 2011 at 05:27:03PM +0100, Graham Percival wrote:
> > 1. what's the official unix definition of STDERR vs. STDOUT?
>
> Quoting the standard:
>
> 3.358 Standard Error
> An output stream usually intended to be
Am Samstag, 25. Juni 2011, 19:21:53 schrieb Phil Holmes:
> I think we need to cover it properly - based on past experience it's likely
> to generate some heated discussion.
Yes, I also think that we should properly discuss the console output of
lilypond and probably different log levels.
> I als
Reviewers: colinpkcampbell_gmail.com,
Message:
On 2011/06/25 19:32:49, Colin Campbell wrote:
If this is still alive, Reinhold, I'd like to give it an entry on the
issue
tracker.
Yes, it's still alive. I can't remember what issues I encountered back
when I wrote the patch, though.
The purpos
Reviewers: colinpkcampbell_gmail.com,
Message:
On 2011/06/25 19:31:00, Colin Campbell wrote:
Just tidying up a bit: has this been superceded by the fix to issue
1671?
No, that patch is for a totally unrelated problem, namely that for e.g.
<6> <3 6 9>
the 3 (and of course the 9) will be place
Reviewers: carl.d.sorensen_gmail.com, MikeSol,
Message:
This is an intermediate step that will be needed for shortened flags.
Description:
Flag functions instead of defining glyphs directly
We will need many length variants of every flag.
Therefore instead of writing flag code directly
in glyph
If this is still alive, Reinhold, I'd like to give it an entry on the
issue tracker. I believe James or I could work with you on the
documentation, as well.
cheers,
Colin
http://codereview.appspot.com/1659041/
___
lilypond-devel mailing list
lilypond
Just tidying up a bit: has this been superceded by the fix to issue
1671? If so, the reitveld issue could be closed.
cheers,
Colin
http://codereview.appspot.com/224052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mail
On Sat, Jun 25, 2011 at 09:18:13PM +0200, Jan Warchoł wrote:
> W dniu 23 czerwca 2011 00:03 użytkownik Carl Sorensen
> napisał:
> >
> > For the short term, you can do
> >
> > git pull origin dev/gperciva-fixcc
> > git pull origin dev/gperciva-astyle
> >
> > to get those branches.
>
> I understand
On Sat, Jun 25, 2011 at 08:58:43PM +0200, Jan Nieuwenhuizen wrote:
> Graham Percival writes:
>
> > I think we need to go here.
>
> No. There will be no progress, warning or error messages to stdout.
But we *do* have progress messages on stderr. This makes sense to
some people, but doesn't make
2011/6/22 Graham Percival
>
> On Wed, Jun 22, 2011 at 12:11:36PM -0600, Carl Sorensen wrote:
> > I think that the implied obligation is saying "Mike will help people who are
> > playing with beam collision avoidance."
>
> Perhaps the word "expectation" would better express my worry.
Ah, expectati
W dniu 23 czerwca 2011 00:03 użytkownik Carl Sorensen
napisał:
>
> For the short term, you can do
>
> git pull origin dev/gperciva-fixcc
> git pull origin dev/gperciva-astyle
>
> to get those branches.
I understand that i should call these in separate branches, not in master.
...something doesn't
Carl!
Woot! It works! I compiled it twice, and everything looks fine!!
I told you you are a genious, didn't i? :D
Do i understand correctly that a variable is available to all fonts
(fet_beginfont ... fet_endfont) which are in the same mf file - it's so
simple?
So you solved the problem by callin
On Sat, 25 Jun 2011 03:53:40 -0700, wrote:
Keith: are you still interested in tackling this problem? I know there
have been some changes in note-collision.cc, so I'll likely scrap this
patch and start from scratch,
I purposely put it off until 2.14 was out.
Looking at it now, I am more motiv
Graham Percival writes:
> I think we need to go here.
No. There will be no progress, warning or error messages to stdout.
> 3. do we believe in the general unix statement "no news is good
> news", in which case why does "lilypnond foo.ly" spam out 16 lines
> of text? (regardless of whether tha
LGTM - is there any way to get this in a pixel comparator w/ the
previous flags just to be certain that it doesn't cause any problems to
the flags. The last time I reviewed a flag-related patch, I gave it the
green light only to find that I was failing to see some slight but
important variations.
Graham Percival percival-music.ca> writes:
> >
> > Stdout is used for valuable program output, stderr for any kind of
> > message, including progress. The name stdERR is possibly somewhat
> > unfortunate and comes from the days that unix commands would only
> > print something (to stdERR) if the
On Sat, Jun 25, 2011 at 05:27:03PM +0100, Graham Percival wrote:
> 1. what's the official unix definition of STDERR vs. STDOUT?
Quoting the standard:
3.358 Standard Error
An output stream usually intended to be used for diagnostic messages.
[...]
3.360 Standard
- Original Message -
From: "Graham Percival"
0. (meta-question) do we think that we can resolve this once and
for all right now, or should we wait a month to cover it as a
GOP-PROP ? If we discuss it now, then I do *not* want to have it
left hanging (as we've done the last 3-4 times w
Mon, 11:00
Implements multiple-line non-cross-staff glissandi
http://codereview.appspot.com/4527086
Cheers,
Colin
--
The human race has one really effective weapon, and that is laughter.
-- Mark Twain
___
lilypond-devel mailing list
lilypond-d
On Sat, Jun 25, 2011 at 3:12 AM, Marc Mouries wrote:
> Is there a doc about opus-libre with examples?
It mainly amounts to a README file for now:
http://git.savannah.gnu.org/cgit/opus-libre.git/tree/doc
As far as examples go, there's the Free Software Song included by
default, and there are seve
On Jun 24, 2011, at 5:58 PM, James Lowe wrote:
> Oops
>
> From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
> [lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of
> pkx1...@gmail.com [pkx1...@gmail.com]
> Sent: 24 June 2011 16
looks decent
http://codereview.appspot.com/4662055/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/06/25 07:15:39, J_lowe wrote:
I get an error/seg fault when I try to make:
I can confirm this.
http://codereview.appspot.com/4580041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-dev
On Thu, Jun 23, 2011 at 01:44:59PM +0200, Jan Nieuwenhuizen wrote:
> Carl Sorensen writes:
>
> >>> it should redirect non-error output to the file, and errors should appear
> >>> in the terminal.
>
> Stdout is used for valuable program output, stderr for any kind of
> message, including progress.
mostly fine, but a few problems that definitely shouldn't be pushed.
http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-notes.itexi
File Documentation/contributor/build-notes.itexi (right):
http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-no
On 2011/01/13 11:23:28, mikesol_ufl.edu wrote:
Thanks Keith,
I think that the case you're talking about (<< e'32. \\ e'2>>) is a
problem with
my code, which triggers stem raising for flags that fall on the right
even
though these flags do note cause intersection problems. Is there a
good
On Jun 24, 2011, at 5:20 PM, Han-Wen Nienhuys wrote:
> On Fri, Jun 24, 2011 at 11:40 AM, wrote:
>> Reviewers: ,
>>
>> Message:
>> I found this 10-month old patch of mine laying around. It still seems
>> relevant, so I'm sending it to the list. Lemme know what y'all think.
>
> What would this
Graham Percival wrote:
> However, for patch 1 he will first remove the change to
> configure.in; we now require at least fontforge 20100501.
Oh, sorry, I didn't realize that had gone in. I don't need
to compile the fonts, but I need to convince the build
process that I'm able to.
Hello,
I get an error/seg fault when I try to make:
(sorry of this a bit verbose)
make runs 'for a bit' then I get
--snip--
ezh --header=texidoc --header=texidoccs --header=texidocde
--header=texidoces --header=texidocfr --header=texidochu
--header=texidocit --header=texidocja --header=texidoc
53 matches
Mail list logo
