mostly fine, but a few problems that definitely shouldn't be pushed.
http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-notes.itexi File Documentation/contributor/build-notes.itexi (right): http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-notes.itexi#newcode445 Documentation/contributor/build-notes.itexi:445: LOOP=+$(foreach i, $(SUBDIRS), $(MAKE) PACKAGE=$(PACKAGE) \ I don't think you should change any example showing exact lines from files. Make this @smallexample, but if that still exceeds the line width, leave it alone. http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-notes.itexi#newcode589 Documentation/contributor/build-notes.itexi:589: Found prerequisite `out-www/version.itexi' as VPATH \ ditto http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-notes.itexi#newcode614 Documentation/contributor/build-notes.itexi:614: $(outdir)/%.texi: $(outdir)/%.tely $(outdir)/version.itexi \ ditto http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-notes.itexi#newcode627 Documentation/contributor/build-notes.itexi:627: $(outdir)/%.texi: $(outdir)/%.tely $(outdir)/version.itexi \ ditto http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/build-notes.itexi#newcode643 Documentation/contributor/build-notes.itexi:643: LILYPOND_VERSION=2.15.0 /usr/bin/python --process=' ' \ this is ok, since it's "the exact input turns into this command". http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/programming-work.itexi File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/4641074/diff/1/Documentation/contributor/programming-work.itexi#newcode405 Documentation/contributor/programming-work.itexi:405: set statusline=%F%m%r%h%w\ %{&ff}\ %Y\ [ASCII=\%03.3b]\ / I'm not certain if .vimrc files allow \ continuations. Could you either look it up, or remove this if you're at all uncertain? http://codereview.appspot.com/4641074/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
