http://codereview.appspot.com/4243060/diff/1/lily/staff-symbol.cc
File lily/staff-symbol.cc (left):
http://codereview.appspot.com/4243060/diff/1/lily/staff-symbol.cc#oldcode72
lily/staff-symbol.cc:72: span_points[d] += x->extent (x, X_AXIS)[d];
it's reasonable for people to want the staff to env
thanks, added here:
http://code.google.com/p/lilypond/issues/detail?id=1600
http://codereview.appspot.com/4367042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
umm. Getting into Canadian politics?
added here:
http://code.google.com/p/lilypond/issues/detail?id=1599
http://codereview.appspot.com/4384046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-deve
thanks, added here:
http://code.google.com/p/lilypond/issues/detail?id=1506
http://codereview.appspot.com/4253059/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
no wait, this one is old. Ignore.
http://codereview.appspot.com/4243060/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Thanks, added to
http://code.google.com/p/lilypond/issues/detail?id=1506
http://codereview.appspot.com/4243060/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
ok, deadline definitely passed. Please push.
http://codereview.appspot.com/4313047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
ok, deadline definitely passed. Please push.
http://codereview.appspot.com/4323045/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
@Valentin's overall comment: we've had 2 or 3 people on -devel asking
about this functionality in 2011, so I think it's definitely worth
demonstrating the possibility -- and in many cases, the current file is
enough for whatever they'd want to do. (maybe after adding one or two
more things, such
Reviewers: ,
Message:
Fixes the problem flagged by Reinhold regarding the spacing between the
footer and the footnotes by adding footnote-footer-padding to the paper
bloc.
Description:
Adds footnote-footer-padding to the paper bloc.
Please review this at http://codereview.appspot.com/4384046/
Hey all,
The command:
{
\cadenzaOn
a128*38 [ e'128*38/2 a128*38/3 e'128*38/4 a128*38/5 e'128*38/6 a128*38/7
e'128*38/8 a128*38/9 e'128*38/10 a128*38/11 e'128*38/12 a128*38/13 e'128*38/14
a128*38/15 e'128*38/16 a128*38/17 e'128*38/18 a128*38/19 e'128*38/20 a128*38/21
e'128*38/22 a128*38/23 e'12
On 4/7/11 4:08 PM, "Mark Polesky" wrote:
> Carl (et al.),
>
> I think your commit a3b2f9e changed the appearance of the
> image in NR 4.4.1 that demonstrates "reference points":
>
> http://lilypond.org/doc/v2.13/Documentation/notation/flexible-vertical-spacing
> -within-systems#within_002dsyste
Suggested rewording, accommodating Carl's suggestion.
Otherwise, looks fine.
Trevor
http://codereview.appspot.com/4388041/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4388041/diff/1/Documentation/notation/rhythms
On 2011/04/07 12:10:14, J_lowe wrote:
Graham, for now the c9landscape size is already included in the reg
test you set
Nope -- it's commented out. Remember that
@c
is a comment line. Please uncomment the c9landscape line, then remove
the c9 line.
Cheers,
- Graham
http://codereview.appspot.c
Carl (et al.),
I think your commit a3b2f9e changed the appearance of the
image in NR 4.4.1 that demonstrates "reference points":
http://lilypond.org/doc/v2.13/Documentation/notation/flexible-vertical-spacing-within-systems#within_002dsystem-spacing-properties
The reference points for ChordNames
On Thu, Apr 07, 2011 at 11:23:45PM +0200, Jan Warchoł wrote:
> I see some, but they were pushed by you. Should i close them too or is
> this message aimed at people with git push ability?
Please close those rietveld issues. I cannot do that, since they
are owned by you :)
Cheers,
- Graham
Am Donnerstag, 7. April 2011, um 23:23:45 schrieb Jan Warchoł:
> 2011/4/7 Graham Percival :
> > Hi guys,
> >
> > If you've put anything on rietveld recently, please go here:
> > http://codereview.appspot.com/mine
> >
> > You'll probably see a bunch of issues under "created by me". If you
> > rec
2011/4/7 Graham Percival :
> Hi guys,
>
> If you've put anything on rietveld recently, please go here:
> http://codereview.appspot.com/mine
>
> You'll probably see a bunch of issues under "created by me". If you
> recognize anything that you pushed, could you go to that issue, click
> on "edit iss
Hi,
unfortunately I just tried pushing a cosmetic change from a detached
HEAD, and instead my master branch has been pushed.
I have reverted the unsuitable commits for now and apologize for the
inconvenience.
--
David Kastrup
___
lilypond-devel mai
On Thu, Apr 07, 2011 at 02:13:56PM +, James Lowe wrote:
> Hello
>
> )Or even simpler, just click on the circled X on the left of each patch in the
> )"Created by me" section to close it.
Oh, excellent!
> Yes but it is nice if that person can indicate, perhaps with a commit number,
> when it
Looks generally good, but I think we need to include the error message
text in the @knownissue.
Thanks,
Carl
http://codereview.appspot.com/4388041/diff/1/Documentation/notation/rhythms.itely
File Documentation/notation/rhythms.itely (right):
http://codereview.appspot.com/4388041/diff/1/Docum
Hello
)-Original Message-
)From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of Marc Hohl
)Sent: 07 April 2011 11:07
)To: Lily-Devel List; Carl D. Sorensen
)Subject: [Patch] Including mandolin fretboard
http://codereview.appspot.com/4388041
James
<>___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hello
)-Original Message-
)From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of Reinhold Kainhofer
)Sent: 07 April 2011 14:09
)To: lilypond-devel@gnu.org
)Subject: Re: please close rietveld issues after
Valentin Villenave writes:
> On Thu, Apr 7, 2011 at 9:27 AM, David Kastrup wrote:
>> @@ -910,12 +908,10 @@ then revert skipTypesetting."
>> (let*
>> ((show-last (ly:parser-lookup parser 'showLastLength))
>> (show-first (ly:parser-lookup parser 'showFirstLength))
>> - (show-l
http://codereview.appspot.com/4373046/diff/1/ly/event-listener.ly
File ly/event-listener.ly (right):
http://codereview.appspot.com/4373046/diff/1/ly/event-listener.ly#newcode36
ly/event-listener.ly:36: (string-concatenate (list
Move close brackets up to previous argument
'instrumentName)))
http
Greetings Graham,
this looks acceptable to me, although I'm certainly not the most
qualified person in this regard.
Are you quite sure this really is generic enough, though? There are a
few hardcoded things here, and more inconveniently this approach means
you have to manually choose which events
Am Donnerstag, 7. April 2011, 01:46:33 schrieb Graham Percival:
> Hi guys,
>
> If you've put anything on rietveld recently, please go here:
> http://codereview.appspot.com/mine
>
> You'll probably see a bunch of issues under "created by me". If you
> recognize anything that you pushed, could you
On 2011/04/06 22:34:54, Graham Percival wrote:
On 2011/04/06 21:47:34, Graham Percival wrote:
> ... no wait, we do! hmm... I'll look into this. It might be a bit
tricky, so
> I'll handle it myself.
Yeah, it was a bit tricky. But done now:
http://git.savannah.gnu.org/gitweb/?p=lilypond.g
Reviewers: Graham Percival,
Message:
On 2011/04/06 21:47:34, Graham Percival wrote:
I don't think we want to add papersize_test.tely to the repository.
...
Could you create a second version of the patch which does not include
paper-test.tely ?
Done.
Description:
Added new Pagesize definitio
On Thu, Apr 7, 2011 at 9:27 AM, David Kastrup wrote:
> @@ -910,12 +908,10 @@ then revert skipTypesetting."
> (let*
> ((show-last (ly:parser-lookup parser 'showLastLength))
> (show-first (ly:parser-lookup parser 'showFirstLength))
> - (show-last-length (if (ly:music? show-last)
On Apr 6, 2011, at 10:30 PM, Carl Sorensen wrote:
> On 4/6/11 7:32 PM, "mts...@gmail.com" wrote:
>
>> Reviewers: ,
>>
>> Message:
>> Before pushing the stem patch (thanks to Trevor and Han Wen for the
>> LGTMs), I'd like to push this one. It allows for beam collision to
>> happen momentarily o
On Thu, Apr 07, 2011 at 10:50:21AM +, James Lowe wrote:
> I'd have to apply the patch to my git and then I'd see it more
> clearly, but am not sure if this is the most efficient way.
~~
Wow, you're talking like a git expert already! Yes, "git am" is
the way that you would apply
Hello
)-Original Message-
)From: lilypond-devel-bounces+james.lowe=datacore@gnu.org
)[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On
)Behalf Of Marc Hohl
)Sent: 07 April 2011 11:07
)To: Lily-Devel List; Carl D. Sorensen
)Subject: [Patch] Including mandolin fretboard
Hello all,
according to
http://lists.gnu.org/archive/html/lilypond-user/2011-03/msg00260.html
I added mandolin fretboards and hopefully included the stuff correctly
in the documentation.
Regards,
Marc
From 6933e27f08ac93330511946f3c69b887aeefc1a9 Mon Sep 17 00:00:00 2001
From: Marc Hohl
On Wed, Apr 06, 2011 at 10:36:15AM +0200, Janek Warchoł wrote:
> 2011/4/4 Graham Percival
> > Think about it this way: how many times have you reviewed my build
> > system patches, or Colin's documentation patches? The same
> > reasons why you don't review those patches apply to people looking
>
Reviewers: ,
Message:
First version of Vivi event listener. This is my first attempt at
non-trivial scheme work; please be gentle. I fully expect to take half
a dozen revisions before it's ok to push.
Description:
Event listener to extract (some) music events.
This may be useful on its own,
Graham Percival wrote Thursday, April 07, 2011 12:46 AM
If you've put anything on rietveld recently, please go here:
http://codereview.appspot.com/mine
You'll probably see a bunch of issues under "created by me". If
you
recognize anything that you pushed, could you go to that issue,
click
---
scm/music-functions.scm | 65 +--
1 files changed, 29 insertions(+), 36 deletions(-)
diff --git a/scm/music-functions.scm b/scm/music-functions.scm
index ed96cfd..9790cbf 100644
--- a/scm/music-functions.scm
+++ b/scm/music-functions.scm
@@ -655,8
39 matches
Mail list logo
