Re: Add dots to tocItemMarkup (issue4182056)

2011-02-18 Thread bordage . bertrand
I added a "dir" argument to \pattern, so that we can get vertical repeats. Also made a changelog item. Bertrand http://codereview.appspot.com/4182056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypon

Re: a present for Graham

2011-02-18 Thread Janek Warchoł
2011/2/17 Graham Percival : > On 2/17/11, Janek Warchoł wrote: >> I wanted to make Graham happy, so looked through the tracker, picked >> an existing frog issue and made a patch without discussing it for 5 >> hours. > > Yay!  :) May i have a kiss? ;P >> Unfortunately i got an error and i don't u

Re: Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2011-02-18 Thread Graham Percival
On 2/18/11, Han-Wen Nienhuys wrote: > On Fri, Jan 28, 2011 at 12:17 PM, wrote: >> >> I'm very sorry about the delay, but at least I'm looking at it now, and >> I'll take care of badgering people to review it once it's ready. > > Nitpick: if this were called something like "change internal pitch

Re: Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2011-02-18 Thread Han-Wen Nienhuys
On Fri, Jan 28, 2011 at 12:17 PM, wrote: > Hi Felipe, > > I'm very sorry about the delay, but at least I'm looking at it now, and > I'll take care of badgering people to review it once it's ready. > Nitpick: if this were called something like "change internal pitch representation" in the first l

Re: Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2011-02-18 Thread Han-Wen Nienhuys
On Fri, Feb 18, 2011 at 3:43 AM, wrote: > I advise against changing the internal representation of pitches. I am rather skeptic against patches that would want to do this, but from a casual glance, it looks thorough at least, and I understand that the current system is too limited still. What m

Re: Fix 1229 Ensure space around prefatory matter (issue4187043)

2011-02-18 Thread Trevor Daniels
From: Thursday, February 17, 2011 6:32 PM Ok, it seems we're all ok with this. Keith, please email the patch to Trevor for pushing. http://codereview.appspot.com/4187043/ Pushed: 6d751144f402dc58ff3f65df0fcaab021a86908c and reg tests bumped to 2.13.51: 6ca2619b3ae13ae94b8f43b124e92d86e

Re: Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2011-02-18 Thread David Kastrup
"Keith OHara" writes: > In the end, I'm a physicist, and pitch is a scalar, so a > one-dimensional real-valued representation seems wisest to me. Since "real-valued" means a fuzzy and undefined set of rational numbers with denominators of the form 2^k for which not even associative law holds, I

Re: Issue 1278: Arrow notation for quarter-tones. (issue3789044)

2011-02-18 Thread Keith OHara
On Thu, 17 Feb 2011 21:58:28 -0800, wrote: On 2011/02/18 05:43:36, Keith wrote: The extra complication, for which the care was given, makes the system more difficult to learn, understand, use, and repair. Unfortunately, I believe that the extra complication is necessary. The commit message d