On Tue, Aug 11, 2009 at 11:36:28PM -0700, Mark Polesky wrote:
> Am I forgetting anything here?
Yikes, did we really decide to @funindex a non-slashed version of
the command? ick.
Anyway, your patch looks fine. Go ahead and push. :)
Cheers,
- Graham
PS what about this? Of course, we'd need t
On Tue, Aug 11, 2009 at 11:36:28PM -0700, Mark Polesky wrote:
> Am I forgetting anything here?
Nope, looks good.
-Patrick
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Am I forgetting anything here?
Thanks.
- Mark
From f6c36eb89454713a5860c06f3bb8a5a087779594 Mon Sep 17 00:00:00 2001
From: Mark Polesky
Date: Tue, 11 Aug 2009 23:33:03 -0700
Subject: [PATCH] Add @funindex for \f.
---
Documentation/notation/expressive.itely |2 ++
1 files change
John Mandereau wrote:
> If you think about it more than a second, you can hardly cause trouble
> by modifying a few lines of ly snippets in translated documentation
> files.
Well, I could imagine causing trouble by omitting some step
that I don't know about... like when I didn't know about
adding
Carl Sorensen wrote:
> This should be in the CG but isn't. Graham summarized this earlier, but I
> couldn't find the message.
>
> You copy the snippet from Documentation/snippets to
> Documentation/snippets/new.
>
>
> You eliminate the comment at the top that says "This snippet was
> automatic
Mark Polesky wrote:
Michael,
Don't forget, you need to mention on -devel that you've posted
to Rietveld, and include the link. You'll also need to close
it when it's approved/resolved (CG 8.7.9).
Here's Michael's patch:
http://codereview.appspot.com/104085
- Mark
Hi Mark,
first I was uns
2009/8/12 Johannes Schindelin :
> Fixed and pushed.
Yep, verified. Many thanks once again! I think this can be very useful
for new contributors.
Max
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond
Could you add some regression tests (doesn't have to be in this commit)
that demonstrate some of the possible combinations of margin settings?
There should also be some tests that demonstrate the warnings.
http://codereview.appspot.com/104085/diff/1/4
File lily/output-def.cc (right):
http://cod
On Tue, 2009-08-11 at 20:03 -0700, Patrick McCarty wrote:
> On Mon, Aug 10, 2009 at 07:02:39AM +0200, Werner LEMBERG wrote:
> > Another improvement would be to provide `shaped metrics': Currently,
> > the metrics for a glyph consist of a single rectangle. This could be
> > extended to a list of re
On Tue, Aug 11, 2009 at 02:30:53PM +0200, John Mandereau wrote:
> Le mardi 11 août 2009 à 04:46 -0700, Graham Percival a écrit :
> > Odd behavior: if I rm -rf target/*/build/lilypond*,
> > target/*/src/lilypond*, target/*/status/lilypond*, and
> > target/*/installer/lilypond* (I'm trying to be sa
On 8/11/09 8:30 PM, "Mark Polesky" wrote:
>
>
> When doing a convert-ly rule, do I update snippets/regression tests?
The correct question is: When changing syntax, what do I do besides writing
a convert-ly rule?
The proper answer is: You apply it to the snippets to make sure it works.
Th
On Mon, Aug 10, 2009 at 07:02:39AM +0200, Werner LEMBERG wrote:
>
> > Also, in the case of Metafont glyphs, there doesn't appear to be a
> > clear convention: some bounding boxes are underestimated, but others
> > are overestimated.
>
> What you call `bounding boxes' aren't real bboxes but the me
On Tue, 2009-08-11 at 16:44 +0200, Werner LEMBERG wrote:
> >> Regarding your "Top" context: why do you override VerticalAxisGroup
> >> #'Y-extent = ##f? This is likely to confuse the layout algorithm
> >> even after the bug I mentioned is fixed.
> >
> > This was necessary for the old vertical lay
Michael Käppler wrote:
> For a single commit it is enough to do just git-cl upload without having
> to pass a commitish.
> Maybe it would be useful to add this information to CG 8.7.7, too.
Michael,
Don't forget, you need to mention on -devel that you've posted
to Rietveld, and include the lin
When doing a convert-ly rule, do I update snippets/regression tests?
These two pop up with "grep pad-markup":
Documentation/snippets/blanking-staff-lines-using-the--whiteout-command.ly
input/regression/whiteout.ly
What should I do with these?
- Mark
(moved to lilypond-devel)
On Tue, 2009-08-11 at 00:22 +0100, Neil Puttock wrote:
> 2009/8/10 Joe Neeman :
>
> > If there's a \bar "" and a clef in the same place, then the
> > BreakAlignGroup will have a non-empty extent, but I think we still want
> > the column to be loose.
>
> I'm not sure tha
On Tue, 2009-08-11 at 21:57 +0100, Neil Puttock wrote:
> Hi Joe,
>
> While fixing the last bug with the new instrument name code, I noticed
> that the instrument name positioning for both inicipit snippets
> (Documentation/snippets/incipit.ly and input/regression/incipit.ly)
> has changed for the
GUB builds the binaries, but fails in dist-check. However, I'm
baffled by the Documentation/css/ files -- they *are* present in
the tarball generated by "make dist". Any thoughts?
file from VC not distributed:
lilypond-2.13.4/Documentation/css/lilypond-blue.css
file from VC not distributed:
l
Hi,
On Tue, 11 Aug 2009, Mark Polesky wrote:
> Trevor Daniels wrote:
>
> > Does that mean shallow clones are inadvisable on Windows?
>
> I'll let Johannes confirm, but I think that shallow clones should be
> fine on Windows now. I got the sense that he "killed the beast" last
> night. It was
Thanks for the reply Michael.
Usually we like to keep responses to reviews on the -devel list, so I've
copied this there.
On 8/11/09 5:51 PM, "Michael Käppler" wrote:
> Hi Carl,
> thanks for your review:
>> Don't use lmargin, rmargin, and lwidth as variable names. LilyPond
>> standards c
On Tue, Aug 11, 2009 at 11:18:33AM -0700, Mark Polesky wrote:
>
> My "concept glossary" idea is now called a "technical glossary".
> I thought the name was fine when it was suggested, but now I'm
> realizing something -- I'd also like it to list terms that are not
> specifically dealing with LilyP
It's completely separate from git.
The easiest way to get it is to clone the repository,
git clone git://neugierig.org/git-cl.git
then add symlinks for the scripts `git-cl' and `upload.py'.
Neil (or someone), can you add this info to the CG?
For a single commit it is enough to do ju
Neil Puttock wrote:
This and the following docstring lines are too long.
Is there a common line length for docstrings? This should also be
mentioned in the CG, I think.
+ Real paper_width = scm_to_double (lookup_variable (ly_symbol2scm
("paper-width")));
+ Real left_margin_default = scm_t
2009/8/11 Michael Käppler :
> here is the first draft of a patch concerning the margin settings for
> review.
Some comments:
+ "Checks whether @code{left-margin}, @code{right-margin}
and @code{line-width)"
{line-width}
This and the following docstring lines are too long.
+ Real pap
2009/8/11 Mark Polesky :
> Neil (or someone), can you add this info to the CG?
Sure, will do.
Regards,
Neil
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Neil Puttock wrote:
> It's completely separate from git.
>
> The easiest way to get it is to clone the repository,
>
> git clone git://neugierig.org/git-cl.git
>
> then add symlinks for the scripts `git-cl' and `upload.py'.
Neil (or someone), can you add this info to the CG?
Thanks.
- Mark
2009/8/11 Michael Käppler :
> Thanks, Mark. I've updated my git package and installed git-web but git-cl
> doesn't work for me.
> Doesn't it belong to the normal git package?
It's completely separate from git.
The easiest way to get it is to clone the repository,
git clone git://neugierig.org/g
Mark Polesky wrote:
See CG 8.7.7 "Post patch for comments":
http://kainhofer.com/~lilypond/Documentation/contributor/Adding-or-modifying-features.htm
Thanks, Mark. I've updated my git package and installed git-web but
git-cl doesn't work for me.
Doesn't it belong to the normal git package?
Che
Hi Joe,
While fixing the last bug with the new instrument name code, I noticed
that the instrument name positioning for both inicipit snippets
(Documentation/snippets/incipit.ly and input/regression/incipit.ly)
has changed for the worse. By a process of elimination, I've traced
the change to your
Mark Polesky wrote Tuesday, August 11, 2009 7:18 PM
My "concept glossary" idea is now called a "technical glossary".
I thought the name was fine when it was suggested, but now I'm
realizing something -- I'd also like it to list terms that are not
specifically dealing with LilyPond *internals*.
On 8/11/09 12:47 PM, "Mark Polesky" wrote:
>
>
> Han-Wen Nienhuys wrote:
>> They were an in-crowd joke at some point, but I think the joke
>> has lasted long enough. I approve of changes that bring
>> regularity in this file naming scheme.
>
> Then I propose the following Dutch->English ch
Le mardi 11 août 2009 à 21:01 +0100, Neil Puttock a écrit :
> 2009/8/11 John Mandereau :
>
> > Why don't you just convert-ly docs after having written the convert-ly
> > rule and compiled convert-ly?
>
> Is this possible on Windows? (I've never tried it myself).
It should be doable in theory, as
2009/8/11 John Mandereau :
> Why don't you just convert-ly docs after having written the convert-ly
> rule and compiled convert-ly?
Is this possible on Windows? (I've never tried it myself).
Regards,
Neil
___
lilypond-devel mailing list
lilypond-deve
- Original Message
> From: Han-Wen Nienhuys
> To: Mark Polesky
> Cc: Werner LEMBERG ; lilypond-devel@gnu.org
> Sent: Tuesday, August 11, 2009 11:57:48 AM
> Subject: Re: Guidelines for bounding boxes?
>
> On Tue, Aug 11, 2009 at 3:47 PM, Mark Poleskywrote:
> >> They were an in-crowd
Le mardi 11 août 2009 à 10:45 -0700, Mark Polesky a écrit :
> When grepping for pad-markup, two hits are from translated docs.
> Do I just silently modify them, or do I need to notify the
> translators?
Why don't you just convert-ly docs after having written the convert-ly
rule and compiled conver
Hi guys,
Am I the only one who sometimes hits Ghostscript failure below?
I have a x86_64 Fedora 11 box, I previously used a post-8.64 Git
snapshot of Ghostscript, which I just replaced with released version
8.70 (all self-compiled); I got this failure with post-8.64, and no
longer got it with 8.7
2009/8/11 Mark Polesky :
> When grepping for pad-markup, two hits are from translated docs.
> Do I just silently modify them, or do I need to notify the
> translators?
Modifying them is OK, as long as you don't change any non-snippet
documentation (see CG 8.7.3, `Write documentation')
You could
> feta-pendaalfeta-pedal
Perhaps feta-pedalsigns?
> feta-accordion feta-accordion
feta-accordionsigns?
> feta-timesigfeta-timesig
feta-timesignatures?
Werner
___
lilypond-devel mailing list
lilypond-devel@gnu
On Tue, Aug 11, 2009 at 3:47 PM, Mark Polesky wrote:
>> They were an in-crowd joke at some point, but I think the joke
>> has lasted long enough. I approve of changes that bring
>> regularity in this file naming scheme.
>
> Then I propose the following Dutch->English changes:
>
> feta-banier
Han-Wen Nienhuys wrote:
> They were an in-crowd joke at some point, but I think the joke
> has lasted long enough. I approve of changes that bring
> regularity in this file naming scheme.
Then I propose the following Dutch->English changes:
feta-banier feta-flags
feta-beugel
2009/8/11 John Mandereau :
> Getting the Y-offset of InstrumentName seems to be really needed in this
> particular snippet; I'll probably push the dirty fix below to be able to
> complete the docs build (plus a FIXME in the texidoc) until this snippet
> is really fixed.
Sorry for the delay, John;
My "concept glossary" idea is now called a "technical glossary".
I thought the name was fine when it was suggested, but now I'm
realizing something -- I'd also like it to list terms that are not
specifically dealing with LilyPond *internals*. Such as:
the archives
the LSR
the tracker
Rietveld
Sav
Le mardi 11 août 2009 à 15:44 +0200, John Mandereau a écrit :
> It looks like a grob suicides in Documentation/snippets/incipit.ly, as I
> get the backtrace below when issuing 'make doc'. I suspect a check for
> SCM_UNSPECIFIED should be added either in the override in incipit.ly or
> in system-st
Trevor Daniels wrote:
> Does that mean shallow clones are inadvisable on Windows?
I'll let Johannes confirm, but I think that shallow clones should
be fine on Windows now. I got the sense that he "killed the beast"
last night. It was actually kind of exciting.
- Mark
___
Johannes Schindelin wrote Tuesday, August 11, 2009 12:51 PM
On Tue, 11 Aug 2009, Trevor Daniels wrote:
Mark Polesky wrote Tuesday, August 11, 2009 12:25 AM
>
> I'm git-weary but still alive. Johannes spent *hours* debugging
> my problem, and eventually traced it to an undiscovered bug
> in gi
Now that I'm a pusher again, I'm trying to return to unfinished
projects. I'm looking again at the pad-markup->pad-around
conversion and I have a question. I remember discussing this
before, but I couldn't find it in the archives.
When grepping for pad-markup, two hits are from translated docs.
D
>> Regarding your "Top" context: why do you override VerticalAxisGroup
>> #'Y-extent = ##f? This is likely to confuse the layout algorithm
>> even after the bug I mentioned is fixed.
>
> This was necessary for the old vertical layout engine -- at least it
> served me well since a few years. I'l
Michael Käppler wrote:
> here is the first draft of a patch concerning the margin
> settings for review. (I would like to upload it on Rietveld but
> I don't know how)
See CG 8.7.7 "Post patch for comments":
http://kainhofer.com/~lilypond/Documentation/contributor/Adding-or-modifying-features.htm
Hi,
On Wed, 12 Aug 2009, Maximilian Albert wrote:
> 2009/8/11 Johannes Schindelin :
>
> > I actually had to change the --work-tree things, since it is utter
> > garbage. I _know_ why I was opposed to its inclusion.
> >
> > [..]
> >
> > I added two shorter notices, and I also set the busy cursor
Hi all,
here is the first draft of a patch concerning the margin settings for
review. (I would like to upload it on Rietveld but I don't know how)
The goals are:
- make default margin settings accessible from *.ly stuff (now in
paper-defaults-init.ly)
- set line-width automatically depending
2009/8/11 Johannes Schindelin :
> I actually had to change the --work-tree things, since it is utter
> garbage. I _know_ why I was opposed to its inclusion.
>
> [..]
>
> I added two shorter notices, and I also set the busy cursor now.
Hehe, sorry for complaining again. But now the script aborts
Trevor Daniels treda.co.uk> writes:
>
> I've finally got around to looking at this.
> It seems the \deadNote function works fine,
> but \deadNotesOn and \deadNotesOff do not.
>
> I had a quick look at their definitions and
> I think they should be
>
> deadNotesOn =
> #(define-music-function
Hi,
On Tue, 11 Aug 2009, Maximilian Albert wrote:
> > I pushed a new version to git://repo.or.cz/lilypond/dscho.git. You
> > can download it directly here:
> >
> > http://repo.or.cz/w/lilypond/dscho.git?a=blob_plain;f=lilycontrib.tcl;hb=lilycontrib
>
> Cool, works like a charm now. Thanks a lo
Hi Neil,
It looks like a grob suicides in Documentation/snippets/incipit.ly, as I
get the backtrace below when issuing 'make doc'. I suspect a check for
SCM_UNSPECIFIED should be added either in the override in incipit.ly or
in system-start-text::calc-y-offset definition, unless there should be
n
Hi Johannes,
> I pushed a new version to git://repo.or.cz/lilypond/dscho.git. You can
> download it directly here:
>
> http://repo.or.cz/w/lilypond/dscho.git?a=blob_plain;f=lilycontrib.tcl;hb=lilycontrib
Cool, works like a charm now. Thanks a lot!
One minor comment: For new contributors with no
Hi,
On Tue, 11 Aug 2009, Jonathan Kulp wrote:
> On Tue, Aug 11, 2009 at 7:00 AM, Jonathan Kulp wrote:
>
> > On Tue, Aug 11, 2009 at 6:45 AM, Johannes Schindelin <
> > johannes.schinde...@gmx.de> wrote:
> >
> >> >
> >> > So it doesn't give an error, just a warning. But AFAIR I have seen this
> >>
Hi,
On Tue, 11 Aug 2009, Jonathan Kulp wrote:
> On Tue, Aug 11, 2009 at 6:45 AM, Johannes Schindelin <
> johannes.schinde...@gmx.de> wrote:
>
> > >
> > > So it doesn't give an error, just a warning. But AFAIR I have seen
> > > this warning on my non-GUI-based checkouts, too, even though
> > >
Hi,
On Tue, 11 Aug 2009, Jonathan Kulp wrote:
> On Tue, Aug 11, 2009 at 4:12 AM, Maximilian Albert <
> maximilian.alb...@googlemail.com> wrote:
>
> > P.S.: It would be nice to let the script print a short message when
> > it's finished so that the user know when to stop waiting. ;-)
>
> I had t
Le mardi 11 août 2009 à 04:46 -0700, Graham Percival a écrit :
> Odd behavior: if I rm -rf target/*/build/lilypond*,
> target/*/src/lilypond*, target/*/status/lilypond*, and
> target/*/installer/lilypond* (I'm trying to be safe), it seems
> to build ok. But if I try to rebuild with "make lilypon
On Tue, Aug 11, 2009 at 7:00 AM, Jonathan Kulp wrote:
> On Tue, Aug 11, 2009 at 6:45 AM, Johannes Schindelin <
> johannes.schinde...@gmx.de> wrote:
>
>> >
>> > So it doesn't give an error, just a warning. But AFAIR I have seen this
>> > warning on my non-GUI-based checkouts, too, even though every
On Tue, Aug 11, 2009 at 6:45 AM, Johannes Schindelin <
johannes.schinde...@gmx.de> wrote:
> >
> > So it doesn't give an error, just a warning. But AFAIR I have seen this
> > warning on my non-GUI-based checkouts, too, even though everything
> > worked fine. BTW, my git version is 1.6.0.4 (the late
Hi,
On Tue, 11 Aug 2009, Trevor Daniels wrote:
> Mark Polesky wrote Tuesday, August 11, 2009 12:25 AM
> >
> > I'm git-weary but still alive. Johannes spent *hours* debugging
> > my problem, and eventually traced it to an undiscovered bug
> > in gitk that only affects Microsoft Windows...
>
> N
Odd behavior: if I rm -rf target/*/build/lilypond*,
target/*/src/lilypond*, target/*/status/lilypond*, and
target/*/installer/lilypond* (I'm trying to be safe), it seems
to build ok. But if I try to rebuild with "make lilypond", or if
I forget to clean one directory, it fails.
I thought that I'
Hi,
On Tue, 11 Aug 2009, Maximilian Albert wrote:
> 2009/8/11 Johannes Schindelin :
>
> > It actually worked here, twice.
> >
> > But you have this wonderful output field in the GUI, what does it have to
> > say? I imagine that it gave you some error message or some such (probably
> > due to an
Carl Sorensen wrote Friday, August 07, 2009 2:49 PM
The generic approach has now been pushed to git
247f0b6d46fd8f3253a99f95a70ce14345daa5f9
There's a generic styledNoteHeads music function that applies a
note style
to music whether or not it's in a chord construct.
deadNotes and palmMute
On Tue, Aug 11, 2009 at 4:12 AM, Maximilian Albert <
maximilian.alb...@googlemail.com> wrote:
> 2009/8/11 Johannes Schindelin :
>
> > It actually worked here, twice.
> >
> > But you have this wonderful output field in the GUI, what does it have to
> > say? I imagine that it gave you some error mes
Mark Polesky wrote Tuesday, August 11, 2009 12:25 AM
I'm git-weary but still alive. Johannes spent *hours* debugging
my problem, and eventually traced it to an undiscovered bug
in gitk that only affects Microsoft Windows...
Nice to have you operational again. Thanks Johannes!
Can you say w
2009/8/11 Johannes Schindelin :
> It actually worked here, twice.
>
> But you have this wonderful output field in the GUI, what does it have to
> say? I imagine that it gave you some error message or some such (probably
> due to an older Git version that refuses to update the current 'master'
> br
Hi,
On Tue, 11 Aug 2009, Maximilian Albert wrote:
> 2009/8/11 Johannes Schindelin :
>
> > It actually only gives you a "Clone/Update" button that makes sure
> > that a local clone (hardcoded to $HOME/lilypond) is up-to-date, but at
> > least it has a progress bar, and I verified that it works
Op maandag 10-08-2009 om 21:01 uur [tijdzone -0700], schreef Patrick
McCarty:
> > `libguile-srfi-srfi-1-v-3.la' to a directory not ending in
> > /home/lilypond/gub/target/freebsd-x86/build/guile-1.8.7/srfi/.libs
> > make[3]: *** [install-libLTLIBRARIES] Error 1
>
> I can reproduce this, but I am
Carl
Yes, that looks good. Paraphrasing the beam settings, they say:
"break beam at beats, but break 8th-note beams at 1/2", exactly what
Ross wants.
So these rules are fine, but they are not correctly implemented when
the final two beats have a 8 8 8 16 16 pattern. This is the bug
that h
71 matches
Mail list logo
