Re: Access2Base - New release

On 19/05/14 08:23, Stephan Bergmann wrote: > On 05/16/2014 06:39 PM, Lionel Elie Mamane wrote: >> [...] >> So, the question is "why does this code enforce this condition, and >> can we change it"? Can we just remove the condition altogether, or >> should we add this case: >> >> ||

Re: Access2Base - New release

On 19/05/14 14:59, Lionel Elie Mamane wrote: > On Mon, May 19, 2014 at 11:06:46AM +0100, Noel Power wrote: [...] > Access2Base is considered a part of the core isn't it? it isn't > shipped as an extention, it is shipped as part of the product, (...) > Access2Base is either

Re: Access2Base - New release

ccess2Base") > or >|| > sOriginalUrl.match("vnd.sun.star.expand:$BRAND_BASE_DIR/$BRAND_SHARE_SUBDIR/basic/Access2Base") > > ? > > It avoids us demoting Access2Base to a bundled extension. yeah, my feeling here is avoiding this perceived 'demotion' of

Re: Access2Base - New release

On 12/06/14 16:16, Lionel Elie Mamane wrote: > On Fri, Jun 06, 2014 at 09:55:05AM +0100, Noel Power wrote: >> On 28/05/14 12:11, Lionel Elie Mamane wrote: >> [...] >> you are just stating how you want it to work, it's not a >> justification > No, that was my pr

Re: Access2Base - New release

On 13/06/14 11:45, Lionel Elie Mamane wrote: > On Fri, Jun 13, 2014 at 09:44:42AM +0100, Noel Power wrote: > >> Anyway, since binary overriding isn't on the table yet my main >> concern was with basic where you have can have Libraries deployed in >> share by the ent

Re: Of customisability, overridability and FLOSS/LibreOffice's mission

On 13/06/14 11:08, Lionel Elie Mamane wrote: > On Fri, Jun 13, 2014 at 09:44:42AM +0100, Noel Power wrote: >> On 12/06/14 16:16, Lionel Elie Mamane wrote: >>> On Fri, Jun 06, 2014 at 09:55:05AM +0100, Noel Power wrote: >>>> On 28/05/14 12:11, Lionel Elie Mamane wrote:

Re: getting help with Bug 71248 - Excel VBA: ActiveDocument is not tracking currently selected document

On 09/09/14 15:55, Justin Luth wrote: > Are sc/source/ui/vba/vbaapplications.cxx and > vbahelper/source/vbahelper/vbahelper.cxx ONLY used for MS VBA > compatibility, or does it also affect StarBasic etc? it only affects MS VBA compatability > > I have identified that the vbahelper function getCurre

Re: [Libreoffice] Examing unicode strings in gdb (while debugging LibO)

On Thu, 2010-11-18 at 09:30 +, Caolán McNamara wrote: > On Thu, 2010-11-18 at 00:17 +0100, Miklos Vajna wrote: > > On Wed, Nov 17, 2010 at 04:44:19PM +, Caolán McNamara > > wrote: > > > print dbg_dump(string) [...] > Without checking myself, are those pu macros horrifically slow or > spee

Re: [Libreoffice] use dbglevel=1 for --enable-debug builds?

On Thu, 2010-11-18 at 13:01 +0100, David Tardon wrote: > Hi all, > > currently, configuring with --enable-debug means that dbglevel is set to > 2, which in turns means that OSL_DEBUG_LEVEL is set to 2. This enables > all the OSL_ debugging stuff there is (well, maybe there is some really > rare st

Re: [Libreoffice] Building problem, DEBUG_ELEMENT when DEBUG is off

On Tue, 2010-11-23 at 23:51 +0100, Joost Eekhoorn wrote: > Hi, > I had a problem in writerfilter, building without DEBUG. > > I did some local hack with #undef, to get it building again. [...] I fixed a bug in this area, should be good now thanks, Noel __

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

On Tue, 2010-11-30 at 01:35 -0800, John LeMoyne Castle wrote: > OOo Basic has had issues with its fixed point Currency type for a long time. > I think the Basic Currency type deficiencies create a bar to adoption in the > minds of business users. > Nothing says 'run away' like mangling the mone

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

sending again ( whilst attempting to preserve the threading this time ) On Tue, 2010-11-30 at 01:35 -0800, John LeMoyne Castle wrote: > OOo Basic has had issues with its fixed point Currency type for a long time. > I think the Basic Currency type deficiencies create a bar to adoption in the > min

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

Hi John, On Tue, 2010-11-30 at 04:09 -0800, John LeMoyne Castle wrote: > Hi Noel, > Sorry about the whitespace problem. Is it because I cleaned up the header > formatting? I would regenerate the patch but I don't understand clearly what > the whitespace problem is. Please let me know what I did

[Libreoffice] [PUSHED] Re: more SAL_N_ELEMENTS

Hi Kenneth, thanks for the patch, perfect as far as I could see so it is pushed thanks, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Patch for i115495: import problem with centered rtl tables from word

On Sun, 2010-12-05 at 23:28 +0200, Lior Kaplan wrote: > Hi, > > Can any one look at the small patch attached to > http://www.openoffice.org/issues/show_bug.cgi?id=115495 > > It would be nice to have this fixed in LibO 3.3, as this annoys a lot > of users of the the RTL languages. > > Thanks > >

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

Hi John, On Tue, 2010-11-30 at 04:22 -0700, Noel Power wrote: > > Main patch makes 1/2 kLOC reduction in sbx. > yeah, so you will have to give me some time to look at this ( not really > familar with the Currently type ) and I need to somehow filter out the > whitespace changes t

Re: [Libreoffice] [PUSHED] [PATCH] Clean code at impress

Hi Kayo On Sun, 2010-12-05 at 14:37 -0800, Kayo Hamid wrote: > Sending for review, cover sd/slideshow/* > > revol_ > Pushed, I didn't commit the changes to slideshow/source/engine/sp_debug.cxx as I find those comment telling what #ifdef the #endif closes very useful. Thanks muchly for the nice pa

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

Hi John, On 30/11/10 09:35, John LeMoyne Castle wrote: Currency is presently implemented with a 64bit struct of 2 Int32s and the math is done by the tools/bigint class. The attached patches replace the code to implement the Currency type with an ISO C99 compiler supported 64 bit integer. Abso

Re: [Libreoffice] [PUSHED][PATCH] RTL_CONSTASCII_USTRINGPARAM for dbaccess/source/ui/dlg

Hi Julien On 06/12/10 21:40, Julien Nabet wrote: Hello, Here's a small patch for dbaccess/source/ui/dlg This is a strange one, it seems SERVICE_UI_FOLDERPICKER is not a simple const char but an instance of ConstAsciiString ( defined in dbaccess/source/inc/constasciistring.hxx ) so I changed t

Re: [Libreoffice] [LibreOffice] [Patch] Fix for i#108228: Bool has negative sign when used in Writer formula expression

Hi Mattias/Michael On 08/12/10 11:20, Michael Meeks wrote: Having said that, this really doesn't seem ideal. I wonder what the compatibility impact of changing it would be [ a chestnut for Noel to consider I suspect ]. From the basic point of view as Mattias says ( and afaics ) this does

Re: [Libreoffice] [LibreOffice] [PUSHED] [Patch] Fix for i#108228: Bool has negative sign when used in Writer formula expression

On 08/12/10 16:22, Noel Power wrote: For this patch I am not familiar with the writer bits involved, so I am not sure if there would be some side-affects. Personally I'd like to understand why the "explict check in the output" doesn't get applied in this case, I'll a

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

Hi John, On 06/12/10 17:58, Noel Power wrote: Hi John, [...] in sbxToUnoValueImpl ( convert to uno without known target class ) in basic/source/classes/sbunoobj.cxx previously an Double or Float basic value ( within the range of an int ) was transfered as a the smallest type e.g. sal_Int8

Re: [Libreoffice] Need review of the ooo/OOO330_m18 changes

On 14/12/10 20:19, Jan Holesovsky wrote: Hi, I wanted to merge the m18 changes today, but looking at the diff, it is not that trivial, and I don't feel like the right person reviewing it according to our post-RC criteria; so I'd like to ask you to review it. Best if you can merge/cherry-pick the

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

On 15/12/10 10:04, Noel Power wrote: Hi John, On 06/12/10 17:58, Noel Power wrote: Hi John, [...] in sbxToUnoValueImpl ( convert to uno without known target class ) in basic/source/classes/sbunoobj.cxx previously an Double or Float basic value ( within the range of an int ) was transfered

Re: [Libreoffice] [PATCH] Basic Currency Issues #i31001# to #i107277#

On 22/12/10 10:13, Tor Lillqvist wrote: It seems that this patch is now in master, and it causes compilation errors on Windows (slightly edited compiler messages for brevity): sbxdec.cxx(735) : error C2065: 'n' : undeclared identifier sbxdec.cxx(749) : error C2039: 'pULong64' : is not a member

Re: [Libreoffice] Build errors

On 22/12/10 02:23, Balachandran Sivakumar wrote: call of overloaded 'append(char)' is ambiguous Hmm I never got that error but happily it seems Joseph Powers commited a fix for that, try pull and rebuild. thanks, Noel ___ LibreOffice mailing list Libr

Re: [Libreoffice] [PATCH] Remove DECLARE_LIST( EditList, AppWIn*)

Hi Joseph On -10/01/37 20:59, Joseph Powers wrote: The attached patch compiles and stands up to my limited testing; however, it's a large patch and touches a lot of sensitive code so I want someone with better knowledge of the Basic Macro Editor environment to review& test it before I try p

[Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

Hi there fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is riskless etc. http://cgit.freedesktop.org/libreoffice/base/commit/?id=0afe2266016b03f6e11008463042c7daacead0e1 is ripe for signoff and cherrypicking, be grateful if someone could help with that thanks, Noel

[Libreoffice] [REVIEW]

I'd like to include this fix ( which fixes corruption of formfield checkbox related data in binary format on export ) in libreoffice-3-3 http://cgit.freedesktop.org/libreoffice/writer/commit/?id=af4d6062b7e676ed56dc84927fb99b79aa03a7b5 is available for cherrypick/signoff thanks, Noel

Re: [Libreoffice] [REVIEW] (Offensive Word Found In Message)

On 12/01/11 12:25, Michael Meeks wrote: On Wed, 2011-01-12 at 06:17 -0600, Norbert Thiebaud wrote: is available for cherrypick/signoff It looks fine to me. Merged to libreoffice-3-3 and libreoffice-3-3-0, and re-working in master to suck less too ;-) Thanks, M

Re: [Libreoffice] [REVIEW] request for review for patch for fdo#32742# regression

On 12/01/11 18:03, Norbert Thiebaud wrote: On Wed, Jan 12, 2011 at 10:35 AM, Octavio Alvarez wrote: On Wed, 12 Jan 2011 03:18:01 -0800, Noel Power wrote: Hi there fix for fdo#32742#, its a simple fix ( but was a bugger to find ) imo is riskless etc. http://cgit.freedesktop.org

Re: [Libreoffice] (un)localized MSI installer [REVIEW REQUEST]

On 13/01/11 21:18, Tor Lillqvist wrote: So the problem must be in setup.exe, in some cases it fails to understand that it should use a transform. That is good, because it means we can debug it. [...] The symptom of the bug was that only the first 20 or so languages in the setup.ini file were r

Re: [Libreoffice] [PATCH] unopkg crasher on SLED11-SP1 (bnc#655912)

On 13/01/11 20:25, Petr Mladek wrote: Hi, could you please review the attached patch for libreoffice-3-3 branch? It looks like a compiler bug. I see it only on SLED11 with one particular gcc version. So, the solution is a kind of workaround but it should be fine in general. See the patch for mo

Re: [Libreoffice] [REVIEW] More reviews for fdo#33108 fix please

On 17/01/11 17:51, Thorsten Behrens wrote: Hi, Lubos fixed an ugly crasher in vcl via fdo#33108 - I've stripped the patch down to the absolute minimum, and would be ok for taking that for -3-3-0 - any further reviews, please? not being familiar with the cairo and vcl stuff but assuming the patch

[Libreoffice] Fwd: [Libreoffice-bugs] [REVIEW] fdo#33237

sent to the wrong list... Noel Original Message Subject:[Libreoffice-bugs] [REVIEW] fdo#33237 Date: Tue, 18 Jan 2011 13:02:38 + From: Noel Power To: libreoffice-b...@lists.freedesktop.org I'd like to add this for the libreoffice-3.3 branch (

Re: [Libreoffice] NEW [PATCH] Unix 64 bits property type / default value mismatch

On 21/01/11 06:59, Lionel Elie Mamane wrote: On Mon, Jan 17, 2011 at 04:58:28PM +, Caolán McNamara wrote: On Mon, 2011-01-17 at 15:18 +0100, Lionel Elie Mamane wrote: (...) we have to make these three places agree. As to whether it is in the direction of "C/C++ long" everywhere or in the di

Re: [Libreoffice] [REVIEW] (Offensive Word Found In Message)

On 14/01/11 12:17, Caolán McNamara wrote: On Wed, 2011-01-12 at 12:25 +, Michael Meeks wrote: On Wed, 2011-01-12 at 06:17 -0600, Norbert Thiebaud wrote: is available for cherrypick/signoff It looks fine to me. Merged to libreoffice-3-3 and libreoffice-3-3-0, and re-working in mast

[Libreoffice] [REVIEW] rudimentary handling for odd/even section breaks

fix for https://bugzilla.novell.com/show_bug.cgi?id=659361 fix here http://cgit.freedesktop.org/libreoffice/writer/commit/?id=da0006a1b5d7be8411d6fbb0190c1c4d44809458 Caolan, any thoughts? be nice for 3.3.1 too ! ___ LibreOffice mailing list LibreOffi

Re: [Libreoffice] [REVIEW] fix for fontwork toolbar

On 04/02/11 10:04, Cedric Bosdonnat wrote: Hi all, Could anyone review the fix for this quite annoying bug? https://bugs.freedesktop.org/show_bug.cgi?id=32872 The fix has been pushed to master as commit: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=05ef821abdff1ec4712cd4b054a21e

[Libreoffice] [REVIEW] fdo#30879

This fix reverts a libreoffice specific change which introduced a regression. please review for libreoffice-3.3 branch fix ( on master ) is here http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=6eb4e55b0a61f793f635a8038895cb2e452dc280 thanks, Noel __

Re: [Libreoffice] Review request: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=7bc42b864b22fd8e0b159dfec212abaf989ff9aa

Hi Tor On 04/02/11 15:34, Tor Lillqvist wrote: I would like to cherry-pick that to libreoffice-3-3. (Otherwise it can't be built on Windows with a recent DirectX SDK.) looks ok to me, I would say go for it ___ LibreOffice mailing list LibreOffice@l

[Libreoffice] [REVIEW] patch for crasher fdo#37045

please see https://bugs.freedesktop.org/show_bug.cgi?id=37045 and the patch attached here ( https://bugs.freedesktop.org/attachment.cgi?id=46565 ) if someone would review / cherrypick etc. for libreoffice-3.4 branch that would be nice Noel ___ Libre

Re: [Libreoffice] [Patch]Clean up XDatabaseRanges in VBA code

Hi MArkus On 11/05/11 00:32, Markus Mohrhard wrote: Hello Noel, with my last patch I forgot to remove all occurences of XDatabaseRanges in the vba code. I don't think that there is any use for XDatabaseRanges in the vba code, because excel only supports one db data. Regards, Markusl looks

[Libreoffice] [REVIEW] fix for crasher fdo#37103

Hi All, please see https://bugs.freedesktop.org/show_bug.cgi?id=37103 and if someone could review and cherry-pick the patch http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=17e8ee1d7b9b4464af73657679df7b0bbdffa028 from master, that would be great thanks, Noel _

[Libreoffice] [REVIEW] fix for fdo#35139

Hi, Please have a find a fix for https://bugs.freedesktop.org/show_bug.cgi?id=35139 here https://bugs.freedesktop.org/attachment.cgi?id=46611 I'd like to apply that to libreoffice 3.4 thanks Noel ___ LibreOffice mailing list LibreOffice@lists.fr

Re: [Libreoffice] [REVIEW] fix for #36915 and #36916

I mentioned the wrong bug, the patch fixes the above On 11/05/11 21:46, Noel Power wrote: Hi, Please have a find a fix for https://bugs.freedesktop.org/show_bug.cgi?id=35139 here https://bugs.freedesktop.org/attachment.cgi?id=46611 I'd like to apply that to libreoffice 3.4 thanks

Re: [Libreoffice] [REVIEW] fix for #36915 and #36916

please see updated patch Noel diff --git scripting/util/provider/beanshell/makefile.mk scripting/util/provider/beanshell/makefile.mk index cbb0c40..1f70fcb 100755 --- scripting/util/provider/beanshell/makefile.mk +++ scripting/util/provider/beanshell/makefile.mk @@ -36,6 +36,7 @@ EXTENSIONNAME:

Re: [Libreoffice] [REVIEW] Fix for fdo#36667 for 3.4

On 11/05/11 16:36, Cedric Bosdonnat wrote: Hi all, Attached is a patch fixing the sw table formulas update in 3.4. Could someone review and sign it off? It's a partial revert from http://cgit.freedesktop.org/libreoffice/writer/commit/?id=2b9726405495529d64e7ab8537ea30119f607d1e The test in the

[Libreoffice] [REVIEW] patch for #36684

Hi, can someone please review ( and cherrypick ) to libreoffice3.4 the following patch http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ea29c4f0d289890fcdb2f12380aa1ccf3d1028c9 from master thanks, Noel ___ LibreOffice mailing list LibreOffi

[Libreoffice] problems with component registration

Hi David, It seems that http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=f9496177a4c942f2acc39a978a3cd65689f14d8d is causing some problems with component registration with at least basic on master. I have a temporary fix for this here http://cgit.freedesktop.org/libreoffice/libs-co

Re: [Libreoffice] LO with clean configuration unusable

On 17/05/11 15:13, Lubos Lunak wrote: Hello, current master, with ~/.libreoffice removed, fails on the first startup, showing a dialog about not being able to lauch the application. Subsequent launches are successful, but LO is unable to load or save any document (I assume the first run resu

Re: [Libreoffice] [REVIEW] [PUSHED]fix for fdo#37277

On 17/05/11 15:37, Cedric Bosdonnat wrote: m_bResetUndo = sal_False ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] REVIEW for fix#37211

Hi, following patch fixes regressions reported in https://bugs.freedesktop.org/show_bug.cgi?id=37211 & https://bugs.freedesktop.org/show_bug.cgi?id=37170 https://bugs.freedesktop.org/attachment.cgi?id=46831 it would be great to get the 1 review for libreoffice-3-4 ( not critical so no poin

Re: [Libreoffice] REVIEW for fix#37211

On 17/05/11 20:13, Clio wrote: 17.05.2011 12:47, Noel Power пишет: ( not critical so no point pushing for the release branch I think ) If it is not fixed in 3.4.0, you can't Select All neither with the menu Select All from the menu has been broken forever, see http://openoffice.org/bug

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

On 17/05/11 17:04, Kohei Yoshida wrote: Hi there, The attached patch fixes the crasher reported in the following bug: https://bugs.freedesktop.org/show_bug.cgi?id=37226 and also several other usage of standard algorithms which I believe is incorrect, since the existing code passes the result o

Re: [Libreoffice] [REVIEW] Fix for fdo#37226

Hi Kohei On 18/05/11 12:52, Kohei Yoshida wrote: On Wed, 2011-05-18 at 12:08 +0100, Noel Power wrote: [...] So, we (Rafael, Norbert, Joseph and I) talked about this last night on IRC, and one question raised was whether or not boost::bind allows pointers to data members rather than member

Re: [Libreoffice] [PUSHED] [REVIEW] Fix for fdo#37226

marking as pushed ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED[ [REVIEW] Fix for fdo#37226

On 18/05/11 15:45, Kohei Yoshida wrote: I accidentally pushed mine to the -3-4 branch already when I signed off and pushed Rafael's patch (since it was already committed locally and pushing Rafael's also pushed mine with it).;-) So, let me just use that as my excuse for picking my version this t

[Libreoffice] [REVIEW] fix for fod#36552

Hi I have a fix for https://bugs.freedesktop.org/show_bug.cgi?id=36552 I'd like to get it into the 3.4 branch if possiblehttp://cgit.freedesktop.org/libreoffice/writer/commit/?id=8f1fe65d4fab09515b0b67319fef67c88533b2e0 thanks, Noel ___ LibreOffice

Re: [Libreoffice] [REVIEW] fix for fod#36552

On 18/05/11 16:48, Cedric Bosdonnat wrote: Hi Noel, The patch looks good to me. Still two other reviews to get it in 3.4.0 thanks, pushed to the libreoffice3-4 branch, of course if I get 2 more acks I'll push it to the 3.4.0 branch Noel ___ LibreOff

Re: [Libreoffice] [REVIEW] fix for fdo#34997

Hi Cedric On 18/05/11 17:09, Cedric Bosdonnat wrote: Hi all, Could you review the attached patch (sign it off, and so on)? It fixes a crash when reading some malformed ODT files. It would be great to have that one in 3.4. looks fine to me, you got 1 signoff Noel ___

Re: [Libreoffice] [PUSHED] [REVIEW] fix for fod#36552

On 18/05/11 17:05, Noel Power wrote: On 18/05/11 16:48, Cedric Bosdonnat wrote: Hi Noel, The patch looks good to me. Still two other reviews to get it in 3.4.0 thanks, pushed to the libreoffice3-4 branch, of course if I get 2 more acks I'll push it to the 3.4.0 branch pushed now t

[Libreoffice] [REVIEW] fix for https://bugs.freedesktop.org/show_bug.cgi?id=37367

Hi Please review this fix for a regression from 3.3.2, patch is here ( ripe for picking ) http://cgit.freedesktop.org/libreoffice/filters/commit/?id=ac80fce47404c0843c372336ab700d62297f1647 on master, would be great to get into libreoffice3-4 branch at least thanks, Noel __

Re: [Libreoffice] [REVIEW] Fix for fdo#37322: Calc binary import crasher

On 19/05/11 15:40, Kohei Yoshida wrote: Looks good. You have my sign-off. Kohei ditto ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fix for https://bugs.freedesktop.org/show_bug.cgi?id=37367

On 19/05/11 17:01, Michael Meeks wrote: On Thu, 2011-05-19 at 16:14 +0100, Noel Power wrote: http://cgit.freedesktop.org/libreoffice/filters/commit/?id=ac80fce47404c0843c372336ab700d62297f1647 You have my +1 - and I've cherry-picked it to 3-4. Thanks, Mi

Re: [Libreoffice] [REVIEW] trivial PPTX import crash fix

On 19/05/11 16:54, Michael Meeks wrote: To avoid a NULL pointer de-reference, don't de-reference a null pointer :-) I'd like to get this into 3.4.0 Thanks, Michael. looks sane to me +1 ___ LibreOffice mailing list Libr

Re: [Libreoffice] [REVIEW] fix for fdo#36690

On 20/05/11 10:02, Michael Meeks wrote: Weelll ... it seems that (for all its ugliness) the more common way of doing this inside button.cxx's draw code (cf. ImplDrawPushButtonFrame) seems to be this: diff --git a/vcl/source/control/button.cxx b/vcl/source/control/button.cxx index c77d14

Re: [Libreoffice] [REVIEW] fix for fdo#36690

On 20/05/11 10:43, Noel Power wrote: On 20/05/11 10:02, Michael Meeks wrote: I prefer Michael's version, so +1 for that ( although I don't agree with the ugly comment, to me it shows the intentional bypassing of the dynamic binding ) ___ I committed that version to 3.4 b

Re: [Libreoffice] minutes of tech. steering call ... (Offensive Word Found In Message)

On 20/05/11 08:27, Cedric Bosdonnat wrote: Hi all, Sorry, I couldn't join yesterday. I'm just wondering where the reviewboard action item went? is that a dropped idea or does it still deserves some action? I meant to say something when this was originally floated but got distracted. I think the

Re: [Libreoffice] Please, review the patch to baside2b.cxx on 17-Feb-2011

On 20/05/11 15:53, Clio wrote: Please, see here, that the patch actually added 1 line: http://svn.services.openoffice.org/opengrok/diff/DEV300_m106/basctl/source/basicide/baside2b.cxx?r2=%2FDEV300_m106%2Fbasctl%2Fsource%2Fbasicide%2Fbaside2b.cxx%40275666%3Ad11c441ed074&r1=%2FDEV300_m106%2Fbasctl%

Re: [Libreoffice] minutes of tech. steering call ... (Offensive Word Found In Message)

On 20/05/11 12:53, Norbert Thiebaud wrote: I do agree. but then it should be possible to use a nice review-tools and still have the generated review comment posted in the the ML I mean, when someone add a patch to be review in the tool that can generate a post to the ML with the patch (either i

[Libreoffice] [REVIEW] fix for fdo#37370

Hi Please review this fix https://bugs.freedesktop.org/attachment.cgi?id=47096 for https://bugs.freedesktop.org/show_bug.cgi?id=37370.It would have been great to get this into rc2 ( unfortunately I wasn't quick enough ) as this is an extremely annoying bug and makes identifying problems with

Re: [Libreoffice] [REVIEW] fix for fdo#37370

On 24/05/11 11:36, Michael Meeks wrote: Looks odd to me - this was not necessary in the past (at least comparing with -3-3 and so on) - I suspect there is a deeper and more interesting problem we're just band-aiding. yes, resources from basic.srs were merged previously into ofa[en].res b

Re: [Libreoffice] [Review] patch for disappearing autofilter when inserting/deleting sheets

On 24/05/11 15:00, Kohei Yoshida wrote: Looks good to me& pushed to the -3-4 branch. If two more people agree, I'd like this pushed to the -3-4-0 branch as well. Kohei looks good to me too ___ LibreOffice mailing list LibreOffice@lists.freedesktop

Re: [Libreoffice] [REVIEW] Fix for fdo#37520

On 24/05/11 21:03, Kohei Yoshida wrote: The attached patch fixes the crasher reported in https://bugs.freedesktop.org/show_bug.cgi?id=37520 The crash occurs in ScRangeList::Join() where the array size is cached prior to the for loop, but array may shrink during the loop, in which case an out-of

Re: [Libreoffice] [PUSHED][PATCH] Replace List for std::map

On 26/05/11 15:42, Rafael Dominguez wrote: ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Nice one, patch looked good to me, pushed to master thanks so much Noel

Re: [Libreoffice] [PATCH] Fix out of bounds access in ImplEntryList

On 26/05/11 21:09, Rafael Dominguez wrote: Fix possible oob when trying to erase an element. Please review and signoff for merging into 3.4.1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinf

Re: [Libreoffice] [PUSHED] [PATCH] Fix out of bounds access in ImplEntryList

On 27/05/11 10:29, Noel Power wrote: really mark as pushed ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] [PATCH] Remove commented out code

On 26/05/11 23:38, Luke Petrolekas wrote: License LGPLv3+/MPL More dead code. Luke Thank you for the nice patch, committed to master Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/li

Re: [Libreoffice] [PUSHED] [PATCH] Very small code cleanup.

On 26/05/11 23:48, Luke Petrolekas wrote: No, this is not more dead code this time :). I noticed this and I'm pretty confident the code is sloppy. It's my first time deliberately touching the code, so sorry if it's a bit small. nope, don't be sorry, useful cleanup, thanks again Noel __

Re: [Libreoffice] [PUSHED] [PATCH] Remove commented out code.

On 26/05/11 23:59, Luke Petrolekas wrote: License LGPLv3+/MPL thanks again, Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] fix for fdo#37590

I'd like to get the following patch into 3.4 so 1 review needed bug: https://bugs.freedesktop.org/show_bug.cgi?id=37590 patch: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ecbd796ee8157047b1738ac12c98a6ef4d3c18ff hanks, Noel ___ Li

Re: [Libreoffice] [PATCH] fdo#34872

On 28/05/11 19:40, Rob Snelders wrote: Hi, Here is a really small patch to solve fdo#34872. This patch is submitted under LGPLv3+/MPL-Licence. looks good ( I suppose some risk that this might have some side affects for other fields that use this Expression field type, but ok, master is the pl

Re: [Libreoffice] [PUSHED] [PATCH] Code Cleanup in calc

On 29/05/11 05:23, Korrawit Pruegsanusak wrote: Hello all, The attached patch is to cleanup the code in calc. Please feel free to comment. thanks for the patch, nice job, pushed to master now regards, Noel ___ LibreOffice mailing list LibreOffice@lis

Re: [Libreoffice] [PUSHED] [PATCH] cppcheck cleanliness

On 29/05/11 05:42, Korrawit Pruegsanusak wrote: Hello all, The attached patch is to remove warning about "inefficient checking for emptiness" from cppcheck. thanks again for the nice patch, pushed to master Noel ___ LibreOffice mailing list LibreOffi

Re: [Libreoffice] [PUSHED] [PATCH] fdo#34872

On 30/05/11 11:55, Noel Power wrote: On 28/05/11 19:40, Rob Snelders wrote: Hi, Here is a really small patch to solve fdo#34872. This patch is submitted under LGPLv3+/MPL-Licence. looks good ( I suppose some risk that this might have some side affects for other fields that use this

Re: [Libreoffice] [PUSHED] [PATCH] Code Cleanup in libs-gui

On 28/05/11 19:47, Korrawit Pruegsanusak wrote: Hello all, Although the diff may look frustrated, I've explained what I've done in log message. Please feel free to comment :-) Nice patch, thanks again, I took the comment 'Clean background first because of plugins. ' from Christina, not sure if

Re: [Libreoffice] [PUSHED] [REVIEW] OOXML 2010 xlsx export

On 30/05/11 13:35, Katarina Machalkova wrote: Hey there, can some1 please review& cherry-pick for 3.4 the following patch: http://cgit.freedesktop.org/libreoffice/filters/commit/?id=6603c30f910b1fb5674a28988304dfcd14c11ecb Seems that it somehow fell through the cracks and never made it to 3.4

Re: [Libreoffice] [REVIEW] fix for fdo#37590

On 27/05/11 14:17, Noel Power wrote: I'd like to get the following patch into 3.4 so 1 review needed bug: https://bugs.freedesktop.org/show_bug.cgi?id=37590 patch: http://cgit.freedesktop.org/libreoffice/libs-core/commit/?id=ecbd796ee8157047b1738ac12c98a6ef4d3c18ff Petr and I chatted br

Re: [Libreoffice] [PATCH] fdo#32263 - Config file location

Hi On 30/05/11 15:39, Takeshi Abe wrote: Hi all, (thanks to Noel, for helpful comments on its initial version and suggesting to post to this list). ahem, I seem to have gotten the wrong end of the stick about some of the patch ( or at least looking at it again I see that ) It seems to work well

Re: [Libreoffice] [PATCH] fdo#32263 - Config file location

On 31/05/11 01:41, Takeshi Abe wrote: Hi Noel, [...] Well the change against common_brand.scp is surrounded with #ifdef, so will not affect to WNT nor to MACOSX. Or am I misunderstanding something? yes that's what I said ( probably not clearly enough ) e.g. I realised that "the config changed

Re: [Libreoffice] [PUSHED] [PATCH] Code cleanup in filters

On 30/05/11 18:18, Korrawit Pruegsanusak wrote: Hello all, Attached patch is a bit more code cleanup in filters. Please feel free to comment. Anyway, I've found some comments are unreadable, eg. in /hwpfilter/source/hwpreader.cxx line ~4440. Should we also remove them? or are they my encoding fa

Re: [Libreoffice] [PUSHED[ [REVIEWED] fix for fdo#37590

On 31/05/11 10:06, Michael Meeks wrote: Hi Noel, On Mon, 2011-05-30 at 20:40 +0100, Noel Power wrote: Petr and I chatted briefly on IRC, as he rightly pointed out most likely the intended change would be https://bugs.freedesktop.org/attachment.cgi?id=47337 as per the ack, pushed to 3.4

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

On 31/05/11 09:25, Noel Power wrote: On 31/05/11 01:41, Takeshi Abe wrote: Hi Noel, [...] Well the change against common_brand.scp is surrounded with #ifdef, so will not affect to WNT nor to MACOSX. Or am I misunderstanding something? yes that's what I said ( probably not clearly e

Re: [Libreoffice] [PATCH] Duplicate code: join ImportFrom and InsertFrom

On 31/05/11 13:03, Chr. Rossmanith wrote: Hi, more duplicate code cleanup. Class SfxObjectShell has two nearly identical methods: ImportFrom and InsertFrom. The latter has a few lines of code more, so I've removed InsertFrom (which was added to the code base later than ImportFrom), added a b

Re: [Libreoffice] [PUSHED[ [PATCH] fix for fdo#37761: Keyboard navigation broken in tools - options

On 31/05/11 18:03, André Schnabel wrote: Hi, we came across a minor accessability issue at the German discuss list. But the fix is so easy that even I could do it. It's just to remove one line that breaks the keyboard navigation in the options dialog and has no sense at all. Christoph Noack

Re: [Libreoffice] [PUSHED] Patch for Bug 34786: [EasyHack]Editing: Sentence movement function broken

On 01/06/11 06:34, jeffrey chang wrote: Sorry here is the patch. On Wed, Jun 1, 2011 at 1:18 PM, jeffrey chang > wrote: Hi, I am new to the LibreOffice community. I know that 34786 has been posted for awhile, but no one seems to have claimed the bug an

Re: [Libreoffice] [PUSHED] Patch for Bug 34786: [EasyHack]Editing: Sentence movement function broken

On 01/06/11 12:05, Noel Power wrote: On 01/06/11 06:34, jeffrey chang wrote: [...] Sorry here is the patch.k, patch looks fine to me and works as expected, pushed to 3.4 branch. look forward to your next patch thanks alot oh and can you please confirm the patch is contributed under LGPLv3

Re: [Libreoffice] [PUSHED] [PATCH] restore Korean comments in hwpfilter (were corrupted to just "????" instead of being translated)

On 01/06/11 13:55, Christian Lohmaier wrote Sure - I attached the patch for that as well :-) (one time to have a list of strings that can be passed on to possible translators, and of course for having it reviewed, in terms of does it cause problems with compilers? Do all compilers deal with non-a

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

On 08/06/11 13:55, Takeshi Abe wrote: OK, so do you mean libs-core/desktop/source/migration?, which functionality I have not yet recognized clearly. It would be great if anyone familiar with the code suggests a starting point to dig into. I *think* this ( see attached patch ) will fix it, not ha

  1   2   3   4   5   6   7   8   9   10   >