On 21/01/11 06:59, Lionel Elie Mamane wrote:
On Mon, Jan 17, 2011 at 04:58:28PM +0000, Caolán McNamara wrote:
On Mon, 2011-01-17 at 15:18 +0100, Lionel Elie Mamane wrote:
(...) we have to make these three places
agree. As to whether it is in the direction of "C/C++ long" everywhere
or in the direction of "uno long == sal_Int32" everywhere, (..)
[no] opinion.
Well, we have to assume from that LoadTableWindowData that the
values may have been cached on disk somewhere, and have been
assigned a data type of sal_Int32 for the purposes of file
storage. So I say we use sal_Int32 everywhere for those four
"long"s.
OK, here's the patch that changes the setters to sal_Int32 then.
minor minor nit-pick, wouldn't it be better to use static_cast here ( at
the very least that helps to grep for casts ) - and yes, I am guilty of
not doing this too ( but I try to remember )
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
