Re: [Libreoffice] About merging and people not paying attention

2011-07-29 Thread Miklos Vajna
On Wed, Jul 27, 2011 at 03:53:18PM +0200, Thomas Arnhold wrote: > I think this was not intended. Simple solution would be to add some > '<<< HEAD' .* '===' .* '>>> master' stuff to git hooks. So > git would block commits with conflicts. Good idea - care to send a patch? The pre-com

Re: [Libreoffice] About merging and people not paying attention

2011-07-29 Thread Miklos Vajna
On Fri, Jul 29, 2011 at 11:46:21AM +0200, Thomas Arnhold wrote: > Yeah, I've already found that file. Strangely we already have such a > check: > http://cgit.freedesktop.org/libreoffice/bootstrap/tree/git-hooks/pre-commit#n61 Oh, now I remember how such conflicts could be still introduced: 15

[Libreoffice] source tarballs: gzip files as .tar.bz2?

2011-07-31 Thread Miklos Vajna
Hi, I just hit this: $ file libreoffice-artwork-3.4.2.3.tar.bz2 libreoffice-artwork-3.4.2.3.tar.bz2: gzip compressed data, from Unix, last modified: Sat Jul 30 22:28:37 2011 Did I miss something or there seems to be a bug maybe in bin/lo-pack-sources? Thanks. pgpKFRxkkDUfN.pgp Description: P

Re: [Libreoffice] source tarballs: gzip files as .tar.bz2?

2011-08-01 Thread Miklos Vajna
On Mon, Aug 01, 2011 at 09:27:12PM +0700, Korrawit Pruegsanusak wrote: > This is fixed by Thorsten. > http://listarchives.libreoffice.org/global/website/msg05679.html Indeed. Thanks a lot! pgppx2vIytEpq.pgp Description: PGP signature ___ LibreOffice

[Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell

2011-08-01 Thread Miklos Vajna
0:00 2001 From: Miklos Vajna Date: Mon, 1 Aug 2011 19:55:42 +0200 Subject: [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell This fixes a crash during RTF export invoked by copy&paste, as the called constructor would unconditionally dereference the DocShell's pointer

Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell

2011-08-02 Thread Miklos Vajna
Hi Noel, On Tue, Aug 02, 2011 at 10:07:22AM +0100, Noel Power wrote: > actually I am not at all familiar with the export side of this stuff. In > theory I think your check is ok ( unfortunately I would guess the > expectation that the doc shell is valid is probably buried deep in the > SvxMSDf

Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell

2011-08-03 Thread Miklos Vajna
On Tue, Aug 02, 2011 at 05:51:49PM +0100, Noel Power wrote: > On 02/08/11 16:46, Miklos Vajna wrote: > > I guess the reason is that the doc shell points to the whole document, > > while you usually export only part of the doc during copy&paste export. > 'copy&past

[Libreoffice] [GSoC] [rtfimport] 10th week

2011-08-03 Thread Miklos Vajna
Hi, Previous week starts here: http://cgit.freedesktop.org/~vmiklos/lo-gsoc/tree/README#n1128 In short, it was about: - fixed the importer to handle test documents from the existing unit test - fixed/implemented the following bugs: fdo#36877, fdo#36922, fdo#35985, fdo#36089 Miklos pgp6l0q

[Libreoffice] [GSoC] [rtfimport] 11th week

2011-08-08 Thread Miklos Vajna
Hi, Previous week starts here: http://cgit.freedesktop.org/~vmiklos/lo-gsoc/tree/README#n1208 In short, it was about: - improved copy&paste import to use the new RTF filter in experimental mode - added unit test in writerfilter, it tests 8 files (6 expected pass, 2 expected fail, all test do

Re: [Libreoffice] XML pretty printer (was: Where did Setup.xcu go?)

2011-08-11 Thread Miklos Vajna
On Wed, Aug 10, 2011 at 11:28:42PM +0200, Eike Rathke wrote: > For which I always recommend xmlpp, > http://software.decisionsoft.com/tools.html Is this better in some aspect than xmllint --format, which cames with libxml and requires no manual installation? :) Thanks. pgpXWgmUojIPS.pgp Descri

Re: [Libreoffice] [PUSHED] fix xml2cmp build with svn gcc

2011-08-11 Thread Miklos Vajna
On Thu, Aug 11, 2011 at 09:09:39AM -0600, Tom Tromey wrote: > Noel> I rolled up this patch and the previous one here > Noel> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=c2a634416ba8f385c25c16cc52aeae6f68cab9db > > I don't understand where these commits go. > I re-pulled in 'ure' (a

[Libreoffice] [PATCH] Make the help repo optional

2011-08-11 Thread Miklos Vajna
uild type where helpcontent2 was disabled. OK to push? Thanks. From e3080e063acf9b61bc5cc8821e7c790759ca739d Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Thu, 11 Aug 2011 18:36:53 +0200 Subject: [PATCH] Make the help repo optional --- configure.in | 18

Re: [Libreoffice] [PATCH] Make the help repo optional

2011-08-11 Thread Miklos Vajna
On Thu, Aug 11, 2011 at 06:42:52PM +0200, Miklos Vajna wrote: > The attached patch allowed me to build and dev-install (wikihelp opens > properly) master without cloning the help repo (saving 20MB of download > of something I don't need during development in most cases). >

Re: [Libreoffice] Can I compile and build only libreoffice writer component instead of whole LO suite ?

2011-08-14 Thread Miklos Vajna
On Sat, Aug 13, 2011 at 01:17:44AM -0500, Norbert Thiebaud wrote: > On Sat, Aug 13, 2011 at 12:20 AM, Partha Chowdhury > wrote: > > Hello all.This is my first post to the list.So if I have not provided > > necessary information or overlooked something obvious, please point me in > > the right di

Re: [Libreoffice] Easy Hacks "remove all the bogus comments lying around"

2010-10-06 Thread Miklos Vajna
On Wed, Oct 06, 2010 at 12:03:47PM +0100, Caolán McNamara wrote: > I want to be able to press "tab" to insert sufficient spaces to move the > insertion point to the next multiple of 4 character cells, so how about. > > /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ That looks fine. :) pg

Re: [Libreoffice] Some more features

2010-10-06 Thread Miklos Vajna
On Thu, Oct 07, 2010 at 12:00:35AM +0200, Cédric Bosdonnat wrote: > I just pushed another patch: > > * Calc, Writer and Impress tables now can have dotted and dashed > borders. Are you sure about the RTF part? Looks like you're patching the old filter. When the new filter was a patch, Fridric

Re: [Libreoffice] Some more features...

2010-10-07 Thread Miklos Vajna
On Tue, Oct 05, 2010 at 09:45:47AM -0400, Kohei Yoshida wrote: > * Insert new sheet icon. This change adds a 'plus' icon at the right > end of the sheet tabs to allow quick insertion of new sheets. Hi, Is it intentional that if you open a read-only document (for example from a browser), t

Re: [Libreoffice] Some more features

2010-10-07 Thread Miklos Vajna
On Thu, Oct 07, 2010 at 12:42:01PM +0100, Michael Meeks wrote: > Oooh ! :-) do we have old, obsolete, and non-compiled code in git > master ? > > Does that make sense ? can we remove the old RTF cruft that we no > longer use ? That's right - when the RTF rework was a patch I just re

Re: [Libreoffice] LDFLAGS break configure

2010-10-07 Thread Miklos Vajna
On Thu, Oct 07, 2010 at 06:15:35PM +0200, Andreas Radke wrote: > '\''--without-git'\'' '\''--with-srcdir=/build/src'\'' Did you try --with-git? There has been some issue with proper quoting when passing args to the internal configure, and that has been fixed in git since beta1. Thanks. pgp4DU

Re: [Libreoffice] small utility script to handle ../bin/g and similar commands

2010-10-08 Thread Miklos Vajna
On Fri, Oct 08, 2010 at 08:58:26PM -0500, Norbert Thiebaud wrote: > # go up the chain until you find a .git > while [ ${current_dir} != "/" -a -d "${current_dir}" -a ! -d > "${current_dir}/.git" ] ; > do > current_dir=$(dirname "${current_dir}") > done do you know 'git rev-parse --show-cdup'

[Libreoffice] ixion breakage in sw

2010-10-08 Thread Miklos Vajna
Hi, 3.2.99.1 was fine here, but now that I updated to latest git (I already tried a clean build), I get the followings when I 'build' in sw: Entering /home/vmiklos/git/libreoffice/build/libreoffice-3.2.99.1/sw/util Making:libswli.so ../unxlngi6.pro/slo/cellfml.o: In function `lcl_Conver

Re: [Libreoffice] small utility script to handle ../bin/g and similar commands

2010-10-10 Thread Miklos Vajna
On Sat, Oct 09, 2010 at 11:00:55AM -0500, Norbert Thiebaud wrote: > The problem is that if you are in rootgit/rawbuild/vcl/source for example > git-rev-parse with give you ../../ > the same result as if you where at > rootgit/clone/libs-gui/vcl/source > and now you are in the road to readlin

Re: [Libreoffice] ixion breakage in sw

2010-10-10 Thread Miklos Vajna
On Sun, Oct 10, 2010 at 09:09:49PM +0100, Caolán McNamara wrote: > No idea, but I can tell that the ixion stuff isn't committed directly to > the split repos, but is still as patches that get applied in one of the > distro-modes, which is presumably why it's not a common build problem > for every

[Libreoffice] Fix RTF export crash with nested tables

2010-10-12 Thread Miklos Vajna
: Miklos Vajna Date: Wed, 13 Oct 2010 03:14:00 +0200 Subject: [PATCH] RTF: fix for nested tables The case when the original and the nested table has different cell / row number is now handled. This is done by invalidating the table writer before starting a new table and after finishing one. This is

[Libreoffice] Fix RTF export incorrect output with nested tables

2010-10-14 Thread Miklos Vajna
Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Thu, 14 Oct 2010 12:53:40 +0200 Subject: [PATCH] RTF: stacked fix for nested tables When the first cell of a table contains an other table, the definition of the outer table has to be written after the inner table. Introduce a stack to handle this

Re: [Libreoffice] Improving the build experience in rawbuild

2010-10-14 Thread Miklos Vajna
On Thu, Oct 14, 2010 at 09:31:29AM +0200, Cedric Bosdonnat wrote: > > > * Change the rawbuild/configure.in to have the defaults matching the > > > options defined in distros-config/LibreOfficeLinux.conf.in > > > > What about Mac? What about Windows? > > Hum... You're right! Any better idea to

[Libreoffice] [PATCH] Fix sc build

2010-10-17 Thread Miklos Vajna
h? Thanks, Miklos From cd178802357fe77499c81e6f20fb6f367ee24625 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Sun, 17 Oct 2010 21:44:19 +0200 Subject: [PATCH] sc: no longer include non-existing scpre.mk and sc.mk They were empty anyway so just including them fixes the problem. @@ -31,9 +31,7 @@ T

[Libreoffice] [PATCH] RTF: fix non-text frames

2010-10-18 Thread Miklos Vajna
From: Miklos Vajna Date: Mon, 18 Oct 2010 13:54:27 +0200 Subject: [PATCH] RTF: fix non-text frames Previously the exporter just crashed when the document contained a non-text frame (e.g. table). Fix this by properly calling MSWordExportBase::WriteText() instead of our custom method that handled

Re: [Libreoffice] User-experience <---> C++ classes

2010-10-22 Thread Miklos Vajna
On Thu, Oct 21, 2010 at 09:02:45PM -0300, Júlio Hoffimann wrote: > There is a place where i can make a connection between my user-experience > and LibreOffice's C++ classes? > > I know this link generated by Doxygen, http://docs.go-oo.org/, but would be > helpful an user point of view to get fam

Re: [Libreoffice] build failure loading pythonloader.uno.so

2010-10-23 Thread Miklos Vajna
On Sun, Oct 24, 2010 at 01:26:46AM +0200, Thomas Klausner wrote: > What is uno? It's a component framework, see here: http://wiki.services.openoffice.org/wiki/Uno > What is this registering step doing? In case a component is not registered, other components can't really use it. (Just like in

Re: [Libreoffice] Where should I edit the code? in clone or build directory?

2010-10-23 Thread Miklos Vajna
On Sat, Oct 23, 2010 at 11:22:20AM +0200, Nadav Vinik wrote: > Currently I edit the code in the clone dir and then use meld to copy > the changes to build/libreoffice* That sounds painful. :) > Where should I edit the code? Under clone/ or rawbuild/ (the later is just a collection of symlinks)

[Libreoffice] Script to find german comments in the code

2010-10-24 Thread Miklos Vajna
and publish the results on some webpage, so that translators don't have to run it themselves. Patch attached - is OK to push it? :) Thanks. From c4d279ffd089842a728e6d8cbde9f8936d37d4dc Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Sat, 23 Oct 2010 18:13:00 +0200 Subject: [PATCH]

Re: [Libreoffice] Script to find german comments in the code

2010-10-24 Thread Miklos Vajna
On Sun, Oct 24, 2010 at 07:19:55PM +0200, Jan Holesovsky wrote: > Sure - please go ahead. Can you please also update the EasyHacks page > with the info about how to run it? OK, I just pushed it and updated http://wiki.documentfoundation.org/Development/Easy_HacksTranslationOfComments showing a

[Libreoffice] [gitdm-lo-config PATCH] speed up an improve merging of logs

2010-10-25 Thread Miklos Vajna
b7045a6eb91eea3f137 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Mon, 25 Oct 2010 14:37:05 +0200 Subject: [PATCH] speed up an improve merging of logs Optimize merging of the logs by creating a single repo via hardlinks. This also fixes the output in case the merge of a commit has an earlie

Re: [Libreoffice] credits page is 403 access forbidden

2010-10-26 Thread Miklos Vajna
On Tue, Oct 26, 2010 at 01:50:06PM +0200, Cedric Bosdonnat wrote: > I'ld prefer without the graphs as it's only a credits page. Miklos > pointed to a nice script for git live stats, but I can't remember it. IIRC I mentioned this: http://mirror.celinuxforum.org/gitstat/ And I added that the cod

Re: [Libreoffice] javac problem when build libreoffice on opensuse

2010-10-26 Thread Miklos Vajna
On Tue, Oct 26, 2010 at 07:56:11PM +0800, ?? wrote: > i have javac in /usr/bin > but i get a problem when build libreoffice in opensuse follow > thehttp://www.documentfoundation.org/develop/ on the make command: > > checking whether to add custom build version... yes, libreoffice-build >

Re: [Libreoffice] Non compiling code on mono-uno-bridge (fix)

2010-10-29 Thread Miklos Vajna
On Thu, Oct 28, 2010 at 11:04:44PM -0500, Joshua Ismael wrote: > /me makes easy task on /scratch/mono-uno-bridge :) Again, in general such cleanups are recommended in the real repos, not in build.git. Run ./download and fine similar code under /clone/ :) Thanks. pgpbRJGCPSzhB.pgp Description:

Re: [Libreoffice] Some hints about git please...

2010-11-02 Thread Miklos Vajna
On Tue, Nov 02, 2010 at 11:02:56PM +0100, Gert Faller wrote: > 1) I update the 'clone' directory often. No problem with that. > 2) I've read that when updating 'clone', 'bin/g' must be run. >I don't find any 'g' in ./bin/. > 3) I don't know how to update easily the source in > 'build/libreof

Re: [Libreoffice] German Translations in Writer module

2010-11-03 Thread Miklos Vajna
On Wed, Nov 03, 2010 at 08:48:02PM +0530, "surensp...@gmail.com" wrote: > Thanks to spaetz for helping out with the quirky german comments for which > google translator did not work for. > --- > sw/inc/cmdid.h | 1105 > +--- > 1 files changed,

Re: [Libreoffice] ./download doesn't work behind a proxy

2010-11-03 Thread Miklos Vajna
On Wed, Nov 03, 2010 at 02:10:14PM +0100, Florian Effenberger wrote: > I'm no git expert, but if someone comes up with a script, that should be > no problem. We can mid-term also host our own git, but for the moment, > I'd stick with FD. Mirroring git repos is easy. :) To do the initial mirro

Re: [Libreoffice] OpenBSD bootstrap diffs

2010-11-03 Thread Miklos Vajna
On Thu, Nov 04, 2010 at 12:09:22AM +0100, Robert Nagy wrote: > Ooops the boostrap.diff and unxobsd.mk files were > wrong. Here are the correct ones. Could you please use 'git add' for unxobsd.mk, then 'git commit -a', write the commit message, finally 'git format-patch -1' to produce the patch?

Re: [Libreoffice] [PUSHED] Use /usr/bin/env bash

2010-11-03 Thread Miklos Vajna
On Thu, Nov 04, 2010 at 01:21:38AM +0100, Robert Nagy wrote: > --- > bin/g |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/bin/g b/bin/g > index f0928de..b1c80fc 100755 > --- a/bin/g > +++ b/bin/g > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/usr/bin/env bash Thanks, pu

Re: [Libreoffice] ./download doesn't work behind a proxy

2010-11-05 Thread Miklos Vajna
On Fri, Nov 05, 2010 at 08:52:19AM +0100, Marc-Oliver Straub wrote: > For such a cloned repository, will push be possible? Or is this then a > read-only repository? It's read-only. It's possible to make it writable, but I guess nobody wants to script a hook that would push back to the freedeskt

Re: [Libreoffice] Problem with sal/cppunittester

2010-11-05 Thread Miklos Vajna
On Fri, Nov 05, 2010 at 09:36:40PM +, Caolán McNamara wrote: > On Fri, 2010-11-05 at 21:10 +, Wols Lists wrote: > > Just doing an emerge cppunit. > > It shouldn't be necessary to use system cppunit, cppunit should be built > as part of the build. > > So, lets just document debugging thi

[Libreoffice] How to build for 3.3

2010-11-08 Thread Miklos Vajna
uild. Is it OK to push these patches to libreoffice-3-3? (I would push them to master, but make unpack is broken there for me, saying: make: /home/vmiklos/git/libreoffice/bin/transform: Command not found) Thanks. From adc319cbd1e9436b9606329f3abb7b607c040984 Mon Sep 17 00:00:00 2001 From: Miklos V

Re: [Libreoffice] How to build for 3.3

2010-11-09 Thread Miklos Vajna
On Tue, Nov 09, 2010 at 09:27:22PM +0100, Thorsten Behrens wrote: > yes, your changes are clearly an improvement. Re. master - > bin/transform is indeed gone, maybe rerun autogen? I'd like to have > them on master, too. :) Oh, yes. I forgot to re-run autogen, that fixed the issue. I just tested

Re: [Libreoffice] [QA] Existing practice & open questions

2010-11-11 Thread Miklos Vajna
On Thu, Nov 11, 2010 at 09:55:02AM +0100, Thorsten Behrens wrote: > * list of assignees is too small - we'd need more subject area >experts Not sure if such a small area worths mentioning, but I try to take care of RTF export bugs (as my time permits) + git-specific issues. pgpK4zpe3jrFt.

Re: [Libreoffice] bin/g clone now possible

2010-11-11 Thread Miklos Vajna
ost of the cases we want the same base url for build.git and the other repos. :) Patch attached, OK to push? Thanks. From b1245b53c462170e219d935be4985c74ba92edaa Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Thu, 11 Nov 2010 11:06:22 +0100 Subject: [PATCH] bin/g: make clone work without a par

Re: [Libreoffice] ooo/OOO330_m14 merged into libreoffice-3-3

2010-11-11 Thread Miklos Vajna
On Thu, Nov 11, 2010 at 08:04:38PM +0100, Rene Engelhard wrote: > On Thu, Nov 11, 2010 at 07:51:55PM +0100, Jan Holesovsky wrote: > > Either we can merge the entire libreoffice-3-3 there, or we can merge > > just ooo/OOO330_m14, and continue cherry picking between master and > > libreoffice-3-3.

Re: [Libreoffice] bin/g clone now possible

2010-11-11 Thread Miklos Vajna
ld bin/g clone to get the sources ready under rawbuild - so no extra 'bin/g pull' is needed. Does it look OK? Thanks. From 259dc7ef7a29a117d986d01f4f47df0e15891842 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Fri, 12 Nov 2010 01:58:27 +0100 Subject: [PATCH] bin/g: create symlinks un

Re: [Libreoffice] [PATCHES] Eight "small" patches to remove trailing whitespaces from help

2010-11-15 Thread Miklos Vajna
On Mon, Nov 15, 2010 at 02:08:52PM +0100, Jan Holesovsky wrote: > I am sorry, but as discussed previously [1], we would prefer not to fix > the trailing whitespace yet, until git with better merge strategies (to > handle whitespace changes flawlessly during merges) is released. Have you tried the

Re: [Libreoffice] [PATCHES] Eight "small" patches to remove trailing whitespaces from help

2010-11-16 Thread Miklos Vajna
On Tue, Nov 16, 2010 at 08:41:28AM +0100, Jan Holesovsky wrote: > That's exactly the one I wanted to try/use, and still do not have it in > my 1.7.3.1 (from > http://download.opensuse.org/repositories/devel:/tools:/scm/SLE_11/) :-( > Even the man page does not mention it here. > > Do you know if

Re: [Libreoffice] ixion breakage in sw

2010-11-16 Thread Miklos Vajna
On Tue, Nov 16, 2010 at 12:23:40PM +0100, Henrik /KaarPoSoft wrote: > It has been suggested to remove fields-table-formula.diff. > However, in the "apply" file, it is listed under [Fixes] which is > included in "Common", which is included in every distro. Except LibreOffice*, where even Common

Re: [Libreoffice] git push / FOSDEM

2011-02-07 Thread Miklos Vajna
On Mon, Feb 07, 2011 at 07:33:05PM +0100, Christina Roßmanith wrote: > I'm 3 commits ahead at home. But I have only the license to push the > middle one on my own. How can I do that?!? Using git rebase -i. See its manpage, you can reorder the commits so that the middle one will be the first, th

Re: [Libreoffice] git submodule

2011-02-07 Thread Miklos Vajna
On Mon, Feb 07, 2011 at 12:18:39PM -0600, Norbert Thiebaud wrote: > The problem of the tinderbox approach is the coarse granularity (it is > not uncommon to have 1/2 a dozen or more of independent commit between > 2 build, the reliability (tinderbox sometime are down and this is not > necessarily

Re: [Libreoffice] git submodule

2011-02-07 Thread Miklos Vajna
On Mon, Feb 07, 2011 at 10:33:00PM +0100, Miklos Vajna wrote: > Automatic git commit --amend is really dangerous, I would not do it. > It's not an accident non-fastforwards are rejected while pushing. It turns out I misunderstood it, I thought this is about git commit --amend in the

Re: [Libreoffice] self-introduction Bjoern Michaelsen

2011-02-08 Thread Miklos Vajna
On Tue, Feb 08, 2011 at 10:32:13AM +0100, Bjoern Michaelsen wrote: > I would like to shortly introduce myself as new contributor to > LibreOffice: Welcome! From git log: commit f6a16194d1348cb1c679acec5cd9e014ca3f3104 Author: bjoern.michael...@canonical.com Did you accidently swap your real

Re: [Libreoffice] Patch

2011-02-11 Thread Miklos Vajna
On Fri, Feb 11, 2011 at 12:16:20PM +0100, Bálint Dózsa wrote: > I have removed this unused method: > writerfilter::dmapper::ConversionHelper::convertDateTime(rtl::OUString > const&) Didn't you forget to remove its declaration from source/dmapper/ConversionHelper.hxx? pgpB8n1txgjRr.pgp Descript

[Libreoffice] [REVIEW] RTF unicode export - need patch review for -3-3

2011-02-11 Thread Miklos Vajna
Hi, This commit in master: http://cgit.freedesktop.org/libreoffice/writer/commit/?id=a37fae128b4badc8f9f2201e28dca3e08948ddec Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=33653 Could someone familiar with that code (Cedric, Caolan?) sign it off and cherry-pick, please? Thanks, Miklos

Re: [Libreoffice] [REVIEW] RTF unicode export - need patch review for -3-3

2011-02-11 Thread Miklos Vajna
On Fri, Feb 11, 2011 at 04:57:57PM +, Caolán McNamara wrote: > On Fri, 2011-02-11 at 17:35 +0100, Miklos Vajna wrote: > > Hi, > > > > This commit in master: > > > > http://cgit.freedesktop.org/libreoffice/writer/commit/?id=a37fae128b4badc8f9f220

Re: [Libreoffice] Easy Hack

2011-02-12 Thread Miklos Vajna
On Sat, Feb 12, 2011 at 11:34:52AM +0100, Bálint Dózsa wrote: > void DomainMapperTableHandler::startTable(unsigned int nRows, > - unsigned int /*nDepth*/, > + unsigned int, The nDepth is a useful info here, so we

Re: [Libreoffice] Patch

2011-02-14 Thread Miklos Vajna
On Mon, Feb 14, 2011 at 12:49:32PM +0100, Bálint Dózsa wrote: > -/** > - An iterator for traversal of a set of properties. > - > - Sample code for use of iterator: > - > - \code > - Return_t function(WW8PropertySet::tPointer pSet) > - { > - do_something; > - > - WW8PropertyS

[Libreoffice] [PATCH] git-hooks: don't stage unstaged hunks before commit

2011-03-02 Thread Miklos Vajna
to master? Thanks. From fb4a829b5f8a1eb4fb8a62d105217a8375dd6a62 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Thu, 3 Mar 2011 01:30:27 +0100 Subject: [PATCH] git-hooks: don't stage unstaged hunks before commit We call 'git add' for files where we fixed whitespaces in. This

[Libreoffice] [PATCH] get rid of duplicated .gitattributes files

2011-03-12 Thread Miklos Vajna
1) is for bootstrap 2) is for extensions/filters/libs-gui/testing OK to push? Thanks. From 23513602a6d68b65b127a42d461b9d9721273a46 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Sat, 12 Mar 2011 23:37:38 +0100 Subject: [PATCH] Introduce a single .gitattributes file in bootstrap --- .git

Re: [Libreoffice] [PATCH] get rid of duplicated .gitattributes files

2011-03-16 Thread Miklos Vajna
On Wed, Mar 16, 2011 at 10:31:51AM +0100, Jan Holesovsky wrote: > I would say so :-) Or - we could create links like we do for the hooks? > It would make it more obvious what is going on... Sure, done. :) pgpg7QR54iqzT.pgp Description: PGP signature

Re: [Libreoffice] Compiled failed in sw

2011-03-21 Thread Miklos Vajna
On Mon, Mar 21, 2011 at 09:07:32PM +0100, Julien Nabet wrote: > [/home/maryline/compile-libreoffice/libo/solver/300/unxlngi6.pro/workdir/CxxObject/sw/source/filter/ww8/docxattributeoutput.o] > > Erreur > > I didn't find unxlng directory but i suppose this has changed with gnumake. No, I got "

Re: [Libreoffice] Compiled failed in sw

2011-03-22 Thread Miklos Vajna
On Tue, Mar 22, 2011 at 01:57:29AM +0100, Miklos Vajna wrote: > No, I got "sw" to build with gnumake already, though I get the same > error after the last pull. I just started a full rebuild; if it's there, > it worths checking what's the problem. The attached pat

[Libreoffice] How do tab dialogs update model/view in Writer?

2011-03-23 Thread Miklos Vajna
Hi, I'm trying to partly implement this bug: https://bugs.freedesktop.org/show_bug.cgi?id=32413 To reproduce: start writer, type in some text, press F11, right click on Default->Modify, set for example font size from 12 to 14, and the target is to get the view updated without closing the dialog.

Re: [Libreoffice] How do tab dialogs update model/view in Writer?

2011-03-23 Thread Miklos Vajna
On Wed, Mar 23, 2011 at 01:29:12PM +0100, Miklos Vajna wrote: > Now what I can't find so far is: where is the code that updates the > model/view once the dialog is closed? I guess I want to call that from > the Apply handler, but I don't yet have an idea where

Re: [Libreoffice] [PATCH] removing the executable mode from some source files

2011-03-24 Thread Miklos Vajna
On Wed, Mar 23, 2011 at 11:58:44PM -0600, Tor Lillqvist wrote: > > Can you send me the git-hook pre-commit so I can try to modify it to make > > this tests automatically? > > but it should be in your git clone, surely? And whenever you invoke './g', it enables them in the local repo. Do a 'g d

[Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-24 Thread Miklos Vajna
it yet for easier review. What's your opinion, OK to push? Thanks. From c63be26e98290cb024078ba260b6bead796e6eca Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Thu, 24 Mar 2011 11:54:09 +0100 Subject: [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer --- vcl/inc/vcl/ms

Re: [Libreoffice] build error with stlport

2011-03-25 Thread Miklos Vajna
On Fri, Mar 25, 2011 at 03:31:00PM +0100, Andreas Radke wrote: > I only found some notes about ixion and fields-table-formula.diff > probably breaking this. > > Any idea about this? Yes, I think anyone using the build repo disables fields-table-formula.diff in the build. In the long term it'll

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-25 Thread Miklos Vajna
On Fri, Mar 25, 2011 at 08:48:25PM +, Michael Meeks wrote: > Looks lovely to me - though I guess it might be nice to just pick a > large number for RET_APPLY and not put that in vcl; that seems to be > how others do it eg. > > sfx2/inc/docvor.hxx:#define RET_EDIT_STYLE 100 > sfx

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-26 Thread Miklos Vajna
On Sat, Mar 26, 2011 at 12:42:36AM +0100, Miklos Vajna wrote: > Ah, I didn't see it. We talked about this with Cedric and he explained > an idea which avoids any modification in vcl, so I'm not planning to > push this version, a better one will come soon. > > The mai

Re: [Libreoffice] [PATCH] Fix curl location in download script

2011-03-26 Thread Miklos Vajna
On Sat, Mar 26, 2011 at 11:41:38PM +0100, Francois Tigeot wrote: > I've recently been bitten by the 'download' script, which was > unable to use curl, even tough it is in my $PATH. > > The attached patch replaces the strange and broken lookup logic > present in the script by a single 'which' com

Re: [Libreoffice] [PATCH] Fix curl location in download script

2011-03-27 Thread Miklos Vajna
On Sun, Mar 27, 2011 at 07:50:06AM +0200, Francois Tigeot wrote: > curl is required at the autogen.sh stage: if I try to run ./autogen.sh > without any curl package installed, I get this error: > > configure: error: install curl to run this script Fine, then we can be sure curl is installed. :)

Re: [Libreoffice] [PATCH] fdo#32413: Add an apply button to style edit dialog in Writer

2011-03-29 Thread Miklos Vajna
On Mon, Mar 28, 2011 at 09:54:56AM +0200, Cedric Bosdonnat wrote: > Ok, go and push it: it looks OK to me... Just make sure to leave another > easy hack for the position thing ;) Done: http://wiki.documentfoundation.org/Development/Easy_Hacks#Save_position_of_tab_dialogs pgpu9Rxljbxi1.pgp Desc

Re: [Libreoffice] subsequenttests now run headless

2011-03-29 Thread Miklos Vajna
On Tue, Mar 29, 2011 at 10:22:43PM +0200, Bjoern Michaelsen wrote: > subsequenttests runs headless now by default and seem to be very stable > that way. These tests are very good to parallelize. On my machine I see: Hi, I'm sure this is a newbie question, but what is the relation between unit t

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Miklos Vajna
[ My email address it .org, not .com. ] On Sun, Apr 03, 2011 at 08:36:45AM +0200, Julien Nabet wrote: > So for the moment, i put the hamcrest lines in comment but I'd like to > understand how the hamcrest lines could work or what is the problem with > my config. Thanks for pointing out, I jus

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-06 Thread Miklos Vajna
gt; first build). I'm attaching a patch that tries to implement this. I've tested with our (Frugalware) junit jar where the classpath is in manifest and also with upstream junit jar, which bundles hamcrest. OK to push to libreoffice-3-4? Miklos From 2be5486a20abe69b7e96e0b8333eb42b4cfe

Re: [Libreoffice] Build current master, stuck in odk, configmgr, more_fonts, sw

2011-04-08 Thread Miklos Vajna
On Fri, Apr 08, 2011 at 04:52:21PM +0100, Michael Meeks wrote: > > On Fri, 2011-04-08 at 16:10 +0100, Caolán McNamara wrote: > > > How do we keep platforms in sync? One tag per platform? > > > > I sort of imagined a rolling tag, last-known-buildable-platform or > > something of that nature. >

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-11 Thread Miklos Vajna
On Wed, Apr 06, 2011 at 01:07:43PM +0200, Miklos Vajna wrote: > I'm attaching a patch that tries to implement this. > > I've tested with our (Frugalware) junit jar where the classpath is in > manifest and also with upstream junit jar, which bundles hamcrest. > > O

Re: [Libreoffice] [PATCH] gitattributes .po filter performance problem

2011-04-11 Thread Miklos Vajna
On Mon, Apr 11, 2011 at 08:29:13PM +0200, Andras Timar wrote: > Hi, > > Some of us experienced performance problems with the gitattributes > filter defined for .po files. The 'clean' filter were not only run on > commit, but also during clone/pull. This was not intended at all. > Miklos asked ab

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-12 Thread Miklos Vajna
On Wed, Apr 13, 2011 at 12:45:29AM +0200, Rene Engelhard wrote: > It looks OK code-wise, but TBH I don't see a sense in this. Distros should fix > their jars, we shouldn't hide problems. > And if the problem is widespread - so be it. One more reason to get distro > maintainers fix it. > > What i

[Libreoffice] -conver-to on master

2011-04-14 Thread Miklos Vajna
Hi, On -3-3, the following works fine: libreoffice -nologo -convert-to rtf -outdir /home/vmiklos/git/libreoffice/lo-test-files/writer/bug/35985/out /home/vmiklos/git/libreoffice/lo-test-files/writer/bug/35985/test.rtf On master, I tried: ./soffice.bin --nologo --convert-to rtf --outdir /home/vm

Re: [Libreoffice] libreoffice-build 3.3.99.1 not on the mirrors

2011-04-16 Thread Miklos Vajna
On Sat, Apr 16, 2011 at 12:49:09PM +0200, Andreas Radke wrote: > any reason why it is still missing? all other sources seem to be there. See the last sentence of http://article.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/9273 pgpD19wg2Dptn.pgp Description: PGP signature _

Re: [Libreoffice] -conver-to on master

2011-04-17 Thread Miklos Vajna
eadless, in 3.4 it does not. The attached patch fixes the issue for me. Does it look sane? Thanks. From 73290beeff9e0cd4e67065aec6ba869fac2e7605 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Sun, 17 Apr 2011 22:01:19 +0200 Subject: [PATCH] Make -conver-to imply -headless --- desktop

Re: [Libreoffice] -conver-to on master

2011-04-18 Thread Miklos Vajna
On Mon, Apr 18, 2011 at 01:52:13PM +0530, Muthu Subramanian K wrote: > Seems to work for me without the patch. How old or new is your master, > please? [ Or I guess you are running without any input files! for the > conversion to work! ] Hmm, this is interesting. ;) The build I'm hacking here i

Re: [Libreoffice] -conver-to on master

2011-04-18 Thread Miklos Vajna
On Mon, Apr 18, 2011 at 12:48:16PM +0300, Simos Xenitellis wrote: > I tried LibreOffice 3.4 (pre-release) and it works with 'csv' to 'ods' > conversion, > as described in > http://www.mail-archive.com/users@libreoffice.org/msg03444.html > > ./soffice.bin --headless --convert-to ods /tmp/test.cs

Re: [Libreoffice] -conver-to on master

2011-04-18 Thread Miklos Vajna
On Mon, Apr 18, 2011 at 01:08:42PM +0200, Miklos Vajna wrote: > ~/git/libreoffice/master/install/program$ file hello.odt > hello.odt: OpenDocument Text > ~/git/libreoffice/master/install/program$ ./soffice.bin --headless > --convert-to rtf hello.odt > convert /home/vmiklos/

Re: [Libreoffice] [ANNOUNCE] libreoffice-3.3.99.2 tag created (3.4.0-beta2)

2011-04-20 Thread Miklos Vajna
On Tue, Apr 19, 2011 at 07:27:51PM +0200, Petr Mladek wrote: > The build repo is not tagged. We would like to get rid of it. Hi Petr, One question: the old build repo created .txt filelists in the build/ directory which helped creating subpackages: we could just read lang_*_list.txt to split lan

[Libreoffice] [PATCH] ooinstall: respect DESTDIR

2011-05-03 Thread Miklos Vajna
ks ok, then sign off / push it to -3-4? Thanks. From 0cabc8890365201cd8ad5764473c5fe50e0f06f5 Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Tue, 3 May 2011 14:27:06 +0200 Subject: [PATCH] ooinstall: respect DESTDIR The problem was that ooinstall just passed -destdir to make_installer.pl, but

[Libreoffice] [PATCH] Fix osl_Security::getHomeDir test under fakeroot

2011-05-08 Thread Miklos Vajna
Hi, See the attached patch, I needed it to build 3.4beta4 under fakeroot (for some reason I did not have this issue with beta3). Can someone sign it off and push to -3-4, please? Thanks. From f68130520cad8ff76559f6e5bf202cf076297b9d Mon Sep 17 00:00:00 2001 From: Miklos Vajna Date: Sun, 8 May

Re: [Libreoffice] Build failure: - start unit test #1 on library ../../../unxlngx6.pro/lib/libosl_Security.so

2011-05-09 Thread Miklos Vajna
On Sun, May 08, 2011 at 05:43:54PM +0200, KAMI911 KAMI911 wrote: > Failures !!! > Run: 10 Failure total: 1 Failures: 1 Errors: 0 > dmake: Error code 1, while making 'test1' > ---* tg_merge.mk *--- > > Hov can I fix it? Are you under fakeroot? I posted a patch here: http://thread.gmane.o

Re: [Libreoffice] Build failure: - start unit test #1 on library ../../../unxlngx6.pro/lib/libosl_Security.so

2011-05-09 Thread Miklos Vajna
On Mon, May 09, 2011 at 11:11:24AM +0200, KAMI911 KAMI911 wrote: > until now I used general user to build, should use fakeroot or real root? No, normal user is correct, fakeroot is only useful to get files in tarballs owned by root without real root access. If it failed for you without fakeroo

[Libreoffice-commits] core.git: 2 commits - sw/source

2013-03-08 Thread Miklos Vajna
sw/source/core/table/swtable.cxx |5 + sw/source/core/txtnode/ndtxt.cxx |2 +- 2 files changed, 2 insertions(+), 5 deletions(-) New commits: commit 332fa1344aaaf8ff190c594fe5829cf1551c5211 Author: Miklos Vajna Date: Fri Mar 8 18:11:16 2013 +0100 SwTableBox::IsValidNumTxtNd

[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sw/source

2013-03-08 Thread Miklos Vajna
sw/source/core/table/swtable.cxx |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit a31707dd91aec5d2dc5b8060ef42960b709ec068 Author: Miklos Vajna Date: Fri Mar 8 18:11:16 2013 +0100 SwTableBox::IsValidNumTxtNd: Allow trivial formatting Not allowing

[Libreoffice-commits] core.git: sw/CppunitTest_sw_odfexport.mk sw/CppunitTest_sw_odfimport.mk sw/CppunitTest_sw_ooxmlexport.mk sw/CppunitTest_sw_ooxmlimport.mk sw/CppunitTest_sw_rtfexport.mk sw/Cppuni

2013-03-18 Thread Miklos Vajna
e4e4f776b8b8ef8d9861f5e771c72219314f4ab6 Author: Miklos Vajna Date: Mon Mar 18 09:47:02 2013 +0100 let toplevel 'make -sr CppunitTest_sw_ooxmlexport' (and friends) work again Change-Id: I610ae1d3672f76435def025bd8819780df863dbe diff --git a/sw/CppunitTest_sw_odfexpo

Re: fdo#55814: unit test is missing

2013-03-18 Thread Miklos Vajna
Hi David, On Sat, Mar 09, 2013 at 02:29:54PM +0100, David Ostrovsky wrote: > I wonder why we don't have any unit test for that part of code? We do have one: http://cgit.freedesktop.org/libreoffice/core/commit/?id=10e02dfdffb5ef3a02a40b52c6cda176f7f4447c It's just not testing the case we have

[Libreoffice-commits] core.git: sw/qa writerfilter/source

2013-03-18 Thread Miklos Vajna
sw/qa/extras/rtfimport/data/fdo61909.rtf |6 ++ sw/qa/extras/rtfimport/rtfimport.cxx |8 writerfilter/source/rtftok/rtfdocumentimpl.cxx |5 + 3 files changed, 19 insertions(+) New commits: commit 60c17b2873506ed8b068b34840aecda0c1d9bd65 Author: Miklos

<    2   3   4   5   6   7   8   9   10   11   >