[Libreoffice-commits] core.git: vcl/workben

2017-03-19 Thread Khaled Hosny
vcl/workben/commonfuzzer.hxx |2 +- vcl/workben/fftester.cxx |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) New commits: commit 550c6ed03a6d5d56ec23ce0d18d081b03226f539 Author: Khaled Hosny Date: Sun Mar 19 16:55:17 2017 +0200 Typo Change-Id

[Libreoffice-commits] core.git: vcl/inc vcl/source

2017-03-19 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx|9 - vcl/source/gdi/CommonSalLayout.cxx | 14 -- 2 files changed, 12 insertions(+), 11 deletions(-) New commits: commit 12490e743fadd9e1d509cdaeee67ccb15e024657 Author: Khaled Hosny Date: Sun Mar 19 17:01:02 2017 +0200 This

Re: Failing VCL complextext rendering unit test on Windows

2017-03-24 Thread Khaled Hosny
On Fri, Mar 24, 2017 at 11:29:52AM +0100, Jan-Marek Glogowski wrote: > Hi everyone, > > when running > > $ /opt/lo/bin/make-4.2.1-msvc -C vcl CppunitTest_vcl_complextext > > on Windows 7, KVM QXL GUI via Spice I get the following failures: […] > All height values are the same, just the width an

Re: Failing VCL complextext rendering unit test on Windows

2017-03-24 Thread Khaled Hosny
On Fri, Mar 24, 2017 at 02:01:34PM +0100, Jan-Marek Glogowski wrote: > Am 24.03.2017 um 12:32 schrieb Khaled Hosny: > > On Fri, Mar 24, 2017 at 11:29:52AM +0100, Jan-Marek Glogowski wrote: > >> Hi everyone, > >> > >> when running > >&

Re: Failing VCL complextext rendering unit test on Windows

2017-03-24 Thread Khaled Hosny
On Fri, Mar 24, 2017 at 04:16:29PM +0200, Khaled Hosny wrote: > The tinderbox emails don’t give a link to the log, but quoting from the > email: > > > complextext.cxx:64:Assertion > > Test name: VclComplexTextTest::testArabic > > equality assertion failed > > - E

[Libreoffice-commits] core.git: i18npool/qa i18npool/source

2017-03-28 Thread Khaled Hosny
i18npool/qa/cppunit/test_breakiterator.cxx |4 i18npool/source/breakiterator/breakiteratorImpl.cxx |3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) New commits: commit 55ddbfc610d2a00e565ca7bcb0277da33bb90947 Author: Khaled Hosny Date: Tue Mar 28 19:58:25 2017

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - i18npool/qa i18npool/source

2017-03-29 Thread Khaled Hosny
i18npool/qa/cppunit/test_breakiterator.cxx |4 i18npool/source/breakiterator/breakiteratorImpl.cxx |3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) New commits: commit 1c5d8ea51f9da89d76b2b2d3bb896225a6ac9dca Author: Khaled Hosny Date: Tue Mar 28 19:58:25 2017

Re: Unix-based systems not using CUPS

2017-04-03 Thread Khaled Hosny
On Tue, Apr 04, 2017 at 09:31:55AM +1000, Chris Sherlock wrote: > > However, now that CUPS is pretty much standardised on mostly > everything - including, it appears, on an increasing number of *BSD > systems - is psprint still required for systems that are sticking with > lpr? My understanding (a

[Libreoffice-commits] core.git: download.lst external/harfbuzz

2018-01-15 Thread Khaled Hosny
3b773d5b41628c1ccf52bdd0d7962183d54c4138 Author: Khaled Hosny Date: Mon Jan 15 15:22:13 2018 +0200 Upload HarfBuzz 1.7.4 Change-Id: I7dd1f87dc95d0fb190755a8742d28ef8679d7b1e Reviewed-on: https://gerrit.libreoffice.org/47897 Tested-by: Jenkins Reviewed-by: Khaled Hosny diff --git a/download.lst b

[Libreoffice-commits] core.git: vcl/inc vcl/source

2018-02-08 Thread Khaled Hosny
vcl/inc/sft.hxx | 16 vcl/source/fontsubset/sft.cxx | 79 -- 2 files changed, 95 deletions(-) New commits: commit e3caecb5a33288dd46a80b2ffcc47a2288305052 Author: Khaled Hosny Date: Thu Feb 8 14:31:34 2018 +0200 Removed

[Libreoffice-commits] core.git: vcl/source

2018-02-08 Thread Khaled Hosny
vcl/source/gdi/embeddedfontshelper.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit c6f39e81ef0615323833270fa434451801e3b21d Author: Khaled Hosny Date: Thu Feb 8 14:40:35 2018 +0200 Use a more direct link to the relevant part Change-Id

[Libreoffice-commits] core.git: vcl/inc vcl/source

2018-02-08 Thread Khaled Hosny
vcl/inc/sft.hxx|6 +- vcl/source/fontsubset/sft.cxx |2 -- vcl/source/gdi/embeddedfontshelper.cxx |2 +- 3 files changed, 2 insertions(+), 8 deletions(-) New commits: commit 59e1fced2b4115a882ffc1ac31a66f8d8e8793ff Author: Khaled Hosny Date

[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - vcl/inc vcl/source

2018-02-08 Thread Khaled Hosny
vcl/inc/sft.hxx | 18 vcl/source/fontsubset/sft.cxx | 85 -- 2 files changed, 103 deletions(-) New commits: commit f0416352ba0290087ad20f4e3a84c34fe7212a21 Author: Khaled Hosny Date: Thu Feb 8 14:31:34 2018 +0200 Removed

[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - vcl/inc vcl/source

2018-02-08 Thread Khaled Hosny
vcl/inc/sft.hxx | 16 vcl/source/fontsubset/sft.cxx | 79 -- 2 files changed, 95 deletions(-) New commits: commit cf3c1bd0b91fe68682a7a3c3cb34066e1fb8d17c Author: Khaled Hosny Date: Thu Feb 8 14:31:34 2018 +0200 Removed

Re: Implementing accessibility non-regression check tool

2018-02-23 Thread Khaled Hosny
On Thu, Feb 22, 2018 at 04:13:42PM +0100, Samuel Thibault wrote: > Stephan Bergmann, on jeu. 22 févr. 2018 15:49:40 +0100, wrote: > > That means external/lxml will need to: > > > > * build against and run with either the system Python or the locally-built > > one from external/python3, > > > > *

[Libreoffice-commits] core.git: editeng/source

2018-03-07 Thread Khaled Hosny
editeng/source/editeng/impedit2.cxx | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) New commits: commit 7a683c31e090e5a81debadcef025df9cd61c75f0 Author: Khaled Hosny Date: Wed Mar 7 23:29:15 2018 +0200 tdf#116157: Always apply Unicode Bidi in editeng

[Libreoffice-commits] core.git: vcl/source

2018-03-12 Thread Khaled Hosny
vcl/source/outdev/text.cxx | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) New commits: commit 489c7088b4a99720d1a2839ed52b3becd7aac342 Author: Khaled Hosny Date: Mon Mar 12 17:41:36 2018 +0200 tdf#116322: Don’t hard-code RTL character ranges

[Libreoffice-commits] core.git: vcl/source

2018-03-13 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit ae0a3825f5ad06ff8d6ae3cb388e215d8abe2eb7 Author: Khaled Hosny Date: Tue Mar 13 16:14:47 2018 +0200 tdf#116344: Don’t Kashida justify Syriac text I’ve always

[Libreoffice-commits] core.git: vcl/source

2017-03-02 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 100da4fadbab795bf470a2e46790d36a7c46d944 Author: Khaled Hosny Date: Fri Mar 3 00:00:11 2017 +0200 Typo Change-Id: I63c0fb6ba0884aa1bcb6c72a8a56efc41d183c0a diff --git

Re: Minutes of ESC call: 2017-03-02

2017-03-03 Thread Khaled Hosny
On Fri, Mar 03, 2017 at 11:41:09AM +0100, Jan Holesovsky wrote: > + community edition IDE can't be used until you register > + E-mail + Account on MS stuff... > + only blocks the IDE, not compiler. Though the UI suggests this (no option to skip) when

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/win

2017-03-03 Thread Khaled Hosny
: Khaled Hosny Date: Fri Mar 3 05:15:14 2017 +0200 tdf#103831, tdf#100986: Force using GDI when needed Our DirectWrite renderer is incomplete and can’t handle rotated text or text with horizontal scaling, so route these two through GDI for now. Change-Id

[Libreoffice-commits] core.git: 3 commits - vcl/inc vcl/win

2017-03-03 Thread Khaled Hosny
vcl/inc/win/salgdi.h |2 vcl/inc/win/winlayout.hxx | 17 +++--- vcl/win/gdi/winlayout.cxx | 113 -- 3 files changed, 22 insertions(+), 110 deletions(-) New commits: commit c328c26a67a865d965cb8bde1b248eeae92f4e75 Author: Khaled Hosny Date

[Libreoffice-commits] core.git: vcl/source

2017-03-03 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 919d5ac6b02e85126b3938c31daf4a891d3b2d90 Author: Khaled Hosny Date: Sat Mar 4 05:06:47 2017 +0200 Make vcl.harfbuzz logging less verbose Change-Id

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/win

2017-03-04 Thread Khaled Hosny
vcl/inc/win/winlayout.hxx | 12 +++- vcl/win/gdi/winlayout.cxx | 39 +-- 2 files changed, 20 insertions(+), 31 deletions(-) New commits: commit 7453cb58df4ce434a1252567f961cfe497064aca Author: Khaled Hosny Date: Sat Mar 4 05:40:39 2017 +0200

[Libreoffice-commits] core.git: vcl/inc vcl/source

2017-03-04 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx|2 - vcl/source/gdi/CommonSalLayout.cxx | 57 + 2 files changed, 41 insertions(+), 18 deletions(-) New commits: commit 5c617a811724a45dd8688869eeafac4c44f6a8aa Author: Khaled Hosny Date: Sun Mar 5 00:04:35 2017

[Libreoffice-commits] core.git: vcl/qa

2017-03-06 Thread Khaled Hosny
vcl/qa/cppunit/complextext.cxx | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) New commits: commit 9af45ef67824f3ec6e95c16e7deb005a73532d65 Author: Khaled Hosny Date: Mon Mar 6 16:43:57 2017 +0200 Try harder to debug the random TB failures here

Re: Chart test failures on mac: text size differences

2017-03-06 Thread Khaled Hosny
On Mon, Mar 06, 2017 at 11:21:25AM +, Tamas Zolnai wrote: > On Tuesday, February 28, 2017 23:42 GMT, Khaled Hosny > wrote: > > > On Tue, Feb 28, 2017 at 11:02:30PM +, Tamas Zolnai wrote: > > > Hi Khaled, > > > > > > > I don’t think text width

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/inc vcl/source vcl/win

2017-03-07 Thread Khaled Hosny
: Khaled Hosny Date: Fri Mar 3 05:15:14 2017 +0200 tdf#103831, tdf#100986: Force using GDI when needed Our DirectWrite renderer is incomplete and can’t handle rotated text or text with horizontal scaling, so route these two through GDI for now. Reviewed-on: https

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3-1' - include/vcl sw/source vcl/source

2017-03-07 Thread Khaled Hosny
: Khaled Hosny Date: Sun Feb 19 22:21:40 2017 +0200 tdf#106096: Fix visible space on Mac with the new layout engine This is not an issue on master since the alternative Mac code path is gone, but we need to skip it in 5.3 when the old layout engine is not used as well

Re: Chart test failures on mac: text size differences

2017-03-07 Thread Khaled Hosny
On Mon, Mar 06, 2017 at 07:56:40PM +0200, Khaled Hosny wrote: > On Mon, Mar 06, 2017 at 11:21:25AM +, Tamas Zolnai wrote: > > On Tuesday, February 28, 2017 23:42 GMT, Khaled Hosny > > wrote: > > > > > On Tue, Feb 28, 2017 at 11:02:30PM +, Tamas Z

[Libreoffice-commits] core.git: vcl/source

2017-03-10 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 3cee50476e422e3ed84169cdcbe6bd9883fc9316 Author: Khaled Hosny Date: Fri Mar 10 16:53:08 2017 +0200 tdf#106466: Use graphite2 shaper first We want to always prefer

[Libreoffice-commits] core.git: download.lst

2017-03-10 Thread Khaled Hosny
download.lst | 57 - 1 file changed, 57 deletions(-) New commits: commit 423cc764291bc07acb9d4d2414151b08de232a0f Author: Khaled Hosny Date: Sat Mar 11 03:13:33 2017 +0200 If these *_MD5SUM are not used, why keep them

[Libreoffice-commits] core.git: Makefile.fetch

2017-03-12 Thread Khaled Hosny
Makefile.fetch |5 + 1 file changed, 1 insertion(+), 4 deletions(-) New commits: commit 48670533998f078525f7dad94b89bc371a5b3947 Author: Khaled Hosny Date: Sat Mar 11 04:09:21 2017 +0200 Ignore the checksum embedded in the file name That is always MD5 sum, but we expect

[Libreoffice-commits] core.git: chart2/qa include/vcl vcl/source

2017-03-14 Thread Khaled Hosny
| 13 vcl/source/outdev/outdev.cxx |1 vcl/source/outdev/text.cxx|4 - 11 files changed, 96 insertions(+), 104 deletions(-) New commits: commit ded07624096183ed310187f29d4692bb39b7d24a Author: Khaled

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source

2017-03-17 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 68b546b17afa0082862f2a20b8f089ae9124a16a Author: Khaled Hosny Date: Fri Mar 10 16:53:08 2017 +0200 tdf#106466: Use graphite2 shaper first We want to always prefer

[Libreoffice-commits] core.git: vcl/source

2017-03-17 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) New commits: commit 6c0525ff453464525cf6f5f2778e55b32de20e01 Author: Khaled Hosny Date: Sat Mar 18 08:00:04 2017 +0200 Move the check to start, clearer this way Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/inc vcl/source

2017-03-19 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx|2 - vcl/source/gdi/CommonSalLayout.cxx | 57 + 2 files changed, 41 insertions(+), 18 deletions(-) New commits: commit 49eadd40b5f0de6fa97498d89f20118b996385d2 Author: Khaled Hosny Date: Sun Mar 5 00:04:35 2017

[Libreoffice-commits] core.git: vcl/source

2016-11-10 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) New commits: commit ba2137d5117f3cd63d781dd545726cefddbcb1ff Author: Khaled Hosny Date: Thu Nov 10 19:48:08 2016 +0200 Reduce scope Change-Id

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/source vcl/win

2016-11-11 Thread Khaled Hosny
deletions(-) New commits: commit 30fefcf71417f8c8644f5c0d3cb28c8c7f92a6c7 Author: Khaled Hosny Date: Fri Nov 11 13:58:21 2016 +0200 tdf#103725: Fix horizontal scaling on Windows * Restore the hack for adjusting font width on Windows, for the life of me I can’t find where we

[Libreoffice-commits] core.git: vcl/source

2016-11-11 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) New commits: commit c49d5dea164b09b05a898495fa2dd48b7ca4f0e4 Author: Khaled Hosny Date: Fri Nov 11 18:24:11 2016 +0200 tdf#103765: Minimize the effect of rounding to int

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/source

2016-11-11 Thread Khaled Hosny
vcl/inc/sallayout.hxx |8 +++- vcl/source/gdi/CommonSalLayout.cxx | 17 +++-- 2 files changed, 14 insertions(+), 11 deletions(-) New commits: commit 553cfda502a1516673233e409f91372766da6c4d Author: Khaled Hosny Date: Fri Nov 11 19:38:16 2016 +0200 tdf

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/quartz vcl/source

2016-11-12 Thread Khaled Hosny
tUInt32(pTable, 50)); +append(rUnicodeRange.get(), 96, GetUInt32(pTable, 54)); bRet = true; if (nLength >= 86) { rCodePageRange = std::bitset(); -append(rCodePageRange.get(), 0, GetUInt32(pTable, 78, 1)); -append(rCodePageR

[Libreoffice-commits] core.git: vcl/quartz

2016-11-13 Thread Khaled Hosny
vcl/quartz/salgdi.cxx |2 -- 1 file changed, 2 deletions(-) New commits: commit 24707c7b8d5e7b3d72decb9749b83153b273917f Author: Khaled Hosny Date: Sun Nov 13 14:24:39 2016 +0200 Fix build Change-Id: I55db5ba855b8d72e9be0298a68b094c7b01d9f54 diff --git a/vcl/quartz

[Libreoffice-commits] core.git: 3 commits - vcl/quartz vcl/unx

2016-11-13 Thread Khaled Hosny
ebfe8bb2b2cfc3dba063260bf746db923a3693f2 Author: Khaled Hosny Date: Sun Nov 13 18:59:44 2016 +0200 tdf#103895: Another fix too macOS glyph bounding Apply font rotation when calculating glyph bounding rectangle. Change-Id: I9c533ec3b33a5858d46b60d1700a50d3b6f915a4 diff --git a/vcl/quartz/ctfonts.cxx b

[Libreoffice-commits] core.git: vcl/source vcl/win

2016-11-14 Thread Khaled Hosny
ea95ced269dceb72681f0e4a21d87499153d5781 Author: Khaled Hosny Date: Sun Nov 13 22:54:58 2016 +0200 Revert "tdf#103725: Fix horizontal scaling on Windows" This reverts commit 30fefcf71417f8c8644f5c0d3cb28c8c7f92a6c7. Thuough it works on my system, others report that it made things worse. A bet

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/win

2016-11-15 Thread Khaled Hosny
Author: Khaled Hosny Date: Mon Nov 14 00:52:14 2016 +0200 tdf#103725: Fix horizontal scaling on Windows * Create IDWriteFont from LOGFONT instead of HDC, as it seems the later will discard the font width. Without font width, GDI/DirectWrite will not scale the font

[Libreoffice-commits] core.git: vcl/inc vcl/win

2016-11-15 Thread Khaled Hosny
d436065bc1c68fc2d90e73253d8c00503c72dfd0 Author: Khaled Hosny Date: Tue Nov 15 13:48:45 2016 +0200 tdf#103725: Default to GDI even with the new layout engine It seems that our DirectWrite integration is missing few key features, so back to GDI so at least people who need these feature can have away to make them

[Libreoffice-commits] core.git: vcl/unx

2016-11-15 Thread Khaled Hosny
vcl/unx/generic/gdi/cairotextrender.cxx | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) New commits: commit ff08ee6ab2e11360f9260462b15f5ca133007101 Author: Khaled Hosny Date: Tue Nov 15 21:47:39 2016 +0200 tdf#103785: Correctly position vertical glyphs

[Libreoffice-commits] core.git: 2 commits - vcl/unx

2016-11-15 Thread Khaled Hosny
vcl/unx/generic/gdi/cairotextrender.cxx |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) New commits: commit 84f644eee78106f01486098d446d9163b62927eb Author: Khaled Hosny Date: Wed Nov 16 01:05:35 2016 +0200 tdf#103784: Shift the upright glyphs like old code It

Demystifying “symbol” fonts

2016-11-17 Thread Khaled Hosny
Hi all, I’m looking into bug 103944, which is mainly about handling so-called symbol fonts. The bullets in the bug document use the “Symbol” font from Windows, which has “symbol” cmap subtable that maps characters from Private Use Area to its own glyphs. Because the document uses PUA symbols, wit

Re: Demystifying “symbol” fonts

2016-11-17 Thread Khaled Hosny
On Thu, Nov 17, 2016 at 02:12:49PM +0100, Miklos Vajna wrote: > Hi Khaled, > > On Thu, Nov 17, 2016 at 02:00:13PM +0200, Khaled Hosny > wrote: > > Now, AFAIK, all glyphs in “Symbol” font have proper characters in > > Unicode (and the font itself supports them as well, in

Re: Demystifying “symbol” fonts

2016-11-17 Thread Khaled Hosny
On Thu, Nov 17, 2016 at 02:07:34PM +0100, Stephan Bergmann wrote: > On 11/17/2016 01:00 PM, Khaled Hosny wrote: > > I’m looking into bug 103944, which is mainly about handling so-called > > symbol fonts. > > > > The bullets in the bug document use the “Symbol” font

Re: Demystifying “symbol” fonts

2016-11-17 Thread Khaled Hosny
On Thu, Nov 17, 2016 at 07:46:40PM +, toki wrote: > > > On 17/11/2016 12:00, Khaled Hosny wrote: > > > The bullets in the bug document use the “Symbol” font from Windows, > > which has “symbol” cmap subtable that maps characters from Private Use > > Area

Re: Demystifying “symbol” fonts

2016-11-17 Thread Khaled Hosny
On Thu, Nov 17, 2016 at 09:10:28PM +, Caolán McNamara wrote: > On Thu, 2016-11-17 at 14:00 +0200, Khaled Hosny wrote: > > Hi all, > > > > I’m looking into bug 103944, which is mainly about handling so-called > > symbol fonts. > > > > The bullets in the

Re: Demystifying “symbol” fonts

2016-11-17 Thread Khaled Hosny
On Fri, Nov 18, 2016 at 02:28:59AM +0200, Khaled Hosny wrote: > So I think the problem here is that we are not doing any glyph fallback > for OpenSymbol. Looks like we skip glyph fallback for symbol fonts in > vcl/unx/generic/fontmanager/fontsubst.cxx > FcPreMatchSubstitution::FindFo

[Libreoffice-commits] core.git: unotools/source

2016-11-17 Thread Khaled Hosny
unotools/source/misc/fontcvt.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 43b5ca69aa545cf93eded55258d92d651917815f Author: Khaled Hosny Date: Fri Nov 18 05:25:54 2016 +0200 Correct minute mapping from Adobe Symbol encoding It should be mapped

[Libreoffice-commits] core.git: sw/qa sw/source

2016-11-17 Thread Khaled Hosny
dev/null |binary sw/qa/extras/ww8export/ww8export.cxx |6 -- sw/source/filter/ww8/ww8par6.cxx |5 - 3 files changed, 11 deletions(-) New commits: commit d8c386593e42e1f0cce52d052b1009c59e75afa2 Author: Khaled Hosny Date: Thu Nov 17 15:03:39

[Libreoffice-commits] core.git: 3 commits - extras/source unotools/source

2016-11-18 Thread Khaled Hosny
4034babeb51af323ff2a47642e3a1386fc1d6b46 Author: Khaled Hosny Date: Fri Nov 18 13:40:04 2016 +0200 Make this look less wired Change-Id: I20b6a5e6ecdf48e1ca8df2e7e86248eae666c9f1 diff --git a/unotools/source/misc/fontcvt.cxx b/unotools/source/misc/fontcvt.cxx index e42c9b3..b48f210 100644 --- a/unotools/source/misc

[Libreoffice-commits] core.git: 2 commits - extras/source vcl/source

2016-11-19 Thread Khaled Hosny
extras/source/truetype/symbol/README |6 +++--- vcl/source/gdi/CommonSalLayout.cxx | 10 ++ 2 files changed, 9 insertions(+), 7 deletions(-) New commits: commit 7a072614b234529d24515464c3f6575bb33480e5 Author: Khaled Hosny Date: Sat Nov 19 15:35:59 2016 +0200 Typos

[Libreoffice-commits] core.git: vcl/unx

2016-11-19 Thread Khaled Hosny
vcl/unx/generic/glyphs/freetype_glyphcache.cxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 4c46c3046fb922f65b562e893e59d6b67ea5b2c2 Author: Khaled Hosny Date: Sat Nov 19 19:58:42 2016 +0200 We don’t use this with the new layout engine Don’t

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-11-19 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx|3 + vcl/source/gdi/CommonSalLayout.cxx | 60 - 2 files changed, 56 insertions(+), 7 deletions(-) New commits: commit 0f3861e65d8e652dcc31cf9a2f2b5c1a0a73b86d Author: Khaled Hosny Date: Sat Nov 19 21:32:19 2016

[Libreoffice-commits] core.git: vcl/inc

2016-11-21 Thread Khaled Hosny
vcl/inc/sft.hxx | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) New commits: commit 05d175a8efceccd684c9e3d7f428073f1b142346 Author: Khaled Hosny Date: Mon Nov 21 16:23:19 2016 +0200 Minor Change-Id: Icb074b628ae479dfe05cc1fe10121f96c492806e diff --git a

Tip for debugging CppunitTest_sd_tiledrendering failure

2016-11-21 Thread Khaled Hosny
I’m having a failure on Linux in this test, I can reproduce it locally but I have no idea how to debug it: http://ci.libreoffice.org/job/lo_gerrit/2956/Config=linux_gcc_release_64/console (for https://gerrit.libreoffice.org/#/c/31053/). The test apparently checks if a mouse event at a certain pos

Re: Tip for debugging CppunitTest_sd_tiledrendering failure

2016-11-21 Thread Khaled Hosny
On Mon, Nov 21, 2016 at 11:51:09PM -0500, Ashod Nakashian wrote: > Hi Khaled, > > On Mon, Nov 21, 2016 at 7:19 PM, Khaled Hosny wrote: > > > I’m having a failure on Linux in this test, I can reproduce it locally > > but I have no idea how to debug it: > > http://ci

[Libreoffice-commits] core.git: extras/source

2016-11-22 Thread Khaled Hosny
extras/source/truetype/symbol/OpenSymbol.sfd | 620 ++- extras/source/truetype/symbol/opens___.ttf |binary 2 files changed, 616 insertions(+), 4 deletions(-) New commits: commit 37a14c5e359a554195fbcbe2805a284ccf4cb677 Author: Khaled Hosny Date: Fri Nov 18 14:13:40

[Libreoffice-commits] core.git: sd/qa vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-11-22 Thread Khaled Hosny
: commit 34d7602954d4483b3bc9db700e7df2c15348947a Author: Khaled Hosny Date: Wed Nov 9 15:22:43 2016 +0200 tdf#55469 Consistent line spacing across platforms We current use platform APIs to calculate line spacing, however different platforms behave differently

[Libreoffice-commits] core.git: sd/qa

2016-11-22 Thread Khaled Hosny
sd/qa/unit/tiledrendering/tiledrendering.cxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit 8e31d8a27baa76564f3b71e0d31750ae56873c61 Author: Khaled Hosny Date: Tue Nov 22 19:58:53 2016 +0200 Probably a more robust way to fix the test Change-Id

Re: Tip for debugging CppunitTest_sd_tiledrendering failure

2016-11-22 Thread Khaled Hosny
On Tue, Nov 22, 2016 at 10:44:40AM +0100, Miklos Vajna wrote: > Another option: given that you mention incrementing Y by 1 changes the > situation, it would be fine to work with the "vertical center" of the > cursor not the "top" of it when we decide the click position. > > Does this help? It woul

[Libreoffice-commits] core.git: extras/source

2016-11-23 Thread Khaled Hosny
extras/source/truetype/symbol/OpenSymbol.sfd | 28 +-- extras/source/truetype/symbol/opens___.ttf |binary 2 files changed, 14 insertions(+), 14 deletions(-) New commits: commit b8283bc46bab7f8bccabaf0d0b2881a5e6a7722e Author: Khaled Hosny Date: Tue Nov 22 17:31:10

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - extras/source

2016-11-23 Thread Khaled Hosny
extras/source/truetype/symbol/OpenSymbol.sfd | 28 +-- extras/source/truetype/symbol/opens___.ttf |binary 2 files changed, 14 insertions(+), 14 deletions(-) New commits: commit 795a2a73a8fc54016bc918e8536081dc86cd2068 Author: Khaled Hosny Date: Tue Nov 22 17:31:10

[Libreoffice-commits] core.git: vcl/unx

2016-11-23 Thread Khaled Hosny
b49611a7cde3607446ad224ff2824c722b17e204 Author: Khaled Hosny Date: Wed Nov 23 21:15:36 2016 +0200 This code is only ever compiled on Unix Remove what seems like incomplete attempt to make it cross platform. Change-Id: I551fa091a3143925a15fced1de44f7f45929b21e Reviewed-on: https

[Libreoffice-commits] core.git: vcl/inc vcl/source vcl/unx

2016-11-23 Thread Khaled Hosny
commits: commit f337e95fb50c9edc10aca859aaf08baab5294d2e Author: Khaled Hosny Date: Wed Nov 23 21:42:47 2016 +0200 Make PS on Unix printing use the new layout engine I’d rather kill PS printing entirely, but this will do for now. Change-Id

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/inc vcl/source vcl/unx

2016-11-23 Thread Khaled Hosny
commits: commit 04f89a0ed1da6bd671007b725bd49e740d0d Author: Khaled Hosny Date: Wed Nov 23 21:42:47 2016 +0200 Make PS on Unix printing use the new layout engine I’d rather kill PS printing entirely, but this will do for now. Change-Id

Windows linking errors after removing old Graphite code

2016-11-24 Thread Khaled Hosny
I’m getting linking after removing the old Graphite integration: https://gerrit.libreoffice.org/#/c/31143/ But I’m getting unexpected linking errors, complaining about almost all Graphite symbol used by HarfBuzz: libharfbuzz.lib(libharfbuzz_la-hb-graphite2.obj) : error LNK2019: unresolved externa

Re: Reverting unit tests?

2016-11-25 Thread Khaled Hosny
On Fri, Nov 25, 2016 at 10:17:46AM +0100, Jan Holesovsky wrote: > Hi Khaled, Miklos, > > Khaled Hosny píše v Čt 17. 11. 2016 v 15:22 +0200: > > > It seems to not cover all the symbols in Symbol (what a great font > > name), or the original bug fixed by

[Libreoffice-commits] core.git: officecfg/registry vcl/source

2016-11-25 Thread Khaled Hosny
officecfg/registry/schema/org/openoffice/Office/Common.xcs |7 --- vcl/source/gdi/sallayout.cxx |5 + 2 files changed, 1 insertion(+), 11 deletions(-) New commits: commit e838d143178ee82c786d11fd792d8d6735858933 Author: Khaled Hosny Date: Wed Nov

[Libreoffice-commits] core.git: bin/findunusedcode config_host/config_graphite.h.in config_host.mk.in configure.ac distro-configs/LibreOfficeEmscripten.conf vcl/inc vcl/Library_vcl.mk vcl/source vcl/u

2016-11-25 Thread Khaled Hosny
67936ee7ed717eb385b608d7eedcefa61fe13295 Author: Khaled Hosny Date: Wed Nov 23 14:00:20 2016 +0200 Kill old Graphite layout engines Change-Id: Ia19d4d0a3a33694b6edfff62e6b40028dac19677 Reviewed-on: https://gerrit.libreoffice.org/31212 Tested-by: Jenkins Reviewed-by: Khaled Hosny diff --git a/bin

[Libreoffice-commits] core.git: vcl/inc vcl/Library_vcl.mk vcl/unx

2016-11-25 Thread Khaled Hosny
(-) New commits: commit 47ea13ef8dc8ab9aeded6121845e3ebd1d28b292 Author: Khaled Hosny Date: Wed Nov 23 23:28:53 2016 +0200 Kill the old Unix layout engines Change-Id: I9e1667faf9644dfab025c82cb11a6490d1e8f998 Reviewed-on: https://gerrit.libreoffice.org/31221 Tested-by: Jenkins

[Libreoffice-commits] core.git: vcl/CustomTarget_afm_hash.mk vcl/inc vcl/Library_vcl.mk vcl/Module_vcl.mk vcl/unx

2016-11-26 Thread Khaled Hosny
abe4d7bd0a1ec4b5a31cc5622080952e4cd53ebf Author: Khaled Hosny Date: Thu Nov 24 00:53:05 2016 +0200 Kill code for Type 1 fonts on Unix We already ignore them, so this is unreachable code now. Change-Id: I6fd4699d8175344c36253bf4bf9c024b8986da31 Reviewed-on: https://gerrit.libreoffice.org/31222

[Libreoffice-commits] core.git: include/vcl vcl/source vcl/unx

2016-11-26 Thread Khaled Hosny
: commit 8c173ce9ba4d90770cd85b148fe3122a097396a7 Author: Khaled Hosny Date: Thu Nov 24 01:12:17 2016 +0200 DisableGlyphProcessing flag is never set now Change-Id: I4a56c5d7490dd78f5cb72f2b821fb43c93f64b2d Reviewed-on: https://gerrit.libreoffice.org/31223 Reviewed-by: Khaled

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-11-26 Thread Khaled Hosny
59859a8aaa75384159e315ee2577d5cc7e2aa6e8 Author: Khaled Hosny Date: Thu Nov 24 01:32:11 2016 +0200 ServerFontLayout is already gone Kill DrawServerFontLayout, and rename DrawSalLayout to DrawTextLayout, in parity with GetTextLayout. Change-Id: I3f61efd8c6ecde64f28301dca6a7c91eb0873702

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-11-26 Thread Khaled Hosny
368de904974b18dc5a8d237e046c0ed005f7c85d Author: Khaled Hosny Date: Thu Nov 24 09:21:56 2016 +0200 Kill PspFontLayout It should never get used any way. CairoTextRender::GetTextLayout() returns nullptr for the unlikely even that there is no Freetypefont for the requested fallback level, so we do the same

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/unx

2016-11-26 Thread Khaled Hosny
insertions(+), 1229 deletions(-) New commits: commit 30ebc895c95ee66adf172717249aa1789b309eff Author: Khaled Hosny Date: Fri Nov 25 09:19:15 2016 +0200 There is one font file type now Change-Id: I47b6f36de5c77cfdf831a2b3ce10b973159520b1 Reviewed-on: https

[Libreoffice-commits] core.git: include/vcl sw/source vcl/inc vcl/Library_vcl.mk vcl/quartz vcl/source

2016-11-26 Thread Khaled Hosny
commits: commit d761d952f460e1943e94c5a7556b3b01d2259666 Author: Khaled Hosny Date: Fri Nov 25 14:00:07 2016 +0200 Kill old Core Text layout engine Change-Id: If80d65899255d8be72f374fbec232d103a08a006 Reviewed-on: https://gerrit.libreoffice.org/31232 Tested-by: Jenkins

Re: Windows linking errors after removing old Graphite code

2016-11-26 Thread Khaled Hosny
On Fri, Nov 25, 2016 at 05:12:03PM +0100, Michael Stahl wrote: > On 24.11.2016 22:04, Khaled Hosny wrote: > > I’m getting linking after removing the old Graphite integration: > > https://gerrit.libreoffice.org/#/c/31143/ > > > > But I’m getting unexpected linking error

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-11-26 Thread Khaled Hosny
vcl/inc/CommonSalLayout.hxx | 17 +- vcl/inc/sallayout.hxx|8 - vcl/source/gdi/sallayout.cxx | 279 --- 3 files changed, 15 insertions(+), 289 deletions(-) New commits: commit 3dab9849115284f9a126356e2354ad7fb8557663 Author: Khaled Hosny

[Libreoffice-commits] core.git: 2 commits - vcl/inc vcl/README.vars vcl/source

2016-11-26 Thread Khaled Hosny
d76bd987ca2b853b85a9464787ae1fdc19321f5b Author: Khaled Hosny Date: Sat Nov 26 20:10:21 2016 +0200 Do not check for SAL_NO_COMMON_LAYOUT any more It has no effect except on Windows, and this will go out soon. Change-Id: I238518624e3288dea259e5ec9d5d76c8f691fd8c diff --git a/vcl

Re: Windows linking errors after removing old Graphite code

2016-11-26 Thread Khaled Hosny
On Sat, Nov 26, 2016 at 09:43:50PM +0200, Noel Grandin wrote: > the windows buildbots are currently broken, and it very much looks like > this stuff is the reason, e.g. see > > http://ci.libreoffice.org/job/lo_tb_master_win64_dbg/lastBuild/console I saw this earlier today, but the Gerrit builds a

Re: Windows linking errors after removing old Graphite code

2016-11-26 Thread Khaled Hosny
On Sat, Nov 26, 2016 at 07:53:15PM +, Kaganski Mike wrote: > 11/26/2016 10:43 PM, Noel Grandin пишет: > > the windows buildbots are currently broken, and it very much looks > > like this stuff is the reason, e.g. see > > > > http://ci.libreoffice.org/job/lo_tb_master_win64_dbg/lastBuild/consol

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-11-26 Thread Khaled Hosny
vcl/inc/sallayout.hxx |2 -- vcl/unx/generic/print/glyphset.hxx |2 -- 2 files changed, 4 deletions(-) New commits: commit 84c5999372ca4af1c79ab3134fda1d67d4ea95d6 Author: Khaled Hosny Date: Sat Nov 26 22:46:35 2016 +0200 Unused typedef’s Change-Id

[Libreoffice-commits] core.git: vcl/inc vcl/source

2016-11-27 Thread Khaled Hosny
f246542d1f61b5253189676688f59e5f952267a1 Author: Khaled Hosny Date: Mon Nov 28 06:43:29 2016 +0200 Simplify things a bit * Drop SortGlyphItems() and update the Kashida insertion code not depend on that sorting. * IS_DIACRITIC flag can now be based solely on the General Category property, since it now is

[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - vcl/source

2016-11-27 Thread Khaled Hosny
vcl/source/gdi/CommonSalLayout.cxx | 76 +++-- 1 file changed, 32 insertions(+), 44 deletions(-) New commits: commit 8715f20644483df9fd26b5656f4f64c4ca9f5411 Author: Khaled Hosny Date: Mon Nov 28 07:53:29 2016 +0200 Simplify things a bit * Drop

[Libreoffice-commits] core.git: vcl/source

2016-11-28 Thread Khaled Hosny
vcl/source/gdi/sallayout.cxx | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) New commits: commit 265c953584f8a1e3a832dd92dc2198056438b418 Author: Khaled Hosny Date: Mon Nov 28 08:03:02 2016 +0200 Use range for loop Change-Id

Requiring HarfBuzz 0.9.42?

2016-11-28 Thread Khaled Hosny
I currently have code that depends on a feature and new API introduced in HarfBuzz 0.9.42. The API use is behind a build time check, but the code elsewhere really assumes the behaviour enabled by this API. So technically we can use lower HarfBuzz versions, but practically the result will be wrong i

[Libreoffice-commits] core.git: vcl/inc vcl/unx

2016-11-29 Thread Khaled Hosny
: Khaled Hosny Date: Tue Nov 29 08:17:25 2016 +0200 Drop assigned but never used parameter Change-Id: If043960898b6388df7a5ecf5fe34172ed08bba9f Reviewed-on: https://gerrit.libreoffice.org/31344 Tested-by: Jenkins Reviewed-by: Khaled Hosny diff --git a/vcl/inc/unx

[Libreoffice-commits] core.git: vcl/unx

2016-11-29 Thread Khaled Hosny
vcl/unx/generic/print/genpspgraphics.cxx | 30 +- 1 file changed, 5 insertions(+), 25 deletions(-) New commits: commit 63ca9554f24194521cfbc7fa90bfef37ea7759c1 Author: Khaled Hosny Date: Tue Nov 29 08:25:57 2016 +0200 Use Freetypefont::GetFontMetric

[Libreoffice-commits] core.git: chart2/source include/svtools include/tools include/vcl sc/source sd/source svtools/source vcl/inc vcl/qa vcl/quartz vcl/source vcl/unx vcl/win

2016-11-29 Thread Khaled Hosny
|5 vcl/win/gdi/salfont.cxx | 199 ++- 33 files changed, 146 insertions(+), 694 deletions(-) New commits: commit 74314b11a4b5a2887bd1ff19bdcfb3572b09240c Author: Khaled Hosny Date: Tue Nov 29 08:34:29 2016 +0200 Drop a bunch of

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-11-29 Thread Khaled Hosny
1ee56fc9f446bad5853b121a3c5b137c1d00bbf4 Author: Khaled Hosny Date: Tue Nov 29 10:41:53 2016 +0200 SalGraphics::GetFontEncodingVector() is a noop now Change-Id: Id706fa242277a0ea7ba44f52eab4a56e404bd2fa Reviewed-on: https://gerrit.libreoffice.org/31372 Tested-by: Jenkins Reviewed-by

[Libreoffice-commits] core.git: vcl/headless vcl/inc vcl/quartz vcl/source vcl/unx vcl/win

2016-11-29 Thread Khaled Hosny
changed, 22 insertions(+), 153 deletions(-) New commits: commit 2e0ab512592e2e134faf9612a293fb8fdd0527d0 Author: Khaled Hosny Date: Tue Nov 29 13:39:37 2016 +0200 Strip down GetEmbedFontData to what is really used The only remaining user is EmbeddedFontsHelper, and it just needs the

[Libreoffice-commits] core.git: vcl/source

2016-11-29 Thread Khaled Hosny
vcl/source/gdi/pdfwriter_impl.cxx | 560 -- vcl/source/gdi/pdfwriter_impl.hxx |3 2 files changed, 563 deletions(-) New commits: commit 70ecf1919e3e3b9509ff55b2265b3d98d2a5f1aa Author: Khaled Hosny Date: Tue Nov 29 11:51:23 2016 +0200 Dead code

<    5   6   7   8   9   10   11   12   13   14   >