On Mon, Nov 21, 2016 at 11:51:09PM -0500, Ashod Nakashian wrote: > Hi Khaled, > > On Mon, Nov 21, 2016 at 7:19 PM, Khaled Hosny <khaledho...@eglug.org> wrote: > > > I’m having a failure on Linux in this test, I can reproduce it locally > > but I have no idea how to debug it: > > http://ci.libreoffice.org/job/lo_gerrit/2956/Config=linux_ > > gcc_release_64/console > > > > (for https://gerrit.libreoffice.org/#/c/31053/). > > > > The test apparently checks if a mouse event at a certain position does > > something, and since I’m changing how line spacing is calculated it > > might have caused some vertical shift. But I don’t understand the code > > of the test that much and don’t know where to start, any tips? > > > > > It's a hit-test. Basically, it simulates a mouse click (by invoking the > relevant API) and validates that the cursor position is updated as a result. > > I guess you need to rework the test to take into account the new spacing so > the mouse would end up in the text-edit control. Line 355 looks relevant.
Thanks for the pointer. Incrementing the Y position by at least 1 fixes the test, but I’m still not sure what the position is supposed to be in the first place and why line spacing would matter. Regards, Khaled _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice
