Hi,
I know this is extremely late for a simple polish fix, but please consider
http://cgit.freedesktop.org/libreoffice/core/commit/?id=f1cb0a4ab4f11dc015be1696c7c7751802171915
as well as
http://cgit.freedesktop.org/libreoffice/core/commit/?id=0b6486772c52d7112e76555fca6525ad2eec2bae
for inclusion
Hi Albert, Korrawit, Ivan,
the idea sounds good, ... patch is simple, and the details seem to be
correct now. Thus, I've taken the liberty to replace "can" by "may"
and then push to master.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e70541dc4627d63f294837f3eefc1cc25398b703
Also, than
Hi there,
On Sat, 2012-01-28 at 04:59 -0800, julien2412 wrote:
> Hello,
>
> Cppchecks reports this :
> core/vcl/win/source/app/salinst.cxx
> 335 duplicateBranch style Found duplicate branches for if and else.
Nice catch :-) I guess we should bin the outside conditional and have:
Thanks Riccardo. It's actually very interesting topic. Please keep me informed
if you get any results. I'll do the same if I get something.
Anybody else on:
4) Are the libraries loaded on demand by soffice process or they need to
be reachable at the start? If they would be demanded on load
On 01/30/2012 10:25 AM, andrzej.pacanow...@tieto.com wrote:
4) Are the libraries loaded on demand by soffice process or they need
to be reachable at the start? If they would be demanded on load it
would give us opportunity to remove unnecessary libs.
Some are directly linked against while
It's the first time I try to build LibreOffice.
Can anyone help me ?
walter
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Same problem here Kazy.7720 on windows 7, Avira Antivir Professional
/LL
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Walter,
Il 30/01/2012 11:04, walter ha scritto:
It's the first time I try to build LibreOffice.
Can anyone help me ?
You may want to report what version are you trying to compile and the
exact error as a starting point :)
cheers,
--
Riccardo Magliocchetti
__
Hi Lubos,
Lubos Lunak píše v Po 16. 01. 2012 v 17:43 +0100:
> Git blame shows a CWS merge, so it is unhelpful.
If you have the CWS name, I can try to dig the commit for you.
Generally - should at some stage appear a need to have full CVS or SVN
history (like, really full, with the history of CW
Hi Riccardo,
I'm building Version 3.5
I have attached a zip (with logs), but it disappeared.
How can I send you a complete log.
cheers
Walter
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/ma
Hello walter,
On Mon, Jan 30, 2012 at 17:32, walter wrote:
> I'm building Version 3.5
Not sure whether you read this :-)
http://wiki.documentfoundation.org/Development/Native_Build
Preferably, you should get the sources from git 'core' repo, but if
you've already done this, in which git commit
https://bugs.freedesktop.org/show_bug.cgi?id=37361
--- Comment #154 from sasha.libreoff...@gmail.com 2012-01-30 02:44:46 PST ---
Regression since 3.3.4
Bug 39415 - Table borders in word 200x .doc are shown incorrect in writer
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=e
https://bugs.freedesktop.org/show_bug.cgi?id=37361
sasha.libreoff...@gmail.com changed:
What|Removed |Added
Depends on||39415
--
Configure bugmail
Hi there,
On Mon, 2012-01-30 at 11:25 +0200, andrzej.pacanow...@tieto.com wrote:
> Thanks Riccardo. It's actually very interesting topic. Please keep
> me informed if you get any results. I'll do the same if I get something.
Of course, the cross-compilation work is going rather well; we'r
On 27/01/12 18:10, Petr Mladek wrote:
Hi,
we moved the used configuration from ~/.libreoffice to
~/.config/libreoffice between LO-3.4 and 3.5 on Linux. Unfortunately,
the old configuration is not migrated. I have finally got time to dig
into it again. The result is the attached patch. It works w
On 27/01/12 18:42, Andras Timar wrote:
Hi,
I made a typo in my soffice.bin/soffice.exe icon reduction patch, so
Writer/Web has the wrong application icon under Windows in rc2. The
following commit fixes it.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=764674700d35d86890e3538039209f039
On 30/01/12 12:01, Noel Power wrote:
> On 27/01/12 18:42, Andras Timar wrote:
>> Hi,
>>
>> I made a typo in my soffice.bin/soffice.exe icon reduction patch, so
>> Writer/Web has the wrong application icon under Windows in rc2. The
>> following commit fixes it.
>> http://cgit.freedesktop.org/libreof
Petr Mladek píše v Pá 27. 01. 2012 v 14:39 +0100:
> Cedric Bosdonnat píše v Pá 27. 01. 2012 v 10:01 +0100:
> > The minutes were transformed into a night... but I'm ok with your
> > patches and pushed them to 3.5 and master. 2 more reviews to have them
> > into 3.5.0.
>
> What commits are we talkin
On 01/30/2012 11:56 AM, Noel Power wrote:
pushed ( or will be when the git gc finishes ) to 3-5. extra reviews
etc. needed for 3-5-0
Patch looks OK to me for inclusion in -3-5-0. One more review needed.
Stephan
___
LibreOffice mailing list
LibreOffi
Hi,
please note that the commit deadline for 3.5.0-rc3 is today, January 30,
2012. It will be used as LO-3.5.0 final if no blocker is reported.
See also
http://wiki.documentfoundation.org/ReleasePlan#3.5_release
http://wiki.documentfoundation.org/Release_Criteria
http://wiki.documentfoundation.or
Hi Korrawit,
Sorry, but I'm the classic windows desktop programmer, I have to change my
mind one more time, sigh !
$ git show
commit 9abb0b6bbe2de65988065f78354ccf5ebde4a7ae
Error Log (last lines)
pastebin.com/u/walterLO
Cheers
walter
___
LibreOffi
> Of course, the cross-compilation work is going rather well; we're
> managing to get most of the startup phase complete on Android/ARM now,
> and even a little (busted) rendering going. I'm interested in why you'd
> want to render to PDF on ARM though ... can you tell more ?
Thanks for info
On Sun, 2012-01-29 at 20:27 +0100, Markus Mohrhard wrote:
> > I reverted the previous af70bc00c6714eb8695babdf5af07416552f7034 and
> > committed the new patch to master, and to 3-5 with my sign-off.
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=08adeedce926bac1a
On 27/01/12 23:06, Michael Stahl wrote:
these commits fix ODF import bugs described in fdo#38542 (regressions
from LO 3.3) and were already backported to libreoffice-3-5 by Cedric;
they want to be in libreoffice-3-5-0 and libreoffice-3-4 as well:
http://cgit.freedesktop.org/libreoffice/core/comm
On 01/29/2012 09:36 PM, Lionel Elie Mamane wrote:
Attached patch fixes fdo#34432, a crash with some ODBC drivers. The
bug report is about Firebird SQL.
The attached
0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch appears
to be completely unrelated?
Stephan
Hi
Bug 44981 - EasyHack: remove obsolete SWAPLONG macros
This patch converts uses of the SWAPSHORT and SWAPLONG macros to
OSL_SWAPWORD and OSL_SWAPDWORD
Code is contributed under MPL+/LGPL+/GPL+
Patches passes a full build and make check.
Regards, Noel Grandin
Disclaimer: http://www.peralex
Hi there,
On Sun, 2012-01-29 at 18:35 +0700, Korrawit Pruegsanusak wrote:
> MSVC complains about error C2695 [1] while building, so I try to fix
> it with the attached patch, and the noise is now silent.
Lovely :-) looks obviously correct, pushed it.
> But the build isn't success yet: st
On 28/01/12 12:53, Fridrich Strba wrote:
Hello, a little safe patch that prevents that "compatibility symbol"
we added for backward compatibility with older versions of Duden
Korrektor from landing in the uwinapi.lib import library. This assures
that no accidental linking with it will happen in
On 28/01/12 13:53, Fridrich Strba wrote:
> Hello, a little safe patch that prevents that "compatibility symbol" we
> added for backward compatibility with older versions of Duden Korrektor
> from landing in the uwinapi.lib import library. This assures that no
> accidental linking with it will ha
On 29/01/12 11:35, Korrawit Pruegsanusak wrote:
Hello Stephan, all,
MSVC complains about error C2695 [1] while building, so I try to fix
it with the attached patch, and the noise is now silent.
But the build isn't success yet: still has problem in 'test', which I
can't figure out.
So, this patc
Hi Michael,
On Sat, 2012-01-28 at 00:06 +0100, Michael Stahl wrote:
> they want to be in libreoffice-3-5-0 and libreoffice-3-4 as well:
So - just poking them from a "will they introduce new crashes"
perspective:
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5&id=
On 01/30/2012 12:04 PM, Michael Stahl wrote:
On 30/01/12 12:01, Noel Power wrote:
On 27/01/12 18:42, Andras Timar wrote:
I made a typo in my soffice.bin/soffice.exe icon reduction patch, so
Writer/Web has the wrong application icon under Windows in rc2. The
following commit fixes it.
http://cgi
On Mon, 2012-01-30 at 11:39 +, Noel Power wrote:
> > the following 2 commits fix problems in the dialog that are regressions
> > from LO 3.3, and want backporting to libreoffice-3-5, libreoffice-3-5-0,
> > and libreoffice-3-4:
> >
> > http://cgit.freedesktop.org/libreoffice/core/commit/?id=974
Hello Tor, Fridrich,
On Sun, Jan 29, 2012 at 02:19, Fridrich Strba
wrote:
> It can use the native Windows API, yes. I ported it to use the mozilla stuff
> especially so that the Linux build doesn't need to rely on openldap and I
> set it for Windows too not to have many different code paths.
Tha
On Mon, 2012-01-30 at 11:44 +, Noel Power wrote:
> presuming you know your window ;-) pushed to 3.5, acks still needed fo 3-5-0
And ack'ed by me, and pushed to -3-5-0. We don't want more repeats of
the creation of the original bug here, obviously.
Thanks ! :-)
Hi,
All my current and past contributions made to the LibreOffice project
are done under MPL1.1+ / GPLv3+ / LGPLv3+.
Until further notice, all my future contributions to the LibreOffice
project are available under MPL1.1+ / GPLv3+ / LGPLv3+.
Best Regards,
Albert Thuswaldner
_
Hi Andrzej,
On Mon, 2012-01-30 at 13:31 +0200, andrzej.pacanow...@tieto.com wrote:
> We need to display documents on custom display (no X11) arm linux.
> Easiest way is to utilize existing PDF reader and just convert them
> with LO. Am I wrong?
Well - it remains to be seen :-) quite proba
On Mon, 2012-01-30 at 12:10 +0100, Stephan Bergmann wrote:
> Patch looks OK to me for inclusion in -3-5-0. One more review needed.
And fine with me; pushed.
Michael.
--
michael.me...@suse.com <><, Pseudo Engineer, itinerant idiot
_
On Mon, 2012-01-30 at 09:57 +, LL wrote:
> Same problem here Kazy.7720 on windows 7, Avira Antivir Professional
We're checking it in some detail; but I strongly suspect this is just
yet-another false positive caused by some co-incidence around the icon
re-work. Possibly we'll get a sl
Hi Arnolf,
On Sat, 2012-01-28 at 09:03 -0800, Arnolf Best wrote:
> I am creating an application using the LibreOffice Calc . Users of the
> application should select from a couple of sheets.
Sounds fun.
> Unfortunately, in LibreOffice Calc new sheets can be added unintentionally
> very
Hi, Michael
> Well - it remains to be seen :-) quite probably our Android work will
> end up giving us a nice backend to render documents incrementally to
> pixels, without having the native UI - at least, as a first cut.
Is this work available somewhere in repo ? It would be nice to look at
Hi there,
On Fri, 2012-01-27 at 16:09 +, Jonathan Adams wrote:
> I managed to hack together a "solaris.mk" file (by copying unxgcc.mk
> and making a few "SUN" changes) and that got me a little further ...
> then on compiling nss
Great - if you send a 'git diff' as an attachment we can
On Fri, 2012-01-27 at 17:08 -0500, Kohei Yoshida wrote:
> Hi there,
>
> I'd like to have the attached patch pushed to the 3-5 branch and
> preferably to the 3-5-0 branch as well.
>
> It fixes
>
> https://bugs.freedesktop.org/show_bug.cgi?id=45084
With
http://cgit.freedesktop.org/libreoffice/co
On 27/01/12 23:50, Albert Thuswaldner wrote:
Hi,
Shows a number of likely candidates; connecting to the 'ModifyHdl'
and running the validator on the name, removing characters if it not valid
might work; but of course.
git grep SetModifyHdl
for some instances of that; p
On 01/27/2012 05:09 PM, Jonathan Adams wrote:
I managed to hack together a "solaris.mk" file (by copying unxgcc.mk
and making a few "SUN" changes) and that got me a little further ...
Are we talking new build system
solenv/gbuild/platform/{solaris,unxgcc}.mk (where a solaris.mk already
exists
https://bugs.freedesktop.org/show_bug.cgi?id=37361
--- Comment #155 from sasha.libreoff...@gmail.com 2012-01-30 05:11:55 PST ---
regression since 3.3.4:
Bug 39903 - FORMATTING: Table number format not retained
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You
https://bugs.freedesktop.org/show_bug.cgi?id=37361
sasha.libreoff...@gmail.com changed:
What|Removed |Added
Depends on||39903
--
Configure bugmail
Albert
On 30/01/12 13:07, Noel Power wrote:
Hi I pushed it to master, it's a nice patch
incase you look for your patch, well I thought I committed it but only
noticed now there is a conflict message, will fix after some food
___
LibreOffice mailing li
On Mon, 2012-01-30 at 13:43 +0200, Noel Grandin wrote:
> Hi
>
> Bug 44981 - EasyHack: remove obsolete SWAPLONG macros
> This patch converts uses of the SWAPSHORT and SWAPLONG macros to
> OSL_SWAPWORD and OSL_SWAPDWORD
Looks sane to me anyway, pushed now. Thanks for this.
C.
___
Michael Meeks píše v Po 30. 01. 2012 v 12:02 +:
> On Mon, 2012-01-30 at 11:39 +, Noel Power wrote:
> > > the following 2 commits fix problems in the dialog that are regressions
> > > from LO 3.3, and want backporting to libreoffice-3-5, libreoffice-3-5-0,
> > > and libreoffice-3-4:
> > >
>
Hi there,
On Mon, 2012-01-30 at 14:56 +0200, andrzej.pacanow...@tieto.com wrote:
> > Well - it remains to be seen :-) quite probably our Android work will
> > end up giving us a nice backend to render documents incrementally to
> > pixels, without having the native UI - at least, as a first cu
Noel Power píše v Po 30. 01. 2012 v 11:39 +:
> On 27/01/12 23:06, Michael Stahl wrote:
> > these commits fix ODF import bugs described in fdo#38542 (regressions
> > from LO 3.3) and were already backported to libreoffice-3-5 by Cedric;
> > they want to be in libreoffice-3-5-0 and libreoffice-3-
On 30/01/12 13:33, Korrawit Pruegsanusak wrote:
So, if I understand correctly, my patch is somehow correct, right?
(Sorry if I don't)
The patch is good-ish, nevertheless, the place to fix it is actually in
the makefile.mk where one just extends for the purpose of that
BUILD_ACTION the SOLARIN
Hi
Attached patch converts SdCustomShow to use std::vector.
Code is contributed under MPL+/LGPL+/GPL+
Regards, Noel Grandin
Disclaimer: http://www.peralex.com/disclaimer.html
diff --git a/sd/inc/cusshow.hxx b/sd/inc/cusshow.hxx
index 1f981e9..1bd3614 100644
--- a/sd/inc/cusshow.hxx
+++ b/sd/
On Mon, 2012-01-30 at 11:58 +, Michael Meeks wrote:
> One more required for 3.5.0 I guess ?
Pushed to 3-5-0 now. So everything is into was it was requested to go
into now I believe.
C.
___
LibreOffice mailing list
LibreOffice@lists.freedeskto
On 30/01/12 13:14, Noel Power wrote:
Albert
On 30/01/12 13:07, Noel Power wrote:
Hi I pushed it to master, it's a nice patch
incase you look for your patch, well I thought I committed it but only
noticed now there is a conflict message, will fix after some food
hopefully I didn't screw it up (
On Mon, 2012-01-30 at 12:40 +0100, Stephan Bergmann wrote:
> The attached
> 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch appears
> to be completely unrelated?
True :-) I suspect the patch intended is attached; the patch it refers
to is already merged. This has my ack
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
Please find the patch attached.
Best regards
Olivier
Em 30-01-2012 05:56, Jan Holesovsky escreveu:
> Hi Olivier,
>
> Olivier Hallot píše v Pá 27. 01. 2012 v 12:14 -0200:
>
>> How can I write a help file to fix
>>
>> https://bugs.freedesktop.o
On Mon, Jan 30, 2012 at 02:08:54PM +, Michael Meeks wrote:
> On Mon, 2012-01-30 at 12:40 +0100, Stephan Bergmann wrote:
>> The attached
>> 0001-fdo-44025-repair-dbaccess-ORowSetCache-isLast-after-.patch
>> appears to be completely unrelated?
> True :-)
Yes, I used an older email as a
Hi Caolan,
On Mon, 2012-01-30 at 12:58 +, Caolán McNamara wrote:
> With
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=611472edb12ba1d8a38bda1857c952eef0bb3568
> already in place in 3-5-0 to sort the writer detection to the end of the
> list does it work "out-
Hi,
Concerning the Virus Kazy.7720 Problem: Can you all please contact
support of your Antivirus Program supplier so that they can check and
rework their filters? So we can save much trouble with false alarms
normal users would see when they install 3.5.0 before anti virus filters
are updated
Andras Timar píše v Čt 26. 01. 2012 v 13:27 +0100:
> Hi,
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=d2961f3fff10ea1254a082ad6d0a72bff740d66e
> I updated LICENSE.odt and generated THIRDPARTYLICENSEREADME.html and
> license.txt from it. Unfortunately the diff is not clean, I could n
https://bugs.freedesktop.org/show_bug.cgi?id=37361
Rainer Bielefeld changed:
What|Removed |Added
Depends on||45401
--- Comment #156 from Rainer Bi
On 01/30/2012 03:43 PM, Lionel Elie Mamane wrote:
I attach here the "less invasive" variant originally meant for
libreoffice-3-5.
My SQL knowledge is actually zero. For example, I have no idea where to
look to verify that for some SQL_ATTR_CURSOR_TYPE, say, SQLGetStmtAttr
expects to find a b
On 01/30/2012 04:32 PM, Petr Mladek wrote:
One more approval needed for 3-5-0.
Approved and pushed.
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Hi Caolán,
On Monday, 2012-01-30 12:58:29 +, Caolán McNamara wrote:
> > https://bugs.freedesktop.org/show_bug.cgi?id=45084
>
> With
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5-0&id=611472edb12ba1d8a38bda1857c952eef0bb3568
> already in place in 3-5-0 to sort the
On Mon, Jan 30, 2012 at 04:55:51PM +0100, Stephan Bergmann wrote:
> On 01/30/2012 03:43 PM, Lionel Elie Mamane wrote:
>> I attach here the "less invasive" variant originally meant for
>> libreoffice-3-5.
> My SQL knowledge is actually zero. For example, I have no idea
> where to look to verify t
Hello Norbert, all,
As compiling --with-mozilla-build on msvc/cygwin, it also needs msvc
2005 runtime library in 'instsetoo_native'.
But a check in configure.in might be incorrect, so patch attached &
review appreciated. :-)
If this patch is pushed, the voreppe tinderbox also needs some love
:-)
On Sun, 2012-01-29 at 15:01 +0400, Ivan Timofeev wrote:
> what is the reason to have this flag? Why only set this flag without
> actually showing? And why not change this flag accordingly when actually
> showing? (This is what the patch fixes.)
Digging into the git history it looks like a collec
Hello Michael,
On Mon, Jan 30, 2012 at 18:42, Michael Meeks wrote:
> Lovely :-) looks obviously correct, pushed it.
Thanks :-)
>> But the build isn't success yet: still has problem in 'test', which I
>> can't figure out.
>
> Any more details, is it a failing test or a build issue
Hello Fridrich,
On Mon, Jan 30, 2012 at 20:52, Fridrich Strba
wrote:
> The patch is good-ish, nevertheless, the place to fix it is actually in the
> makefile.mk where one just extends for the purpose of that BUILD_ACTION the
> SOLARINC variable adding this directory.
>
> I fixed it now in master
Hi Michael,
On Thu, 2012-01-26 at 19:35 +0100, Michael Stahl wrote:
> On 26/01/12 19:30, Michael Stahl wrote:
> > On 26/01/12 16:21, Cedric Bosdonnat wrote:
> >> Hi all,
> >>
> >> Could someone review and cherry-pick this commit to -3-5, -3-5-0 and
> >> -3-4?
> >> http://cgit.freedesktop.org/libre
Hi there,
http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2bf6d863a25475f27e2b0d37f8c36aec74d6d4
This is simple enough that we can safely put this into 3.5.0.
Thanks,
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
___
LibreOffice mailin
On Mon, Jan 30, 2012 at 11:05 AM, Korrawit Pruegsanusak
wrote:
> Hello Norbert, all,
>
> As compiling --with-mozilla-build on msvc/cygwin, it also needs msvc
> 2005 runtime library in 'instsetoo_native'.
> But a check in configure.in might be incorrect, so patch attached &
> review appreciated. :-
Commited and pushed on master.
Now it's :
bool WinSalInstance::CheckYieldMutex()
{
bool bRet = true;
SalData*pSalData = GetSalData();
DWORD nCurThreadId = GetCurrentThreadId();
if ( pSalData->mpFirstInstance )
{
SalYieldMutex* pYieldMutex =
pSalData->mpFirstIn
Hi Kohei,
On Friday, 2012-01-27 17:08:14 -0500, Kohei Yoshida wrote:
> I'd like to have the attached patch pushed to the 3-5 branch and
> preferably to the 3-5-0 branch as well.
>
> It fixes
>
> https://bugs.freedesktop.org/show_bug.cgi?id=45084
It seems to fix the symptom and the document is
2012/1/30 Kohei Yoshida :
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2bf6d863a25475f27e2b0d37f8c36aec74d6d4
>
> This is simple enough that we can safely put this into 3.5.0.
+1, pushed to libreoffice-3-5
Andras
___
LibreOffice mailing l
The regression is caused by commit 8434a6966914547451489db6828b31ae86901186,
which added size checks, but incorrectly - remainingSize() is called before
the seek to the right position is done, which occassionally makes the code
believe the file is corrupt.
I don't actually know the format en
2012/1/30 Andras Timar :
> 2012/1/30 Kohei Yoshida :
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2bf6d863a25475f27e2b0d37f8c36aec74d6d4
>>
>> This is simple enough that we can safely put this into 3.5.0.
>
> +1, pushed to libreoffice-3-5
>
Looks good to me. One more needed for 3-5
Michael Meeks-2 wrote
>
> Hi Michael,
>
>> Since this is not a list for reporting feature requests, I assume you
>> would like some code pointers to how to implement the setting ?
>
> No. In my opinion, this ought to be done by the inventor of the 'insert
> new sheet' tab.
>
> I was just
Hi,
this time a brief summary of what happened during the 3rd week in 2012
on LibreOffice repositories and the living branches:
+ master:LO-3.5 development
+ libreoffice-3-5: fixes for LO-3.5.0 release
+ libreoffice-3-4: fixes for potential LO-3.4.6 bug fix
Hi,
this time a brief summary of what happened during the 4th week in 2012
on LibreOffice repositories and the living branches:
+ master:LO-3.5 development
+ libreoffice-3-5: fixes for LO-3.5.1 bug fix release
+ libreoffice-3-5-0: final stabilization of the L
Hi,
On Monday, 2012-01-30 19:22:38 +0100, Markus Mohrhard wrote:
> 2012/1/30 Andras Timar :
> > 2012/1/30 Kohei Yoshida :
> >> http://cgit.freedesktop.org/libreoffice/core/commit/?id=1f2bf6d863a25475f27e2b0d37f8c36aec74d6d4
> >>
> >> This is simple enough that we can safely put this into 3.5.0.
>
Hello,
Here is a report of cppcheck :
core/svtools/source/filter/sgvtext.cxx
365 duplicateExpression style Same expression on both sides of '||'.
Here is the line :
if (c==EscSet || c==EscReset || c==EscDeflt || c==EscToggl)
FlgVal=c; else {<--- Same expression on both sides
On Mon, 2012-01-30 at 10:03 -0800, julien2412 wrote:
> I wonder if we could more simplify like this :
Looks nicer to me :-) whatever is most readable and pleasant with two
return paths in the function we could drop the 'bool bRet' as well and
gain a vertical line :-)
All the best
Hi,
On Mon, Jan 30, 2012 at 10:07, Stefan Knorr (Astron)
wrote:
> Hi Albert, Korrawit, Ivan,
>
> the idea sounds good, ... patch is simple, and the details seem to be
> correct now. Thus, I've taken the liberty to replace "can" by "may"
> and then push to master.
> http://cgit.freedesktop.org/lib
Hello Albert,
>
> Thanks for taking care of this (and yes "may" instead of "can" sounds better).
>
> Just a thought: should we push this to the 3.5 branch? This is a small
> polish of the user experience and it might be
> good to have it in a release soon, instead of waiting for 3.6. Also
> the bu
On Mon, 2012-01-30 at 19:22 +0100, Lubos Lunak wrote:
> The regression is caused by commit 8434a6966914547451489db6828b31ae86901186,
> which added size checks, but incorrectly - remainingSize() is called before
> the seek to the right position is done, which occassionally makes the code
> belie
Hi julien2412,
On Monday, 2012-01-30 11:24:18 -0800, julien2412 wrote:
> 139 #define EscSet'' /* Flag setzen
>
> */
>
> Now why EscSet = EscReset = EscToggl ?
> I took a look at the git history and found the commit
> 9e5584a82633442467a53cc
Commited and pushed this version :
bool WinSalInstance::CheckYieldMutex()
{
SalData*pSalData = GetSalData();
if ( pSalData->mpFirstInstance )
{
SalYieldMutex* pYieldMutex =
pSalData->mpFirstInstance->mpSalYieldMutex;
return (pYieldMutex->mnThreadId == (GetCurrentThre
On Mon, 2012-01-30 at 19:52 +, Michael Meeks wrote:
> Looks lovely to me; pushed to -3-5, Caolan are you happy for 3.5.0 ? we
> had busted comment interop with .docx in 3.4 (so people used .doc) :-)
Yeah, makes sense to me. +1
C.
___
LibreOff
Hi,
I have read a
"0001-fdo-37740-remove-duplicate-icons-from-soffice.bin-so.patch". It is
technically the correct solution, but it is not optimal solution.
A. "soffice.bin" file contains all the icons. Windows Explorer takes it from
there. Icons of this file (LibO-3.5.0rc1 and earlier) were used
Commited and pushed on master (commit
10bfc4df5335c6cd2ae700df7485668d896998b5)
Thank you Eike !
Julien.
PS : if it could be useful to push this on 3.5, just tell me :-)
--
View this message in context:
http://nabble.documentfoundation.org/Same-expression-on-both-sides-of-in-svtools-source-filte
Hi,
See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2aa3d43a3746c797391afb1a08c024d512976006
Could somebody sign-off and push to -3-5, please? (Technically this is a
new feature in the tokenizer but it's a regression from LO-3.4, so I do
not request this to be in -3-5-0.)
Thanks,
Mi
On 30/01/12 21:44, Miklos Vajna wrote:
> Hi,
>
> See
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=2aa3d43a3746c797391afb1a08c024d512976006
>
> Could somebody sign-off and push to -3-5, please? (Technically this is a
> new feature in the tokenizer but it's a regression from LO-3.4, so
Hi,
I'd like
http://cgit.freedesktop.org/libreoffice/core/commit/?id=e2b11f4fd79dce4116badb0ecf6477546ca5d0d4
cherry-picked to the 3-5 branch. It is probably too late for change
like this to be in the 3-5-0 branch so I won't even try.
To reproduce the problem, open the following file in Calc
Hello,
Cppchecks reports this :
core/store/source/storlckb.cxx
74 duplicateBranch style Found duplicate branches for if and else.
Here are the lines :
67 OStoreLockBytes::~OStoreLockBytes (void)
68 {
69 if (m_xManager.is())
70 {
71 if (m_xNode.is()
On 30/01/12 18:16, Cedric Bosdonnat wrote:
> Fixed in
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=458d56d9b35f2ecb2eea2589737079390b10ee26
looking better...
> Would be nice to cherry-pick these two commits to -3-5, -3-4 and 3-5-0
> (if it's not too late).
pushed to libreoffice-3-
On 30/01/12 21:19, Caolán McNamara wrote:
> On Mon, 2012-01-30 at 19:52 +, Michael Meeks wrote:
>> Looks lovely to me; pushed to -3-5, Caolan are you happy for 3.5.0 ? we
>> had busted comment interop with .docx in 3.4 (so people used .doc) :-)
>
> Yeah, makes sense to me. +1
>
> C.
doe
On 30/01/12 15:43, Lionel Elie Mamane wrote:
> I attach here the "less invasive" variant originally meant for
> libreoffice-3-5.
>
> However, if people are happy with cherry-picking the (more invasive)
> master commit, by all means, cherry-pick it. This would have the
> advantage of not "forking"
1 - 100 of 114 matches
Mail list logo
