[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 --- Comment #143 from Michael Meeks 2011-06-08 00:51:30 PDT --- suggest 37825 - can't un-encrypt a file. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on

[Libreoffice] [REVIEW] fix for fdo#37584

2011-06-08 Thread Cedric Bosdonnat
Hi all, Could someone review the attached patch, sign it off and push it to the 3.4 branch? John, I CC'ed you particularly to point out a bug in one of your previous commits... that made me search hours long the source of the bug. Please take care of these kind of things for your next patches. T

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

2011-06-08 Thread Thorsten Behrens
Marco wrote: > I hoped to get some type of object or container that let me to find > the selected thumbnail slides out. > On the contrary the result is that the selection type is "void", > that means "no selection" IMO. > > So I don't know how to carry on this task. > Hi Marco, Cc-ing the list,

Re: [Libreoffice] Duplicate code: hwpreader.cxx

2011-06-08 Thread Korrawit Pruegsanusak
Hello Christina, Michael, * On Wed, Jun 8, 2011 at 13:31, Christina Rossmanith wrote: > Once upon a time the easy hacks list had a topic "SIMIAN" (similarity > analyser). Now it's gone, don't know why, don't know when, don't know > where... It was quite nice because it had the precise instructi

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

2011-06-08 Thread Regina Henschel
Hi Thorsten, Thorsten Behrens schrieb: Cc-ing the list, this may be of public interest - for the moment, I suggest you simply export *all* slides. Christian, off the top of your head, is there a way to retrieve the current selection from the Slidesorter via UNO? Using Basic you first get th

Re: [Libreoffice] [REVIEWED] autocorrection crash fdo#38000

2011-06-08 Thread Cedric Bosdonnat
Hello Michael, On Tue, 2011-06-07 at 17:53 +0100, Michael Meeks wrote: > It'd be lovely to cherry-pick to libreoffice-3-4 from master :-) Pushed, thanks for the fix and keep providing good patches like this one ;) Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.o

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

2011-06-08 Thread Christian Lippka
Hi Marco, Am 08.06.2011 10:29, schrieb Thorsten Behrens: Marco wrote: I hoped to get some type of object or container that let me to find the selected thumbnail slides out. On the contrary the result is that the selection type is "void", that means "no selection" IMO. So I don't know how to ca

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37390, which changed state. Bug 37390 Summary: LibreOffice does not create valid ODF. https://bugs.freedesktop.org/show_bug.cgi?id=37390 What|Old Value |New Value

[Libreoffice] [ANNOUNCE] libreoffice-3.3.3.2 tag skipped (3.3.3-rc2)

2011-06-08 Thread Petr Mladek
Hi, no changes have been committed into the libreoffice-3-3-3 branch. The code is exactly the same as for the tag libreoffice-3.3.3.1 (3.3.3-rc1). Hence it does not make sense to do the libreoffice-3.3.3.2 tag and 3.3.3-rc2 build. If no blocker is found, 3.3.3-rc1 will be marked as final on June

Re: [Libreoffice] MacOS path in python wrapper on Linux i586

2011-06-08 Thread Petr Mladek
Christian Lohmaier píše v Út 07. 06. 2011 v 18:24 +0200: > Hi Petr, *, > > On Tue, Jun 7, 2011 at 5:20 PM, Petr Mladek wrote: > > [...] > > The path mentions "MacOS" but I build on Linux i586. [...} > > pull in ure, I pushed the fix & cleanup to get rid of the orig/rej makefiles > > git diff --

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

2011-06-08 Thread Marco
On Wed, 08 Jun 2011 10:44:14 +0200, Christian Lippka wrote: Hi Marco, Am 08.06.2011 10:29, schrieb Thorsten Behrens: Marco wrote: I hoped to get some type of object or container that let me to find the selected thumbnail slides out. On the contrary the result is that the selection type is "v

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

2011-06-08 Thread Marco
On Wed, 08 Jun 2011 10:54:21 +0200, Regina Henschel wrote: Hi Thorsten, Thorsten Behrens schrieb: Cc-ing the list, this may be of public interest - for the moment, I suggest you simply export *all* slides. Christian, off the top of your head, is there a way to retrieve the current selecti

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

2011-06-08 Thread Christian Lippka
Am 08.06.2011 12:16, schrieb Marco: but as I said aSelection internal type seems to be "void" So from which controller should I get the XSelectionSupplier interface ? You talk about an xModel object where should I get it from ? I thought that I should get the frame/component representing the Slid

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

2011-06-08 Thread Marco
On Wed, 08 Jun 2011 12:23:25 +0200, Christian Lippka wrote: Am 08.06.2011 12:16, schrieb Marco: but as I said aSelection internal type seems to be "void" So from which controller should I get the XSelectionSupplier interface ? You talk about an xModel object where should I get it from ? I thou

[Libreoffice] Patch for fdo#32786

2011-06-08 Thread Samuel Mehrbrodt
Hi, I have a fix for fdo#32786 [1] and here's the patch. As stated in the commit message, I copied the fix from the OOo repository [2] changing just a few data types to the 'sal_' types. When I wanted to commit, git complained about remaining tabs and so I also replaced them with spaces. That mak

Re: [Libreoffice] [PATCH] Replace List for vector<> in sc

2011-06-08 Thread Petr Mladek
Rafael Dominguez píše v Út 07. 06. 2011 v 20:21 -0430: > Fix adding NULL objects to ExcEScenarioManager. Ah, this was too paranoid ;-) --- cut --- --- a/sc/source/filter/xcl97/xcl97rec.cxx +++ b/sc/source/filter/xcl97/xcl97rec.cxx @@ -1328,11 +1328,16 @@ ExcEScenarioManager::ExcEScenarioManager(

Re: [Libreoffice] [PATCH] Replace List for vector<> in sc

2011-06-08 Thread Petr Mladek
Rafael Dominguez píše v Út 07. 06. 2011 v 20:36 -0430: > > > On Tue, Jun 7, 2011 at 8:19 PM, Rafael Dominguez > wrote: > > > Also haven't pushed > 0002-Replace-List-with-std-vector-XclExpUserBView.calc.patch > because I am not sure about

[Libreoffice] which mailing list for extension writers?

2011-06-08 Thread Christian Andersson
Hi there, a short question, I'm writing an extension to libreoffice, and I wonder which mailing lsit I should use for api questions, etc should I use this mailing list (libreoffice@lists.freedesktop.org) or should I use the users mailinglist (us...@libreoffice.org)? /Christian Andersson _

Re: [Libreoffice] [GSoC 2011][svgexport] I need some help on exporting "all selected slides" task

2011-06-08 Thread Ariel Constenla-Haile
Hello Thorsten, On Wednesday 08 June 2011, 05:29, Thorsten Behrens wrote: > Marco wrote: > > I hoped to get some type of object or container that let me to find > > the selected thumbnail slides out. > > On the contrary the result is that the selection type is "void", > > that means "no selection"

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 36306, which changed state. Bug 36306 Summary: LibreOffice 3.4 beta1 crash in Letter Wizard https://bugs.freedesktop.org/show_bug.cgi?id=36306 What|Old Value |New Value --

[Libreoffice] [GSoC 2011][svgexport] add support for browsing slides

2011-06-08 Thread Marco
Hi all, I implemented the javascript code for navigating through slides in an svg exported presentation. At present I have tested it under Firefox 4.0 and Opera 11.0 and everything works smoothly. I attached a git patch based on origin/libreoffice-3-4-0. Here there is a sample svg presentation y

[Libreoffice] [PUSHED][[REVIEW] fix for fdo#37584

2011-06-08 Thread Caolán McNamara
On Wed, 2011-06-08 at 10:28 +0200, Cedric Bosdonnat wrote: > Hi all, > > Could someone review the attached patch, sign it off and push it to the > 3.4 branch? Done. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedes

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37584, which changed state. Bug 37584 Summary: track changes: deleted text lost https://bugs.freedesktop.org/show_bug.cgi?id=37584 What|Old Value |New Value --

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

2011-06-08 Thread Takeshi Abe
Hi Caolán, Thanks for your comment! On Tue, 07 Jun 2011 14:42:55 +0100, Caolán McNamara wrote: > Not an objection, but an aside that I presume this means we don't get > automigration of user settings from the old config to the new config ? > > Poke around in desktop and migration stuff IIRC to

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

2011-06-08 Thread Noel Power
On 08/06/11 13:55, Takeshi Abe wrote: OK, so do you mean libs-core/desktop/source/migration?, which functionality I have not yet recognized clearly. It would be great if anyone familiar with the code suggests a starting point to dig into. I *think* this ( see attached patch ) will fix it, not ha

Re: [Libreoffice] which mailing list for extension writers?

2011-06-08 Thread Sophie Gautier
Hi Christian, On 08/06/2011 13:55, Christian Andersson wrote: Hi there, a short question, I'm writing an extension to libreoffice, and I wonder which mailing lsit I should use for api questions, etc should I use this mailing list (libreoffice@lists.freedesktop.org) or on this one you should be

Re: [Libreoffice] [PATCH][PUSHED] Replace List for vector<> in sc

2011-06-08 Thread Petr Mladek
Rafael Dominguez píše v Út 07. 06. 2011 v 19:05 -0430: > Made a new patch, with the fixes now im using size_t to handle size, > also ensuring we dont add a null object. I have pushed it as http://cgit.freedesktop.org/libreoffice/calc/commit/?id=31a268eb01d9d808a35ffe3161acbec7d4134519 Well, I ha

Re: [Libreoffice] [REVIEW] Unity Quick List in StartCenter desktop file

2011-06-08 Thread KAMI911 KAMI911
Hi Björn, Of course I don't want to harm any UX @ Ubuntu, however I used this modification for a while and it seems useful to me because I don't have to put all main icons to the Unity bar. Starting all main application from one icon is very comfortable. I am sad because it is not point of view at

[Libreoffice] New Member

2011-06-08 Thread Klaibson Ribeiro
Hello. My name is Klaibson and yesterday me signed up in the LibreOffice in the FreeDesktop. I living in the Florianópolis, capital of Santa Catarina, Brazil. I'm leader user group LibreOffic

[Libreoffice] Пpемудрости учeта в новых условияx

2011-06-08 Thread Пpeмудрости учeтa в новыx уcлoвиях
> ЭФФЕKТИВНЫЙ PУКOВОДИТЕЛЬ > Тpенинг • 22 июня • 2011 г. > г. Kиев • бульв. Шевчeнко 4 • отeль «Caнкт-Петербург» > Тeл.: (044) 223-4882 и 223-5141 -~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~-~- Задачa любогo pукoвoдителя сделaть свoю оргaнизацию peзультативно

Re: [Libreoffice] New Member

2011-06-08 Thread Sasa Ostrouska
Bemvindo :) Rgds Saxa On Wed, Jun 8, 2011 at 10:59 AM, Klaibson Ribeiro wrote: > Hello. > > My name is Klaibson and yesterday me signed up in the LibreOffice in the > FreeDesktop. > > I living in the Florianópolis, capital of Santa Catarina, Brazil. I'm leader > user group LibreOffice in my stat

Re: [Libreoffice] [REVIEW] Unity Quick List in StartCenter desktop file

2011-06-08 Thread Bjoern Michaelsen
Hi Kami, On Wed, 8 Jun 2011 15:50:48 +0200 KAMI911 KAMI911 wrote: > I am sad because it is not point of view at Canonical, but I > understand your decision. Just a short note: This is _not_ a "Canonical decision", but one that was made by the whole Ubuntu community. Best, Bjoern -- https://

Re: [Libreoffice] Trouble building the redland module on mac

2011-06-08 Thread William Lachance
On Tue, Jun 7, 2011 at 5:24 PM, Thorsten Behrens wrote: > William Lachance wrote: > > Christian suggested modifying the configure script not to use > > xml2-config/xslt-config at all. Here's a patch which does exactly that. > I'm > > not exactly thrilled by the size/complexity of this patch for w

Re: [Libreoffice] [PUSHED] [PATCH] Trouble building the redland module on mac

2011-06-08 Thread Thorsten Behrens
William Lachance wrote: > Apologies, there was a typo in my patch (had LIBXML_CFLAGS in one place > where I should have add LIBXML_LIBS). > Great, works like a charm here - and making the build more resilient always a worthy goal - pushed to master. Thanks, -- Thorsten pgpqI4hRbMpjk.pgp Descrip

Re: [Libreoffice] [GSoC] Re: KCachegrind

2011-06-08 Thread Matúš Kukan
Hi there, On 7 June 2011 22:57, Michael Meeks wrote: >        So - then I wonder if we can catch the problem lower down - inside the > valgrind 'cachegrind' skin. Now - I know what you're thinking: 'valgrind > is a complicated nightmare' :-) but you're wrong. Valgrind skins are > single-threaded,

Re: [Libreoffice] [PATCH][PUSHED] Replace DBG_ with OSL in writer and remove debug.hxx

2011-06-08 Thread Petr Mladek
Jacek Wolszczak píše v Út 07. 06. 2011 v 22:48 +0200: > Hi, > > 0001-Replace-DBG_-stuff-with-OSL_-equivalents-in-writer -- removes some > last leftovers of DBG -> OSL conversion in writer > > 0002-Remove-the-remaining-debug.hxx-includes-in-writer has to be applied > along with 0001-Replace-DBG_AS

[Libreoffice] LO Manager Config file, shell script and command line doco?

2011-06-08 Thread djfw
Hi, Is there any doco for the rc or shell files or command line for LO Manager? I have tried the users forum and checked the help files, but no luck. Cheers, David -- View this message in context: http://nabble.documentfoundation.org/LO-Manager-Config-file-shell-script-and-command-line-doco-tp30

Re: [Libreoffice] LO Manager Config file, shell script and command line doco?

2011-06-08 Thread djfw
Please ignore, this was meant for the doc list. Cheers, David. -- View this message in context: http://nabble.documentfoundation.org/LO-Manager-Config-file-shell-script-and-command-line-doco-tp3039513p3039520.html Sent from the Dev mailing list archive at Nabble.com. _

[Libreoffice] [REVIEW] fix for fdo#37799

2011-06-08 Thread Cedric Bosdonnat
Hi all, Could anyone review, sign-off and push to 3.4 branch the attached patch fixing a broken loop? One less annoying bug for 3.4 ;) Thanks, -- Cédric Bosdonnat LibreOffice hacker http://documentfoundation.org OOo Eclipse Integration developer http://cedric.bosdonnat.free.fr >From 7265c670608

Re: [Libreoffice] [REVIEW] fix for fdo#37584

2011-06-08 Thread John LeMoyne Castle
Cedric, I apologize for the time cost for you to dig this up. I do remember removing a string copy (or maybe two?). I should have clearly seen the need for a full copy after digging into the counting process and seeing the changes it made to the string in order to count excluding hidden or red

Re: [Libreoffice] [REVIEW] fix for fdo#37584

2011-06-08 Thread John LeMoyne Castle
Test with LibreOffice 3.3.2 OOO330m19 (Build:202) tag libreoffice-3.3.2 shows that Changes->Record does not produce redlining there either I feel sick jlc=={*-P} -- View this message in context: http://nabble.documentfoundation.org/REVIEW-fix-for-fdo-37584-tp3038258p3039788.html Sent from t

Re: [Libreoffice] [PUSHED] [PATCH] fdo#32263 - Config file location

2011-06-08 Thread Noel Power
On 08/06/11 14:19, Noel Power wrote: On 08/06/11 13:55, Takeshi Abe wrote: OK, so do you mean libs-core/desktop/source/migration?, which functionality I have not yet recognized clearly. It would be great if anyone familiar with the code suggests a starting point to dig into. I *think* this (

[Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

2011-06-08 Thread Michael Münch
Hi, in Calc when clicking Insert->Hyperlink->WWW-Browser a webpage is opened with a text containing OpenOffice.org and http://www.sun.com/staroffice or http://www.openoffice.org depending on the language. This patch replaces these strings with LibreOffice ones. Regards, Michael >From 8196d726f04

[Libreoffice] [PATCH] Disable Removebutton in optchart

2011-06-08 Thread Rob Snelders
Hi, I have here a small patch to disable the remove-button at the chart-colors if there is no color to remove. This makes it more consistent for the GUI. -- Greetings, Rob Snelders >From 0f64b62344f6c0fdc2f6d1460bdfb1cb3bd3f2ed Mon Sep 17 00:00:00 2001 From: Rob Snelders Date: Wed, 8 Jun 201

Re: [Libreoffice] Lotuswordpro : Found duplicate if expressions in xfbookmarkref.cxx:75:85

2011-06-08 Thread Julien Nabet
Le 07/06/2011 11:18, Caolán McNamara a écrit : On Sun, 2011-06-05 at 00:59 +0200, Julien Nabet wrote: Hello, Just a guess, perhaps it needs this patch : ... Someone to comment ? If it's ok, I can, of course, commit this and push it in master. Your patch seems sane to me, I reckon you should

Re: [Libreoffice] 3.4.0 SDK installation needs some tweaks?

2011-06-08 Thread Andreas Radke
Any hints how to handle the sdk paths for now? Just "sed" our distro paths into it and add the missing setsdkenv_unix.sh.in file from the sdk source? -Andy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailma

[Libreoffice] Disappearing Frame Borders

2011-06-08 Thread David Burleigh
I'm running LibreOffice 3.4 under Ubuntu 11.04 (amd64). I place a frame on a page, and set the borders of the frame to a particular line style, and all seems fine. I can print the page and the borders are printed as expected. However, if I close the file and then reopen it, the borders are gone. I

Re: [Libreoffice] New Member

2011-06-08 Thread Sophie Gautier
Hi Klaibson, On 08/06/2011 16:59, Klaibson Ribeiro wrote: Hello. My name is Klaibson and yesterday me signed up in the LibreOffice in the FreeDesktop. Welcome and thanks for your work on LibreOffice. However this list is dedicated to developers work, better for you to post on disc...@documen

[Libreoffice] [REVIEW] Fix for fdo#33705

2011-06-08 Thread Kohei Yoshida
I'd like to have the following commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=5743e7b36220e9689091812cef7a4396dd48c4e6 cherry-picked to the -3-4 branch in order to fix https://bugs.freedesktop.org/show_bug.cgi?id=33705 Reviews appreciated. Kohei -- Kohei Yoshida, LibreOffice

Re: [Libreoffice] Duplicate code: hwpreader.cxx

2011-06-08 Thread Chr. Rossmanith
Hi, I've found a .hwp document here http://openoffice.org/bugzilla/show_bug.cgi?id=31091, tried to open it but only get a blank page - no error message. Where would I start to analyze what's going wrong? If hwpfilter is not working, maybe it's no use to improve the code... Christina ___

Re: [Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

2011-06-08 Thread Andras Timar
Hi Michael, 2011/6/8 Michael Münch : > in Calc when clicking Insert->Hyperlink->WWW-Browser a webpage is opened > with a text containing OpenOffice.org and http://www.sun.com/staroffice > or http://www.openoffice.org depending on the language. > > This patch replaces these strings with LibreOffice

Re: [Libreoffice] [patch] remove duplicate placeholder icons

2011-06-08 Thread Joachim Trémouroux
Hi, Done. I've just made my first git push ever. :-) Regards, Joachim. Le 7 juin 2011 20:51, Michael Meeks a écrit : > Hi Joachim, > > On Tue, 2011-06-07 at 20:27 +0200, Joachim Trémouroux wrote: > > I have made some stats to check the number of duplicate icons in the > > clone/artwork direc

Re: [Libreoffice] [patch] remove duplicate placeholder icons

2011-06-08 Thread Joachim Trémouroux
Hi Norbert, Much faster indeed. It's instantaneous versus 35 sec for the md5sum. Thanks for the tip. Regards, Joachim. Le 7 juin 2011 22:53, Norbert Thiebaud a écrit : > 2011/6/7 Joachim Trémouroux : > > Hi everybody, > > > > I have made some stats to check the number of duplicate icons in th

[Libreoffice] LibreOffice Calc

2011-06-08 Thread Roderick Edwards IMP-IND
Hi dev team!!! I love LibreOffice. Much better than reg OpenOffice. The macro interoperability and the excel like autofiltering made me consider using it as a replacement for Excel. Anyhow, at my work, we have some people on Excel and some people on OpenOffice (hopefully soon Libre) so I am

Re: [Libreoffice] [PATCH] replace OpenOffice.org and StarOffice references with LibreOffice

2011-06-08 Thread Cor Nouws
Andras Timar wrote (08-06-11 21:40) and the Document target button (which is there by mistake, I think) from the Insert -> Hyperlink -> Internet panel. Agree, it only should be on Insert -> Hyperlink -> Document -- - Cor - http://nl.libreoffice.org

[Libreoffice] [REVIEW] Fix for fdo#37816

2011-06-08 Thread Kohei Yoshida
I'd like to cherry-pick the following commit http://cgit.freedesktop.org/libreoffice/calc/commit/?id=34a1f66c5f69aba2cd6135895563cf569a2531eb from master to the -3-4 branch. This fixes a rather nasty crasher when moving a field button inside a pivot table. The bug is reported here: https://bug

[Libreoffice] Replacing ByteString with rtl::OString

2011-06-08 Thread Chr. Rossmanith
Hi, I encountered the problem that rtl::OString::valueOf() won't eat sal_Int16. Solution A: cast argument Solution B: add support for sal_Int16 to rtl::OString::valueOf() Any opinions? Christina ___ LibreOffice mailing list LibreOffice@lists.freedesk

Re: [Libreoffice] Replacing ByteString with rtl::OString

2011-06-08 Thread Kohei Yoshida
On Wed, 2011-06-08 at 23:05 +0200, Chr. Rossmanith wrote: > Hi, > > I encountered the problem that rtl::OString::valueOf() won't eat sal_Int16. > > Solution A: cast argument > Solution B: add support for sal_Int16 to rtl::OString::valueOf() You can cast it to sal_Int32. That's probably simpler

Re: [Libreoffice] [REVIEW][PUSHED] Fix for fdo#37816

2011-06-08 Thread Markus Mohrhard
You've my sign-off. I pushed it to the 3-4 branch. 2011/6/8 Kohei Yoshida > I'd like to cherry-pick the following commit > > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=34a1f66c5f69aba2cd6135895563cf569a2531eb > > from master to the -3-4 branch. This fixes a rather nasty crasher

Re: [Libreoffice] [REVIEW] Fix for fdo#37947

2011-06-08 Thread Kohei Yoshida
On Wed, Jun 8, 2011 at 12:38 AM, Kohei Yoshida wrote: > I'd like to cherry-pick this to the -3-4 branch > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8c02d7e41b5406471ede62099fceac5c8ce17fe4 Apparently cherry-picking this from master to the -3-4 branch fails. I've re-issued a new pa

Re: [Libreoffice] [REVIEW] [PUSHED] Fix for fdo#37947

2011-06-08 Thread Markus Mohrhard
Thanks for the new patch. Great work. You have my sign-off. Pushed to 3-4 branch. 2011/6/9 Kohei Yoshida > On Wed, Jun 8, 2011 at 12:38 AM, Kohei Yoshida > wrote: > > I'd like to cherry-pick this to the -3-4 branch > > > > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=8c02d7e41b540

Re: [Libreoffice] [REVIEW] Fix for fdo#33705

2011-06-08 Thread Kohei Yoshida
On Wed, 2011-06-08 at 15:10 -0400, Kohei Yoshida wrote: > I'd like to have the following commit > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=5743e7b36220e9689091812cef7a4396dd48c4e6 > > cherry-picked to the -3-4 branch in order to fix > > https://bugs.freedesktop.org/show_bug.cgi?

[Libreoffice] [PATCH] List structure cleaning in calc

2011-06-08 Thread Rafael Dominguez
More List cleaning up From 64ac9b0a4c39d0279fd5dbe9f8f160261d9c0420 Mon Sep 17 00:00:00 2001 From: Rafael Dominguez Date: Thu, 2 Jun 2011 22:00:58 -0430 Subject: [PATCH 10/21] Replace List for std::vector. --- sc/source/filter/inc/lotrange.hxx |4 +++- sc/source/filter/lotus/tool.cxx | 3

[Libreoffice] [PATCH] List structure cleaning in impress

2011-06-08 Thread Rafael Dominguez
From 811e66c084d35f80dd61cf5367a383523c407bdb Mon Sep 17 00:00:00 2001 From: Rafael Dominguez Date: Sat, 4 Jun 2011 10:46:37 -0430 Subject: [PATCH 1/4] Replace List with std::vector. --- sd/source/ui/dlg/navigatr.cxx | 32 ++-- sd/source/ui/inc/navigatr.hxx |2

Re: [Libreoffice] [PUSHED] Patch for fdo#32786

2011-06-08 Thread Norbert Thiebaud
On Wed, Jun 8, 2011 at 5:32 AM, Samuel Mehrbrodt wrote: > Hi, > > When I wanted to commit, git complained about remaining tabs and so I > also replaced them with spaces. That makes the patch look bigger than it > actually was, but I didn't see another way. You could have edited the patch afterwar

Re: [Libreoffice] [REVIEW] Fix for fdo#33705

2011-06-08 Thread Kohei Yoshida
On Wed, 2011-06-08 at 21:50 -0400, Kohei Yoshida wrote: > to see if that will solve the unit test failure issue. The test passes > in my build environment so I'm suggesting this entirely in blind, so I > don't want to check this in before confirming that this is indeed the > issue. Ok. This won

Re: [Libreoffice] [REVIEW] [PUSHED] Fix for fdo#33705

2011-06-08 Thread Markus Mohrhard
I think we tested it well now. You've my sign-off. Pushed to 3-4. 2011/6/9 Kohei Yoshida > On Wed, 2011-06-08 at 21:50 -0400, Kohei Yoshida wrote: > > > to see if that will solve the unit test failure issue. The test passes > > in my build environment so I'm suggesting this entirely in blind,

[Libreoffice] [REVIEW] Fix for fdo#37673

2011-06-08 Thread Kohei Yoshida
Here is another fix for review. http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4820648fc4abe7984c3c3c35e4c727c5574e8939 This one fixes the following crasher https://bugs.freedesktop.org/show_bug.cgi?id=37673 which BTW happens only on Windows. The reason for the crash is that the pTabl

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

2011-06-08 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 37799, which changed state. Bug 37799 Summary: Crash when Break (remove) DDE link to CALC https://bugs.freedesktop.org/show_bug.cgi?id=37799 What|Old Value |New Value

Re: [Libreoffice] [REVIEW] fix for fdo#37799

2011-06-08 Thread Norbert Thiebaud
On Wed, Jun 8, 2011 at 10:29 AM, Cedric Bosdonnat wrote: > Hi all, > > Could anyone review, sign-off and push to 3.4 branch the attached patch > fixing a broken loop? One less annoying bug for 3.4 ;) Looks fine. Pushed. Norbert ___ LibreOffice mailing

Re: [Libreoffice] [PUSHED] fix for fdo#37799

2011-06-08 Thread Norbert Thiebaud
oops forgot to change the header. pushed Norbert On Wed, Jun 8, 2011 at 10:29 AM, Cedric Bosdonnat wrote: > Hi all, > > Could anyone review, sign-off and push to 3.4 branch the attached patch > fixing a broken loop? One less annoying bug for 3.4 ;) > > Thanks, > > -- > Cédric Bosdonnat > LibreOf

Re: [Libreoffice] [PATCH][PUSHED] Disable Removebutton in optchart

2011-06-08 Thread Norbert Thiebaud
On Wed, Jun 8, 2011 at 11:24 AM, Rob Snelders wrote: > Hi, > > I have here a small patch to disable the remove-button at the chart-colors > if there is no color to remove. This makes it more consistent for the GUI. Thanks, Tested and Pushed. Norbert.

Re: [Libreoffice] LibreOffice Calc

2011-06-08 Thread Norbert Thiebaud
On Wed, Jun 8, 2011 at 2:53 PM, Roderick Edwards IMP-IND wrote: > Hi dev team!!!  I love LibreOffice.  Much better than reg OpenOffice.  The > macro interoperability and the excel like autofiltering made me consider > using it as a replacement for Excel.  Anyhow, at my work, we have some > people

Re: [Libreoffice] [PUSHED] Fix for fdo#37673

2011-06-08 Thread Norbert Thiebaud
On Wed, Jun 8, 2011 at 11:26 PM, Kohei Yoshida wrote: > Here is another fix for review. > > http://cgit.freedesktop.org/libreoffice/calc/commit/?id=4820648fc4abe7984c3c3c35e4c727c5574e8939 > > This one fixes the following crasher > > https://bugs.freedesktop.org/show_bug.cgi?id=37673 > > which BTW

[Libreoffice] Patch for Bug 35938 - EasyHack: UI - Picture Caption dialog not remembering Separator textbox value

2011-06-08 Thread Jeff Aigner
Hello, I'm new to contributing here, so greetings to all! Attached is a patch for bug 35938. It changes the Picture Caption dialog to remember the last-used value of the caption separator text. Kind Regards, Jeff Aigner >From b80eab85eb6288c8b5c08cbccd2cadc75943a8b6 Mon Sep 17 00:00:00 2001 From