Hi all,
please review the attached patch which applies an important and safe
subset of the changes to sal/osl/unx/interlck.c on master to 3.3.2,
mostly:
http://cgit.freedesktop.org/libreoffice/ure/commit/?id=788072cefdce8cb61d46549a7aede4c754d9fae3
So the commit should have "Jani Monoses "
as
Hi,
I'm having a look at your patch files. The first thing to mention is
that "whitespace-only changes" should be avoided. The second thing:
12000 lines for a single patch file is too long. You should split them
into pieces that reviewing a single patch can be done in a reasonable time.
You'
Bjoern Michaelsen wrote:
> > For a developer interested in working on a certain topic it would be
> > easier to get a final voting like
> > "The Design Team asks you to add a 8 px wide blurred shadow in grey
> > transparency to all borders of the document. If the zoom factor
> > reduces the space
Bjoern Michaelsen wrote:
> please review the attached patch which applies an important and safe
> subset of the changes to sal/osl/unx/interlck.c on master to 3.3.2,
> mostly:
>
+1 from me.
-- Thorsten
pgp8gnjzaPSyH.pgp
Description: PGP signature
___
On Thu, Mar 10, 2011 at 3:29 AM, Bjoern Michaelsen
wrote:
> Hi all,
>
> please review the attached patch which applies an important and safe
> subset of the changes to sal/osl/unx/interlck.c on master to 3.3.2,
> mostly:
>
> http://cgit.freedesktop.org/libreoffice/ure/commit/?id=788072cefdce8cb61
Hello everyone,
As I am currently between assignments (I work for a consulting firm), my
employer has graciously allowed me to
improve on my skills using open source software, and submit anything I do.
So for starters I'm looking into
the unit tests, because that's an area of expertise I've neglec
Hi David,
I am assuming you are working on an improved version of the patch taking
Cedric comments into consideration.
Thank you so much for your contributions! Looking forward for more...
- Muthu Subramanian
On 03/08/2011 02:21 PM, Cedric Bosdonnat wrote:
> Hi Muthu, David,
>
> On Mon, 2011-0
Christina Roßmanith wrote:
> I'm having a look at your patch files. The first thing to mention is
> that "whitespace-only changes" should be avoided.
>
I have to second that. At least for the while, they add to the
workload during merges, for (at least to me) almost zero benefit.
Xisco, otherwise
Hi Thorsten, all,
On Thu, 10 Mar 2011 11:25:32 +0100
Thorsten Behrens wrote:
> Bjoern Michaelsen wrote:
> > > For a developer interested in working on a certain topic it would
> > > be easier to get a final voting like
> > > "The Design Team asks you to add a 8 px wide blurred shadow in
> > > gr
Thank you for resending. I am reviewing them...I will push them in a while.
Yes, translating the debug messages, DBG_ASSERTS would also be really
helpful.
On 03/08/2011 05:30 AM, Martin Kepplinger wrote:
> Am 08.03.2011 00:23, schrieb Albert Thuswaldner:
>> Hi
>> Here are last ones that did not
Hi all,
I have the fix for fdo#34718 ready. I am looking for 3 reviews.
http://cgit.freedesktop.org/libreoffice/libs-gui/commit/?id=1f4078d8be0755ea33ec36edacdf805e1ce24270
fix for 3.3.2 blocker fdo#34718 - change the type of nDrawerHeight to long
- before it became big positive long in the cal
Hi,
some people were interested into the build dependency between the LO git
repositories. It is the following according to the openSUSE LO source
rpms:
+ bootstrap
+ artwork
+ ure
+ libs-extern-sys
+ libs-extern
+ testing [1
Radek Doulík wrote:
> fix for 3.3.2 blocker fdo#34718 - change the type of nDrawerHeight to long
>
+1 - of course matching the local type with the return type is the
right thing to do. :)
-- Thorsten
pgpWmVzov6aYK.pgp
Description: PGP signature
___
Li
Hello all,
FYI, I got this email from the list..
Dear OpenOffice Crew,
In fact i am/was a very satisfied OpenOffice customer. Ive been using it
for 4 years now and i never had a problem. But for the last time (let's
say for about a year) OpenOffice is getting worse instead of improving.
Its getti
Hi Albert,
I have pushed after correcting a few typos - hope I have caught the
important ones and most of the others.
If possible (in the future), please do compile and check the code before
submitting the patch - I found some stray characters.
Thanks again for the (huge) patch...please do contin
Then, let not push my 'useless' patch lol :')
Sorry and thanks for detailed explanation.
--
Korrawit Pruegsanusak
On Mon, Mar 7, 2011 at 16:45, Bjoern Michaelsen <
bjoern.michael...@canonical.com> wrote:
> On Mon, 07 Mar 2011 01:52:11 -0700
> "Tor Lillqvist"
> wrote:
>
> > > I hope someone wit
Hi Muthu,
Thanks for pushing my patches! It is always nice to see them go in.
On Thu, Mar 10, 2011 at 18:38, Muthu Subramanian K wrote:
> Hi Albert,
>
> I have pushed after correcting a few typos - hope I have caught the
> important ones and most of the others.
Sorry for the typos, I try to revi
Hi,
I've pushed patch 1-3. Patch 4 only removes structuring
"//---" lines. I'm not sure if this is wanted. Maybe
someone of the experts can comment on this? Then I'll go on with reviewing.
Thank you for your contribution!
Christina Rossmanith
Am 10.03.2011 19:24, schrieb
Hey, i took a look and i think that you can push -> {0043,0044,0048}.
On Thu, 10 Mar 2011 22:02:57 +0100, Christina Roßmanith
wrote:
Hi,
I've pushed patch 1-3. Patch 4 only removes structuring
"//---" lines. I'm not sure if this is wanted.
Maybe someone of the experts can
I've attached patch for the (embarrassingly simple) fix for the filter
dialog as well as a German comment translation patch for the filter dialog
cxx and hxx files - feel free to reject this because my German is pretty
weak or if you'd rather have a larger chunk done at once.
On Wed, Mar 9, 2011 a
>From 3bffa7b2a431686eeedd7859eaba1ce22671d474 Mon Sep 17 00:00:00 2001
Message-Id: <3bffa7b2a431686eeedd7859eaba1ce22671d474.1299801754.git.wilhelm.pflue...@web.de>
From: Wilhelm Pflueger
Date: Fri, 11 Mar 2011 00:59:16 +0100
Subject: [PATCH] EasyHacks: Reanimated tests in ure/codemaker
---
co
On Thu, 2011-03-10 at 21:44 +, Tibby Lickle wrote:
> I've attached patch for the (embarrassingly simple) fix for the filter
> dialog as well as a German comment translation patch for the filter
> dialog cxx and hxx files - feel free to reject this because my German
> is pretty weak or if you'd
https://bugs.freedesktop.org/show_bug.cgi?id=34404
Rainer Bielefeld changed:
What|Removed |Added
Depends on||34093
--- Comment #13 from Rainer Bie
Hi Albert,
oh...Will have a look at those patches too...
I assumed those were the ones you resent...Will get back to you in a while.
Would you also want to look at some simple hacks? features? Since you
seem to be comfortable with C++?
Thanks!
Muthu Subramanian
On 03/11/2011 02:12 AM, Albert Th
24 matches
Mail list logo
